From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9648C41513 for ; Fri, 21 Jul 2023 19:31:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3ED2B8D0003; Fri, 21 Jul 2023 15:31:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 374DF8D0001; Fri, 21 Jul 2023 15:31:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EF248D0003; Fri, 21 Jul 2023 15:31:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0B15B8D0001 for ; Fri, 21 Jul 2023 15:31:12 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B86BC403F4 for ; Fri, 21 Jul 2023 19:31:11 +0000 (UTC) X-FDA: 81036612342.21.87C3BD4 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf19.hostedemail.com (Postfix) with ESMTP id 9A1821A000E for ; Fri, 21 Jul 2023 19:31:09 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=kDmWxsg8; dmarc=none; spf=pass (imf19.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.214.179 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689967869; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f3fNBXK6DdLEjSA1dgCCAp4qYAepk3u3d3m0rz5z1fE=; b=iWJ8pKKk4nJHPFszZe5kmt6wi1OzaB4p6mo1HcOdB8eiJIwl91TgQlloD2bO2EKGvGGvtc nMkLB0QmfOvDxHQtYzngkCZQvxn1FC7fHjWfXRa8MhIfJzL3fJG/cTCVzPYqvhiNhN3og1 0fNKsbxddv1t6mL1GydO7XpTM67XJ90= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=kDmWxsg8; dmarc=none; spf=pass (imf19.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.214.179 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689967869; a=rsa-sha256; cv=none; b=Wfuz4xr1NGhjlzqHm3oVktwbbtJqNM8g/kLQt2c1b172Qjvah1XeiGfMwGSY2/S2zRUesY pKnnaF9d+jjbI/PiEkrXGvrc+hdKDHTyq2zFkppu4cItQeKnVfN/Dlj3elyCYrl9c2Xj9g j7KpZ+8JzFw1BkkeibGmJWq0RdGyW9c= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1b8baa836a5so17070175ad.1 for ; Fri, 21 Jul 2023 12:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1689967868; x=1690572668; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f3fNBXK6DdLEjSA1dgCCAp4qYAepk3u3d3m0rz5z1fE=; b=kDmWxsg8ZqlraY3EitIJv4Evr2CcqLMRY3qJJ8AcjlKJ3bFOzgBkDnjKefyYbdeSfz k86T0qkxGRO51XZTaYeEKipExFEf8j1Hv1UVrlMbeSWAAge69sWytNfaMcA7RqeT6zuL 3L23q9S/iI50qzztXd/HyH2HoeCpvu0Z2gNnWlaIpHe3ERs66DUZ8IU1MTauRcMdzksf ILJCbJ6VdIAYJt/7FJu58WJgwsSS2VgS9zoptDQ2XjWHdUPjgabRgHusalzm4+RsCynb dnms2eGvIrcLiBFxG5n4oVrQg7cm8ONAc3J+1xhZDfp15hiSb0l0fBegQfffD1CHZhNd TBLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689967868; x=1690572668; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f3fNBXK6DdLEjSA1dgCCAp4qYAepk3u3d3m0rz5z1fE=; b=iBO+0zyNH7KBJZvu06xfllnuANjkRZ1Z33wxGZK9rJ3EAJ3hrO/qstjJRXwomj4IS8 pWCj5jghGZbMNA3eKvN+cquy6ChJAmNGZyrJCplHRR2g/Aofh/+K8NtWNpCquKjqW88r 1tQaEvUPsFdeJkT9n3fPv0BwpRKVeS6zPcGW39PGHdzO7dsLgaeKIYPVARyogs7WRzjT 43GilbWFfTBvYHXogT3ZA8W4XjGb/1iEebEIY6+dcp35pf2tt/YEDLHyG4BfBYUb7VJc I+WSqOHj7AmLzWRyQb2xdN4+AHr0qbIjz66f5GspIsMICkREMks5pI3UG6FCn1bOYYDP OKAA== X-Gm-Message-State: ABy/qLYQN06PQACt8rQzkzKyjXa4s+50D9Z+7ehh5AUmEnjiMzg5rJ4N KxA/RHnn4pJwz6GtYA6KGjZL8A== X-Google-Smtp-Source: APBJJlHihJyY9wXFkjydx/6tfCAtPCW82R9C1y8RYnU52rOS6+M8sM4/6qnSkSyFxd3dSuGWl4EDkw== X-Received: by 2002:a17:902:b418:b0:1b8:b2c6:7e8d with SMTP id x24-20020a170902b41800b001b8b2c67e8dmr2649069plr.66.1689967868340; Fri, 21 Jul 2023 12:31:08 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id r16-20020a170902be1000b001b8422f1000sm3860137pls.201.2023.07.21.12.31.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 12:31:07 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qMvqE-003IGg-98; Fri, 21 Jul 2023 16:31:06 -0300 Date: Fri, 21 Jul 2023 16:31:06 -0300 From: Jason Gunthorpe To: Alistair Popple Cc: akpm@linux-foundation.org, ajd@linux.ibm.com, catalin.marinas@arm.com, fbarrat@linux.ibm.com, iommu@lists.linux.dev, jhubbard@nvidia.com, kevin.tian@intel.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, nicolinc@nvidia.com, npiggin@gmail.com, robin.murphy@arm.com, seanjc@google.com, will@kernel.org, x86@kernel.org, zhi.wang.linux@gmail.com, sj@kernel.org Subject: Re: [PATCH v3 5/5] mmu_notifiers: Rename invalidate_range notifier Message-ID: References: <3cbd2a644d56d503b47cfc35868d547f924f880e.1689842332.git-series.apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3cbd2a644d56d503b47cfc35868d547f924f880e.1689842332.git-series.apopple@nvidia.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9A1821A000E X-Stat-Signature: qury768t8b8rfa3yq9a7jiuzkniytgin X-HE-Tag: 1689967869-536661 X-HE-Meta: U2FsdGVkX1/I32MRuq6HnmwpDy+YWD18PUyExjErCDKNbBMAZ2Z6iUsXrNFBVwC9O8AeI7LDUE46SmTnHkJN/nw5jRmjB5gwZLSm53klzmOVt1RC1YRbAlYJqyX8IdbZxVaT/WlhkCcQdbWfXe0kUZzWFOUAaCdEiGpV/hh+2nkEgNxZKlBCizQIAOs9EraL9WHUs3t/OMyJZWjerfPixsJ0/U4Tve3iULeS4zGKiJRIPLdXNFfp9c2fSeDMFE1+aHtw/XwcG290zgUN3DKFuGFK8nbP5H+y8QUN2Et1X0iKVRtFJTMQOfSc4BX/ehd6dtPZj2qa7w6aqqRJWJiPi9GFx3me3oG6L7h7YhWnJ6NdIfRuzFJtR8yKCkShTFSObqzxvFKWWddt+Ql/gAyezlc5gxMTPUPWRIZHlaRdOZeevs+X9UPDwrkm34Y7Mt6fh2D1PXx4EXm06KQq2swKkdWrRydr3+tFg+IZuwdkxQ4Wp0NDSVWm5EZ8E+TZh+rUirLCPKnPlb1jj8PoGR7c8TTsLUAu9g6wNeok+HgSmwFkvAv3CqKJCyULyk9hKDbWfYdNo5BJ7Ww7mbiyIZ6PgWilAU19CfPfSvvJ5PVIIGQ8SID1vkWOVrHY++YwW+8h0EETyZB0DGh05jQpOGvcjcrSbLbbJrtm/3Ja0faFneEEMVHqfLOxI5EVRGSLBiLEIzw+THaYuxqkDq20rJzKq3y61kjbLqw/6odJYxg8iOKfHudzggBxB0NLdgRyDy3bmQCsPUc8mL6aks+3zJ3dKn7uGTtuGJpbUjCvZ2KXaP7JQJhsyGFpRNwhs8zxCjmHg1mGX8vHBjGJXkksJhFD0e2yo/sYOR4cLiPtHu5Od8fioDt2HKrQxIXp8mZ6PLXlodZULBu/ezAeRzzvral50fkaq7+0MYsNcqsr7iYZCUmcV3BxADu8RaLx2RXeyagIBjDI+VIXD7ZxuoEO+VG YLQGgd4m gahMslQbrbjrVPSBtGOZRlU3LLhZZyXGWgNsXg0y4FZSIVFJ+VdMBbTOTPS3U6Ac6DqtRArGqyotYK6TRmtMPkJA/B5xLgz/T+smp52fpmex1zQRi8e6r0NatSD2/w52JQTJRPFvlKunRKjpbDQ+A3Cg5fzIThfAPaXPpNdksVxKBwHjtxDV0+VvX4HKpkUIfmKD7H9BJFTMfOTs954azXdES7UR6yshtfflsFRtr4zxl1DwHHyywZKCcm0XtZsTWJO9ngVcpNUT6cshIjjGK9rcermN3B5AhbaddeXZVyYS6J/8CS8nL2nz2ZkIjITVDB0YVL/yfECB8xetMJFecEC2If0OzR4UHSbxL7XNN7zgZ3p+lodVnQCbGGOEuVljFsVeV/oQ/sQ55tIpq6HJ+lRcT6HihbVD5lX8jpixEdt/VN7HhTzNsq7Oo8PJHt6DDC4fQZy1BslIe4q0bcsobtJskMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 06:39:27PM +1000, Alistair Popple wrote: > There are two main use cases for mmu notifiers. One is by KVM which > uses mmu_notifier_invalidate_range_start()/end() to manage a software > TLB. > > The other is to manage hardware TLBs which need to use the > invalidate_range() callback because HW can establish new TLB entries > at any time. Hence using start/end() can lead to memory corruption as > these callbacks happen too soon/late during page unmap. > > mmu notifier users should therefore either use the start()/end() > callbacks or the invalidate_range() callbacks. To make this usage > clearer rename the invalidate_range() callback to > arch_invalidate_secondary_tlbs() and update documention. > > Signed-off-by: Alistair Popple > Suggested-by: Jason Gunthorpe > --- > arch/arm64/include/asm/tlbflush.h | 6 +- > arch/powerpc/mm/book3s64/radix_hugetlbpage.c | 2 +- > arch/powerpc/mm/book3s64/radix_tlb.c | 10 ++-- > arch/x86/include/asm/tlbflush.h | 2 +- > arch/x86/mm/tlb.c | 2 +- > drivers/iommu/amd/iommu_v2.c | 10 ++-- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 13 ++--- > drivers/iommu/intel/svm.c | 8 +-- > drivers/misc/ocxl/link.c | 8 +-- > include/linux/mmu_notifier.h | 48 +++++++++--------- > mm/huge_memory.c | 4 +- > mm/hugetlb.c | 7 +-- > mm/mmu_notifier.c | 20 ++++++-- > 13 files changed, 76 insertions(+), 64 deletions(-) Reviewed-by: Jason Gunthorpe Jason