From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2B58C0015E for ; Fri, 21 Jul 2023 19:25:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48A8E8D0002; Fri, 21 Jul 2023 15:25:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 461708D0001; Fri, 21 Jul 2023 15:25:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3506E8D0002; Fri, 21 Jul 2023 15:25:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 246EA8D0001 for ; Fri, 21 Jul 2023 15:25:54 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E3E2D403BE for ; Fri, 21 Jul 2023 19:25:53 +0000 (UTC) X-FDA: 81036598986.30.F99A472 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf13.hostedemail.com (Postfix) with ESMTP id ABA462001A for ; Fri, 21 Jul 2023 19:25:51 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=XQzjypm8; spf=pass (imf13.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.210.172 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689967551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MMsZNxLO6ied/G62NsNmuJtbpPqA/ZDXuniKdHv3YB4=; b=eizwTOOlaOqRPDw/wSYyxtVBoXWxD2h0wvunlB/0lnqLBKBvgEuZB9sET4UG9hJ5J2dqua xXA8G0yKRLGyhPEPNt0jL2+xyperGL+eHHObCa+m4R+GZ1O5Lf1vRZjcJLATROIhnJsqnC 8xQBnLq5KEvXQGaDC7x5qFGyTTpAi5s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689967551; a=rsa-sha256; cv=none; b=0uWeNaeGpINiQxxFVK0Mp6i9FMcbJN2pJHooy60sWwGhY0VcmVSS4yJphVGLCV+G/Ijqi8 pGzBaZCaORLl6EFRXMUQkCK1DZWlFCR3eEIFzQN+wN5KGFIsRPWWxgZe8+shoEtAbiITs5 kZnK3i9/96y294o0QAXoQV/BW2AQE2E= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=XQzjypm8; spf=pass (imf13.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.210.172 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6686c74183cso2002791b3a.1 for ; Fri, 21 Jul 2023 12:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1689967550; x=1690572350; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MMsZNxLO6ied/G62NsNmuJtbpPqA/ZDXuniKdHv3YB4=; b=XQzjypm8qf/fouvehrBkEZjx7rraTNYkUvdCKXn1r1gfZnRnhcrrwzmNXN35Uu7gzI 8oZahINtXmo9uCfjOT5mfF9tPFqadYED4ml2Rvg4gr4OGGmk2vfi6ALPhCVFDbYVbCVR bizj8weYssavNq2IYvHIenQVmt+p9+kOYvZhgrRMHxTk+VUEpNpnyoTxavBUyIHeBvaf qo1QRc6+YoA80RoGKZsLsD7vsvUGziFJq2u5Wn3UEGI6GwRgyCcJvjby4g2TfS0YmrN7 IaJoLwJh5sfemxuaaNtQypWoArXN7KcGOCwTG4BZdi4RfD5EEjDf6oZVJxfS3TMV68DT 4znQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689967550; x=1690572350; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MMsZNxLO6ied/G62NsNmuJtbpPqA/ZDXuniKdHv3YB4=; b=UXVBjsu5xKSkhztTKU/woPRhEUHEkR/u92IxGq1VQ4A/N/BFwO1Z2TX6/vj/pg0UjP bprFWr0BGokfPgExJJEXE0CVt/Ta+9bow3VcaxI/jmUyl1V26FCLf5NZ6YNYU8/qpmhG /NPIG6JYeQFvQfHkG3vjqIY1lo4Ynsepr277S5w7Q2U7bIBvY7MPsHia/8C7uas1Jb1M B5wHDEKoULfLHzmDLGPKMuj/A8/gi/KHtdAQt+Wy5YmUhzZqvQi+NiI5J/RzU3gEG1qq MX3hJ+4W9FbbZ4W4yHW0YDKoIMXuBKzgUuL6O9acD1G5aoDDVIAvfNJKOSFFptAQK15X JWtA== X-Gm-Message-State: ABy/qLZU5S/nfCfAzZKpf1r46+sZ6oD9QMiHgNKTDOSN/hLV1SEXJzdy V1pkhNxd/ehB67aasyTlpVatbQ== X-Google-Smtp-Source: APBJJlEp8s38SXROq49pagsC5pVvuYXs5UAkGBJHAYanGZ9PMcBXp3bCvAhBUtgXgds2MFlgz7aUow== X-Received: by 2002:a17:90b:2308:b0:262:f06d:c0fc with SMTP id mt8-20020a17090b230800b00262f06dc0fcmr2530695pjb.7.1689967550531; Fri, 21 Jul 2023 12:25:50 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id d5-20020a17090a8d8500b0025bd4db25f0sm2845416pjo.53.2023.07.21.12.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 12:25:49 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qMvl5-003ID1-Uq; Fri, 21 Jul 2023 16:25:47 -0300 Date: Fri, 21 Jul 2023 16:25:47 -0300 From: Jason Gunthorpe To: Alistair Popple Cc: akpm@linux-foundation.org, ajd@linux.ibm.com, catalin.marinas@arm.com, fbarrat@linux.ibm.com, iommu@lists.linux.dev, jhubbard@nvidia.com, kevin.tian@intel.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, nicolinc@nvidia.com, npiggin@gmail.com, robin.murphy@arm.com, seanjc@google.com, will@kernel.org, x86@kernel.org, zhi.wang.linux@gmail.com, sj@kernel.org Subject: Re: [PATCH v3 1/5] arm64/smmu: Use TLBI ASID when invalidating entire range Message-ID: References: <082390057ec33969c81d49d35aa3024d7082b0bd.1689842332.git-series.apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <082390057ec33969c81d49d35aa3024d7082b0bd.1689842332.git-series.apopple@nvidia.com> X-Rspamd-Queue-Id: ABA462001A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: czbfdmkge6n9oxdzuce53dhbzt7m46n8 X-HE-Tag: 1689967551-59266 X-HE-Meta: U2FsdGVkX1/VQTVm9K8ERpm00xgzAUqkJK7wnMxSS0DLBH1Y+9WRV1LwKKytPKXhqp+59K8sRgpvjGHUUPe7yDdQwD+jPrO5bNCC3gXhKEkr0rFtRSLHWQw1f3ErF76cxkAHSfev9bmbevM4GhVhDa5otrSRfmYBUUNrwrb3yYkegP6a9w2/lTBDTYI8pjtz3d6MdpIDaEfjMKYksbObhRR4s28j0YxVfJjArcIqBs1USwSvRQbZ4bIeb2EdJT6bLRYkgVMnJTupYDqwckXJ1HwSUCLUNwYfvpa3mYN54tGf2h/psjFWYvjJP3OuCiaZs21qNDvEjVZtdQAOku3yHPbbSChAu6egsqqTmsqqZDV8IsXG12g1yn5NB4L81YVrR5HPjHSCiEUNEn9l5Fb/77VWQ6sIO/IfN2qZ3qLzWMjRjpqciJaEokyyrbuBL3fhztEHdd/AXUfxQQw3IZtBG/C1nJ5q/qDbA4rII2rbjfH8VIRB2dZu+AH2XUho7bTStktz8J/icWV+jpzl9TV/vFSCpCoW8g4sVTlpM1pXI32qqFj/l05Ij3YGPZW00W0q0inlSi8jIiO9WoQfr0zFIm9gbIbrqkn0gpl3fP6nf++zs0NjAHux4au667s/4TteahqUm6TvR0WEvKeDFhAiI+mqqdB/NytfEL8Aj6HyOvTCiJBm9XA9JCiO5IW5b9S0+gTBZejchdwH++mYIG75ruP2CAGjCzmYi++s2gnfkZEKFhdHPen1Z235EByPwCriaiOJP9uSPsK3mgr9xvSc0IRE+FBHrS+NJ8eadQ07eIYEnfNMNWwfLp+aJOh2DVr4lWahj9if9RTLv8ArnxVef7h6v74gw5gRne+O9XBy89Ed3dh4kDS7ycQg8nDdEIfb5dYPi6bv/y3Zc1LCLjw9feUXDDv5E/PXnJFFY4UrFdy4W+aCnThnORGX4u21veru9s44/Bx08hl2JrJGtoI +fWgj2EB mLv5rRlhx9+iYcjG6VVs8bM/f1mwCpwMnv8U9xkERiph6Dj1K+TFCj78jA9KCZUz2hULBHLacAZzzAR3Oz/iN7aP7s3MfLJTYtLJxa3w7l5uPzQKc8Ezagxd1YHgvTwdGP27QX7RF9ZwYbht7YzQELeD9lAREXwe2ShHh5Q9iUBHCHZDk+XgNs3BPulek2fCUUFd9LOPd8HOvt0YiO8yVGrFv3hV3LQfoRY3YfYQNaX0btEocpAKQ2irmuVLc0/BgjlhOfCfXjATBpdEgseAYHVxPkHrGzF1NU+jWdHhaMTBJ7anM2qWSFgwufTkEF8pRyJB2VS/LKVjpUjAn0hUZL7Rz4mlueL9V58Mg/eUYeMaKJAZOT1HVgEWbrTTSJt1evFSCN78/8eP2wkBct4t2wvice2f3umyiJXRDvjZ6RxzK6vA0IK2SswASZ6HfKUVEW1WRLj+nP1JiATya6kfQMTXXeA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 06:39:23PM +1000, Alistair Popple wrote: > The ARM SMMU has a specific command for invalidating the TLB for an > entire ASID. Currently this is used for the IO_PGTABLE API but not for > ATS when called from the MMU notifier. > > The current implementation of notifiers does not attempt to invalidate > such a large address range, instead walking each VMA and invalidating > each range individually during mmap removal. However in future SMMU > TLB invalidations are going to be sent as part of the normal > flush_tlb_*() kernel calls. To better deal with that add handling to > use TLBI ASID when invalidating the entire address space. > > Signed-off-by: Alistair Popple > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe Jason