From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96BC8EB64DD for ; Fri, 21 Jul 2023 18:25:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31A3B8D0003; Fri, 21 Jul 2023 14:25:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CA588D0001; Fri, 21 Jul 2023 14:25:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16BFF8D0003; Fri, 21 Jul 2023 14:25:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0296F8D0001 for ; Fri, 21 Jul 2023 14:25:34 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CD39014038B for ; Fri, 21 Jul 2023 18:25:33 +0000 (UTC) X-FDA: 81036446946.30.534840F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 48C1CA000A for ; Fri, 21 Jul 2023 18:25:32 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689963932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7/ZsR5qhNpsaI7It+i/lja9YCvTQH5CI17/Q0gkAP0Y=; b=tZfVZffS2kGy03QBVp9K6nImwJAyWVpYso+QMxdN4wKqSA5boiYL3r5orsPwX0uEEayz4W B8h7PqjHEFdyVjTy6BTvDm6c7qvkSkT9pH1eem9OEQnQPVtgxlKLCPi3ne/FWs00KaZ5jg ji8W+PnaC5FDowS1H9hlcPF8bxIHZZo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689963932; a=rsa-sha256; cv=none; b=qGntILEg6E6MEduJKjOrMHDRNMaI7VsU1iCQnUTMzJAcHS8ERN+7/X97E0h4euC145jym1 4WgwKkurUUwD20opGT356vE58G8U9SsArVFKpH66DWGehGsuutrOrRnVTP+vMEQM1zw1nb obQLKC7Ztj1QTE6e/QioMoYHoHC0ZgE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 67A2561D7E; Fri, 21 Jul 2023 18:25:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C769C433C9; Fri, 21 Jul 2023 18:25:27 +0000 (UTC) Date: Fri, 21 Jul 2023 19:25:26 +0100 From: Catalin Marinas To: Alistair Popple Cc: akpm@linux-foundation.org, ajd@linux.ibm.com, fbarrat@linux.ibm.com, iommu@lists.linux.dev, jgg@ziepe.ca, jhubbard@nvidia.com, kevin.tian@intel.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, nicolinc@nvidia.com, npiggin@gmail.com, robin.murphy@arm.com, seanjc@google.com, will@kernel.org, x86@kernel.org, zhi.wang.linux@gmail.com, sj@kernel.org Subject: Re: [PATCH v3 3/5] mmu_notifiers: Call invalidate_range() when invalidating TLBs Message-ID: References: <86a0bf86394f1765fcbf9890bbabb154ba8dd980.1689842332.git-series.apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86a0bf86394f1765fcbf9890bbabb154ba8dd980.1689842332.git-series.apopple@nvidia.com> X-Rspamd-Queue-Id: 48C1CA000A X-Rspam-User: X-Stat-Signature: y31f8whwd37qkd7syxzb8jgdhh9gtn3e X-Rspamd-Server: rspam01 X-HE-Tag: 1689963932-116208 X-HE-Meta: U2FsdGVkX1++A7honx4waknlzmUMcWKHr9wr4Wx6ZrxJ2ELPi4YVXZtqA43RC9j6GU/xy6aFJMMgcr/KDzSoMi/TKVPNmBn4BQLWJ0JpfGidsTsFemst2XH6jXRabh3BbWGhJMBfS4wZuwn9z2jQL6eVAwMz01Zcj+1Iqyd+nMo0+nCSJ+EoUpaxt9CFjQSPCSw5doDVjFy5FFt22Borzxy2NXfrOP89xfnFD6fhCafwfv6JrTw9a5SRfXSIF+naXNpgKWaLi6Wk6EEKOeTKO2RHOUlSCJ4TJyrDFXcBvNURrN5+joxC8SrRsfzXt5WrYbs8nf7yKjSZ5fQgpn9l5f2s3LRDCmGTmP9tKr/+XliYLE1hOLqCU0mmhzmfCjDsSkz/iq/QE/7tAY3q9QUIjOtnKF6twkOl+g5+ZyMsaKS8GJIVWMXybS/Pt+y9ItkYQXlILTcwq5oQAPjEPJJWimlIgSizmxTCy/AqFmimraFZbL/rY/praSZTcPDSZI6XBG4ZFOsZirdfkSyoEkUcWCIr7sNf1QXTHZh4ap9ZPHnG3c9X2pRfHfSlxYGxf/loGqxbU2Bjj+MJqkQgMdcu5r9gQA1niXI7FCYsNe/OC6np89UgdLXvGhiNJ3KFIQKpstkLoH6mk8oA1NuQQ1dshXLOE2GS1raD07VrIo0GlvZ8XzXHBDsUBbmwy1BMAD0Ey3BhICb17DlwCTRRyvn+IovIPebzFYp1OLxJe276OtUaeItREfCkz1j69NCg3sjLVz3Uf/jG0euQwgOYeycW4M4lY8Si185j+ecG0Sid2dXeT+SOhW5Uush9GbOiiCiAW2JWh3gSY2amALPur/Hqkhp8UBWBbC0elMvDuqohuD7Lo12iFPA8upoy0AEJtU2BCfw++LPzWGa6QBCDAT4nL6KdwAv0Vywdqf35q8rqcJw8M/sDFQryM6SVd7gsMhwo5CM2hgBPCxhBdqCEuzi MUfYBOQ3 59pVuEIrartVKzi9vsf1/3Kti9gHzf9jDz6mCpRoprk2roAzj3NMFX7iF0BUE1F+TAawWOL2EiCKtXVjfs3CPI27XxCQEwJWrDfSt+++e+7RQOmBll7yJ93VJbfbiYmxoaYCab3uzVYcdwH2Z3DBpFTcj7s7hPirgZJBLdN/LWg8C+F4pAmU9Wo8r1VZSTZPIBajxoxB+PIHUJrAQSw4wm0oP/nxWhTlAyi7Uy1/h/EwZyHDsAGpthUiRpRYoUaN3OK/PvaVhaK+2IJti0vD9TWON+hi7+Pct/cAU1kkmjvkQtx+agFHfar6UwP0rZ9r0vkhjD7kqKlqsmhFyPTDL9KXUblY9islaEE6usbVx7QwGIDwOH3Cjm9izxTxNmQGdye3hk/XlLJW0xyWbD4wlrAu0mfC+veIWNv5CCArzZkSOYRTYkWmRcdPEBm5muhvSlA4xupZ+r9tbQMx+m18dE/KMugVhICBHCoJMi/1hBPrnHV4fWa3dlT6ynxqJYC25tAZ89+kkZqga+O4uBbnK75em+ShNZYfHMN48ulY7eJvFEAT4Rsc+KI/VIG1hsg8NCJHp7vhta8w1qeelXmGuIXI7+fbqhISj82Wj90NuJtrIgWMTpwmtU0FFRKw7QXxLTNTT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 06:39:25PM +1000, Alistair Popple wrote: > diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h > index 3456866..a99349d 100644 > --- a/arch/arm64/include/asm/tlbflush.h > +++ b/arch/arm64/include/asm/tlbflush.h > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -252,6 +253,7 @@ static inline void flush_tlb_mm(struct mm_struct *mm) > __tlbi(aside1is, asid); > __tlbi_user(aside1is, asid); > dsb(ish); > + mmu_notifier_invalidate_range(mm, 0, -1UL); > } > > static inline void __flush_tlb_page_nosync(struct mm_struct *mm, > @@ -263,6 +265,8 @@ static inline void __flush_tlb_page_nosync(struct mm_struct *mm, > addr = __TLBI_VADDR(uaddr, ASID(mm)); > __tlbi(vale1is, addr); > __tlbi_user(vale1is, addr); > + mmu_notifier_invalidate_range(mm, uaddr & PAGE_MASK, > + (uaddr & PAGE_MASK) + PAGE_SIZE); Nitpick: we have PAGE_ALIGN() for this. For arm64: Acked-by: Catalin Marinas