From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9740CEB64DD for ; Fri, 21 Jul 2023 18:25:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38F2C8D0002; Fri, 21 Jul 2023 14:25:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 319068D0001; Fri, 21 Jul 2023 14:25:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E0DD8D0002; Fri, 21 Jul 2023 14:25:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0D4CA8D0001 for ; Fri, 21 Jul 2023 14:25:16 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C12381C9046 for ; Fri, 21 Jul 2023 18:25:15 +0000 (UTC) X-FDA: 81036446190.11.BC1642B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 2BC2C1C002C for ; Fri, 21 Jul 2023 18:25:13 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689963914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u22j1tQJjYe2c+z4v5sEZIj1MZ/hC29GTHuxq2STV5s=; b=4pJPSo2tQC50WC9lSOIF5/MKTyJXFCYZHGJMQJ2YI/ItvXYIKvSFMesSSdSlBlYRL6Xyof hUOV3b6716c/nbv9pBv2OCnDCgexIahZkA9gqQSff3gOSeb0IEon/N9f42F3DoWczEjhhC fEWhjBIwADSMJrychhkSJWAHvsHAiCY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689963914; a=rsa-sha256; cv=none; b=ash3bYIKAxWpry9Q9OdPCAwA1De5Ieuw9yT38IXhN+LhQqfY8KULfZNZvfBzfPzGrJL7v6 ED2B5Uc3nQjBKhMIkH+bDkXd4CBB5dXYZhwTur26GT95zPTIeyaQv9PRK4I1C9CMC1Afgu /wVi3V/FM/B0FWrYq6TuHKCBsLNpF8g= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5D98061D70; Fri, 21 Jul 2023 18:25:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D11E2C433C8; Fri, 21 Jul 2023 18:25:06 +0000 (UTC) Date: Fri, 21 Jul 2023 19:25:05 +0100 From: Catalin Marinas To: Yicong Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, mark.rutland@arm.com, ryan.roberts@arm.com, will@kernel.org, anshuman.khandual@arm.com, linux-doc@vger.kernel.org, corbet@lwn.net, peterz@infradead.org, arnd@arndb.de, punit.agrawal@bytedance.com, linux-kernel@vger.kernel.org, darren@os.amperecomputing.com, yangyicong@hisilicon.com, huzhanyuan@oppo.com, lipeifeng@oppo.com, zhangshiming@oppo.com, guojian@oppo.com, realmz6@gmail.com, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Barry Song <21cnbao@gmail.com>, wangkefeng.wang@huawei.com, xhao@linux.alibaba.com, prime.zeng@hisilicon.com, Jonathan.Cameron@huawei.com, Barry Song , Nadav Amit , Mel Gorman Subject: Re: [PATCH v11 4/4] arm64: support batched/deferred tlb shootdown during page reclamation/migration Message-ID: References: <20230717131004.12662-1-yangyicong@huawei.com> <20230717131004.12662-5-yangyicong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717131004.12662-5-yangyicong@huawei.com> X-Rspamd-Queue-Id: 2BC2C1C002C X-Rspam-User: X-Stat-Signature: bdiuhca8fyciwzt8exkfhy8tafnbu8at X-Rspamd-Server: rspam01 X-HE-Tag: 1689963913-481375 X-HE-Meta: U2FsdGVkX19gn4w1x4DtMud9G6HIfOtaC6E1boylG7chzb/Av5MRjuABccOJxKCr9SdS/exU14Md/nBS/3EZbhiNgQS4ONO72XPMDbWtfD4+w5Gk6GxTM37QlyrKWaKTXq03EJhlzicAyaseZX150R6Q5fTHPx7Z/xWVCvFBSXb7iIUjIxHD6bj1Bad3sDUyM2oFcpL/9JoN/7oy1YWT3C/TEg1x/M2kU4X0zXXbTMuz8OwWlLWiQvfCRDbtX7JLvFEKahH+1tHGJRo2X4E7kkvMv/ovHAeHOQR8K9K6/x0BiGTJv4fRIaM8jNGq3/oyq0vQOmXpimYyQ+51ejy80Vy/g+eGe5it9hGXej5X56s4nrefpMZJlNH/ivRRmoAR+8YUqYW7hAk73dvOWz+5icjzqujYtAORKt2rg2h2qjOghJi1LH2a0poHO0+rAj7fgTUSM+NOojdGl/1fmW0W0drU+m/2ZNuP/H+tN3YUd390IQW5Er7SpPR/RDWjI2l8wCeDy0I72mBTl0DZVwJ19oXZ5krhxea3jhQfOCleVFrKKd7I0uR2/WE9AAvlsQKb/CrRKha9npbL0DYL5xABm2yMpCul0ZJ117KvaGQ3xdXZ653W2xZtNLagKQBxe0RUqBt+1mZeif3KYhZp2z81NW3pPrQQEskePVCAgq4MEa5wpe1AN8S1jySlux84nUkGrvRVhSPZDXK9poKaUglshQ5ILtj+r/Iybj3Ph9Kdq29jF+5CN0y3jtXbt1yxBNK2Aao6x31udTly15TIgM2axuKNuuqNJEYG4Vwh6Jwz1ydB7cVTz8AZHSTrhO1d8PGd50xWfGpapNbiGruV1vxgP4BOPK0EudQ4h/JOOtsMTsvEi51rdAOtjI+Mz7F9FZXzYXB6LdLupWX3/dLiUNzrO7shInHFOj2AqX4zip6MXY5OHs0e+g3AU0MRxAiQeCG8wyFBKQKtMQOZs6ufE8W UzYwjw2H ORrTKzsDH2ADH8XMmq0MPeAp9/VgT20m0w8nykyd/VvrVV98VmDSPi0bfKFCGGACXdJh8asC5kC25WMr6HriCQZ9btbSSTzW0l9Y3VBfWSPTDC/23SMU8GDvy6CyAMKDjRZCSyBFXvcs4Hvv6BtG2WonYyoupz+HMtQzMdYc3V8E1puLrqt4RGGmz2cvMq2UE+7HVUItiQO2HRZcubSGSy6t5YntL9piDbDt7zrSSD7GySkf7Ckn0JDpxaEpVh7VrE0Nc0GtEOz4s1fSdCdjOggDz5I6uRbqXx2hkQQKtlxDvaqOYDyh5GO8jw/mG15Glfty0Nlea86Ql3LNnlOt9KixpZrdL58E55KiCWWba5vRmhZ2QGlOtrAau7S1yNZIX5NsIYI0YUdF6pz0TIKpu5w72B9l/L/G90d+owWsshc+2pwdDMjWdgPUMR+nqvCSbtj7q1FG5A4DXd4RznmbpA4JrbXoRF8my+lzs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 17, 2023 at 09:10:04PM +0800, Yicong Yang wrote: > +static inline void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *batch, > + struct mm_struct *mm, > + unsigned long uaddr) > +{ > + __flush_tlb_page_nosync(mm, uaddr); > +} > + > +static inline void arch_flush_tlb_batched_pending(struct mm_struct *mm) > +{ > + dsb(ish); > +} > + > +static inline void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch) > +{ > + dsb(ish); > +} Nitpick: as an additional patch, I'd add some comment for these two functions that the TLBI has already been issued and only a DSB is needed to synchronise its effect on the other CPUs. Reviewed-by: Catalin Marinas