From: Catalin Marinas <catalin.marinas@arm.com>
To: Yicong Yang <yangyicong@huawei.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org,
mark.rutland@arm.com, ryan.roberts@arm.com, will@kernel.org,
anshuman.khandual@arm.com, linux-doc@vger.kernel.org,
corbet@lwn.net, peterz@infradead.org, arnd@arndb.de,
punit.agrawal@bytedance.com, linux-kernel@vger.kernel.org,
darren@os.amperecomputing.com, yangyicong@hisilicon.com,
huzhanyuan@oppo.com, lipeifeng@oppo.com, zhangshiming@oppo.com,
guojian@oppo.com, realmz6@gmail.com, linux-mips@vger.kernel.org,
openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
Barry Song <21cnbao@gmail.com>,
wangkefeng.wang@huawei.com, xhao@linux.alibaba.com,
prime.zeng@hisilicon.com, Jonathan.Cameron@huawei.com,
Barry Song <v-songbaohua@oppo.com>, Nadav Amit <namit@vmware.com>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH v11 4/4] arm64: support batched/deferred tlb shootdown during page reclamation/migration
Date: Fri, 21 Jul 2023 19:25:05 +0100 [thread overview]
Message-ID: <ZLrNgfDNyZGWx5bG@arm.com> (raw)
In-Reply-To: <20230717131004.12662-5-yangyicong@huawei.com>
On Mon, Jul 17, 2023 at 09:10:04PM +0800, Yicong Yang wrote:
> +static inline void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *batch,
> + struct mm_struct *mm,
> + unsigned long uaddr)
> +{
> + __flush_tlb_page_nosync(mm, uaddr);
> +}
> +
> +static inline void arch_flush_tlb_batched_pending(struct mm_struct *mm)
> +{
> + dsb(ish);
> +}
> +
> +static inline void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch)
> +{
> + dsb(ish);
> +}
Nitpick: as an additional patch, I'd add some comment for these two
functions that the TLBI has already been issued and only a DSB is needed
to synchronise its effect on the other CPUs.
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
prev parent reply other threads:[~2023-07-21 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 13:10 [PATCH v11 0/4] " Yicong Yang
2023-07-17 13:10 ` [PATCH v11 1/4] mm/tlbbatch: Introduce arch_tlbbatch_should_defer() Yicong Yang
2023-07-21 18:23 ` Catalin Marinas
2023-07-17 13:10 ` [PATCH v11 2/4] mm/tlbbatch: Rename and extend some functions Yicong Yang
2023-07-21 18:24 ` Catalin Marinas
2023-07-17 13:10 ` [PATCH v11 3/4] mm/tlbbatch: Introduce arch_flush_tlb_batched_pending() Yicong Yang
2023-07-21 18:24 ` Catalin Marinas
2023-07-17 13:10 ` [PATCH v11 4/4] arm64: support batched/deferred tlb shootdown during page reclamation/migration Yicong Yang
2023-07-21 18:25 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLrNgfDNyZGWx5bG@arm.com \
--to=catalin.marinas@arm.com \
--cc=21cnbao@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=darren@os.amperecomputing.com \
--cc=guojian@oppo.com \
--cc=huzhanyuan@oppo.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lipeifeng@oppo.com \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=namit@vmware.com \
--cc=openrisc@lists.librecores.org \
--cc=peterz@infradead.org \
--cc=prime.zeng@hisilicon.com \
--cc=punit.agrawal@bytedance.com \
--cc=realmz6@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=v-songbaohua@oppo.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xhao@linux.alibaba.com \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox