From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86180EB64DD for ; Fri, 21 Jul 2023 17:43:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0444C8D0002; Fri, 21 Jul 2023 13:43:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F36838D0001; Fri, 21 Jul 2023 13:43:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD7728D0002; Fri, 21 Jul 2023 13:43:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CF7F18D0001 for ; Fri, 21 Jul 2023 13:43:02 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A3FB0120385 for ; Fri, 21 Jul 2023 17:43:02 +0000 (UTC) X-FDA: 81036339804.23.61CD936 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf08.hostedemail.com (Postfix) with ESMTP id CF3BF160012 for ; Fri, 21 Jul 2023 17:43:00 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Kleh8Qps; spf=pass (imf08.hostedemail.com: domain of 3o8O6ZAYKCEIwierngksskpi.gsqpmry1-qqozego.svk@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3o8O6ZAYKCEIwierngksskpi.gsqpmry1-qqozego.svk@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689961380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7DBmD+NWofmGocm5Vnh+WkykM6ONviwwjpnheMJOIK8=; b=OXPWjK02CggO5nhPQ28jdpFRIIR218oz0cNdR7rhK+7nJQM7s+AHtEizOkQ0Ipwr+/f2GG abYvZZ+U7CSUvkQTpnha59Hja7Gak1sVfYu2Nw6N+Ub5Y5LfYqjQVdK6e0RwARsZOT/g9W nPixJ6pu8KRiKlzk1N5nLWFeR1z9wVg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689961380; a=rsa-sha256; cv=none; b=ceZTd+ZK0fM+eqw2YAPCx7eGkz5Ua559bhmzrTfuwPn7FHTG1YMwset3oCt8SY0VD/6rXk wJCXilLP/uE8J/dX6mLFGpD06DNXSOYXIsp2pKoDVAXM/lZ9TGvkQwGvlDqWzLcoYrdAyK yGU5nuYbqHrmUHpcYVnzQJbnRzzhARo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Kleh8Qps; spf=pass (imf08.hostedemail.com: domain of 3o8O6ZAYKCEIwierngksskpi.gsqpmry1-qqozego.svk@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3o8O6ZAYKCEIwierngksskpi.gsqpmry1-qqozego.svk@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-d00a63fcdefso1470334276.3 for ; Fri, 21 Jul 2023 10:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689961380; x=1690566180; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=7DBmD+NWofmGocm5Vnh+WkykM6ONviwwjpnheMJOIK8=; b=Kleh8QpsTsNUhesVcFKaorRemH2b7oCPrjs/EZvvDbSIhnU646cwazqZifDUNyxi+Q 5JqV9CUAW8QaG2YIfQCin1qnHve1MgXICSxbyDPLV8MjQRP2Kpasi9pL5sbB8O7UYjBa jgRp3U3UDnkkD6e19TR7wMGjHPVEilwKuPvhlll1BPS6C8DVpWehyFU2WczctGneBM1v 8h/JnmhFLy8tlfXVq6NzVrFmSK26MkEiOaRidvtVK6eqi9qhd/VP0gDfCAxADqhE52gi 5Uc2vJ9HkSFyp91F1M5r9W96Us+3KtG0sWvhTTO0jFsQ1GbEx81tOU6Kjmmi3SIi/0Fk yy7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689961380; x=1690566180; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7DBmD+NWofmGocm5Vnh+WkykM6ONviwwjpnheMJOIK8=; b=MYX5uQXwfPvsMxhLJYG0WKktAsw1xOJ/Lvzbi9B1bz+i7uOU2Cm0HiOfgtBILnmlSM loxhMGIMdmoKIIRmE4vhVxlvBa3tiLAS7k+TIobBukWyl8fXHCPimO22pGpPl19/E/62 wnxwtCjF1eONoAdp0DeilyUTArADj5M5HPHCXF0/INqNYsYEQEi+offMHQmaZxRt+BMy uT4ic8WJZ326mSiYNX/gv3qWR0vOplnHaLvGyOSEHEpjlgPBFlygdf1xNN3YqsqJDt1i pAkJ1nfPtZslb/vHCAb6Rn9SlYHgRZkDzI+T3fM6FCDQS9+QLS1tTp1jWlGjM9j+25J/ +6fQ== X-Gm-Message-State: ABy/qLawQpx+Cwh6wE2iA5poQUWtRwR7y7xNREnN51Sp7l47Cvs+gj3i H4QqzPBwm6iu8cq4uEMtuc/PEZYltGU= X-Google-Smtp-Source: APBJJlE/aF1pYHHKoAMy1+E4aY5+aL4FeQDb+p2ML0zhZVvr/Ah+OV80Lx1tRjSoeSb0qOhWhlHbRbztBVY= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:10cd:b0:c1c:df23:44ee with SMTP id w13-20020a05690210cd00b00c1cdf2344eemr19665ybu.0.1689961379855; Fri, 21 Jul 2023 10:42:59 -0700 (PDT) Date: Fri, 21 Jul 2023 10:42:58 -0700 In-Reply-To: <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-13-seanjc@google.com> <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> Message-ID: Subject: Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 9m4uni4e7wo15tuk5syr551oepsyzmmi X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CF3BF160012 X-Rspam-User: X-HE-Tag: 1689961380-872818 X-HE-Meta: U2FsdGVkX18nR7o/vtwMBi8gLL38bImML7LJazX4HxnQajJ1YtxB6k8a5qa/iPsCffaHsaCgxzRHcOHJ9zYyITzXCcs+dliIcds602BCOMzG2CKgB9yhAzXV3CBBy2MbVUcFb4CRSj0Yz1h8Pox5gVTy2MPKrQucFZJn/pFQGW5a9TPNeIPtm7B9pH4NrC1QMATN6oVbq83YeBpJ8HCZAG6VbAP3HNHC1Z366sjSQ8xdBD/MBNHqHBb1sF7XgxFftaD2hjewmCuMO7Zpmp+ot9+LQoS6rOdTD57AKsnPhe1GvEB2t91q3EnfInvfHYBoK+5GnJ4d8zBxVciKLccyxLTfar1HF1qwqn78DSJtuBcsouAv0M5AQAYrUZkYYr854Z1RS5LPPVKMRPGXPr22K3DUCQek0MaGlsky02yckC7FbVsjLwZK08YJUbBl0A5is+lEQ5qcuA26O8wiBv67hXqqfLbaouc2tdFX/0VHua9EykgHCIZjQ0vuCcl6wYWul/8jSmSxAy84xv/3v+0QUV2o6VG2J1PVQV9R6UU6XqdKUFKxQTD+YFPUZJGFtPDYY2kLAuX3jqvikhONLEVfHJymq36VSLYd1gQBfbBijNBJOISjN7BCMCRF//0M/u6SievKBfKlY1vs1Q5g396+73NtWOvNXv1Agd4YP8u61wNGCfYujPrK8Dnmvfe1kVjDVYBLDDUM/meN5d7mrGlHB2LyzKOjO8KdhHsdV2/JcygaH44mPCux0M2LNtq/PmGO33j/lMmxZziGbSHW1Vd5Ocjh5P6kwkWSrjG3nfAmWZ2Xx2J7FXMGrvkQUoUqwRuo7l9fiKA76no1ZoxAOqlL8z15hMEu5R41Uzxi2EdO+BZNIDNgxXotTzdJF9bjgKidhfpEvLTPNyx60Bkks1eg0iLslUpfPfhLrhJccHoyKlPLY/vM8vwA1ca/DS0fokdT+FO85y1+pCvgRbD5K3y 1oJGifrd NFkbVVVlQJbkQAtlv/Wnw+N1s/0tQcyT/pwvkKRAnUcLI+IORTsa72RKybQt6ALJBbyC9NB113WwDf+UJhDgkhVqDp2NlGRcjxHjSdkVe8CeBXImCzvEOvR0qyvl1N47Bzo3Ivhhrmm3ROezONE6EFcXucWDLFU5eILE2ai4imGpq26wN4h6eYJPG0BjpW+r62+UWJ1WDib6Jh5iOOArf6FVl0DXzmRI4VajrRUQpF5g/HRtu6LvA/BscfFjUGWSg0m5/ChJwpYmGM2zoiDes4bx/XzNgaJIqTFZFIqpqz+gKvhHsQx737ydKwbZiYRh1reNsQsEQwXfaaY1krbLbGhsb6b5YRrNbglGmmNkdGQ+e9A4GtRRXorqRi9TZQsZd6LTcNUYtD/QrELpUQqCfeaVQVTEigbS2kW/wdGg6/4jMU+yGVrGGl68sdZ53E6UTOPVvnKAb2fah9oDekX8SQENcVYimBSbBBy6Nc6yWmg1reAhbe7b5McDIovZRLmi//wcKDXFYCSf/Aw3EQ1X7wCPD4pQn0ePm7WlWmIt38dF8HxvESNv422pq/sqqhKCoH5+4NstptxUTpI9uOApfhfbcibbBVcN2X1KbayA8S5ChQkk2YKPw3YZN/Eyj3iNwrwBsze0e8N457tFgTkV0A8zwB77keXRppdLkr055Ia0cjgT72VQJ6Agf7Ugi9u1i4IZjB0wyRqF65Uk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 21, 2023, Xiaoyao Li wrote: > On 7/21/2023 11:05 PM, Xiaoyao Li wrote: > > On 7/19/2023 7:44 AM, Sean Christopherson wrote: > > > @@ -6255,12 +6298,17 @@ int kvm_init(unsigned vcpu_size, unsigned > > > vcpu_align, struct module *module) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (r) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto err_async= _pf; > > > +=C2=A0=C2=A0=C2=A0 r =3D kvm_gmem_init(); > > > +=C2=A0=C2=A0=C2=A0 if (r) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto err_gmem; > > > + > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvm_chardev_ops.owner =3D module; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvm_preempt_ops.sched_in =3D kvm_sched= _in; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvm_preempt_ops.sched_out =3D kvm_sche= d_out; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvm_init_debug(); > > > +=C2=A0=C2=A0=C2=A0 kvm_gmem_init(); > >=20 > > why kvm_gmem_init() needs to be called again? by mistake? >=20 > I'm sure it's a mistake. Yeah, definitely a bug. > I'm testing the gmem QEMU with this series. SW_PROTECTED_VM gets stuck in= a > loop in early OVMF code due to two shared page of OVMF get zapped and > re-mapped infinitely. Removing the second call of kvm_gmem_init() can sol= ve > the issue, though I'm not sure about the reason. Not worth investigating unless you want to satiate your curiosity :-)