From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D761C001DC for ; Fri, 21 Jul 2023 17:13:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AEF08D0002; Fri, 21 Jul 2023 13:13:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15FF18D0001; Fri, 21 Jul 2023 13:13:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0272F8D0002; Fri, 21 Jul 2023 13:13:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E664C8D0001 for ; Fri, 21 Jul 2023 13:13:50 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A99DF4039B for ; Fri, 21 Jul 2023 17:13:50 +0000 (UTC) X-FDA: 81036266220.27.15CC96C Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf06.hostedemail.com (Postfix) with ESMTP id E6804180016 for ; Fri, 21 Jul 2023 17:13:48 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=saEUf444; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 3y7y6ZAYKCFwM84HD6AIIAF8.6IGFCHOR-GGEP46E.ILA@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3y7y6ZAYKCFwM84HD6AIIAF8.6IGFCHOR-GGEP46E.ILA@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689959628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7shZuEDiffXRYK22UXnQcffVUND6wfTW4U7DmHj+BWc=; b=NQdLtshGP0s6XyAVXVE84sGDieT+5zw8jzxf4EHgYm6LqocGJmxk7cPMlv+psMYx8ChKcF Kfe0PecUZ/+CUSP1uR3auu7S4omueif8gh1lRq5hrkP1mP0K5LxHeD9jT3PX0IYSOIjhKV Aa/mgYi7HJeCaQuhjRnk7U0XpuZAUa8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=saEUf444; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 3y7y6ZAYKCFwM84HD6AIIAF8.6IGFCHOR-GGEP46E.ILA@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3y7y6ZAYKCFwM84HD6AIIAF8.6IGFCHOR-GGEP46E.ILA@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689959628; a=rsa-sha256; cv=none; b=mfss52uT7tbzLF7uha36n1nbxs4t+D4K5IaA89e2QspXmxGdejfIi/t/vtpIApaXspGYkn oIhAj1rsAbhthXGtarw5kdAzOHy2BREw26+tetvqqWrMT8KtJZefUowXWa/oMSet3DBgaD ZAZSdbq91i2UIyTujgNILc8wSOc2EMc= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-c8f360a07a2so1926476276.2 for ; Fri, 21 Jul 2023 10:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689959628; x=1690564428; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7shZuEDiffXRYK22UXnQcffVUND6wfTW4U7DmHj+BWc=; b=saEUf4445sfHkPWRX975heL8zENfXcs3PgCyCgvEVdQjEpNK/pp+iAjdHt4YEb3A4E Wx6AMp1fx4AxdUC7quE/wuY8PzajpllFI1PSVxa0GJ6TCvZZ95BwZYWsRgoM01BQ4SqE g1i1UMNIUCRiN6vVjQF+QtV7pxLVFxnr+vtjGFTshuCRS/R0Np16E0/qf+bH5mnx7XFz ZsljdMjRbBLWTIazxQedjqyAevMpWeXTTd8MiT3v+VX/sBebfo66Po7WIiS0jw2kNrZS H5psY9S7R0h0zicR7miAPapKCtbYppPvDwh7bNN96b+Zux6kO9omgHgr2n7bbHvjHh23 55GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689959628; x=1690564428; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7shZuEDiffXRYK22UXnQcffVUND6wfTW4U7DmHj+BWc=; b=F/ruEq0f2N2KqvcfcrWc8zNFQRE0sFBJTjYUPUVJvCrCIEXqFJs9ebYUKg7VqL6DKI ospjiDPeUnfsyu5yHzRK7Ub8H3ZXg4Me0Kcowvp+SVML/pShF9yKeHXQYvXKPW6udg/W JO/F+k2M5DiI72xXVzRDP6Ld2pfHR3ABc2H1f/JvfG31QaN2opIukUnFE3Y0sp6Ww4so zT5FBrExCVMAGYykqVX9woL2L3kgpjw3UriOY7M+Cv1toy4aIBhl3zMJ3dJiX7X17067 NfkPGr2CyzXp7jVxhqQ+NuQyYvTbeGlyl+HSZEqWsdwO3caw4XNShbLe1B3Zc4QQhO9p kt9w== X-Gm-Message-State: ABy/qLYVch40Yh/MO+3nCB/sLe65S2tYFtCXXGDWue6JQLrmeFaov9Az iZokXot9yCuLQ9l+c32GiGi2Ah6kGSQ= X-Google-Smtp-Source: APBJJlHTu6oxQip7Fs57WKX81frcXYslN0cZxNmgdAvx9eWDlCTFu1+cjXODNvw8IvlIlsVUOd7h6YXth7Y= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:a28f:0:b0:c6e:fe1a:3657 with SMTP id c15-20020a25a28f000000b00c6efe1a3657mr16139ybi.3.1689959627795; Fri, 21 Jul 2023 10:13:47 -0700 (PDT) Date: Fri, 21 Jul 2023 10:13:46 -0700 In-Reply-To: <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-14-seanjc@google.com> <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> Message-ID: Subject: Re: [RFC PATCH v11 13/29] KVM: Add transparent hugepage support for dedicated guest memory From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: E6804180016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: af97xemixq37a3pc83kshd7fo8hmz369 X-HE-Tag: 1689959628-640701 X-HE-Meta: U2FsdGVkX19JpHU6YFbsJxA202ri91i5lYUbglGuigr9r8QLZVHng+50DcPAV/44wBiZVYp6fTcDFHjGe8fSynAi1/ompL1TjJ+EsnW1IDHA5PQHbM4P/TSGZX025Nlz68bGYxCqnXcrXnrE+/M898Q+AYyV7UQRdWCO3Lw6OGOoXNM4jqW403bK8jhGJjhrnVeURthtQgoUrH7BsK4427cYuMn0jMMlsEcvRBWNdbdoMYF8REVG85k1XAbdVv4D76TsvgkNeeyyduSZLq2Rd+4DsRUOxSqrvk0MFoR4rNy4ZdGYA+nrTS8cNyXHaauRIDqxJP3filancgJHeZ+wblxIr4RMfpK0LXKDjePzswI4WL2arsQHG43DHKzJ3hWZQf9oKO6H3plUx2SI0SqbWAzZVhtWsoU1pdvuAppQDLeunWWHdYxnOIeZTXEsYdN1qlTNIwqQWuJ88/+VJnb+4LivcYoepyKSbOOmBzmoA0eoNdM6VMcyIgE+YOEeSC6tW832YLYE0MOypWDeFUseEL4+LNgwNeO2aTeHzVaYv6kFG/pIhBLfqEtdFhFAThN270ZkBuQ55T+WeBpdDMbmHtlS4JwmOMHh9WCEQGMhI183AXqYyO3eFsJYHfKSi+FhnhhanK1PGFyjtp5cI06L9efsehQnyQxxlbrB7jwYEOzkqJ7WR4hIGybpA4Lb9AvpYxnvwqrXR0oOwB77+qvxC52LKKfVtVJQuyeOKtAKizWz/SLgYHY8WohAxMCQKrODApqBKpUhGVRzCXwViizxHnPD+5oFccwlg+PdyFO+Nr3XgVBA8GVFg/5E5wHvsuV8t/DiPStWN4iYF+J0SOexnWAY5jJRVB41XLydDCsSDUyY7mJTDHNFmB0ZMsgAWdCIEaDr2n2ZYEoSEWFAZi4f6TICTmBpuFaJnHOjbiMNzRhFNh/hsOVhZSTHtgEGDZFl6wKcSlr4erqquPZZak3 p4quhEKe GGEXlTsi9ZaGCJEy1UqNCFnj4PO4HT8skPBh1kMzfhR1mtDW6AoNKQtdQkpydZB9eQelMK2bmYGiomSDVd+5ckIRgnaNdLcT0Ss0DU2gvDpNhMSplleM/GWDk2r0cESB36N7JbJ9hBwWQDp6YC1DTtRjPGsBVct9N1ILrrStf7y5pMlWd0/l2XHBmpmbiLYLaDNr5O5psWNZ+HbJjQRZDRBwmgDbSnoGfSCarT94EgPMvvJ47pbdYwXjLlkD8imYcZvA1Q712DGTGTjTl5XxXQeFzRr0w1OVYmvntF6IosUwETPj7fQBcT6PwRJII/z84GGHV2H755v4HI/XYR+7/HhrWKrWccpSIfHlP5RrMkMVd9sSYtPcTAiCvtjGG9QsiFSSBKmBUsRxQ/XuHBCt+XRqCXNFSJ+0lfkrL684nVg5AQfvelNIYXwFdLyW5RKqiWSLlS6jLx385e1uOY0rPQ9xbHHkvJk3Xe152fjSrVokRFyJoW6AsOYmXuLv10cYy1ikqwin9gBvqNU1778praFjRk9EhWhoKHtCsdA5lf47er8b5UnfFve8kgCOUvXjrJXf/OQL2inFzHrQ0Gq7zpm5J00ktlAk0b27D3u9BdBLuFvzks6LtiSnq7EIgJwClPtwf8dKCUaPs0GYBnHQmAzm1wA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 21, 2023, Paolo Bonzini wrote: > On 7/19/23 01:44, Sean Christopherson wrote: > > @@ -413,6 +454,9 @@ int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args) > > u64 flags = args->flags; > > u64 valid_flags = 0; > > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > > + valid_flags |= KVM_GUEST_MEMFD_ALLOW_HUGEPAGE; > > + > > I think it should be always allowed. The outcome would just be "never have > a hugepage" if thp is not enabled in the kernel. I don't have a strong preference. My thinking was that userspace would probably rather have an explicit error, as opposed to silently running with a misconfigured setup.