From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A06C001DE for ; Thu, 20 Jul 2023 19:50:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 627DA280157; Thu, 20 Jul 2023 15:50:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B0CF28004C; Thu, 20 Jul 2023 15:50:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42A75280157; Thu, 20 Jul 2023 15:50:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2AF9628004C for ; Thu, 20 Jul 2023 15:50:36 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ECEDD12029F for ; Thu, 20 Jul 2023 19:50:35 +0000 (UTC) X-FDA: 81033032430.01.70FC32E Received: from rere.qmqm.pl (rere.qmqm.pl [91.227.64.183]) by imf25.hostedemail.com (Postfix) with ESMTP id E41A7A000C for ; Thu, 20 Jul 2023 19:50:33 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=rere.qmqm.pl header.s=1 header.b=hRKxNIdH; spf=pass (imf25.hostedemail.com: domain of mirq-linux@rere.qmqm.pl designates 91.227.64.183 as permitted sender) smtp.mailfrom=mirq-linux@rere.qmqm.pl; dmarc=pass (policy=reject) header.from=rere.qmqm.pl ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689882634; a=rsa-sha256; cv=none; b=8i/nWZx1Jiu0ldDlCFx8Y9I/PzRVbIsEhAMQrfv6AR93HiBZJBAEMBgNfLhFa7xPgfv44p zx8Tfihs5PP7DB+JmcXk4S8Kc5+SfD5KTU5ab9YSKVUjPa5E+h7MF4cYeF6VwtIZpnXCpH SMc5y1EXgXYxmcIKJge6cYdjEyOpQLQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=rere.qmqm.pl header.s=1 header.b=hRKxNIdH; spf=pass (imf25.hostedemail.com: domain of mirq-linux@rere.qmqm.pl designates 91.227.64.183 as permitted sender) smtp.mailfrom=mirq-linux@rere.qmqm.pl; dmarc=pass (policy=reject) header.from=rere.qmqm.pl ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689882634; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XJT0zsUTrIoJC2x51eJQJbswBmi63rqfb5kWjhq86js=; b=kclyWUFW59mWc4jw1tHkJ3gSmgY0qCSuFsMjs6l5WyL5cK2qiva3WOXEL2A3smbgnBAPCw usshR+OFAIcXtZ4SZy6NhKt0cer7eMSnfK2aQlrspMQZ3r/eyRuHNh5A9dgedRYnxHt+4e mkq8MGoYf8Z2te2ExZrIU4T/qWAFXW8= Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4R6NZt1JgmzB1; Thu, 20 Jul 2023 21:50:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1689882631; bh=a9pL0kNuMRIgcmjOND4LJd48iF3+VEg/CEzl3bltNR0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hRKxNIdHwobRsOgpUwGtj+PdQV6SIpFKL7mg/O157lrA1OdMbATu7NMdtJdaMFxHH wYb2lzjgjAc1zwBOkuf1Y0YCoCa/3zkjF+oLjeIyGbnIekVSjv2pTGB3Lbs4TtUmD3 CDrONvId5YYm2VrtVW/O9+xteB94GdrKp1I5VNl9qFJERmhGiMmmkQrYEKIScjkFBO 33PVI8P5Y4bfRGiOr5nvIcC8qulynBJ4tKxHKswiPiNutMC3cmuOiM8/NTOdRebSR7 61Q6DeowDNmdlT15unjNT2E1xXOyW4lVB0A5PDXjykFs2NSoxKU5chGOowKNABgOOM DOhpTS7bkz/jw== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.8 at mail Date: Thu, 20 Jul 2023 21:50:28 +0200 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Muhammad Usama Anjum Cc: Alex Sierra , Alexander Viro , Andrei Vagin , Andrew Morton , Axel Rasmussen , Christian Brauner , Cyrill Gorcunov , Dan Williams , Danylo Mocherniuk , David Hildenbrand , Greg KH , "Gustavo A . R . Silva" , "Liam R . Howlett" , Matthew Wilcox , =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= , Mike Rapoport , Nadav Amit , Pasha Tatashin , Paul Gofman , Peter Xu , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Yang Shi , Yun Zhou , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, kernel@collabora.com Subject: Re: fs/proc/task_mmu: Implement IOCTL for efficient page table scanning Message-ID: References: <20230713101415.108875-6-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E41A7A000C X-Stat-Signature: z87n7jknnhmyxszp1repz3cudais4n4k X-Rspam-User: X-HE-Tag: 1689882633-436200 X-HE-Meta: U2FsdGVkX1/CV9YorsekwlEHWm39dNPjm/73PjhxYnBbo5z+3V72zFw45Sn4zJZ1AG/IFt5Rx7u1M0zaDIKeWS6ftvODw03EcsjNCaz5XdT+bWHhydeukSegSNYpN0V/1uG8I2Gl1rohLgadxIpW4H3fFCH71yKgn2S3l2OYKRtJg1nvu9mLi++Xsyws/T4lyKT5nXOXKyv4mSeLFMg8zxubIr8UkVbTPwJaG45DLPlCcXvV8eioxLEPAZ/r2eN3lGurXibucD7kOCR/sQAEwKfWCaXidhnST/Z6rOBafQtJIrngCmi6HfE+d7NJyy1jlcVPKGBpOS4YOoRYIOJEdSNqIXf2B8QC3b6MAPyqNsxXGjN5HITXBNfVOHw3WIRQwHbBzEsV/r5V7WNEz0rBWXzZ6tfcL9dV0Cd3kTIqxdJ2YTG9LQ/35UqiOIp/cx1jI0y68sVDSAYTJqxp4fAT7wdyZD04XkQfOKToSuXH0QR5O5PUc6a5BIgrWmUd8n71p77ALXjZgB10cZGTb8EJX9Ai31269JfKRGSRg4o3nmopra3q/pFEKGbrU8fo4tAlfpDMWHUPPWhz9IXlJvtYUUD3CLenGDhxG9dCAam4TI/8xDlk8g4BJUQNf4h8tHaabIf6VzL9T2txRDNiMmcquQia1tuo/eX4lDdgo78WeZIiuyNaymOehTtdExGHVV33X7cHXfIh9CeCjB+O9G+slD0mjaHhibzFvtWEcBlzW6I/ontCVwdth4F9pihgHPFM6U89oZLcrqNgq+nw7w7M6+rp+A3Z/UbLbljw7Lc6qQ25j+hS5PB5z3buyxOFaoYoB0WCyHgsiJdtAdMNRMjHLI+F4+oTgw/md1AUmyv2yVXuRU5hgNrXfKjGg0lk7AvhWjSLzUfpKRgraqKbrHzDC1dMxREPpmffMeWIAwyC5imP0O2FWYpZj+/gU0xWgNr03ecB4bgxrAeZ0XyVbR9 VrzHKEWL Z3ZIp69BQHmv5n1/8eADG7iTJ4y2LvJ54W46FUkVaMHBgOfovBKjcFJ5HYKxAhWr/E6OWK9w7/S7P4lT2erEkxuW3IRjkTjsF8FmbjM7e9ATMhtVw5dDb288JkcAFO3blXv+k/BzP+nvOY6Mfj9qu2nKluq/yhgRqmcwEhhsgXRm/xHWx1Qdi+/K7cEnohKUnQihKMs2a8I3FwXCKrzEBws1cJ6V7BPj7dN8JM4dL6EUCKYrlE3r9u1K4CjDp0hJHZ91d5svuMNopSw+fZBML2BKImT+TMh7MRmGj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 09:28:52PM +0200, Michał Mirosław wrote: > This is a massaged version of patch by Muhammad Usama Anjum [1] > to illustrate my review comments and hopefully push the implementation > efforts closer to conclusion. The changes are: [...] > +static void pagemap_scan_backout_range(struct pagemap_scan_private *p, > + unsigned long addr, unsigned long end) > +{ > + struct page_region *cur_buf = &p->cur_buf; > + > + if (cur_buf->start != addr) { > + cur_buf->end = addr; > + } else { > + cur_buf->start = cur_buf->end = 0; > + } > + > + p->end_addr = 0; Just noticed that this is missing: p->found_pages -= (end - addr) / PAGE_SIZE; > +} [...] Best Regards Michał Mirosław