From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E077FEB64DA for ; Thu, 20 Jul 2023 05:34:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 397D82800B0; Thu, 20 Jul 2023 01:34:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 347DF28004C; Thu, 20 Jul 2023 01:34:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20FA32800B0; Thu, 20 Jul 2023 01:34:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0D19D28004C for ; Thu, 20 Jul 2023 01:34:42 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B7E33A00FF for ; Thu, 20 Jul 2023 05:34:41 +0000 (UTC) X-FDA: 81030875562.17.18087A3 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 12A3E20006 for ; Thu, 20 Jul 2023 05:34:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vGqIT386; dmarc=none; spf=none (imf03.hostedemail.com: domain of BATV+ae7cc45e83adbe90d207+7270+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ae7cc45e83adbe90d207+7270+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689831280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hFybdOvvnOfesblq0ygtn3MBu6SceidBPg+cvmISP3Q=; b=eqOS2jbqyw5sCEuqPi0Ihpde+OG5w+3LTF+tGww47sSJAr3C/OW0a3LPVBftNb2y4KDaKT jwfgohYE9O6+Wdqvy6G1XIgbJKXyiA+lPT/2nblEh5f4VeIbjRPXFG7os/J6FiPvqW/CjI KgdkHt9lzayqDG9pbJwL1cSFHY+nWNo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vGqIT386; dmarc=none; spf=none (imf03.hostedemail.com: domain of BATV+ae7cc45e83adbe90d207+7270+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ae7cc45e83adbe90d207+7270+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689831280; a=rsa-sha256; cv=none; b=gHbw9C94xyk7Ullc67RjzEv07gRLbVsnxGa7QZL56NwmkF2iLW/sA0Pv1AF5egmwkensWe 0lx7Fzv+a6taaq+SGRwKjK2N8B7ysNjyDWwqGPz/Kzw5Tzp/n0ceJdv1zTZ44DeTgz11Wi 9UB/Khm7lEaU5nHTRg0wN+ZggzH8FK0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hFybdOvvnOfesblq0ygtn3MBu6SceidBPg+cvmISP3Q=; b=vGqIT386WlC6G+dGehwmvQGZoA buFsz+rMXKRceZlZD+mTvjlQ5n5jQmUi2TdpTrSMYfguBM6aE8HAu7ApPiINW/WVjQXh5TecxAyyd mxTpquGrOiEFxshhsY1ht8BMVCX1YrMRebpbb1yM7nk8qH+0idECOxXnCO5qNHlw0s/R6hrnGngrH hWfBit/tIb2A9ZpkmyXQYvJRvsom0rJCryXYfeRg0Y71+p9BPvVCEMxVKFBWV0WgAHIHFWOFLk1jl qOzjTLdwPnQ9NGGv+jobG1LlwWe2+pVbE7He32UoQdy5ZpmT9/R2qzc9gy8HCsG1B7C4iDLsJISb0 WAX4G2fg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qMMJA-009pxE-18; Thu, 20 Jul 2023 05:34:36 +0000 Date: Wed, 19 Jul 2023 22:34:36 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: Peng Zhang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, sidhartha.kumar@oracle.com, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH v2 3/9] mm/page_io: convert bio_first_page_all() to bio_first_folio_all() Message-ID: References: <20230719095848.3422629-1-zhangpeng362@huawei.com> <20230719095848.3422629-4-zhangpeng362@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 12A3E20006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: okrcg8zyepogmcts8xomuguz3ehz5ra9 X-HE-Tag: 1689831279-723536 X-HE-Meta: U2FsdGVkX19IvU669a39/e/53QQm+7Y5uM8D14As1X5j8RpIXI7Tk8vDhg6dJsU6yu2Q4/lHCRczn2mZQjLr2Jujezi4YwIkYQAOdVl/9PuArGglbmtKrEjsqDtojiVEwWr0cZEB0Je4WKXsP3IWISlMBGrtl9ryKY8cnwDM0tWPPXXuvn1C8rNuKDn8I9ml3itij7Zz1afgnkdCFLR2CtsJqT8upipJzInYjEnCJZQ9R7PITZe4p6yLdNA+4TD2vUG/S6Nt0j+EifOH/DgKPivk46N2gWbMkFaFhfSkot0DwO7HKFZDUVCNOnY5lfV4E0cOqFqcwzxZ8eiySbBNYnT9O1f3ZSo9Gbq/S9UBHm3gkiFIf/9m57C6fZGLH8QX35irr9jVE9/HKQtbpJ5BtFFSGoqXzPbW9ZYeV3koza2PrTT1O3kAbL+MkqjGaLyLJEN7P4825xC43DaMV0LCaARP0mpc8YsglxWKjGeQDojSfUcPb2vaAGbP+012UjouuPaFY+n2VHoBfeRzQAUuCBtrccZrfi5vDatfjsydgzsrz5d+CAGBTnIY+97Z3QlW4mBTU6f94O+ii/R9D1raG4WtubVJzRqirsz9lHKhu2ikU7oQ2MmcTcGClqmkI+SnIej1n1k8JvjhO3TVQJVHy4rWIlAN3CFZdxi5ewRf0iCnT+nhC047bfGL7z15Dpkwj6pX0WmBcoM8KwjgdbJ8TyP4x9ZXZu5W6ywC2GQlEWNtM3Lh88ZjtgLh/6wt483Dtz53PgmsoTOOqfqN0+SujFY1kpdCPMq60nsbBQvPEFeV9WN2QCHZK3gh6cGi4cNMZPuixff1oV4Xbc5S+A7p7k5vE3VLvhsRL37XikFpJ5OknQoNElIJtRtbKKM1vZ3kc86eTFd4ozZ5EDH/6OQK9msxBggzROpaYGSA45b09y5SCB/JZDYrrML7KCMdtcohWC9YcnjCsYwAW8nBGBK XKYQ8BS6 /xr4Mm8bKD/2H0zFOJZ24pyewjhjpRq24b2BxsOoY+BfTYC+AzSyeDbFvNtRd9lVjcYtbXW1m9VBOCDtSdtsM4RcO1eba/9B56PJt7zhWZkdmbPH+FTLu17J9VZWv3rozMyUf2+SeZGxMa24uVquMDFFiPq+b4QUmB7Cq2PfXTiFqTB5qV1dXK1AiBafZYc9hnkiY5uGircBstfgMijc/7b2+gkf/G4CGYMZUVLLYLh1uooW/4nzhd60AsUAt1czq/vMHdQFRha2T1sIFrF0YvySYV72rpWYOkJjIwuuB0mM1lFcQowFHMGlXNeqbabPVDkwdE0rXSJNVCXe/7gBKbcA/5tJpN1g+6QXjzu9L5pYxVBu1oYPbiy1X7qgyezETxKTOt/TAsX2b//jxtBcSONhERM4/qCJUmNV3yhBCyWqEPHc1EonmpvakyVqq8K08slS9K03Ezz5TJQk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 19, 2023 at 03:17:34PM +0100, Matthew Wilcox wrote: > On Wed, Jul 19, 2023 at 05:58:42PM +0800, Peng Zhang wrote: > > From: ZhangPeng > > > > Convert bio_first_page_all() to bio_first_folio_all() to return a > > folio, which makes it easier to use. > > This wasn't what I was suggesting. Indeed, this may introduce bugs. > I was suggesting adding bio_first_folio_all() so that it can be used > by code that knows this is what it wants. To add another opinion: I'd really like to see bio_first_page_all go away. The right way to iterate over the pages is an iterator. If we really want to micro-opimize not setting up an iteator because we know we have exactly one page/folio just stash it into bi_private.