From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 060C2C0015E for ; Wed, 19 Jul 2023 18:12:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A8A728007E; Wed, 19 Jul 2023 14:12:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 358A328004C; Wed, 19 Jul 2023 14:12:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 220DB28007E; Wed, 19 Jul 2023 14:12:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1389028004C for ; Wed, 19 Jul 2023 14:12:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 97F3E1A041D for ; Wed, 19 Jul 2023 18:12:10 +0000 (UTC) X-FDA: 81029155620.08.E2D9CB3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id B82B11C0019 for ; Wed, 19 Jul 2023 18:12:06 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PJd5FNKR; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689790328; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kk5QZGiEytes23SJ/m2wKXRoxkJuL/JZms+EeEgVKw4=; b=TmTm25NcUbWq3EiS/YKjjC8IeCODO/nXN67iS+m3PK47pVtybCLPscawa8z3Lmz24qC+vX uPN82yU2CpjwWSmfswoOmp+U9MVDMMOindY1sFswj4ktIqoh8s3Csq2LPNxdefGfR8BEyK eIh9pX0VYP3y+xzLzE951PbIURJOHNo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689790328; a=rsa-sha256; cv=none; b=ccJgqSlX0iS2knyH63hxhjDtTEqNC7diLRKL1fUkRMzFnr8zU3l3WPaiCirPBQdVsYhzgM dSwMWrR8MS0++qfkWDmY2lRBv2zMlib8C6TdpQWztvj3pmV1qdZ0DyURhKcdjsDprk5xEl Nqn8hCY/ME8FQKkg8FiC19ePeXJTUZI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PJd5FNKR; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kk5QZGiEytes23SJ/m2wKXRoxkJuL/JZms+EeEgVKw4=; b=PJd5FNKRXZKyTYWisyfy2NiVoe gqzEp7xcgDWlfvS2a+/NENi9SLDV2i/4q7lpc6XjgtMb75W1ZwcKwTI8mdJ0k1aCZXg9Fp4uC6hI6 nj10NeHuhL6YZdEN61ddSwQdmROSfNP7KPWMta0t+l7ExQgZmZYw32Tx5/6sh+9YQfQdzNvlW6i5M bpdiamNgi/5f4hZTqQ8QQb83Qcq/xxZrJtVZh86PyriSORqjInSDccs8fjdKbiqo/0mz5EfllgmaD rTquyBURcDtxKOD7RwUA6RNG94HS+71a+6UT8g2eCDBDj4ngC4KAapfTdA97wzwJ9hexQVewdo3Yw kQmYfzIA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qMBeW-006LLw-9E; Wed, 19 Jul 2023 18:11:56 +0000 Date: Wed, 19 Jul 2023 19:11:56 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com Subject: Re: [PATCH] mm/hugetlb: get rid of page_hstate() Message-ID: References: <20230719175944.292929-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230719175944.292929-1-sidhartha.kumar@oracle.com> X-Rspamd-Queue-Id: B82B11C0019 X-Rspam-User: X-Stat-Signature: wkqemn3isrqx4w3uee6rtdkoqfaqq94h X-Rspamd-Server: rspam03 X-HE-Tag: 1689790326-504521 X-HE-Meta: U2FsdGVkX19uviV2s5HdFI65voBMcBDVTsYd49OLXFOOn5JyidgDollz+M80q7GSawvV7Q/PUwEYyW1/FNybjtGyaDEQnkzAjzqFMLKaMAHmOVf/PMhZL+ej1NCu4OXdlKFV+xlcGTt+fwxSWZhDvrR/+WFtHj+p8ue8Sy5+/4b6bhKBxeGuNkHd47AJhXmFPyINe72QN8TDE9mZjSiV/zt+3SU1sFwJ6ggSrg4ILtVIAwycTNyVDowUSRg3v/GKiH/W4QSpyoKIKyTAttzASUjPrWLVFs9p2+Ht0EX+M5yHA1Ot/Y9ZgdaUmcl0oN9VH60EvZM4Ek8f9INqm852umj91g2pbxDQygTkZcMeLsAJOT8ycgqK5TgNn37IYMWjWkB60Sbf5oAEolawjfZvlTYL/lJc0hsZP20xmVlS9EJgve0GC1RdXtIysCL9mzUbrGotSLw1xdcHOeCOD32tkAP6jB3CSAGc2jcPKREOoJXjfRtvc7LwAzsGsNyRj/ujpJ6Sp0ZUHnFUWTCvOCf/3FmLjkeSXG8eIHgPkMd6R27tb4U5+GWuCS70dZ7ynwRAONptkXIHty+xsejRN/xsX8OOcOpR1KE8r5iCLFec+qSrXnxgdgtt2RdKeXbBfu+TA/5IxTOhBIFTV2a1guVvrp+WRWw8ma08JRJDuacGxo86faYKYoSNdLSzamSd8xnzhd4hbXlKObldtFZkeEmRoxt+5zQYnIzFafO4mI3t+dnp0X404u4DWD61NwZbhvJkmG/fOlcLN6tsrf3UgwJOXkQzHQZjAgWR7YMAH/5+wINNuQq4PgIHiZb8q3rJjpYtMFbxY8xS8LNeJQqVwJ6fYa1MPaLNb/YUd3bY/Z43s4dnAwRAPcRjI1GMTjDLcTBm7nFhY/C7r8GH4iPI6zBL0xlE7HynnznnRKYI4mBDE+tX0MPIO5I/yygepOJpMP6R8d/Fqm+NRuycrtPWd/U HJrLLyYV Yvymnpz65WjwelJ254mPcQQFu0Xp9T8etWIfeZiPpU/k7UvofB+Bqb8sEZYM4xMd7R9bGBVTXin6mpMKjTPJ4Aw19Tr1Zte+FlhIAUZzpBNbranUQhJlkdPs8RsWadtrs0To6DrXPA0grWO3JQKX6DpLe3zS7JWBywvmrcNSth8u3ik/LZ7KOUsAZAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 19, 2023 at 10:59:44AM -0700, Sidhartha Kumar wrote: > - skip_pages = compound_nr(head) - (page - head); > + skip_pages = folio_nr_pages(folio) - (page - &folio->page); It turns out that you can't do (page - head) under all configs. It works on all common ones, but the safe way to do what you want here is: skip_pages = folio_nr_pages(folio) - folio_page_idx(folio, page);