From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8458EC00528 for ; Wed, 19 Jul 2023 14:24:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A1EF280065; Wed, 19 Jul 2023 10:24:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0527428004C; Wed, 19 Jul 2023 10:24:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5D36280065; Wed, 19 Jul 2023 10:24:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D9B4B28004C for ; Wed, 19 Jul 2023 10:24:19 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A388B1202B2 for ; Wed, 19 Jul 2023 14:24:19 +0000 (UTC) X-FDA: 81028581438.14.14EDE8B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id C264940003 for ; Wed, 19 Jul 2023 14:24:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Zbo7rd5M; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689776657; a=rsa-sha256; cv=none; b=N6fpJ5VSAMqzJQ1D/hZ4LYbRYYhfMRolqacZOyEJTx3LHAeJbMg2Xe8Wh957WZ7ykGcnas du6TEaSE2eqyxv2TZRZjsM2urYTi5elxejC3bzDnueuQE9By41uz1UZe5JrEJwXyJcytfy hWlJkxHBy1qqww3K3aH7um6DvuiE9GQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Zbo7rd5M; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689776657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JC/eCR674tDcgmpCVJw/UxLXLL972fZka0yLGt+KBbk=; b=isBPPrW+FIvTevuCh6KE/jmQhrQTyHemAAlMlXiPZAIganz3Juo9eS3Y93OljUUgQGQRQu z4lGZFCTnwhLfeJGTKsfs93Nfr5mS+vTkds1eowEDx621kv4V7jfTs0VjOGgbrL1Fv5ncB 83Q5FbDJlPbJ0/r3dfrY38nDb+HZVa8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JC/eCR674tDcgmpCVJw/UxLXLL972fZka0yLGt+KBbk=; b=Zbo7rd5McHqDmFlDZ5rQNL6/bv Jg6pY42ISXHQ1rU7Ebn2LQ4FMnOhlv9Av9yQ9sATcZk36LGrp/4e11S/hSJIqaz9V+dSmQKa66R1A KK5NGxcrT5vn7etCln+whJhXRO1TqugX6HA4XAOCWJRhpwotqGHfF418Si6BUNW1iA4kKiqciVmke eVR4wPkdcjSSFxygY2pJywn+ZjyVm9qENYjYjs8VST+Mk+RvIarCAeRlyW2jq7x/sDWBYl3WrmQyt a2AE2yHUNYTmEwaOHUNh9VMmVRO3HpRF7mVesNI/jfxNi27kPfVeWzAZvWD1TetGDx7KG2iVjkdPu QIvAH6Ag==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qM86A-0068WO-4k; Wed, 19 Jul 2023 14:24:14 +0000 Date: Wed, 19 Jul 2023 15:24:14 +0100 From: Matthew Wilcox To: Peng Zhang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, sidhartha.kumar@oracle.com, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH v2 8/9] mm/page_io: convert count_swpout_vm_event() to take in a folio Message-ID: References: <20230719095848.3422629-1-zhangpeng362@huawei.com> <20230719095848.3422629-9-zhangpeng362@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230719095848.3422629-9-zhangpeng362@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C264940003 X-Stat-Signature: 7487zyfk81ewbqa6tjuyz5xto3nak5b7 X-HE-Tag: 1689776657-207315 X-HE-Meta: U2FsdGVkX19Frp5nDTN/BacYus4/sPihlXxnqRlJs5fgKjgMb05UbsiA741GDC3iITJUeTkCuoVaZ7vZExf+hnpHnoGkYNMxKaOWsVT3feTwCrDNJr4jArH49Wd/4/zZzeIDxGb7qDwUvMKz4ZTkvgNnJanj32Gs/VxDymOfBo6BOGa9v4bZcwochcee6c0SR+aqujniJoa97scJii/jdLn/+WiHqxfYuBzGLwEmJ/n6jztJ5WOvJov0Hgk262eh2bFtttFuIvOWbVYNqfwUwx9gr92bjoIXwyyLuXdRi3uxdXVMZ2YXXRpytGJo+VMxjrFb14oaEEP/SF0iFfKj/+H/TYD7yapcBUiBMx2SM7An7aLtyClzy9iCJRajdJurzsNyWHwj3+ZAZjiYXBUvaDDqsyzMXhxl+KOdVX/uu9fwBrhAfmgzkXj3zSCHIS9g5vDtYqKVtlUgb+tljtZlr4GGDnElzQb/dZjf38eSFF8Mw2Pk6aBZNi6HDzfVDbgYpphCSIjXz18RyAAQFXRLO8V9XhFOrUGk5AfE5IVRfer2l+sR0j8NArUagPYMtO92ppAdTDJT8wU6BWzMLoEerAxsteOhE//w4tn8FI5egP56SZJBqRs/APXckZRoKaTToA1BPyfaidGikE6Wy3oye9cbfZxY9mhrjFh0cGyMfSRBGXSDJuyNvNjHMAn6eea0aLUNYxRvNYxxx+zNWGBthBfVxeNBlkVj4BvGtdxwi1ZYqbIqhZzGk1mxjZU39vdox8nUUfiNR5KxsuvFzURRKLKXlAgpVm6ZAlp8TlodS3uikZDITJWwcIYXnAxfrh2oyrTlJfjYCsUd8BvnqGOdob27S3Sob4D751Ruvp/e3AmUGFrQ+qC+GdOm8n7WWnXow4GXVW4kLPsfKXBw5hCzWGGOdeQw1IavvP9tljKioue237Yz+aqJqW0/T1cHDJLNOQ5iyxqIMfUVsSsejB5 zL7WLB8M eHZtYWHFIUbqbyNO79aqp/N0kzOenJQZcQGEyi9ngcxqwq+WmJ65qkGMY5/8DghLPO0xUqzxG/+VkU5jnLSpf0V2WZvclakpPPnK9IWGf0ksyZpd9ukhz6TUUZtpOaul+tBIADMiVg2ND7joQshBWpifVZ1miDW4Zr3nRTl5HtmFmoh4cQE6gHSFDrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 19, 2023 at 05:58:47PM +0800, Peng Zhang wrote: > -static inline void count_swpout_vm_event(struct page *page) > +static inline void count_swpout_vm_event(struct folio *folio) > { > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > - if (unlikely(PageTransHuge(page))) > + if (unlikely(folio_test_pmd_mappable(folio))) > count_vm_event(THP_SWPOUT); > #endif As I said in my earlier response, you don't need the ifdefs. Check the definition of folio_test_pmd_mappable.