From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC82C001B0 for ; Wed, 19 Jul 2023 14:15:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A59E280062; Wed, 19 Jul 2023 10:15:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0558F28004C; Wed, 19 Jul 2023 10:15:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E39B3280062; Wed, 19 Jul 2023 10:15:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D32E528004C for ; Wed, 19 Jul 2023 10:15:15 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5F27C1C8CCB for ; Wed, 19 Jul 2023 14:15:15 +0000 (UTC) X-FDA: 81028558590.17.0BC986D Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf09.hostedemail.com (Postfix) with ESMTP id 7EC9F140009 for ; Wed, 19 Jul 2023 14:15:13 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=j6O4A4Kn; spf=pass (imf09.hostedemail.com: domain of 37--3ZAYKCNoOA6JF8CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=37--3ZAYKCNoOA6JF8CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689776113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZpT1srfgRytmcGt7uikxVNkA3BifxPUMvb756SCoWfo=; b=nNA43xZ7JpOwrLaQKdOZEo1TBomMZi6pH0aNu+l793tOfSiEwBI251uIzXloZncx7tnLaj A9QYOvv1+52MIa0pDWIvCH84y1UGk+mv7HjQzqacaEN89Q6XhMmuPUg6EuCorDrAiWqc5x tkQXQC7RHp04heGTZd86ZCRbStmV4co= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689776113; a=rsa-sha256; cv=none; b=MwxGJD9G4SL7NfrZWDpev9stmSdv17J4xRpnlpIAHYTeKmvOA9i28auDzC0EwEH5UGsbiG b4wI0rlyisYNRB9JjeJSQq9FuYYVQJV2FkapqGqqzHsPUO1LVGpUd+Hgkbcu1T5+YX/0uu 5eJo9oYkeItUPVC4E/4nUStFXhunocY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=j6O4A4Kn; spf=pass (imf09.hostedemail.com: domain of 37--3ZAYKCNoOA6JF8CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=37--3ZAYKCNoOA6JF8CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-1b8ad356f6fso36967095ad.3 for ; Wed, 19 Jul 2023 07:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689776112; x=1692368112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ZpT1srfgRytmcGt7uikxVNkA3BifxPUMvb756SCoWfo=; b=j6O4A4Kn8RrMiTsmWugcLoaBmDhdEOi6nm13D61dQWbrv/4yDEEVo/KZUz/JqdfsPo ZnKg9K95Lj7ZE2/dyLjlrZe55VZWZdtTVn9fgyfdtCrw5ElGnLLq/Qm5V23hi657OpUr Ebqn7DpgmWmZ6MQquOf5BjnPEIp0JeTMJYNB26HnYKqlFJQ9PECoKhiIFC6MpAGppjwD QEmzIJjuF0aS8nAXfMaVCs/HL9rulvVWCoWXejxaQyjwn7Vpfe71Kirx4tiYJoYvfJy1 s3tsizGDD9BtrGq0rYlfmNI7dH4xGaeqfoCnPAOEbyXtpSJtpl3/bu64M8d1b+aFanZ/ 4psA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689776112; x=1692368112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZpT1srfgRytmcGt7uikxVNkA3BifxPUMvb756SCoWfo=; b=cEmDJsOxTX20gnjNCHhQYN7O4OsVcEkQi8s43zfjMR7RiU4Sdn0npL6owFkP00OvTv 1Tdo6Jyj1hWTraPzftIRu9uXMkjz2Abck6OAmx4EjvV/3bsHFVlMaaxTw7c8yYEICJcm Lq6GWAtNT0ynshZWnSGknxIYDLQB+hjp/vEibc0tzd+L49rRv/9TRzx5xDTZkuHm6SrW B3z+6nQbsE7wjhmI1X6bpgdHeJHZEe05KfAObIUmi4Z1y8Z4UwRIjX7N/NiThfS5Clfz tFmTVZ3J9Tj+6p3WxJ6yiOgm6+4j7Yb7Zd4RNA8YpoHIIekhIfJXcUkUk40XQkNWJh+y JgZA== X-Gm-Message-State: ABy/qLZk5hH+5nlvJg/xvZgBOk8VJJo7rWXib9FAwk2/7qV2fRQRvxdb 0f7s3IUsa7J69la2ttAIQ/PschOABpA= X-Google-Smtp-Source: APBJJlG/y4qA2BEDL4k7hIJJKli+sdbNpvQf/prgfQp/iya4mlyKn4vdU0WvDm35KgLLUXfLwfwgiDZvoZw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:e812:b0:1ae:6895:cb96 with SMTP id u18-20020a170902e81200b001ae6895cb96mr14210plg.5.1689776111918; Wed, 19 Jul 2023 07:15:11 -0700 (PDT) Date: Wed, 19 Jul 2023 07:15:09 -0700 In-Reply-To: <20230719073115.vuedo2cf3mp27xm4@yy-desk-7060> Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-6-seanjc@google.com> <20230719073115.vuedo2cf3mp27xm4@yy-desk-7060> Message-ID: Subject: Re: [RFC PATCH v11 05/29] KVM: Convert KVM_ARCH_WANT_MMU_NOTIFIER to CONFIG_KVM_GENERIC_MMU_NOTIFIER From: Sean Christopherson To: Yuan Yao Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 7EC9F140009 X-Rspam-User: X-Stat-Signature: c37b68s9qzaxy81omm3d4jyyjp4f7ep3 X-Rspamd-Server: rspam03 X-HE-Tag: 1689776113-900742 X-HE-Meta: U2FsdGVkX1+VfGIvYpXbDA07yd1Y3mH8o2u6vb+QWj8xr2EhmgRWhDkfXJVlfUCtVy6NI4026ybmIeUMoqZB+7PT6Q/QUyONAlDwqfyVnnuyMGAemGKJkLgLr4dXPUsKZtCqr7os+zTTfKfA1uc1MkLky/J/RkfTc1sRXeZyOiNhNfwM2dN6sWeHyksnAKpbEIexFTOD3LtoCdPNNKioINrRBXvJISL75jFfNBIsn7zmzY/kvE7ocZkP1ldu9WTV0bZZH/ROaqUWuSNHdYDduFPaV5kAtL+F637um884K3DfMZ8tCl2jullpAHxcZ4NSWD+0UCv+Nny34DMfBxjdndli/x1ssMiLdKZpq3Yun/OLpZONeIF8OGFHXCgiHqUF45+21l5KIxVHjoBbu7bHKoyRuTKfn8+B+TjXfA11P6HUpYEZ7JxJJV4rFPXS6cxAEqEWBA+GDFO2LAcASoZqc4tQVmnge21MttnTSlHFRXF1QcFBiO8+PkW799uCwCSMl97JWIN2Lia2qqf4NQirKs6VkxCXSTt6ddEv/z7kWVOc0R4g3ITL8icaril13ANQ66t+xMJ/ZBa0wWaqIB8KAaqpycL+YPXymQ9uOZSA0AmUecnhIavBrDBFFB/H42QpxGrCmHNhRGoy0UZvsYKa+djZIDTeiLoRp+9lqO84Ptxcu/TXRSEszG1br5PIYmiMteSl82kfsoAK64OI/UTE3PJRkzuD9o82qqt97cxOauHR/tjEbOXey+uEr7bx5/LRKOESty61Fz6edBczQEBPnog4cL3bhMsjlrakh5HxjeG6WEYRBJZlz4du8ASkVLLCOrIz1CiawIIsh8gCsxQY9zxUvXdEkzTVpZfSs05geAetwfH7uAw1BaXvNh5HJsNcjCIQLajKf1zKSFqLsGQocZKGM47xvTzM3cAU8/iXs0w/mMXUPsyXcRSXh6nSnHId5RDdRCez2Pf8sqfoKEG ivUuQCV4 A0Gk+0irSnBXD91erVW/V8jHwKF45XQR2GV05W+s7+Ky93eNd3K49nCD+kHxGbR2pmcC3Wbf0FrMXJoYF4jmjPfqSnD1NzAPakcOuhfdUkGUUwP0zMKvbs0+PuTaBhWorwmXAaxguA4XXkropYnVGXjEKPr8NU8kFURlCh+msCszaKn0a5qATSk6AjA+mM9eHZnmpFTgIRBrpem/xKSp4Gq0JHA3jjKpNL7xw+BbTRilv2zbcht6lT9pPSx7Ve5jPTq2Q6JWjkks33BsP/jaFwTLdGNkol6TCiNktVjBdpTEl5tAJygWRNWxYxQ7NpblddEQL+yQRxP1vMQMuqzL5dlofbSFjpqESBvZvG2fVBxIjczDL8QgH3xCl9x49vWqUXxv6ETPUEULdG3wHecChNnt9t1iinKcmsUkPHOwg/PDRIKNfZwFO4CHOhGG+qK0fMEhdby581tt0cOsGTXPHcLFOTAr7R0y1hV1GXWbCyGoWfb0FZA7enpfLrDR+TuUji8eI74fTJRuuPXE2/OikrN/8bNaOx9sfSoCQPz2TtuSO5rGdTAzqvvfZJQ50jm0kEoNwLJFjDQNTFnOEXymD9Te/W64LDo4na6Z1/R0C+uFiJPU2Q9tzGQgX0cyHBPrTzrFrXRKOfQb7cKcBOjjWU1FQn1Bdz5sBSazfwN7WJXJzKI8pRv6QCgkI7+CLujRBkp5+iZq5WTwGT20= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 19, 2023, Yuan Yao wrote: > On Tue, Jul 18, 2023 at 04:44:48PM -0700, Sean Christopherson wrote: > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > index 90a0be261a5c..d2d3e083ec7f 100644 > > --- a/include/linux/kvm_host.h > > +++ b/include/linux/kvm_host.h > > @@ -255,7 +255,9 @@ bool kvm_setup_async_pf(struct kvm_vcpu *vcpu, gpa_t cr2_or_gpa, > > int kvm_async_pf_wakeup_all(struct kvm_vcpu *vcpu); > > #endif > > > > -#ifdef KVM_ARCH_WANT_MMU_NOTIFIER > > +struct kvm_gfn_range; > > Not sure why a declaration here, it's defined for ARCHs which defined > KVM_ARCH_WANT_MMU_NOTIFIER before. The forward declaration exists to handle cases where CONFIG_KVM=n, specifically arch/powerpc/include/asm/kvm_ppc.h's declaration of hooks to forward calls to uarch modules: bool (*unmap_gfn_range)(struct kvm *kvm, struct kvm_gfn_range *range); bool (*age_gfn)(struct kvm *kvm, struct kvm_gfn_range *range); bool (*test_age_gfn)(struct kvm *kvm, struct kvm_gfn_range *range); bool (*set_spte_gfn)(struct kvm *kvm, struct kvm_gfn_range *range); Prior to using a Kconfig, a forward declaration wasn't necessary because arch/powerpc/include/asm/kvm_host.h would #define KVM_ARCH_WANT_MMU_NOTIFIER even if CONFIG_KVM=n. Alternatively, kvm_ppc.h could declare the struct. I went this route mainly to avoid the possibility of someone encountering the same problem on a different architecture.