From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B918EB64DC for ; Wed, 19 Jul 2023 01:35:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B9FD8D0030; Tue, 18 Jul 2023 21:35:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16A088D0012; Tue, 18 Jul 2023 21:35:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00A868D0030; Tue, 18 Jul 2023 21:35:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E29E78D0012 for ; Tue, 18 Jul 2023 21:35:44 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B71AE1A014B for ; Wed, 19 Jul 2023 01:35:44 +0000 (UTC) X-FDA: 81026644608.21.F8FE3A6 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by imf13.hostedemail.com (Postfix) with ESMTP id C653A20003 for ; Wed, 19 Jul 2023 01:35:42 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=UyEHrifu; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf13.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.54 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689730542; a=rsa-sha256; cv=none; b=WTfWcKZ8x2VEFsxw33qQbkq6PrEbzEeDTf4luCXqLSrmWcgeUpE3dolZtae6+L7XNyJQKc A0SFjsBI1XYwfahSbA/pVXirJpdgIj/Z+o0gfFqEocg2uQQuIE1cpC5ElRZJHBTCRIlYoQ zo7mi3GsBH4HmM3pH1HZHmBBIW+cFxA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=UyEHrifu; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf13.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.54 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689730542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xZssYNKocP7SJAjxckC3wBJ507CzulE9IvrMWjf3P+k=; b=JDNXOgeBvDyjvR8C9tT65c88wfVVvgruaUBj8iGt5hGviN8RIOmfNfnu8oYCMeWmekcdAi ocJnJJwSQd397vJqXZ/3qfBLDkLoatODJxsUOOeojfarSurEo7/qlmFVYoR+71Ccg+nI9T ODc72W+QOfQ70rknbjns1HcNwXzBBlk= Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-6b9cf4739d9so2670327a34.0 for ; Tue, 18 Jul 2023 18:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1689730542; x=1692322542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xZssYNKocP7SJAjxckC3wBJ507CzulE9IvrMWjf3P+k=; b=UyEHrifuRZ5o/LHdOIBVgqU3uLQ83/YVba1yDcKzGrDyYSuZqv7XHBgrl0Op6xs5QN tvuwKKInMS7kWFCpQ413M0M/9cpoRM/lb4yrdCRkcJ3bkiiHxN7rVBGNpRpQqdvodGbE +hcO6T/MCqCtlo8tkPp9TIeY810LL7ekmi6sHsRSZt6cuxxB5cu8pAoA2NAxUPnpcne9 k/e7Ryv2DJFAmUwjMWYmDEs7P5F9V9jkOVzNqtllggDcifIBnTsK1YD50cGA9bQRQDwW fGSdrlY9enexhyJANn+z0+unf1WXTpsisI2lqgkNPM3HlXuIyTHSyMHkC/aA/iRrP++4 JWtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689730542; x=1692322542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xZssYNKocP7SJAjxckC3wBJ507CzulE9IvrMWjf3P+k=; b=eIghG4XOC6H0ix17AecGstee/XH2ClhWOIiPmp+A/O8DUYqrdU0BdoSKSqNdaNC6zg 6lB2JrM/siWM1kPL1FOOUw8TvK0FJE/z/LzszH9WPyiPlvg/T3xT6xDzWaGEtP2J8FDo ZbYYhnI37cZjnCEJkPouQMaNMq8tk6sGK4hwkXNqMmbkDX20P5A2MezO59rBm7EMu6+V ieCBX++rrApDscRqsXHVuLAxenk3bpkXSHsi/6f6t8rrswUZbR6vRZ+4hd/+4vAfCXr+ oTT8b0S/pOL08Oq/zt/HzyjMQS1VF4BkZ3kUiBSe/LY5/fL0Rumh/Xtwbu4TRH3cb1vf U2TA== X-Gm-Message-State: ABy/qLaSEbw+oIhTxpDOx/poDxpwh2TqcL31xuGqtFfJo76zNPxKc8Ti rYsXfNQndLQ4Z+2QKd7pYb54kg== X-Google-Smtp-Source: APBJJlHb4gEwJfD+TL2icCrXL1rPSO1/If2sqk52+FC1gSV2ztjdma15fYoDbEqUpP5c7bsoFPcHEw== X-Received: by 2002:a05:6870:96a6:b0:1b3:8d35:c85f with SMTP id o38-20020a05687096a600b001b38d35c85fmr1011777oaq.1.1689730541592; Tue, 18 Jul 2023 18:35:41 -0700 (PDT) Received: from dread.disaster.area (pa49-186-119-116.pa.vic.optusnet.com.au. [49.186.119.116]) by smtp.gmail.com with ESMTPSA id 201-20020a6301d2000000b005633311c70dsm2343100pgb.32.2023.07.18.18.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 18:35:40 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qLw6L-007mcz-1V; Wed, 19 Jul 2023 11:35:37 +1000 Date: Wed, 19 Jul 2023 11:35:37 +1000 From: Dave Chinner To: Jeff Layton Cc: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Alexander Viro , Christian Brauner , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , "Darrick J. Wong" , v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v5 6/8] xfs: switch to multigrain timestamps Message-ID: References: <20230713-mgctime-v5-0-9eb795d2ae37@kernel.org> <20230713-mgctime-v5-6-9eb795d2ae37@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230713-mgctime-v5-6-9eb795d2ae37@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C653A20003 X-Stat-Signature: ekzpdmwjgn8bhybtyqgbhwhymhsbnnjp X-HE-Tag: 1689730542-965139 X-HE-Meta: U2FsdGVkX1/GxIQ5SNe25OU94WPFvpTR5I8WwR3F0ckI3sId6yRpXa4o/d92f5mT/Q8s1JzLG+CYoc9kNfslcCs05zw5i0MuBgchlzprlVRnLR7xJJgkBLeDC+prwEYFZsXCvJgjZ+t0416P+74FhIO7p2tr7GWxwKfzSUVtNqspVO1XQCBuUa7g5KG7P9Pa6+pux9cGU5cjcANb0xNtTmLZIF0YhsjrgOwFqT1zh2l215YK0WxPvM9KYpr9tUYz99GjmBEBT14zGrAcM//7w9OA3xVqLqv8EUh/yQpI1RB/rwGCYDMrO9atFLFMajpw2KgJBlhPVGfNo26+l4lZPdBKlpx69pyCDf4+wsjRgjx9TI8GobLBAt9x3te9MoPiddRn9Y++5Hrj+6ExbsSmozcvQMOjec5jFsiGLcbf9L2mXq2x2VblbmGFVL9lzJTFJAbi9QWXaXQQ9T6uSaOZx8O72DHODGzRQjJEGPzZSXcmchDmdo4XQiY631qtp4dPLQngfEGsbwgDmyqDgrc22IuZPF2eP5/nMyC/SgVw9JdQQ6hEzVvEP7Pd1eWONeIUZnIIt1RMmnYOXRjxVejuj2WjSDylgUOXajptRviQMiEPhAcJSXka79TX484HDUDicw8ymBngknZYYa0TGvzesTcOB+EJaDQZvh10IZDV1fAJ5MrOrsv0Uyk0sw14YsT7i+ZhhZLt3I8AlaXUMwKeu/75UoFOvxZXkDcJEKxydVBXcKUsCvgi3v9nd+fEIFy4Ww0+DK/pxTc1dk7RNjJaZx8VOJzOuV+GX5K8qhZPffjaDT6o57X2p7zUTRLrBkOUCNQq9sh/ce1DDFqQjMUaEs8ZxBYKGQ6ZF58BU+dDsnkn+/Mf+pW3nL3DG9jxUoh8Hw0gJjY4rVoCUpEkQ8xtelkTd4Z6zrXxdVLzpE+w5g4C6f0jHWHx23m7cO5Te4IFtdnCeH70I76tCBB5sII kt06mIV8 BCo08akfqHfwou74lK5CE7knKDAwbReqYkloCnZxpDJtDRQ72YnBFb/rO1O2Thb5ANsboruXb5+1yfejaXgYEyAj5QhuBlzsmVsm0riLa+tQ46xgWFMNFKpCxVNuPo7ztiHOz+Gnpoy7V1EfhuzVrSJZZwDNq1WuZ60flv9QtNa7A4+gyVTviEpcAbzmX4fTnsLUPomFwatklfKko6TerKiWqU4oOJmHyCp1QTuHOG9xhIxpEDxkxLDCXfMMClOrOihgBNs0+hDe5ckFqFcDnvr024y2+9/02Stv5nMjlI9NafXabbwFFMvgI9LqXQk6xWl3vACT2UqhCeR13rBAINC26FMbCTFlc+Scy5ltgWUwYhp8TutifUmJxvtY/ESj9PA5XfGF7g/Et1a66eKhVcj5QBtJKKcGlBrfOQpuPh2sUYdOi5cJz6171x13eVsLhnKj3jUFqa66Gip/jSB1qNYwrkwgj/YC/hEI+HoO6ySvrANjMclvh7POrFGoQhAPJa4B2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 13, 2023 at 07:00:55PM -0400, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > Also, anytime the mtime changes, the ctime must also change, and those > are now the only two options for xfs_trans_ichgtime. Have that function > unconditionally bump the ctime, and warn if XFS_ICHGTIME_CHG is ever not > set. > > Signed-off-by: Jeff Layton > --- > fs/xfs/libxfs/xfs_trans_inode.c | 6 +++--- > fs/xfs/xfs_iops.c | 4 ++-- > fs/xfs/xfs_super.c | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_trans_inode.c b/fs/xfs/libxfs/xfs_trans_inode.c > index 0c9df8df6d4a..86f5ffce2d89 100644 > --- a/fs/xfs/libxfs/xfs_trans_inode.c > +++ b/fs/xfs/libxfs/xfs_trans_inode.c > @@ -62,12 +62,12 @@ xfs_trans_ichgtime( > ASSERT(tp); > ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); > > - tv = current_time(inode); > + /* If the mtime changes, then ctime must also change */ > + WARN_ON_ONCE(!(flags & XFS_ICHGTIME_CHG)); Make that an ASSERT(flags & XFS_ICHGTIME_CHG), please. There's no need to verify this at runtime on production kernels. -Dave. -- Dave Chinner david@fromorbit.com