From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8125FEB64DD for ; Tue, 18 Jul 2023 09:10:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA81F8D0001; Tue, 18 Jul 2023 05:10:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E59CE6B0078; Tue, 18 Jul 2023 05:10:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAB778D0001; Tue, 18 Jul 2023 05:10:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BAFA76B0075 for ; Tue, 18 Jul 2023 05:10:40 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 87B27160296 for ; Tue, 18 Jul 2023 09:10:40 +0000 (UTC) X-FDA: 81024162240.23.0C8B8CA Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2080.outbound.protection.outlook.com [40.107.22.80]) by imf07.hostedemail.com (Postfix) with ESMTP id 9C7F040014 for ; Tue, 18 Jul 2023 09:10:36 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=mg6FGotE; dkim=pass header.d=armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=mg6FGotE; dmarc=pass (policy=none) header.from=arm.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf07.hostedemail.com: domain of Szabolcs.Nagy@arm.com designates 40.107.22.80 as permitted sender) smtp.mailfrom=Szabolcs.Nagy@arm.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689671436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cbR284YFKWqqp/H3njFY2FaXUqfJsbXnUaTpKzvcYfg=; b=612/4r2nUdi1gMLoy99/ti+sH+P/fXXUU9sR1aKP7iHohrPuHf+Dkto/GsrfCt4mfjTt4k 04kS3RwzzKt/S7nzlFC3KaQO2FraQesS/WFZVE11drNfwX3dTz1W+sw3/QT1baZInMgP6D JYEFTJ7GpZR+ee8mu6TA7oN5JB1AoQM= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=mg6FGotE; dkim=pass header.d=armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=mg6FGotE; dmarc=pass (policy=none) header.from=arm.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf07.hostedemail.com: domain of Szabolcs.Nagy@arm.com designates 40.107.22.80 as permitted sender) smtp.mailfrom=Szabolcs.Nagy@arm.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1689671436; a=rsa-sha256; cv=fail; b=d0QKSJzI/MFsv12t4jPswpuWu4ZP75k2YTU5IawsUsvmSqBIcBZb3Aci4/ICVNpxjcukKP 0YRyHpnudV4n2QpUUCHJfKvznoeabiD6zD7dXVVDbqjieR4fZUjJjBPrVcXRQp4QSRFM/c r8Y8P3A3caY4XG1koeoPCst4Au9j6R4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cbR284YFKWqqp/H3njFY2FaXUqfJsbXnUaTpKzvcYfg=; b=mg6FGotE+bzzST0D36aFgGxT54jtHLzVH1IQuOOd3mcWAjvYXugq+VrfvAs6EJ4bDaDskuujWgPgU8o06XlcJm5WoLbwGpfhiNWku+IJ6/8w4HE5QvYuRt6IQFlV44IuNgKzLpxhxrle9xe4ogYhfMsFbGhg11DqENklR3ZEQiA= Received: from DB3PR08CA0018.eurprd08.prod.outlook.com (2603:10a6:8::31) by AS8PR08MB10364.eurprd08.prod.outlook.com (2603:10a6:20b:56a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.33; Tue, 18 Jul 2023 09:10:33 +0000 Received: from DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:0:cafe::67) by DB3PR08CA0018.outlook.office365.com (2603:10a6:8::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.33 via Frontend Transport; Tue, 18 Jul 2023 09:10:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT011.mail.protection.outlook.com (100.127.142.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.34 via Frontend Transport; Tue, 18 Jul 2023 09:10:33 +0000 Received: ("Tessian outbound e1fdbe8a48d3:v145"); Tue, 18 Jul 2023 09:10:32 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e51d28f378240e8d X-CR-MTA-TID: 64aa7808 Received: from 1518e62880fc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D1158AE4-ECEA-4C7E-A403-ECDB7C1FE219.1; Tue, 18 Jul 2023 09:10:22 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1518e62880fc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 18 Jul 2023 09:10:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BewX935bHjIuBCmpHZmS+inb94ZgCyVJmD8LEokrAOwgDorRz3DeNTp6O0PTVAZmM3oioAm3X27mp5UzmFBmYP5gWJygda6gl7XMwDIEPPOF++vgQhLEitw6n/XlcbuM9bS4cBhntH1UnWkkmBpQE1XfVruRu4xKyFJkUaoXOzlJehPbRl0dBZ3D04yOykocRSzE19+nLTZ42tXt3oUAQiNm7ZSznVxDlGAj+ainZrVXMzpcWi0lfh95OxYpnypfg01e18oFiOk79GCFz1pVxnmp49U9V2bZCU2HbK9E67CEVRQvPDuiWoEyk5cx3jBuH++bjYITpw1X27e2AQnjHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cbR284YFKWqqp/H3njFY2FaXUqfJsbXnUaTpKzvcYfg=; b=GHQRpe1/KZrupIPs0UyJmly7biiMzW3ug/tGzLt/oQP9TOTjhAk5uJv9QsB+V0MhG1ux3aI8uzRYMxoDAEETtsUmnxRX8oPI+82SXGkZbuGMfeS/Tm2i1gB67eqD/+7ghTV6IqJu6fnlZxl6tHQg6lQPe8u7DFHnT2v9Si2yLuS0W0yNfH/L3bUE6WST4h8SnC4dn2cYH/ErJofbU/MAhSBwf7KVewjk5YulmPfvTdjBahxPLK3w6+IxB/SLyeZBvS07hJ2pIHYGgezsOjtoiX0ATfHgH0hSTdzJlbm6/KVq/qOivZOvOvCeFFJLCi/QUed28vmtAmSPfrhvkKZ3tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cbR284YFKWqqp/H3njFY2FaXUqfJsbXnUaTpKzvcYfg=; b=mg6FGotE+bzzST0D36aFgGxT54jtHLzVH1IQuOOd3mcWAjvYXugq+VrfvAs6EJ4bDaDskuujWgPgU8o06XlcJm5WoLbwGpfhiNWku+IJ6/8w4HE5QvYuRt6IQFlV44IuNgKzLpxhxrle9xe4ogYhfMsFbGhg11DqENklR3ZEQiA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DB9PR08MB9612.eurprd08.prod.outlook.com (2603:10a6:10:45e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Tue, 18 Jul 2023 09:10:19 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::adb0:61cb:8733:6db2]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::adb0:61cb:8733:6db2%7]) with mapi id 15.20.6588.031; Tue, 18 Jul 2023 09:10:19 +0000 Date: Tue, 18 Jul 2023 10:10:04 +0100 From: Szabolcs Nagy To: Mark Brown , Catalin Marinas , Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Kees Cook , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel Cc: "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 22/35] arm64/mm: Implement map_shadow_stack() Message-ID: References: <20230716-arm64-gcs-v1-0-bf567f93bba6@kernel.org> <20230716-arm64-gcs-v1-22-bf567f93bba6@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230716-arm64-gcs-v1-22-bf567f93bba6@kernel.org> X-ClientProxiedBy: LO4P123CA0363.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::8) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|DB9PR08MB9612:EE_|DBAEUR03FT011:EE_|AS8PR08MB10364:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b719327-eead-4a73-026e-08db876ed73e x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PxUwwgtHGL7gREDYcK9VjFQP3zehF4F17x0IZmGn2/yz/Pxqim/BcuRfwx0BEjsieoReHjCAbOWDl5Z1zUqBBz5naW7gzISdS3ofd6M0VNZYPmiyDMmhlYP+Z6maYR5R+2H8DwNC8jrCVvcgmOWFJ0i26WZeRkV+O+MjBu8bdZIws0s9NtkLY0SUs/g/aB71g7YW7FJce+TBVRP7pDJCptBkUMwPlPwdwvvDSiODU7R6XTAdXeXJLc1gs0mUoFYK8EaVZiaTgxdL1wXklWvK5XdjXC8RltAVIIO4C24GTmaZJ/tjiOPADTsrCv2SmtN5dh3tSZ3aTgXrzJU7N2wrM34aebIcmcI0ckePZxKdAYpmfQAF1+YQXlP9jXfp6yni4ltJqjbTddf9TPkR7qOyyNEg8tX5R4mzCGNjSETyfvNsBlG/Qj273NwPEUO1VyQwYG6B+vmrP9rB2KJw05ewzhJZVKIxJBwZcRn6FPaF4JJnYVUrPGJX9OfVbvQ47tZ/dPGxBkU61eoQEtjYVq/b9w49UGujkqUvroYHwkjacUbmvhH/nQm8dK6CpRiFyRHkjW/hRhICkKsR/nG6HJpKCppncIrZyEWWhPsquBN4scs= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(396003)(39860400002)(376002)(346002)(451199021)(110136005)(478600001)(6486002)(6666004)(54906003)(6506007)(186003)(6512007)(26005)(2906002)(4326008)(316002)(66946007)(66556008)(41300700001)(7416002)(36756003)(8676002)(5660300002)(8936002)(38100700002)(921005)(66476007)(86362001)(2616005)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9612 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fde0465f-6270-423d-7d57-08db876ecec7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Tf3Y4OCkd9UU0uI+43lV42z09wmCa1tuZNo3pNDAjoBJgjGpaWPW+yZzCAQsc43Bf2l+pYlANTO0XhtBSEcc/Zc+Sgcq3Y7Xw1gPsAjOHP2qAhuyY8mx4zKUy951shwhgdji+0mXs6W13QTC6Ep5NyOBnLJ559d8TZbbNApgzTlrwSto7oVTjTbUYrtwUWzcqQOwJZwsdt84NKKuByOVhV/JIOGuSf0thkRsEZNidL4BA5xjsBqItKfIJuu+Uyu5K1jsNZbbK6o1JTnimiCpxGFpm4/x1ohrQ2hHSPSL3+TWHSDkyDUJiSMD+MfcpnS91j9ULENHz09nZ8a1+G/+t9nRd5TUDHzxlqNUkU8M8WJPINFlvbQqH8rBsS0WFprYtxtUMuzbRQawDwU3WjLY4qrSrV3Z+0rX0av+V2LK8baDgCOTHDNYmoxNetWUZkJmLrkaBCmIN32vXyaoBM/stmlPfBTjrtg9NAgO/7B7z8Zwn8k5TdfcZeVfvpYCyYvGMQfYPA2Cy9n8QDlwDcJJwUh7aZSgq5za8i543whjx82ig6j10GaLX5p5V7OTdkPIIdKUJbFCtnU6CtRAy0hfMNxYTSfTP8NFFR6PnTNuIW4pFFGIPtu51YbIEfQNXThT2qPm+1ahHYalG/xR0o7JJ9yn9PtycRjzEQDfo8SweFV2lx1DLgbvFiSViAhz8J6mSrcV7VOYQpDKMvIR/KKRZIiq+/3D1gYXr72XGnwD9Lop5F+hI0QOtFPEzUQDiGKgQLsGFx5/rrR2LbxEMc1ljg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(39860400002)(376002)(82310400008)(451199021)(46966006)(40470700004)(36840700001)(6512007)(6666004)(47076005)(83380400001)(6486002)(36860700001)(36756003)(186003)(336012)(2616005)(40480700001)(107886003)(40460700003)(26005)(6506007)(70586007)(70206006)(4326008)(54906003)(82740400003)(110136005)(81166007)(921005)(356005)(41300700001)(86362001)(316002)(5660300002)(8676002)(8936002)(478600001)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 09:10:33.0374 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b719327-eead-4a73-026e-08db876ed73e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10364 X-Rspam-User: X-Stat-Signature: dhzwxh7uyqgnfd6hffufjb51pee75zm1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9C7F040014 X-HE-Tag: 1689671436-487344 X-HE-Meta: U2FsdGVkX18Ci4fW3IXrMKuJszCJ0g2tujD4ADwou5MNq+ZDltqp0RLlZ+9To9+PqRxBPo9fEIV7p7gPfLSevreECHegqFreSD2E74dOU3llsGzuFdCp6z+wAyh3Y4cqGmIgipKrGcRu/Pn2+A7rDydTizJf1LVwghmRmcIEwVSbbawPpdRf+TVYw5fkRhC4B5MZwuQWIFQNaq2f3ZULA+qlB1w5T5xK3ogP2v/mhqlTERJ6eXJUz/CgmK2gHrjLok38Q0sCJUfaWzdwv8zJ8mSBxVCc79BV8XBhkDee/8HIHyN352Bz0FigSQ+D7/L6x8Icc5ny71lk1byYldbcUtbQ3bQyRdlgZ+u1Q6+uWN29ZEaGu1fsi+W/GwhkusioxxSKINS5RfLUaDcD2OmV5Urv/HVaOe4reqkKcu4nU6jpgp8BB6HJ59qJ7LHEnmjOLajBrag2eTb/QN7GohIUNlooa6gMiv/WPQWvtEuAhZvuUGpKyqyonDTfT6eKHAvO8iiqcyxVSMCvc9uj1UaHx6Tvjqb9E30QEjOXmq4aFtLgdngBiaAHmRLaYnUR7Bibuy1wYyXNfkvnr9WhwjdKiQvMuHp7znUHmtHejW1LEwT4dBfN5pD90YavSXN/LEOjzeiUoH78rC41FRwh48bAYrctH8FxK5efK7sBQZXYzeGS3H1vusc+SmfNAs6RoaCfyPed5zsfoEuewJ43kdBiT7ePw4Cj+sBEBCkrvfuVo6DUnHC+0tSioEN0mHj3EXf+qwBMGbX6Y9hY/w7uYHqzz1l/MApr+0s6UxBcusYY/KIvEhexYOvvv9UrulgqFq1dOpfZjld2PbLgeX2EW3V3kTjkWw8N0Pne9/gMp9uGSAN7Ld1UoNVT684+TBacXzMGvW//p2sLRo/M/u+3dolOmOfyk5GON4IjKFxZ16vg1cMC5B3ZNKPQTGestcEOnTIxnfMZCDeK9oH5bdCFPw9 1vOprRHO d48I6EAh5AzqWYINs95gSDOw6MqqplhCEWk3ZQQfh+1iag017lS3aEPZnMEXaAlivQrOmOWNrkwAOGtZjPHzt4CRjXJ1MYNJdIeaf5afU8pOS+JzZxns1qHu5AQd8n7xDzF2Zt01Z80R7rfqwwBL/tcUI+jr//2tb/YM5gnsayhqC9+XFRcgYndcvA6IFlmS0zkZ8W2QqoOLBsfNDiO/8HbDNiPYZVp2g1+QOtzo9AqIouA520hRLvTeWan88M9MnWVyII9BPptKBhLeWyQTeT5kliVaN8vhR9MeYggOg1kal6ZfICccWizhxN/v8+/zNQWsDtZpAhbolnlPI6qa0pRcvvyo6JWvC2Verto4xndGL773pwqejP3yf0DtmwoJ7WGyVYY9rBB/n5Vpk1zJVENhxqRX1TXHuXDjeOIJh7w0+uOkzLvXECMaEPTGxpbYGF1xARWVmA/dvfSR7vGnO0u0CyjHA7a5xPFg+gOQfxUuOHnXAYPX7hoyEDCiixmDIY3y2dlsPLcgqp3Sy1jUnJ7yrCCys7iiFj1k3/fti3WlHrAaSAghh7D+NxmJ9gQndIdqXMomKgywLimO2rkWCXwu8vA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The 07/16/2023 22:51, Mark Brown wrote: > +SYSCALL_DEFINE3(map_shadow_stack, unsigned long, addr, unsigned long, size, unsigned int, flags) > +{ > + unsigned long aligned_size; > + unsigned long __user *cap_ptr; > + unsigned long cap_val; > + int ret; > + > + if (!system_supports_gcs()) > + return -EOPNOTSUPP; > + > + if (flags) > + return -EINVAL; > + > + /* > + * An overflow would result in attempting to write the restore token > + * to the wrong location. Not catastrophic, but just return the right > + * error code and block it. > + */ > + aligned_size = PAGE_ALIGN(size); > + if (aligned_size < size) > + return -EOVERFLOW; > + > + addr = alloc_gcs(addr, aligned_size, 0, false); > + if (IS_ERR_VALUE(addr)) > + return addr; > + > + /* > + * Put a cap token at the end of the allocated region so it > + * can be switched to. > + */ > + cap_ptr = (unsigned long __user *)(addr + aligned_size - > + (2 * sizeof(unsigned long))); > + cap_val = GCS_CAP(cap_ptr); > + > + ret = copy_to_user_gcs(cap_ptr, &cap_val, 1); with uint64_t *p = map_shadow_stack(0, N*8, 0); i'd expect p[N-1] to be the end token and p[N-2] to be the cap token, not p[PAGE_ALIGN(N*8)/8-2]. if we allow misalligned size here (and in munmap) then i think it's better to not page align. size%8!=0 || size<16 can be an error. > + if (ret != 0) { > + vm_munmap(addr, size); > + return -EFAULT; > + } > + > + return addr; > +}