From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 318E6EB64DA for ; Tue, 18 Jul 2023 08:02:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A56056B0071; Tue, 18 Jul 2023 04:02:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A05888D0002; Tue, 18 Jul 2023 04:02:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CC988D0001; Tue, 18 Jul 2023 04:02:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 77E656B0071 for ; Tue, 18 Jul 2023 04:02:37 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 31B7EA0203 for ; Tue, 18 Jul 2023 08:02:37 +0000 (UTC) X-FDA: 81023990754.10.814CB7F Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf27.hostedemail.com (Postfix) with ESMTP id 9F8234000D for ; Tue, 18 Jul 2023 08:02:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=heitbaum.com header.s=google header.b=YDBzoZ2Q; spf=pass (imf27.hostedemail.com: domain of rudi@heitbaum.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=rudi@heitbaum.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689667355; a=rsa-sha256; cv=none; b=jAKHF1TtCkPsza2xUcTelLWT0Q+1drOgm2N9XbA1HqbNgIibsJfmpo+ZH8c59MwBncWSmo cncrs8bnQVEaKTfT9wyiVzkh+AifMrgtuitQTviYg2hnZjQ8w8bTojIdXQONg027WRU1C0 bOrRhJTAQWObtsOGWpFd4NE7PS0JDUw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=heitbaum.com header.s=google header.b=YDBzoZ2Q; spf=pass (imf27.hostedemail.com: domain of rudi@heitbaum.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=rudi@heitbaum.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689667355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fnwKc/o3ISHm8NcR21OLJ9uDUCnyHyDdo8J6H/w7iTw=; b=QSxJO+Z1jYPGhSaBmb9avHBBxeJKcVsF79sbU5yZI17aInME9irJbEDaY1DsHmUEy6OwPn Q97wXwgmVb9xqEQtEBxo9cQfUtvbJIG5avlO9LLTz+sHB8GYHiMnLkoUiK28B8VGwce4vu EbU8pA+dfvIXvVt6nEg/7w0JknD0o/Y= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1b89e10d356so33211055ad.3 for ; Tue, 18 Jul 2023 01:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heitbaum.com; s=google; t=1689667351; x=1692259351; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fnwKc/o3ISHm8NcR21OLJ9uDUCnyHyDdo8J6H/w7iTw=; b=YDBzoZ2QJljNIlYmSvS0QS08AyWmQkA8eWYBsjFyGKN2ULcH2tKZpx2j3CTyz5zKJ1 itg3Haejzl9W/y1o8RiUcUBiZwDyI8F4M0avo9WLTpITRc+UcnRqZCEnYxvW4wgL6D8Y Z2Gz1B74iO4ilDDZM6OZhcD/m62y4/h25ry3U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689667351; x=1692259351; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fnwKc/o3ISHm8NcR21OLJ9uDUCnyHyDdo8J6H/w7iTw=; b=L4zb04SGgSoBa/5Na+noXOdPNObPmFqChQS86K2oZcQ6iDc+A6wEamTO9WMNtvIUi+ PxcDrOGjXdaMd16bWc+6hZI8VqZErBKr3Du8+KvX+SdAIzfGhpKVu8Ez6mxnkTaIjLhN BW1mAyNJxViKZZ+JdGtovid/ESfnNVDyWacEG72P+gYgSI7dZKxFNnvro3OfAA4pM29w o53x+fgbUYujUKSAadDoC3hAVtGidhvD4347UMZqmvTaXdsRWFTnfW+qoskDTa95SNr0 hc/fVZuRTH5nDJGvMCUccDCdTr1SPXx+tn9hYgj4l8Bik5yLgqN1pExHmU8tPkBk3wmm kNmQ== X-Gm-Message-State: ABy/qLaHWeuw79EzUnJ3mdcVSEcSlNS0NEFKvget+fIh+BiiW1KTS40Q kdI7dYFGOG7V4Fh1hfGny9FCBw== X-Google-Smtp-Source: APBJJlEe7fB6yHcAj9JWOSeLLAJphdyZKwKLmfC2xgNTv4YvfT8lwCODnKRipFxioXejYwrlNBunGA== X-Received: by 2002:a17:902:e743:b0:1b2:5d5b:e871 with SMTP id p3-20020a170902e74300b001b25d5be871mr1425468plf.59.1689667350665; Tue, 18 Jul 2023 01:02:30 -0700 (PDT) Received: from 503599e9be06 ([122.199.31.3]) by smtp.gmail.com with ESMTPSA id y6-20020a17090322c600b001b53953f306sm1173206plg.178.2023.07.18.01.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 01:02:29 -0700 (PDT) Date: Tue, 18 Jul 2023 08:02:22 +0000 From: Rudi Heitbaum To: "Peer, Ilan" Cc: Bagas Sanjaya , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Kirill A. Shutemov" , Michael Ellerman , Andrew Morton , Linux Kernel Mailing List , Linux Regressions , Linux Memory Management List , Linux Networking , Linux Wireless Subject: Re: mm/page_alloc.c:4453 with cfg80211_wiphy_work [cfg80211] Message-ID: References: <51e53417-cfad-542c-54ee-0fb9e26c4a38@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9F8234000D X-Stat-Signature: qhcoupgdnxieiff4ynmmpwpiybewj9rb X-Rspam-User: X-HE-Tag: 1689667353-218174 X-HE-Meta: U2FsdGVkX18PGWSYzzmIASbJOagpsAfOik7FnW9CZwfqTTyas/jHzLc9hYOFYHYVpdA+mqvjGh7o0ZyhXpKX7zUvDXstC+8E4F/xQw99K7IhfQfdiwT8/wGBl0pPTYCHG8nDplzXami6N4y+KCGyG+g7jesOBVRqx22y5Ls/Y8Ap/dHSCWnwvHSVfzHpYm1mGlEelLjYmEW7WL4suWU4WFECGsbizXHBIFXV4fLZurwi464nUPGw2qUyQUcg9LVhDkR2R0HK2sGH/Pe3GqudvGnvUAKwmq0VCy3Rgs8QwuEtXbO1X0jlPAvkz1PRFEBKdi/oU7YvrVgef/ad8rtXLy55PdZT/VEpgOmTm6BtCXn6ZcyhpaKoc5UJJlpKic/qfWxNanbbxIxeRJ9L15v+LsHvW0c3PpTgwUrQGKZTB6ztORz4coZs+eCyuyYC2+PcIjdw1P4nL7JLppp88eHO7FIW8fmgryn64VE7Od+N3A1nR89vtHwJl3geIbgrwWejsZ8KLApqlCf5upS/Xv55dVdDjk+0JNSFb74V8nCYKoNYqNiN0h4Va4IbPyFt11Caz3hMYpUGULp3JSR6Uy0S6BjVQxvwhgrf6iWme3nfvOxGiYwnlP2pAt+StQVwzD497xJxjWVueE0cDHyR9x0EePGsiCr19fJku9DlJSQfcIIFO+yDtpArh3OiqSLdwbs/Ch80nrwbQxcdBscnMs2xQhwxaJtea+vIi0M5jDvGI5Cagb4ruwnmto1wnmQWfsLMg1qk8bXHUSerK8FZg/cUlzAIRIpXSgkn4rMrm3trVlVBaDT0pEuvpIlhJbtflOo1Ns+ZAPdTprIYa5T5jlPHy4noO9FIjp2tvhlYEr+31tdf2l0a98dY/SR/3JAp0jJ9xBRT3qHqM45gFfhq0FG/mIk96dd2EQ+TSptZJ4L2JPO3o3/NY24We3qNas6tEuphuLs8YhhKAPNtV/SfVbk aNcMfeOE pQjyGL26p5NdiYSLYaMPHDQ5WIyyMDRFcUpENrv4PsfEuq1eFQDSaiglwe4YcDtG1KHJNQYmw0niciuMJ83TdcK5//+wT96kHGNPw26tIm75B8R4fd16uJzSZ8PvNstaNdZGrC5MPsJ6ojS2hz9HEJY6FGCE2DO38HmgZy/O8OT3GVbF8otWWmpH/iZZ7uzIq4OuIdqV7Vl8xZwZpqhpgSp9x9+rC9GJtsoEY63UsTn/ks9kI9XBHg1UAv2FkSKnXNNaeDNVdz4kxLy3JoruKLEpQ24agnwK4DyU6eV3NVhuorGMagNXe3nVtMw/RyJIaFu6XA/tJbq9DGERhQ4pm+7lTBznSHmlr5bhJYqOfbvX1VOhLBjMxuUvmvcKjI5zQFQx/+/VAHWYQFRbw2d9IO1I+qQ9sOwLQ3v14UYeuc67Y3ea8kH8w1Dt7MUHpk+jdERgahlYJknDwHR7mt8jZ86Y+V7qtFLCe77xK32Es6/MBK85m+N+TSOqTiKwJt7wTOE7pnZrNDXIho9FNBGXPqb8/hg0HRjEmcen27vB5ZFy1sPzJHtuwAAWykpDNpi8rIYDgeQej9JTCWG4OkWqUm7CdUS9e2M9+sCicsxy6LUEWJWVGngolYm2VGHvG+7JIA9aUSP/ThCARAI9ygHzLV1iOMmV9unzrTKZT6JFDdI4yTw7s/lMoRr6MFvF7u/LZ3S6bU7bt8rAUtVGOL7rrwQAUn9hXnHwH/OaYSvv38mOZ4Ubl79ZROvU2v3RYXStWiF17d9LOXtsn58ES40Itixtqzx4MOTYh0axL+c4PiaFEWcvYiWW815rk7KnxeUmDQ81A5uXKyyk+nzM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > From 5a6fcc4b2a91608917697f8446ec3e10b2ce9178 Mon Sep 17 00:00:00 2001 > From: Ilan Peer > Date: Tue, 18 Jul 2023 00:33:04 +0300 > Subject: [PATCH] wifi: cfg80211: Fix return value in scan logic > > As cfg80211_parse_colocated_ap() is not expected to return a negative > value return 0 and not a negative value if cfg80211_calc_short_ssid() > fails. > > This bug was introduced in commit c8cb5b854b40f > ('nl80211/cfg80211: support 6 GHz scanning'). > > Signed-off-by: Ilan Peer > --- > net/wireless/scan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/net/wireless/scan.c b/net/wireless/scan.c >index 8bf00caf5d29..0cf1ce7b6934 100644 >--- a/net/wireless/scan.c >+++ b/net/wireless/scan.c >@@ -657,7 +657,7 @@ static int cfg80211_parse_colocated_ap(const struct cfg80211_bss_ies *ies, > > ret = cfg80211_calc_short_ssid(ies, &ssid_elem, &s_ssid_tmp); > if (ret) >- return ret; >+ return 0; > > for_each_element_id(elem, WLAN_EID_REDUCED_NEIGHBOR_REPORT, > ies->data, ies->len) { >-- >2.25.1 Hi Ilan, I can confirm that this fixes the error in my dmesg. Regards Rudi Tested-by: Rudi Heitbaum On Mon, Jul 17, 2023 at 01:41:43PM +0000, Peer, Ilan wrote: > Hi Sanjaya, > > Can you please check if the attached patch fixes your issue? > > Thanks in advance, > > Ilan. > > > -----Original Message----- > > From: Bagas Sanjaya > > Sent: Sunday, July 16, 2023 14:11 > > To: Rudi Heitbaum ; Johannes Berg > > ; David S. Miller ; Eric > > Dumazet ; Jakub Kicinski ; > > Paolo Abeni ; Kirill A. Shutemov > > ; Michael Ellerman > > ; Andrew Morton > > Cc: Linux Kernel Mailing List ; Linux > > Regressions ; Linux Memory Management List > > ; Linux Networking ; Linux > > Wireless > > Subject: Fwd: mm/page_alloc.c:4453 with cfg80211_wiphy_work [cfg80211] > > > > Hi, > > > > I notice a regression report on Bugzilla [1]. Quoting from it: > > > > > Linux version 6.5.0-rc1+ - up to > > > 831fe284d8275987596b7d640518dddba5735f61 > > > > > > [ 7.312665] ------------[ cut here ]------------ > > > [ 7.312671] WARNING: CPU: 8 PID: 659 at mm/page_alloc.c:4453 > > __alloc_pages+0x329/0x340 > > > [ 7.312683] Modules linked in: exfat ntfs3 bnep btusb btrtl btbcm btintel > > btmtk bluetooth ecdh_generic ecc iwlmvm mac80211 libarc4 > > snd_hda_codec_hdmi iwlwifi snd_hda_codec_realtek > > snd_hda_codec_generic ledtrig_audio cfg80211 snd_hda_intel > > snd_hda_codec snd_hwdep intel_rapl_msr x86_pkg_temp_thermal > > intel_powerclamp snd_hda_core tpm_tis intel_rapl_common > > snd_intel_dspcfg tpm_tis_core idma64 rfkill tpm_crb tpm rng_core > > pkcs8_key_parser fuse dmi_sysfs > > > [ 7.312725] CPU: 8 PID: 659 Comm: kworker/8:2 Not tainted 6.5.0-rc1 #1 > > > [ 7.312729] Hardware name: Intel(R) Client Systems > > NUC12WSKi7/NUC12WSBi7, BIOS WSADL357.0087.2023.0306.1931 03/06/2023 > > > [ 7.312731] Workqueue: events cfg80211_wiphy_work [cfg80211] > > > [ 7.312785] RIP: 0010:__alloc_pages+0x329/0x340 > > > [ 7.312791] Code: a8 44 89 e6 89 df c6 45 c8 00 4c 89 6d b0 41 89 de e8 0b ef > > ff ff 49 89 c7 e9 90 fe ff ff 80 e3 3f eb c0 c6 05 69 49 f7 09 01 <0f> 0b eb 98 e8 > > 1e ec 6d 01 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f > > > [ 7.312794] RSP: 0018:ffffad8e80defbf8 EFLAGS: 00010246 > > > [ 7.312798] RAX: 0000000000000000 RBX: 0000000000040dc0 RCX: > > 0000000000000000 > > > [ 7.312800] RDX: 0000000000000000 RSI: 0000000000000000 RDI: > > 0000000000040dc0 > > > [ 7.312802] RBP: ffffad8e80defc50 R08: 0000000000000005 R09: > > 0000000000000018 > > > [ 7.312804] R10: ffff938899d4a800 R11: ffff938891a9c800 R12: > > 0000000000000034 > > > [ 7.312806] R13: 0000000000000000 R14: ffffffffc02b150d R15: > > fffffffffffffc90 > > > [ 7.312808] FS: 0000000000000000(0000) GS:ffff938fb6600000(0000) > > knlGS:0000000000000000 > > > [ 7.312811] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > [ 7.312813] CR2: 00007f540c94b710 CR3: 000000059502c000 CR4: > > 0000000000f50ea0 > > > [ 7.312815] PKRU: 55555554 > > > [ 7.312817] Call Trace: > > > [ 7.312819] > > > [ 7.312822] ? show_regs+0x69/0x80 > > > [ 7.312827] ? __warn+0x89/0x140 > > > [ 7.312833] ? __alloc_pages+0x329/0x340 > > > [ 7.312837] ? report_bug+0x15d/0x180 > > > [ 7.312843] ? handle_bug+0x42/0x80 > > > [ 7.312848] ? exc_invalid_op+0x1c/0x70 > > > [ 7.312852] ? asm_exc_invalid_op+0x1f/0x30 > > > [ 7.312857] ? cfg80211_scan_6ghz+0x12d/0xcb0 [cfg80211] > > > [ 7.312911] ? __alloc_pages+0x329/0x340 > > > [ 7.312916] ? cfg80211_scan_6ghz+0x12d/0xcb0 [cfg80211] > > > [ 7.312968] __kmalloc_large_node+0x7e/0x170 > > > [ 7.312973] __kmalloc+0xb9/0x120 > > > [ 7.312976] cfg80211_scan_6ghz+0x12d/0xcb0 [cfg80211] > > > [ 7.313028] ? sched_clock_noinstr+0xd/0x20 > > > [ 7.313034] ? sched_clock_cpu+0x14/0x190 > > > [ 7.313040] ? raw_spin_rq_lock_nested+0x12/0x20 > > > [ 7.313046] ___cfg80211_scan_done+0x1e0/0x250 [cfg80211] > > > [ 7.313099] __cfg80211_scan_done+0x23/0x30 [cfg80211] > > > [ 7.313153] cfg80211_wiphy_work+0xae/0xd0 [cfg80211] > > > [ 7.313201] process_one_work+0x1f1/0x3e0 > > > [ 7.313204] worker_thread+0x51/0x3f0 > > > [ 7.313207] ? _raw_spin_unlock_irqrestore+0x26/0x30 > > > [ 7.313212] ? __pfx_worker_thread+0x10/0x10 > > > [ 7.313217] kthread+0xdb/0x110 > > > [ 7.313222] ? __pfx_kthread+0x10/0x10 > > > [ 7.313226] ret_from_fork+0x3e/0x60 > > > [ 7.313229] ? __pfx_kthread+0x10/0x10 > > > [ 7.313233] ret_from_fork_asm+0x1b/0x30 > > > [ 7.313237] > > > [ 7.313239] ---[ end trace 0000000000000000 ]--- > > > > See Bugzilla for the full thread. > > > > Anyway, I'm adding it to regzbot to make sure it doesn't fall through cracks > > unnoticed: > > > > #regzbot introduced: v6.5-rc1..831fe284d82759 > > https://bugzilla.kernel.org/show_bug.cgi?id=217675 > > > > Thanks. > > > > [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217675 > > > > -- > > An old man doll... just what I always wanted! - Clara