From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44E48EB64DC for ; Mon, 17 Jul 2023 13:34:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2E296B0072; Mon, 17 Jul 2023 09:34:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDE9E6B0074; Mon, 17 Jul 2023 09:34:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCD8E8D0001; Mon, 17 Jul 2023 09:34:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B134C6B0072 for ; Mon, 17 Jul 2023 09:34:35 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7CDF4C02BC for ; Mon, 17 Jul 2023 13:34:35 +0000 (UTC) X-FDA: 81021198510.12.1831E8A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 13D8740019 for ; Mon, 17 Jul 2023 13:34:31 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ecUGWeYl; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689600873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wKKN1YUOoGsvhPfY2Rq6Z6lVgG5y1GpB+sjDgdgd22g=; b=y7H9rWIjcyDesQ0gBcFaW74j2vnCPJeIazvH1xiIEJfwS2UpfMhrQ+Qcbw8UfIlyrjGph7 grN3HXsrK1kNvwR5MNM2U9CmSQEXo8K4LrqPf2KkAzAnP3vHquRwKNDiUoSRsWsUH/p9Zh iQW9yF7xiFsdJ/hykRcYdnaqeNUB0pE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ecUGWeYl; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689600873; a=rsa-sha256; cv=none; b=ofqqb2MwYprvCmtDM9Bu1z1OrnMHG/y6GbTJfhKhqwphyXSEa4GoakYInXIGzwFSbcq37n 0RZ8DBIKNsluxbf0YsjPDkk43FiThn9ilcVCbmK9JJkl3GtFy6L2S415NXCQffgDcdJXTI iuh0RAyI8oRXJ+Ab/BVabUdouhoCDnU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wKKN1YUOoGsvhPfY2Rq6Z6lVgG5y1GpB+sjDgdgd22g=; b=ecUGWeYlGsQSQf8xRjneISGn2t um0nVCPO+s6BHHUrXZeCihb57E4O/+NZM2xNNJcN0u4qJvQDSGjUZI0o4M2fWxKEstVh9+att8Cew dLcdpnhgG+F5YJFqIWEoaBOPpyCYAQFJcihb68na5EGvTh/NCtifOziWXrjGfktFKH8ifNKzyBesF 2z5ExPnpIkOiIG7alWfDNj0yQarKZ2D2ZJbdB4QpoaE2QTDlW1tUC/MajWuq4a02id/+XpvVuHta1 HmSRQIrDJ5B9O177wv3iww6nfseREhZS3/dagQoOUVGh/sKpbvGYERfDh7CydB6cWuh7MLVTKuPr4 +i/5fLDA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qLOMs-003wzt-It; Mon, 17 Jul 2023 13:34:26 +0000 Date: Mon, 17 Jul 2023 14:34:26 +0100 From: Matthew Wilcox To: Peng Zhang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, sidhartha.kumar@oracle.com, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH 1/6] mm/page_io: use a folio in __end_swap_bio_read() Message-ID: References: <20230717132602.2202147-1-zhangpeng362@huawei.com> <20230717132602.2202147-2-zhangpeng362@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717132602.2202147-2-zhangpeng362@huawei.com> X-Rspam-User: X-Stat-Signature: 6dmn5ygnmy58qd4wqixpad1atszz7z5o X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 13D8740019 X-HE-Tag: 1689600871-539241 X-HE-Meta: U2FsdGVkX1/aqE4GTT7n/Xz6ON1g4hhTGwGvxVQgcG0FCukreHnC0uz0wg3ZpYr6YrSdLscxNn03p+SIULMwhKOX9sA/DOYbxba0hwxRKDeVHpkL22LvptuZ8ga87tLxFdT5vTmraxJpxNqpPCb/WNBhIe5/gyfpGLiB/gKnH2U8Dl31sb48KdRaYcdRpJ++ngSLqBXYrrDS+nA9B8H9+bYnH5yqlUuQ3ZbBUQpUz75dVMqUpoAwuuo1IzwSqIpxRP6c2qshXmFuqdlJV+FcUz4zdK9N5NY2p+QRgWI9M8YkaH/xKZzBVl5AR8br3DjeZaV2/OjIdZmoLIP5HKBPvyHgzNuyALzVQv4pCmPHqfjJ5c39+JGOel7q9cL4qyZN4Yrk+ej1G1JzbZdUNqmEkJA+/ZRB7ugzZkvaJUvjmtBr4XwKX3QL43HeC3E7OHpnEDHIvYPrTTkhbwmLKc3Ak1JG5p8TaxIBkNEDoTD/OdObFEpofQCDIXfr5iN+wNZ4tliyYi9Sk2Cn+PT5mBk2gpkwHnEFtRm1IyHKRM6VzG3zc0lsZXisye5iU+LOwk89llb/qWG1ZIBekxw8d92O1dvrCWUl/Hf/vbFVyQTN3HVEpmBAmGACgZOcFS0AlTEGIN2WhCJkXVsgnD+12tlBP72cmiTaK45fsXSh9u34PXFg3ckdyx/FomP0d1Eg6Qm6Mo5jtvetRHfnyc65imuU8/XW15DrgQJsjN2YUmO5ePwK1vV8Ohz0DrecQI59oCcLKQOgKvabJbqtsXxYvKPtHa+u/92GOVtmHfNGc3NKj/b02/uT/CiA7gdi7K7oOX2dsMzN++ImJvOzS9jJDvZuJv32Yjxn9AZQ7UY0rNqVGweVl+R9vs+DN4viLDQlkgFaFVgAHtm1gqVqrQfrsoKKkOqvWkHndthIg5FZfKFCevSTAernNtVMOk6LTXRW5GyePeFbiH+cOTvKxjDZrQN /5r380NN 5kuOFTDCvCv45OUMHXi2IkWjIUw1w6Gwwg01Dwr5MW5Y2DX/ByD4kblrKudC/ZkUesS/lnRA0wUNoQPVWEKDVomb8gEqEtYwHWaW+HO6FiCTwRm712Tlhes0mLDOlttlOXSr4D4lWaKnlp0QjD9MH7NCiYpKPB1LGPgpUILnjk+V02Gt5cgOQGwC+MQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 17, 2023 at 09:25:57PM +0800, Peng Zhang wrote: > +++ b/mm/page_io.c > @@ -58,18 +58,18 @@ static void end_swap_bio_write(struct bio *bio) > > static void __end_swap_bio_read(struct bio *bio) > { > - struct page *page = bio_first_page_all(bio); > + struct folio *folio = page_folio(bio_first_page_all(bio)); Should we have a bio_first_folio_all()? It wouldn't save any calls to compound_head(), but it's slightly easier to use. > if (bio->bi_status) { > - SetPageError(page); > - ClearPageUptodate(page); > + folio_set_error(folio); I appreciate this is a 1:1 conversion, but maybe we could think about this a bit. Is there anybody who checks the PageError()/folio_test_error() for this page/folio? > + folio_clear_uptodate(folio); Similarly ... surely the folio is already !uptodate, so we don't need to clear the flag?