From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 256A4EB64DC for ; Mon, 17 Jul 2023 06:40:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DAE78D0006; Mon, 17 Jul 2023 02:40:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58A728D0002; Mon, 17 Jul 2023 02:40:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 403DA8D0006; Mon, 17 Jul 2023 02:40:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2E0A68D0002 for ; Mon, 17 Jul 2023 02:40:17 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 057F81203A4 for ; Mon, 17 Jul 2023 06:40:17 +0000 (UTC) X-FDA: 81020154474.12.5BF3C08 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf24.hostedemail.com (Postfix) with ESMTP id E3B5B180005 for ; Mon, 17 Jul 2023 06:40:12 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RKp+BOmU; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf24.hostedemail.com: domain of yan.y.zhao@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=yan.y.zhao@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689576013; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kZUV49p7Cb0wg38ZuXeCimeAlrW555Zzj1UvLu7rq0o=; b=TTsbqJPk7u8Eod3gs4wFlvVXGnIBv/EJzEdsLRr35B4hjBEEJNR9a9rXsEQvMZkg/wu75z qQFDoegnMXzozhDdEG1oBa4w/tEf9ZnRITScuUIQOccvhkOXlfgB1VxZq+k2Sa4Ba3v4MQ qNJoF+R8oJ2Ml8p4s3bypG/FCHrwg1U= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RKp+BOmU; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf24.hostedemail.com: domain of yan.y.zhao@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=yan.y.zhao@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1689576013; a=rsa-sha256; cv=fail; b=uTiEBk6Xn1gtBTcsOaZeY26XWiJqiWVmmAi5M7zS7da7H8gtpgqZsAvLq2AD6zFmNgloGk zM+aol4FTmUZnMpinWoxB8v2A6FMreutYbuC8EJtJAvs8/vn3W3j5YNfDIHApVkCg0ltR5 kt5+LclBpyZ6oHq+JbPerePDHydqvFE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689576013; x=1721112013; h=date:from:to:cc:subject:message-id:reply-to:references: in-reply-to:mime-version; bh=IdOmaGkqV7vkOl+82RoVPl+mJemdszGA2MJy6hGMe5Q=; b=RKp+BOmUQhIixyUCz76P7Zp69V0qinzGzWm8JasA56pDZyPzjvwSVF9g vr9mMBH28o8po2yy+C3NzDjS/K6w8jMFaLABut8J2TJH/ff2luAczcXJY 9B4yHu4PoUHy4oTIiQNmc0DydNPgdr2QUjomIAr5bsgNjaaE+Tkhz/K8T EA38VAgfVpjN25mfIASEJToqa9yii7uHz2oPWl3PD6HhpaxhVBvQS+gS8 hwAOyJ877Kd0bs9kvdungH6zxgR5P/9XcuEDsE1ABG3b1TEaLHTUk1tZ8 0wru45MJD7Ba+v9bd2eHb1822StM7x9XA9HpNfy7D89wAIrBLgKs9N8vp Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10773"; a="364731204" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="364731204" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2023 23:40:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10773"; a="813184538" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="813184538" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 16 Jul 2023 23:40:11 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sun, 16 Jul 2023 23:40:10 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sun, 16 Jul 2023 23:40:10 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Sun, 16 Jul 2023 23:40:10 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Sun, 16 Jul 2023 23:40:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TUbwv3djxsZwhM3iNdxyQaWpTl1Bu3Zc2cKXoPbrovMbRvd8ryjBWH9l/JOKgbh2UN40CR+xk96V3YzKkxmOx84dr+50lVrAnUA3oBA+WkG/8s+a1pdyMtn5smQzJW6FKxp6/ABlVvWYiTu4rXXBqlHYiAGEmYmcrF80Dl52h6OrcBiAjujzRynUBMGXT7GOIwQJ7Y5PkQbiiPrKEScaWhV4P5mXoCAE99G3DJ8ioBkmQxc231piTjAVCNxHdwNfY2yEDmyc9XwxrPCKDI2J+C/Z5FUOU2k6Fm05oix9MEaPR1kh76IZ/GQYUkhXCfkuX/uP+tBaJOURuC5z5XbjoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kZUV49p7Cb0wg38ZuXeCimeAlrW555Zzj1UvLu7rq0o=; b=VVMtAvvOFUQrSTrAKxDkf4o4yfOHIXOXR/IEvEC6z4X6W9NqN4lEHxWQN5w0KvYowzoI/DrPeN9cGcpQyL+Yxqolw0OwQXHfsMuSbkJnPlS1raJOY2oXKaR//B/tVwimNcDFObLajZLz6Js97suYggwdkByJvOKIewjLgAJytMVTXWIso/dL75mlIDR0wUw2K2vizCposZaG66NKSFtazw8ybRYBBnKXF+0XkVMm94o27TNP65J7XxNqV/uE7BI+gr03POPurnUGRj4cUaPD37bTJSVIPyDerK4ttEVUxaDN5HPwq6NtqmiUK5TBtMPKx7wXknMNdF61d7W/kci5FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS7PR11MB5966.namprd11.prod.outlook.com (2603:10b6:8:71::6) by PH8PR11MB6901.namprd11.prod.outlook.com (2603:10b6:510:22a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Mon, 17 Jul 2023 06:40:08 +0000 Received: from DS7PR11MB5966.namprd11.prod.outlook.com ([fe80::c7b3:8ced:860d:6fe6]) by DS7PR11MB5966.namprd11.prod.outlook.com ([fe80::c7b3:8ced:860d:6fe6%4]) with mapi id 15.20.6588.031; Mon, 17 Jul 2023 06:40:08 +0000 Date: Mon, 17 Jul 2023 14:13:22 +0800 From: Yan Zhao To: Suren Baghdasaryan CC: David Hildenbrand , Matthew Wilcox , Dan Carpenter , , Andrew Morton , "Liam R. Howlett" , Laurent Dufour , Michel Lespinasse , Jerome Glisse , Michal Hocko , Vlastimil Babka , Johannes Weiner , Peter Xu , Dimitri Sivanich , Mike Travis , Steve Wahl Subject: Re: [bug report] mm: replace vma->vm_flags direct modifications with modifier calls Message-ID: Reply-To: Yan Zhao References: <331201b2-5f13-8e81-b5d4-b17f8784d498@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SGXP274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::17) To DS7PR11MB5966.namprd11.prod.outlook.com (2603:10b6:8:71::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR11MB5966:EE_|PH8PR11MB6901:EE_ X-MS-Office365-Filtering-Correlation-Id: e40bf87d-c317-4754-8b94-08db8690a92b X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k7IHYh9Q/f65jYEvvQrUDPukoNUxKZXW5CJ+LkN6NAAyAqRoZivYxHFTpVRKkB6TNQ7WQKrO3UczdUeAy1bZaKhxM279Far5Hw4hxz58LWSATdEH1FrNkKi8DvZjpsdoFGYqRg8FaPqf6fH9T4N3sP4wnczoJXaZs1uNEMtz9/JbM+Q9ZaCWh7xEY+Jze3c3q7sON/ZoSEg3nFpjZ2Fv0GmZMmFbL3c+qVXyd05pGLYuUgTiCPBCI4MPPSdow5Dkbhh++H6yuqRj8h1sRpq04L10eoStO2zszDtIL7O+jZSTpgYcTFrsHgBT6QxLE5HPEMFeNq8WDEs9b0/30YT38dQiy67UhzKQy7ve9EOU/vez4Xrn/r7NPDG1M5TeG6QoVSul4y1uZXfgZ0b40TQHcJqd7vwff/RGngJdUFG/lRLA+RsQC8NPGmioWcCJ6dDh9M4K3lv9gql14fyC206Z1jhfAvjb8dAYPdw0y0CRfs4vRqBXlPDvgVDbjwsVJYATk9/4038fyy8gR/QtfKJze2ide5wOJh6wTn1UvS+9SII= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR11MB5966.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(376002)(39860400002)(366004)(346002)(451199021)(54906003)(6666004)(6486002)(82960400001)(478600001)(7416002)(5660300002)(8936002)(8676002)(2906002)(4744005)(3450700001)(86362001)(4326008)(6916009)(38100700002)(66476007)(66556008)(66946007)(41300700001)(316002)(6506007)(26005)(186003)(6512007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?f5mAWoms5UYS71I5E+K0UxfgzSlZHH/uBcuXilvGh0NjRjNe8PVvbm8eDWxG?= =?us-ascii?Q?LCQnAX6b95Pi+uAi38DZl6FrNYuiKWkYvEjXAmdP2w9jQlr713PStomb0n6m?= =?us-ascii?Q?o4s9Enq8aKmW/ueVWfbQOKZlNfTILef3cL8bAbDHvMo0YrNP7uUCvyo5hvl0?= =?us-ascii?Q?MIa0nXYXSX2KNayR1jtRlrUPrtJ5ur1NWwTKwXKFH+eKu5CGrRgZwQRE8qTs?= =?us-ascii?Q?fecfuKDbBylC2i4nm893tv3FeAcM6AOkOrpdwcT3ZYI34jP5ozDk2Jn3gMKm?= =?us-ascii?Q?GG93aNip9aq3t0NLWAE3QfSe6lYxu3mmgv1x9VnDlGTD30zVQRk/3V0UtFSS?= =?us-ascii?Q?/AZhLVyCGz/OKnh2rO+XZtlslxMSNgRcjIDTX+623edjSAs31R89cWkWUTN0?= =?us-ascii?Q?pWJahnhg7yyHuy/WApaA2IbLbQVfrH6aMo81J+4tC0n3hlCmBAxZyF6PmROS?= =?us-ascii?Q?Tvtoc3/IgTAKRVe96/9xFK+s9z2APexcVZigbZlCrIle0H4mTPp3UvrFn7ej?= =?us-ascii?Q?8hpQy2rc8Cg4P0bQpJFAAGuwt1vSle2famdDDYW0BE9xePcL98yMb8Jyhau4?= =?us-ascii?Q?PQyqm0Cr5xe9X3ljOUr+wuESEdfXaedz2Se3GNTFHqC4quWXdYmnnHQ++8X5?= =?us-ascii?Q?sFZaylhGbQxBbmIO2ZZOMxjL2ENDZKL6TkgvtI5ERd6Wf0Sp05HLoVU3Q4mV?= =?us-ascii?Q?GQAKvDGcKoGeyl9tGWC+SNNbcx8+A7vPVhovalSl7UbEXFEgw8vXKzAV3fEO?= =?us-ascii?Q?BCtfBPiOMBsFSI/qBMl7Hr+kQFDXGC4A3Ai02/SRY3hV9DReQEg4179TbNnV?= =?us-ascii?Q?BP1Bs1W/gDZRiZdU6Vcb7l9T5MDPURCu+e5snfMMIqsaSDGbdzUCeV2Qo4r3?= =?us-ascii?Q?kPfN1aPNfBjky1wwMyQu5V7v568IdhiIW96AjriSvjE8+uFy4AD8Yb3Z4Hk2?= =?us-ascii?Q?I7IrBdnKojfaAhpkzgtnLNhnJOXQs5rhbNOuFwVfHett8iFk2oYbTCwxANxj?= =?us-ascii?Q?7PdbVjDD+2LdIk3jtBQz7+DhZfp1xCXZ8F3NOZ1ZOgOCWHSe326XqoF1Oak3?= =?us-ascii?Q?5tK8pd+7X2lACTCeYWNdn0Uhwhr06cYEpP6D3UJSlrvdDhodanyBxX1cTXw8?= =?us-ascii?Q?x0ZcAH+X14RlY888Vxw9O3CoVKIb31aVS0zgka6s0yiyxzs5FlmaXQ4CJnKM?= =?us-ascii?Q?6n5q6uigLI6dBcy4xx96tDC7Z6qmKEcaoezyke30ZpcwJjsjigKZojLf1I2C?= =?us-ascii?Q?NehTltsgiivbCNcD+TNMlgJX35HvRH+ZzHKkJr8fsB4vQitDnI+AkrrWBw5U?= =?us-ascii?Q?8BOyD+wWtaPw0Ph340SmiWqvNLW/hrP9ms8hNjSfJC4Z5D7gezzlOmA+gezA?= =?us-ascii?Q?GueT16Qie1fvVqv063t8bAdy5Kb3Dx+pMdo7zPnSXcqTI2z8Jxhp+YeGZYCO?= =?us-ascii?Q?E9NQ3E4ybKrk/Ow3NJHM5MulAqlibR5C8lr8eGDY9lAOJMISwIa0zoMatABo?= =?us-ascii?Q?P9vzkNDkUoZOgQmFG5qBmOoA8hWDtQ6IDNr8ccGwm5rL+brJ4AkVvWhQrKXb?= =?us-ascii?Q?MkbEF8A9CC88/TRuGTWBBNWTgVy8/o4Yd4EPFL/G?= X-MS-Exchange-CrossTenant-Network-Message-Id: e40bf87d-c317-4754-8b94-08db8690a92b X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 06:40:07.7223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ojEuchFsT/Xz2cs3mrNALGVqTFgK8zsz5BO/cqc+yXgV82mJCoYDI7K64hOVHAlbdFq9LAKz84zoJaMo5avGCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6901 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: E3B5B180005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: byf15tx3yiipq5prx9jgt1tuetm36im5 X-HE-Tag: 1689576012-509176 X-HE-Meta: U2FsdGVkX18F1UoXDec3Xnx3qRqnfdgibBNr9DDJ4aInJuDLSkP0bqG2pv6g7EqzCaZ/8D6s22I1xFbWH2fOYwDiaxNJIHHKIYSuHEqsTrXWK8rkoAfbRtK2a57qvnK41rFyCuoMegMIixARAvxuO1IGPk3p2itBUviaPuB8DnApA8sMMyBXeAuA+wE3fpsNyY2k+UC3R9ejGMem0sZak4cWUd5wCXa4+0n3EC+0Zus3GociE+mPhSnHg80DJyDaiBdY9sb7rUUHXaP+LESpmJjqReTgyY4t+QXT1+x2KABZd75XFeL0jPlDY4dah7ccshCyEW5SLhpIHWxLyVFz1NI9HDHwLXd8TWcMajPYhVP65RueaW/WOphSHDOHV4QKQgdzfDLn5hdZ4mKzxHuDhQ7lncS+2ul4PFBvYAl+qaBQ80F4BNgFec09R/zJe+ArrHEYnI+1rqFuznH9WxLwp3hmAaqTmGzUqcnJIxQAcTBfnkqfduVAtipwyiap/2zpJ/PGNv5hvW7vPUFO6wuOhupnGvI6fgPQ+CYyKOli00cTRO1BZV29HCImZropu0+D1ZO2KF0oeXL+yjdgm5ZPkpxktFuTZ/X6b2FWVkrdY+Cv60Rc3qx57faLYDeabDlX6MegBiZaIS8e2ZFkQGJNYWhtuZBgTLSZq/15VWCVmw6t2Jy5Q8NsiZKLJpfPgZaG+63dC8g6OZuADJS80t/8bsIWN9JeCdM/4ilW7sepSn+rXho7il8d7FcS4qYB+4p+QuWf5GtzwWPSkvxAa4+Uuj7SyA77QFW4FpAvnx9Paz11Z9Zia5bcaWYNArcsceL5jZXb8tSYvMqTubSVdTUkQWvM+yS8Mcifwpqi9h1kZVAe1nnz9rOvET89n94UjbOzH0KuulZYzy+17V/8fRWUQxjDnX10NwmU8KZU4vLzOKVz0nN2Yyv2NvrIWNAtS0C/R/hXyzpI97LCKwCG71y rtJlg1Sa E//S0VJqsrwuKFwSN74BT89sQFO/+sjSIl16EkrQU6NZQJg5waBF1EufvK5kTf1IvwjeMcJoTw00OYUwgE+C3LHUINxsw5QnqM/4i5PSvcBTTFC7YnJF3nXiWtVMZyLnygZanMe4hlS+dDDTq7j0OsKeurP4DWw/ghJlVm7UH2pB6Do9AA8RTNDKbqmXHvP36+zjqpgarDpYwkto3eDAhk3+St17kiOwsaNME8WLIhuLq7DupgO4387E9ehME+qwX4dexOybQdb0jpmkCAZRHKwNCtqClblXaq2qA9CHxznJulmWSq2W9EYtbqnwHu99POAz1CyIXXXYxNysX+6DzB9yk4Dfjb6f6VDw9m2fmxMu4iQs/1l5DJ11RRkDT1iL/zOS5JlTKN2+Lr5k70KHzdGfwwxGNm3ATddlezna90llKRD8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 12, 2023 at 07:48:06PM +0000, Suren Baghdasaryan wrote: > > Would we be able to fix it in stable simply by not triggering the > > vm_flags_set() in case these flags are already set? > > I think we can do that. gru_file_mmap() sets all the flags that are > set by remap_pfn_range_notrack() (VM_IO | VM_PFNMAP | VM_DONTEXPAND | > VM_DONTDUMP), so we can check if all bits are already present and skip > the vm_flags_set() call. > But on x86, remap_pfn_range() also sets flag VM_PAT. (in track_pfn_remap()). Is there any interface to allow device driver to pre-set this flag in .mmap() before .fault()? e.g. export track_pfn_remap() ?