From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C036EB64DD for ; Sun, 16 Jul 2023 15:12:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C18876B0071; Sun, 16 Jul 2023 11:12:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC77A6B0074; Sun, 16 Jul 2023 11:12:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADD996B0075; Sun, 16 Jul 2023 11:12:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9F82D6B0071 for ; Sun, 16 Jul 2023 11:12:03 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6BB99140213 for ; Sun, 16 Jul 2023 15:12:03 +0000 (UTC) X-FDA: 81017815326.04.4B754EA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id B9E7D40003 for ; Sun, 16 Jul 2023 15:12:01 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689520321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AgoofMymdZyOdUtsAe1UsW5CIzZPJ6bSdSbmS7A7yoI=; b=SEzO2HVqS3f0staFNKNWQMBZmUVPRomcRnuHUJQyewOpYlsQreV/sjo6X2ri9Dg81AX152 CK02Y+E16Xu9qvXAtyJVlQGb1YDDSSkABL2NXWcHjIuJDN1NHmNNYRbtPsium8SsdtWQ71 CdBsYT2NvejUTyPA2lHQjVTB8z+shJM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689520321; a=rsa-sha256; cv=none; b=oOCkpNrYfOgE4jYOsO81PQ1SQXOXVUzlcpVZDm6zm7+YWTPnb3DGD1Rz2Tyc0fcpqLp8vU 18rJZPvkdrtKtvypmdMc0OpNBCc23HBXQJcMUtwkc6MUI85s30/f+aDdU/MLYLNbQNdCBY ZRlTRfi1FIWstjiCLY08Nz0EHo3HspE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E2D3260D2D; Sun, 16 Jul 2023 15:12:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FFB8C433C9; Sun, 16 Jul 2023 15:11:58 +0000 (UTC) Date: Sun, 16 Jul 2023 08:11:56 -0700 From: Catalin Marinas To: Yicong Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, mark.rutland@arm.com, ryan.roberts@arm.com, will@kernel.org, anshuman.khandual@arm.com, linux-doc@vger.kernel.org, corbet@lwn.net, peterz@infradead.org, arnd@arndb.de, punit.agrawal@bytedance.com, linux-kernel@vger.kernel.org, darren@os.amperecomputing.com, yangyicong@hisilicon.com, huzhanyuan@oppo.com, lipeifeng@oppo.com, zhangshiming@oppo.com, guojian@oppo.com, realmz6@gmail.com, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Barry Song <21cnbao@gmail.com>, wangkefeng.wang@huawei.com, xhao@linux.alibaba.com, prime.zeng@hisilicon.com, Jonathan.Cameron@huawei.com, Barry Song , Nadav Amit , Mel Gorman Subject: Re: [PATCH v10 4/4] arm64: support batched/deferred tlb shootdown during page reclamation/migration Message-ID: References: <20230710083914.18336-1-yangyicong@huawei.com> <20230710083914.18336-5-yangyicong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710083914.18336-5-yangyicong@huawei.com> X-Rspamd-Queue-Id: B9E7D40003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: igcfnqfceq3pqohpn83xh6ua8i346r1j X-HE-Tag: 1689520321-826035 X-HE-Meta: U2FsdGVkX196k8W6+CkMJ38xTBD3X+rnofAARAsUJ70CwGUwrvD61Yp/KitUazy5lGJ0h2dFSBerQUttB02HOhCDr9t59b//pbDTEiusdUNbk/C9cBknOS+hJ2gW9CE53v4/mQDVL7JxmNFvYrO2Lgi/9gpm8i+OtwQ9DNlOFRyU+YJN7ZUXgZT0/ADcUS8xdWIgrxR47+9nSz3aCj8C9OisbNrpiSN+Yf0JXFkBrGmGbDAhkyQnZ9Lmq1eZMW/szIKsNEgANUtC6wweCqztgPoxcBXE2y7t29ERDDWucVSyYlarzRI/0hh5bIMYhMS9BjGapCWTBgihDuPyCYU5E7o+FZ6DqQ4OdHK/EnZBn0KnDwZ7aBJb7XdWvUMi2WKAxJ6HB7lmMK0tl4KdIzDP4qLN+/TQYPjVybmrvtOIHlhXmoKAtMcfp9QggWe2/1OpB0ZwtCCzUK2LPrdVnG0oWON6Gjfl5bP0AjY3Byf20hWOegvfPLtCKbyFlGiO5Xu/RBrmnBWW7YacunjMcT9wqiwEDUMbLwJkOBObz0vO5wZW8hBmwhe8OcHGEUM/769F5dZt3O56E7l48R6OMbRaFhfU4/B7EgChdXzSQWGvPk38ojnAZtwh2sQHNaF+y0J4TTGzTNLGI6T8MRCxdp9OKZ4eK9PcdzYNT1JHJRkcZiRHZUWTbYxAXlfrvhXDE+o+iibl6zgl08SLP2kN60MISWzz1Qp2dPQjPhtp/dmkNoLIjZJOl9ZrNzxBK/H4ovi+glJQsVWLeOp9yHXeZmFtMXftkZCivXE6YIc9U6MM3892h1xElCPzKhm7PI6IbT6geIEyVGjAOkNR7Iw1havBSuYQkSSkI1EH0ZvWD2sfgEr+VyZAeKZe74YKW5Rti+WsfxlzKKjlTD4D+WA1QPF9gdWWj3JCQp9F8gHZ5grYrYgQU715vmG8X4wpi5mj3qqlET5Br0GoE8wgF5LorsG hZlHoL+G 9NEpeh8MXCbxPihwF6B3C4yJCM84B0d/flnwbPl+6XLsNrg0w44t9yqpb2WLw7JMGDn5ZNEz3ixe5P9UOqK8vXpZEiwAjyIR+gsYIifr9/4VfEdrLOYR8CBOnem5yBcbhd0CCRi+6Fm6bP8uyimeKup3pUi9TTOxQQv/afGzaNu2Pz9BtqIq0d8PjQwBsPZylkYy5eAk5v+1y3LKt2e2X/HJxh/j9AqUtKg+PoKQLrlITJrbLowa7pucFVLsIOCRUihDAjV2g9nYqTO/wBbsbwj2nZJVdRGyS42ICq5IARhrp+6vN0YiVILHNdN/59JVS+wLcOVAm2acKvzFSTtKWbKQfEZeFEOYUhZKHqyg8KjrYOVMAZKIR7vQTkGrQ8MYmM4Pj7WdtKLI6O5hJBFvQgZQqn2vAurpsmAUPRNowY5Ta3Cw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 10, 2023 at 04:39:14PM +0800, Yicong Yang wrote: > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 7856c3a3e35a..f0ce8208c57f 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -96,6 +96,7 @@ config ARM64 > select ARCH_SUPPORTS_NUMA_BALANCING > select ARCH_SUPPORTS_PAGE_TABLE_CHECK > select ARCH_SUPPORTS_PER_VMA_LOCK > + select ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH if EXPERT I don't want EXPERT to turn on a feature that's not selectable by the user. This would lead to different performance behaviour based on EXPERT. Just select it unconditionally. > diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h > index 412a3b9a3c25..4bb9cec62e26 100644 > --- a/arch/arm64/include/asm/tlbflush.h > +++ b/arch/arm64/include/asm/tlbflush.h > @@ -254,17 +254,23 @@ static inline void flush_tlb_mm(struct mm_struct *mm) > dsb(ish); > } > > -static inline void flush_tlb_page_nosync(struct vm_area_struct *vma, > - unsigned long uaddr) > +static inline void __flush_tlb_page_nosync(struct mm_struct *mm, > + unsigned long uaddr) > { > unsigned long addr; > > dsb(ishst); > - addr = __TLBI_VADDR(uaddr, ASID(vma->vm_mm)); > + addr = __TLBI_VADDR(uaddr, ASID(mm)); > __tlbi(vale1is, addr); > __tlbi_user(vale1is, addr); > } > > +static inline void flush_tlb_page_nosync(struct vm_area_struct *vma, > + unsigned long uaddr) > +{ > + return __flush_tlb_page_nosync(vma->vm_mm, uaddr); > +} > + > static inline void flush_tlb_page(struct vm_area_struct *vma, > unsigned long uaddr) > { > @@ -272,6 +278,42 @@ static inline void flush_tlb_page(struct vm_area_struct *vma, > dsb(ish); > } > > +#ifdef CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH If it's selected unconditionally, we won't need this #ifdef here. > + > +static inline bool arch_tlbbatch_should_defer(struct mm_struct *mm) > +{ > +#ifdef CONFIG_ARM64_WORKAROUND_REPEAT_TLBI > + /* > + * TLB flush deferral is not required on systems, which are affected with "affected by" and drop the comma before "which". -- Catalin