From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54339EB64DA for ; Sun, 16 Jul 2023 11:29:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8754F6B0071; Sun, 16 Jul 2023 07:29:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 825396B0074; Sun, 16 Jul 2023 07:29:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EBE96B0075; Sun, 16 Jul 2023 07:29:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5E83F6B0071 for ; Sun, 16 Jul 2023 07:29:16 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2E914C0187 for ; Sun, 16 Jul 2023 11:29:16 +0000 (UTC) X-FDA: 81017253912.11.6F28B7C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 30204180003 for ; Sun, 16 Jul 2023 11:29:13 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lHQYkapW; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689506954; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GOnYVx5YAK+ziErge/1x9HGyqYnguAw6jCerx1KHHb4=; b=kb4+n+dzSt45tIVgPAsOjjAqrAXgY3NSalNu9QRITVB7XeR28zYP7obBODVYOjz7JIQc5k z+aCjwOmuLxW+dLcovZRl8ec1QdxyuGueB7jM0hLzzKsb0URqvYzxiv+HMBPdUOEovrNW+ cbE7AkWkZp2blBSegAOl7L/jcsJ2YuI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lHQYkapW; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689506954; a=rsa-sha256; cv=none; b=nInL+u+rgzqt2O5/dSewcUCp8TaHZhBWdwOfv5t7AX2zuxqgLIApChHPGLwumbHOJIRBfM Qi8c9jY6L9PC5lHYvyq7bFGa9fC+0muN5aP1PJO957aI4q+KxAi9X68wmgANHr0+ZRP2OI NcrqL/a+FN4CORhmSGaVVmMtnnLq+6Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GOnYVx5YAK+ziErge/1x9HGyqYnguAw6jCerx1KHHb4=; b=lHQYkapWUxpmBZVezHRrXRy+HR pn1BNgG2r6jVTEqLOhK18KRo/D9WG3nPHWJJUhuaHWR1UEdc+maI+AavFMkzfcxfxQQjaZBUxHuLq GLCOKkIR1vYeBxwttP8yMFvjmqeRUnycRgiTXtIqdfVPVdAR+EdHxfk9md6cuwjM5SwdcOKGtan+I +dtzOgPYIRQyjwKNoehOszgu8B8yAz+KV2UdNTjQJFaKw7/ok3MBVm3/e/32AId35uBuoAf/IplkL RVKkjbrrSKBeBjdvhra+giB+TlkPxIf3AbrPi8VgM+Tob9QXq1K7BLnJytzo64UmqyLLwCcFnzPil mIKAGnQw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qKzvS-0032Ta-B6; Sun, 16 Jul 2023 11:28:30 +0000 Date: Sun, 16 Jul 2023 12:28:30 +0100 From: Matthew Wilcox To: Bagas Sanjaya Cc: Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Rudi Heitbaum , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Kirill A. Shutemov" , Michael Ellerman , Andrew Morton , Linux Kernel Mailing List , Linux Regressions , Linux Memory Management List , Linux Networking , Linux Wireless Subject: Re: Fwd: mm/page_alloc.c:4453 with cfg80211_wiphy_work [cfg80211] Message-ID: References: <51e53417-cfad-542c-54ee-0fb9e26c4a38@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51e53417-cfad-542c-54ee-0fb9e26c4a38@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 30204180003 X-Stat-Signature: mmz819meeth1us1sx1p49qzzcha968au X-HE-Tag: 1689506953-866766 X-HE-Meta: U2FsdGVkX18WcH9tZ8VxE/DxDt7jOs8xlZHLs3O4yYCMLLqQD9yWsWAX5ICiCa9abARdnnBNjlw22iCsLrUs+fajPOlSVDFiyqmf12DNfhBheOfKslXXd5JpvrjijB32jelZ1vmMm1zWar/k9JZ/vpdfPYdRKdJo/ggpmJIhsP6UhTpO6qv74IqaW8xVlKPvmB+z5lxbPxptEiMFGzrBDbgAKj0ROI4s5G09I0IYQHnnkUnR51hucpmQkK9XDtwnk2mgM3ExeQ+UlrgJN9aOg1jEIHERYACOQ+TGp3iJ6wgAl9Ycd5XkzpcCPjGM6aXIfJ9fC1tZv0M1N12sdrH+5yEQ5dggmyyMsX+PrBNFNcbwTwc4vlZKwRmzuJ0IkVik5Z6sF09y3gEe1Xj6yZz1CL893OjrOdGE+Yn/hjzQOS9um0gz1c5E+imj3QiJsYfkp6Rgo2oFQB1ZfXQA3hCiNFfSs3op0FFKdMm5SpTkUJTMkst0t6TxoOw4tg+KuUYmwoWShNMk9SyJhu9BH0f7fxmoP3Ox/gbEd+LR7cUJsEGqahWi1+77f9tq9tG/5TJYEUcfocBX9YH3NGgme91G6qrST1HbbVTnaf46CMjnkKlPAghkEy58BQ8KV+7TnxHLFhCDOCbRB65VaclgrkXjGbOzjWu8M3s8DH8pM9CtNtU9UHMHq7HB88V+3gtngUEInjl4w3GfGu0Hu31SL3RpUlUorK9gqkmH9rL1fldlc6Gw/9ZMgo28CpDxsOXKh/0ouOHKU1e7R0hjBnfjXUeA7TTC9HnCETJONqAV8q5kwnG3ewwU/7GdGz4rbejeFGVYrWjrRzDjk+mCUNCfcmTjI+GNvcBQBdhdq7uI9dxrF4bQq+hJ7BpR/EsIX2fCEBQUhag69XQVeweR64WSno1B1WwokQIXaG2MdzTV5SrLEAiyuNRZpHGoUQmfJcow0ah0Q/1BWVzov1hTkCmFelK 671WX4dN iAr3CwHJFE+p5H+dl/OuM+NlUTtQ8r3MtFaRwuBQBdPJ8YTvmCaLskGHHiNtIiFWCNVT5KP6yTADN78cn3hVJ5UdxTOmOSxPC5630TCe90vfdPSQ/MJ8vnuWN2MLjNDX8GxGZX033mHuRjx3AGa42icYchlPTEJSb0ocd9ZPW/qqb/1DLaFufTlXpI/S4KSlx6cJRHgVArl1XH3rI9/dnYH589DTz5OQvO7sKinUf6Pakz6+SHEC0xf53FnM8psKDS9hz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 16, 2023 at 06:10:44PM +0700, Bagas Sanjaya wrote: > Hi, > > I notice a regression report on Bugzilla [1]. Quoting from it: Maybe you could try doing some work on this bug before just spamming people with it? if (WARN_ON_ONCE_GFP(order > MAX_ORDER, gfp)) return NULL; This is the page allocator telling the caller that they've asked for an unreasonably large allocation. Now, this bug is actually interesting to the MM because the caller called kmalloc() with a ridiculous size. Arguable kmalloc should protect callers from themselves (alloc_pages() is more low level and can presume its users know what they're doing). Vlastimil, what do you think? Something like ... +++ b/mm/slab_common.c @@ -1119,6 +1119,8 @@ static void *__kmalloc_large_node(size_t size, gfp_t flags, int node) void *ptr = NULL; unsigned int order = get_order(size); + if (order > MAX_ORDER) + return NULL; if (unlikely(flags & GFP_SLAB_BUG_MASK)) flags = kmalloc_fix_flags(flags);