From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD7BC001DC for ; Sat, 15 Jul 2023 04:07:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 540D06B0071; Sat, 15 Jul 2023 00:07:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F0EE6B0072; Sat, 15 Jul 2023 00:07:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DF676B0074; Sat, 15 Jul 2023 00:07:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 305966B0071 for ; Sat, 15 Jul 2023 00:07:11 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F30C5A00F9 for ; Sat, 15 Jul 2023 04:07:10 +0000 (UTC) X-FDA: 81012511020.14.4872400 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id D31DB8000C for ; Sat, 15 Jul 2023 04:07:08 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=q2aBEUe+; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689394028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E6BKvalc76lCISIlkA/GnH7FAR2tEutl4Xg0nyimIoc=; b=GATMuFDBHtF4CY7DKbBQCsRJBSajNb89aji80OCBF0Rgmw7yzEJLmAm83vMEQRlfc8GEru xh+5kJ7YNPXTL0kENEltwQt4ee9r8AQ7lZ0nYZuRx6fO2hmVPy7dXAODkQ19dRx1DBIOFx 0mRJOvHe3lWt9LoXkc2nvHFBwtc2Rn4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=q2aBEUe+; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689394028; a=rsa-sha256; cv=none; b=lZx+3igjSmzLT/8nfZ9X6Evsz41nhuQcxKJtWHZZRAlMjMTaHKrrPKbiD58q+SHH6peKa+ vm7weA1CXsKafCFMzh8xyM0kVFwfwh40YVEpuEaRyYNRpXb0h0PErFW0MaRAvmWtfj9YX8 u74nNrzurr8sajxb81U2c0rXhZth/cA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=E6BKvalc76lCISIlkA/GnH7FAR2tEutl4Xg0nyimIoc=; b=q2aBEUe+ad0PVFePYgpW3j8qVg JLhgMydUFQrcarZZZCVOjLXoQQHGERh1YmHzeA8176T18gNQZrgPZsnYU3/YrLlS2fvjAywmBoxqH NuEWQrba1HvD2dUgLOqtKOJOtsXHeUipp3iSy5EKNkP3Or4GCj2BpilAExEHslhQ++NP8njkowJ/s 1Dqwg1lLn9Kib+F/TVnLRPiRaSauh6GpHfAT5vLuvyrzSwElE+6nEC4gD1ATsqnDgBWSd42hyDht4 tH5rxTuYo52MT6MtQqAalwfUckXk2w5ND2Eh1RBfwjGcgeCZJKprKPOXV9RTnEQmUukxDZKqQr+qg 6/XTXKhQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qKWYh-001oOJ-DQ; Sat, 15 Jul 2023 04:07:03 +0000 Date: Sat, 15 Jul 2023 05:07:03 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, linmiaohe@huawei.com, naoya.horiguchi@nec.com Subject: Re: [PATCH mm-unstable 8/8] mm/memory-failure: convert unpoison_memory() to folios Message-ID: References: <20230112204608.80136-1-sidhartha.kumar@oracle.com> <20230112204608.80136-9-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230112204608.80136-9-sidhartha.kumar@oracle.com> X-Rspamd-Queue-Id: D31DB8000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: fqu4igx4ekfmcyjrnetcu3qut1xqutiw X-HE-Tag: 1689394028-937613 X-HE-Meta: U2FsdGVkX1+F0jnXXZzV5ikzJvaWMBfRm0BRYjELH5kHdbTSx9uqZlV/sHPmmLQPKY2yoAFXUtrTABOPKQDihnYmUyelpi1gMrXhywz93P0TK9b7M0U/subhRu8z+P2spJ7PRE9BHjNzj90KYqFMKVjNeRr1ji7Q9II1F6lI3lgZeaGPXDKlHd+Us3/gB6zxd8pwYAszBKnaxpZ9cVRx5zWIyNo/9Pm3D3a9TMwhjE6KK7t6Op/zGvIZ5f6i9SiQhgciT/8JBZ+lZ9lIC07vK/pKXap92bui1RkMiUGxTWTif9NOA2TjfKKLL2m/TkOhjZL2lPYN19N53hQs3LOpeEvf0nMNcwEXneBFBSZHIsrtniMXoOeJhhoUYsdqUNnCH+yWYwyQNVlGItbBX2YSpugupmAZkF4urBJuSpQB651uDFip/lTHm9DdJ3oUiQXkNIF1qHO519bzPBQe9bo0cyIeBcuBVuKxJky2d/1k2xnzRYcBeKfuPLUyU9fm+HX58qH7xCiv3qXnSRwkxhzEVoYNBsRMWD+GJ1bwmXio7NERzeZNA3BNEnldiACV/3k6hnW//r/lzATr2folKFOMfckwjLkImAgh0gmsP87DKQ49qqmKWxyVxFPwNabluz9kS6PW1A/SORGC4IzyaXm00IUiSar3MaTrPdwxlzWTeF2ob3SSC8frJYEBQ7tiyArTLy4ghK1nmN7lq9RCjHtJcGlCnn+l+8GWoglDB78HNcPXyeTOfDZF8jdxyNTF6Vodt6Z8Z37XaDsZYsOO7N9mMJUwxNe+deFBIW3HhJ5jWESAXrwQBHHe+pDkSsePbeyU46uVivkcF4z9GevXXS4O9Hc7zCiQoONBOFoiqklyYQQVUg7ny4DMQthNr7jurv8XEUM9fn6Bsk/EcXZrJjd0LYZhBdxlGu4DW2G0E3A1qTot9+2W0y7o/JhFl9vrHVz1c2g44l7SrYLr0CWtQDY HNrxzMov 007zzpAdkZl4AUFM5tsP7afmU8SKJfVRdp4SqRNooo7Mk87S0umLG18+qzpuh6q+eUD+J9yxKLtWEZ3nuiBuiwxxJyKp5CAfehjS7Sx0LktkpB05XttwoYVuZd9zNOHSn93O0g6OvX4Th7/NLpXF7uYteyh9NRjuWiy7evLgXVIRWGqIFzVUAJnyF8wkkZD4PZQ15V3/NsV2URMifbg+snSn78+ZKrszKCybD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 12, 2023 at 02:46:08PM -0600, Sidhartha Kumar wrote: > @@ -2348,7 +2347,6 @@ int unpoison_memory(unsigned long pfn) > return -ENXIO; > > p = pfn_to_page(pfn); > - page = compound_head(p); > folio = page_folio(p); > > mutex_lock(&mf_mutex); > @@ -2360,31 +2358,31 @@ int unpoison_memory(unsigned long pfn) > goto unlock_mutex; > } > > - if (!PageHWPoison(p)) { > + if (!folio_test_hwpoison(folio)) { This is wrong. You need to test the individual page for PageHWPoison() instead of testing the folio. I understand that this will work for hugetlbfs pages, but for THP, it's the individual pages that get poisoned, and folio_test_hwpoison() on a THP actually only tests the head page. Ideas for preventing this mistake in the future gratefully received.