From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7A9AEB64DC for ; Sat, 15 Jul 2023 03:59:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A3646B0071; Fri, 14 Jul 2023 23:59:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 652B96B0072; Fri, 14 Jul 2023 23:59:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51A566B0074; Fri, 14 Jul 2023 23:59:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3DDFC6B0071 for ; Fri, 14 Jul 2023 23:59:20 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1753C400C8 for ; Sat, 15 Jul 2023 03:59:20 +0000 (UTC) X-FDA: 81012491280.04.D63E8EE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 5D4CA20011 for ; Sat, 15 Jul 2023 03:59:18 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Wc3/75xk"; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689393558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l+q68KBe+8nXV0cOjAwQofMDskSvIjb730x1Yrm5888=; b=GfDIc2iRNhU5JuLxUnk6Zb7HUYXtsJb3S4kBzfkDuy7ItMSQwZg38m58hvSJ15FpIbnIDD vcYzvoKbvWiKW7XatQRoPGSp4jPmCkdyGQ6xKr8Qi/TppqFQCmzWQIhrgWehRuEanaIsKw GdIgppGflr6XIex9mOPyCp/XyUUXRc0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Wc3/75xk"; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689393558; a=rsa-sha256; cv=none; b=0meA8k1iMzYti4rlEh7uQ66t3iWCiby+tJQGsYAsHgkF5qFrfwjqstHhLhbNG2JFESuhAO NwflWNCxFvfMx4ZF0mPnD/LKWxZQgLXIGDtZcPs/BkLdsmvEIjCpAFktx56TDQZ73O6MFP 4sOZa1SZfYahbLxCs1Odm3K/NMOIHTc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l+q68KBe+8nXV0cOjAwQofMDskSvIjb730x1Yrm5888=; b=Wc3/75xk97LMC8vxR+F4N+8nkH rvI2oDM+jwRckDL/y7JHfvtHqb4BUG5zbDOiZg4RQTOUudrtudz3ty+3kRRn19yA5UuvvBoiBIyfZ gqbSI9rGd3ltoS959pYsVtMp+8nS0SYvkL86j+x5jiR9h8mdcFPyj2JjDJTVLPM8Y8eGZXn0w7fE8 jxjpVIvobIcWiR58N/lWhYlxXTrBRTiPNoNBZtshexums51OuV2cbfAMF9RUXnxZoTXsG07GL403K NCaADEL5j+Lwi6rGosr5b2d1Ih9TNODluuT/k42gwF6fWvQMSQek+X7Vc2od3E+MJ5U7w0pt+Z1M7 +ZywhOEg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qKWR0-001nxD-Q6; Sat, 15 Jul 2023 03:59:06 +0000 Date: Sat, 15 Jul 2023 04:59:06 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, shy828301@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] mm: memory-failure: avoid false hwpoison page mapped error info Message-ID: References: <20230715031729.2420338-1-linmiaohe@huawei.com> <20230715031729.2420338-4-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230715031729.2420338-4-linmiaohe@huawei.com> X-Rspamd-Queue-Id: 5D4CA20011 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: puz4equt6up93qmgq1cbwaz9nkyqi5do X-HE-Tag: 1689393558-452398 X-HE-Meta: U2FsdGVkX1/F9r1M2gyl/t7XLySXcuOvBlusWCc32bYqQcPHYivk6SSNd+XA7MFkpPTG/nbardlTA/+vylQMnR3B1Eg871uAqlR7B0i7iDAFm1HTk0RnfeWzeAa1a2fL5YBjNSqo+wYdvDVrEAdrbtTV3SmWryrt+nkUgZZ4Y99F8aRQVr6cyXSc0wejQmyC7xtcVNZsPQnk7aa5UQKN8oI2l6c6YX1sdr4RBDHm0SC+xEf3NKLVQ29K/SzCic0XvWaFW38NINsXHWuaC52upFv2A38BVVkukO5FDFUqIXRSFuQhHElj9vPO0pssqHndM0yWaIkytYPR8tdg/fEJmXCKBUEs/BOtK0VzuKp2kZ5YONNjxgFJuQzFpy6i3NSau+nHjX/DtC179AFY9TtxMeKKJ3CwrF/YA/dQJi/wpmlUt3Tpyfs/4ANqoK72yVXqd0kXDqbeTbjGDYr8XUbbnj+fC2ka/BDnze5laDgk4tElmyUL0Vi0tldnn3ajMcIiz08HLIm+nR0udZ6mNiqrxIiZ/T99T97iNNu61VtjliwyZ1rPqMAqYFE6woni4tPPRgk61b4h3aT3Tvds/m/IS31KN6ru5swEVIyil59glKtRe+N6I4MVgmzb/kpNxbeYjcbI1z4x+/LKHbYjGU3UaOtw2eNXzsYo7eQukH5zgqieSUNs4AQk1+2YYHh2fmX8vYuyhZ3j4IT2xjrEbpfpkay7X6RtM1E2Cn6ySaZ2RO43c8VC70bjNUFpmgI3oalWhi6SyyXSVIKSj56zhlM4r9drvyoev1xK1wtsp8HDootZmXd7XZdPIzQei2EK2Th9ZVwyg91Ur1VD6/SOfGcP1GhwFWV7nqkeQHsmQ0+j4PESeueReriSdZw0Xn9jX/UM3C9vF08FGJxOUxb7O25cz5Q0GOiNkFO6qzD4MbZHmIWlhg5s/abHagw+4w4PcFtQ0xoG0fDzVI2NZLfjC09 +yHPO7TY VFWT86JWC0aglcfJjj2ztQ5IQ60L7sz/96DtA3QNcpLbuq0HbOzgwcuiw500P5voC7QFJRkurcpocppBnRYjXSHOYSzbgBE1VtHxLdDG75oRbxRKdoPb0hcINLWHlJgjXFjtCC0d9QkoqLeZ0s2Z1mfXoskwbvp0pEpQ1WbbGbmDpcLqRbFjdDL0oudq7nn7GAXl6vz0b+Fzo6UEDni19qsz5ew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 15, 2023 at 11:17:28AM +0800, Miaohe Lin wrote: > folio->_mapcount is overloaded in SLAB, so folio_mapped() has to be done > after folio_test_slab() is checked. Otherwise slab folio might be treated > as a mapped folio leading to false 'Someone maps the hwpoison page' error > info. > > Fixes: 230ac719c500 ("mm/hwpoison: don't try to unpoison containment-failed pages") > Signed-off-by: Miaohe Lin Reviewed-by: Matthew Wilcox (Oracle)