From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A91DEB64DC for ; Sat, 15 Jul 2023 03:16:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BFD76B0071; Fri, 14 Jul 2023 23:16:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0703F6B0072; Fri, 14 Jul 2023 23:16:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA0F56B0074; Fri, 14 Jul 2023 23:16:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DB61D6B0071 for ; Fri, 14 Jul 2023 23:16:23 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8E71B1C8971 for ; Sat, 15 Jul 2023 03:16:23 +0000 (UTC) X-FDA: 81012383046.14.0C25134 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id CC971160002 for ; Sat, 15 Jul 2023 03:14:26 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Sb7I+uOz; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689390868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rzzcvrMOZmLVJ3qqStCtg2gxmWnvYjv7H4zS+C4FIDY=; b=N7Ud2m+BRUggpIA3c4LEn8FM+3UI1tYHZ92/Z4/eOLyDOcKwtFzOmq219DUa8/B+Kd7Mjk MoICfe+/FZTjD+4FfJ4C1kNaYCazqFgvpi0RBHlGA6APhqBBJQgg8tsY3giWI+8Udz5OO8 Oq8IGukav+jEZF4ayNOgBc8NFrVcWHQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Sb7I+uOz; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689390868; a=rsa-sha256; cv=none; b=OsbFGsXBgDiT/PJwEaA2GsH2AAVZ77WarrVJMcxr5COw74mc4+LauLuFlrqvAiU0sIjAgl pRqcuZB46Rzt70plYzcwnw4Moq2Ruuq2PYo4i8ITu1UJVw05BTuRz8ZYgmjttnr8wON72z +V+jqNauYST05aMNAwdhnyiWr87CwwQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rzzcvrMOZmLVJ3qqStCtg2gxmWnvYjv7H4zS+C4FIDY=; b=Sb7I+uOzGR99xPAR8LAErP730X Z8e1zIay5znOBrHBHXZom0u0uBbafOb9DATBYqK5lzNYQyBI0eeY18elonLDyLCKM+57aiZl71qXN i46XEAHq+li/aWDJbuECA8XTMmMC+UeTadV159WB7UpoFW9hOQI9F0bKIOGpdI4IrlxfpE1hkefZZ jwVliNT4jvjFTP5sgssUcpIkvhd6EuJU4bit65WevOiHb6VxuhDDuf16pcy7dc19XL2Kim2oeMPNI b5Zw6aJFrsOJDM2ahcn5kHp+HvAIWjv8NNapWy9T/KSQ7y6858TqKueNaw5cxbI7ssrMi6F1InTU0 Z9wF700g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qKVjh-001lqt-23; Sat, 15 Jul 2023 03:14:21 +0000 Date: Sat, 15 Jul 2023 04:14:21 +0100 From: Matthew Wilcox To: Tom Rix Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] shmem: set variable shmem_mark_dquot_dirty and shmem_dquot_write_info storage-class-specifier to static Message-ID: References: <20230714215113.3919026-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714215113.3919026-1-trix@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CC971160002 X-Stat-Signature: cjybfoat75kfkibeoqh9g4b71t4u8do3 X-HE-Tag: 1689390866-34758 X-HE-Meta: U2FsdGVkX1/58zUSZ7hFLOSals4DI3lp7mBeUVRACPdSKjmWxxiKDo4wuMgicLpqmhoBqsDtSTpVGShazR9PaH5dQfrohhuvcT7beIBUoSLRE+Qw7RVBNrKeXan7qY3aGsr/891s0bGq4dEcsPC0brpOc+7gtqh9gWu9aBjAeEiQQHms0AYR1TbwdDZOGV+BKQYdaL69WG5jpNZSHaBwlNn3FHAvUTCRkyDsraDoFryMEhKvEctl7LoelR1/lzqvihHgHP1JxQIDoL2qmjsF4Dascr17C0m3ZGB1ZBJrt4VPzoEWzo2d6Z3v71j+AZPdN0labIoVY+bGHGfDU73ByScS5QRVAeQ2e2CLfRTkCV4PYPixGpv2J2A02ZjxYakEoXhWpU9YKWXEZw4p7qPQc+1FKw2qGNBehQDBv5sBy+7y6q2XY3kVY4VNgzD049FpvhvlMnPHQ+4E1GcEUhmx3cpLMO/6yIY5pX8RlCWJYOI5DdNGRqa3TWQXcFBXg29Jna004QlVmp8/7lWCI9YHmiOxK6QsVn4gGnCiNIMzeCYieQL8/NpZ2iKG4ktUQ9+JfSEV1znEaeAC4NR+xnOrewvyFqGTSwAltpalQeL1SaIwbH5QAPVsTn8dBdDfSfnPj0Z6fvU1MK2i8Y0OoFR+slZvpyEHjZoTXTO/YQhaja1bK7TPclmnHcz7x6KX8xeIc9R6WjyFr2WyGpGpr1gztUTu/0nzay9U0cINQqnTqrKj3XpsSGaxkqAUjp1GyO4l1NjPIgKA3cl8Th7TXwVdhRvCKhAKqz09dSDV//o1bBLPhfrkuytUR1zjwftUdaSuII4NrhBx+d5QnvNyF9YpHsxVQeGvZni/vWNYtdBUjxVekXm+m2jNDZ5EvExDjBUEEq2oRY6rDVMTT7LDw+bOPPDCXkWshfbREpdpXY+UmuUIQeeTuXmpj62ShE7ZnRYm7Ki2aOhKMCHtMO73x70 8oMX/Xka C9h1dDYTuyUyfSvOvfu3vYYC5WGjYNEUE0U4d49Mf4RizwZZ1bsOHWjLjwzz3QP9qYr5SFss9ivYYsW6N4v+AxEJ2GHU3YBYrZfZPbM6X36h1zB610QDsZ+Htz5oui9m3m1oxILxd8L5TLkVceKWcUe0MnsDoINtnpBew3eM/5GQU3DPYi89Pk6EoUA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 14, 2023 at 05:51:13PM -0400, Tom Rix wrote: > smatch reports > mm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty' > was not declared. Should it be static? > mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info' > was not declared. Should it be static? > > These variables are only used in their defining file, so it should be static. These are functions, not variables, and you're the third person to send this patch today.