* [PATCH] shmem: set variable shmem_mark_dquot_dirty and shmem_dquot_write_info storage-class-specifier to static
@ 2023-07-14 21:51 Tom Rix
2023-07-15 3:14 ` Matthew Wilcox
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-07-14 21:51 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, Tom Rix
smatch reports
mm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty'
was not declared. Should it be static?
mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info'
was not declared. Should it be static?
These variables are only used in their defining file, so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
mm/shmem_quota.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/shmem_quota.c b/mm/shmem_quota.c
index e349c0901bce..062d1c1097ae 100644
--- a/mm/shmem_quota.c
+++ b/mm/shmem_quota.c
@@ -315,12 +315,12 @@ static int shmem_release_dquot(struct dquot *dquot)
return 0;
}
-int shmem_mark_dquot_dirty(struct dquot *dquot)
+static int shmem_mark_dquot_dirty(struct dquot *dquot)
{
return 0;
}
-int shmem_dquot_write_info(struct super_block *sb, int type)
+static int shmem_dquot_write_info(struct super_block *sb, int type)
{
return 0;
}
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] shmem: set variable shmem_mark_dquot_dirty and shmem_dquot_write_info storage-class-specifier to static
2023-07-14 21:51 [PATCH] shmem: set variable shmem_mark_dquot_dirty and shmem_dquot_write_info storage-class-specifier to static Tom Rix
@ 2023-07-15 3:14 ` Matthew Wilcox
0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox @ 2023-07-15 3:14 UTC (permalink / raw)
To: Tom Rix; +Cc: akpm, linux-mm, linux-kernel
On Fri, Jul 14, 2023 at 05:51:13PM -0400, Tom Rix wrote:
> smatch reports
> mm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty'
> was not declared. Should it be static?
> mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info'
> was not declared. Should it be static?
>
> These variables are only used in their defining file, so it should be static.
These are functions, not variables, and you're the third person to send
this patch today.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-15 3:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-14 21:51 [PATCH] shmem: set variable shmem_mark_dquot_dirty and shmem_dquot_write_info storage-class-specifier to static Tom Rix
2023-07-15 3:14 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox