From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B66E9C001DC for ; Fri, 14 Jul 2023 15:11:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 444228E0008; Fri, 14 Jul 2023 11:11:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F3348D0005; Fri, 14 Jul 2023 11:11:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E2348E0008; Fri, 14 Jul 2023 11:11:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1F4718D0005 for ; Fri, 14 Jul 2023 11:11:53 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 01A721602CA for ; Fri, 14 Jul 2023 15:11:52 +0000 (UTC) X-FDA: 81010557306.06.1A9671D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 35CE214002B for ; Fri, 14 Jul 2023 15:11:50 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LBq+zkLs; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689347511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RgISAtnie1KjrmoNex1ps1jVxgVlVHi0wuwdiZIjY3g=; b=grYM+PiZ5yQwGriVgM/0G9URELjYmmtCrMIGyV3VDO8BWEdZJ3mX1U2HVzSYBmk7k3TzSR NIJAyp1DTz20/tgVIZ4yPBViPAv5p9zUdfHlDnEUsPxyJlQKJIKUC8/nytTh4I15Sri9aO dvsfiGZcOYFfibh+cnkrnRT4z+RKKAw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LBq+zkLs; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689347511; a=rsa-sha256; cv=none; b=m3+sttHRj00px1Y8sAFcQ/yIfDALHb7gxknwS7tYHvnh5m8BSXkUo0RYUfweEHHYu4ynZe S8iw/3G+vVrV/OkCziuNY+w+kWDmjt13h9kQTngbmm4VZzmP+6eimo8pss395ifwpbQ25T S+SRgd+MJjySQa/AvJmEeZ1oaTKTVVM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RgISAtnie1KjrmoNex1ps1jVxgVlVHi0wuwdiZIjY3g=; b=LBq+zkLscVVIWra6YTXm/DpAK5 /r3UFOA65TvW6v2MAklyS3Os6+nJLFHz+NfoSrGVg4xtutr4ectKhIR7ELImmtWYm81+0FNIibnfk 51co6KaPTxao4ZxQ20TbcnhXsjegZ5rOjTzCaoyMympZeVHJpp5XdB/YD+WxlRa3fWbjGgyaf9YQ7 au/cfQprF7c6XIbZNZWm4KBUJ+H9uMRhLoo3XxMFDLIk6uBXW0F67sTf83Xl9txwB0EanNPHGtDYK vAYSzxYWMlpSX1UmNOplFpa1siQEW34ym9j0fDl6iMwVX4+89tIpRf+fFnwPSxg2b0KCGpaKdrhWX MkHf6CEg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qKKSJ-0019Rx-S2; Fri, 14 Jul 2023 15:11:40 +0000 Date: Fri, 14 Jul 2023 16:11:39 +0100 From: Matthew Wilcox To: Peter Zijlstra Cc: tglx@linutronix.de, axboe@kernel.dk, linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [RFC][PATCH 05/10] mm: Add vmalloc_huge_node() Message-ID: References: <20230714133859.305719029@infradead.org> <20230714141218.947137012@infradead.org> <20230714150948.GC3261758@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714150948.GC3261758@hirez.programming.kicks-ass.net> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 35CE214002B X-Stat-Signature: p8uiayt3tpdwjomr7ytz9xs1otanjzeo X-HE-Tag: 1689347510-124600 X-HE-Meta: U2FsdGVkX18gJSv4l5hRPLctnjfINUNbf1kD82rl/oeDXclbQDCzPXqzuZwHgtoP0ZRR2IegN+2L0E++CHhZK3Sofj6JIlClUu0QxxxPC27CpP7KgQZg5kxbg1W20ZbcSOpkmOtgtaeIzqrSyjSh9t5zIQwWSHiICy5E7HJVGiwu9+NbPp6gMTNr6DrrUJpAFjWmnRzaThH8LD9wIUpMErhEB2MmZ/+TJPOZqf0AGoMCjsHTauDaqHPsBFzJvDssY6gfzpAQONXFAmdmzGwsaD9SXMXY/NFdyCNmggnujekgLezfYp9VYXgOca2LZ3jc8TPO18qhg4hr6+HlBDKtYr9lzT/h5fm0PoNtwiSK62bt7U7CkNmvlJicqbWzivOjBvOWWfzyMyjY3z4LbyJjzGvPstw4csKWwuls3+/mHHzCUwRh3Ho/84B/zJIf7L5IxkxdP84ctVbvdJhrtzdxEZ25SDKvPsNfV3QRqojW/0owAOTakhbqmIPA/HMSOGrccCvhfUtrphoHpRSU+EXyvFUSgC7dPmaa9drk3YlpHfZAve5hhbxGbEKI3ayvMfmMRhkzMVlp34hEkIYcXmLMh32MMqhMf7lLWgwM9d1qCGlrPl/uqtQ4GnYL2g5mEtbY6H3MTEJk7XfzrDhnIWiKCwNlwOvMuUxrDEHMJZ4OKVyiNS7XTl9lGxP5Ces2DN/bonagC2ExFWGf1it+PjZpBblToqwH/qB0aVowT+aNkPVayMUkGbMgxgCqNRhSTG+zq2mzV7Nk0Ap5qmMt9LV+O8alDKVHJXYwzCjsWOYkGuEGqElvF41A8A7u7XxXPmLPx5ykpuyJuo6CFBInnCEGRvRsxtnYQ+94ZkFZvu+0AK52JMpNieseJJ4Llbq2hxVTBhDghyJNPZhgNubA+KB71XIhnGutDX3dDnhmgXhwD6AV1esSTcQPW5FcJQ632NDDa/W34s7sFcP341PJvDE x/ZXPwOF SfzqAaQrg6vuHZ0n+w0+JQ26NioPI9jaHytnRtTgaWvSgItUcoL+OxE8bydtEGORaNKYXB3H9r86onYdVwhrBOzq7bHNGx2tr0pUR2E3dU0dbJrv1L3aT4X4EocDAK2S3s5eks8KSff6ONna8o9ANhGKJRi2v0THCOiVkICbxAZaDIZnPuHuYz35DEw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 14, 2023 at 05:09:48PM +0200, Peter Zijlstra wrote: > On Fri, Jul 14, 2023 at 03:37:38PM +0100, Matthew Wilcox wrote: > > On Fri, Jul 14, 2023 at 03:39:04PM +0200, Peter Zijlstra wrote: > > > +void *vmalloc_huge_node(unsigned long size, gfp_t gfp_mask, int node) > > > +{ > > > + return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, > > > + gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP, > > > + node, __builtin_return_address(0)); > > > +} > > > + > > > /** > > > * vmalloc_huge - allocate virtually contiguous memory, allow huge pages > > > * @size: allocation size > > > @@ -3430,9 +3437,7 @@ EXPORT_SYMBOL(vmalloc); > > > */ > > > void *vmalloc_huge(unsigned long size, gfp_t gfp_mask) > > > { > > > - return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, > > > - gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP, > > > - NUMA_NO_NODE, __builtin_return_address(0)); > > > + return vmalloc_huge_node(size, gfp_mask, NUMA_NO_NODE); > > > } > > > > Isn't this going to result in the "caller" being always recorded as > > vmalloc_huge() instead of the caller of vmalloc_huge()? > > Durr, I missed that, but it depends, not if the compiler inlines it. > > I'll make a common __always_inline helper to cure this. ... or just don't change vmalloc_huge()? Or make the common helper take the __builtin_return_address as a parameter?