From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C7AEB64DC for ; Fri, 14 Jul 2023 14:37:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B3D08D000B; Fri, 14 Jul 2023 10:37:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 317438D0005; Fri, 14 Jul 2023 10:37:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B6308D000B; Fri, 14 Jul 2023 10:37:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 096498D0005 for ; Fri, 14 Jul 2023 10:37:54 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C0B9FC02B8 for ; Fri, 14 Jul 2023 14:37:53 +0000 (UTC) X-FDA: 81010471626.24.A40F6DD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id B67681C0030 for ; Fri, 14 Jul 2023 14:37:51 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=s6y4CQQf; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689345472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fwMtJhD650GS2lSKMkJ/a0kXZxCufQOcNDJN76I6F4A=; b=uFDicDYzz6yrFqWgu66S7FIge16LHfvU15Onme9xPz3Bbm9Xvpd/2bRUSGotx6vntdeqdD BJs/QENGNPpSBitiCrlqigWOnVn84+j7gM5QBgo3LI7ddv2jeOD/9d6lXIHYK6RtMEWsMK wAoAPGOkNvydbziSzymJ/on0IArtMO0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=s6y4CQQf; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689345472; a=rsa-sha256; cv=none; b=1rBGNr0NdgPAoZrpYnqVe9fKL7dEwwVbW9kEX44qmcKnXDs+C0XfmrFsjCN68LpUAVm23c BpuWadtFsyon689wGRkJ5q0O8VxfyRYC6/5r9+KR09B/ULJ4qobOJW+d5c57RWjss4r4yr baANK7U6vjv19+pYGawG8vIDPHNyCpY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fwMtJhD650GS2lSKMkJ/a0kXZxCufQOcNDJN76I6F4A=; b=s6y4CQQfqU01g9T0DiOQ44nh71 zXoHA7GnnmatL3Nm7jZ+VAdR8IWWw4X+D5NfISmpI8Qabv6QQhQyOhHHlQp1kmrjP0tW6EFRhVZhw 2DngGxMq+0yQSLpZJUMkTo59y2j7lj/m1XcMdsHAvM0ai5f4fsKe+r+fUWuiXTuOhZt4J2ZBHU2q3 8X7kOVa3KGZuMTvNkNEuSonLYMx1lGU+EDRAWmlI8EOkoGhWl3v0dCeXnWXUfhOy9+2Z6TYT2VB68 9wcLAAEq0/gGV5Yo/vw+C3jHt/68QKWIXsB5H615s6jLq9FqwD7fLZmRPFG+EWxwBNRRxPzgLztuq rb5jZfmQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qKJvO-0017zR-It; Fri, 14 Jul 2023 14:37:38 +0000 Date: Fri, 14 Jul 2023 15:37:38 +0100 From: Matthew Wilcox To: Peter Zijlstra Cc: tglx@linutronix.de, axboe@kernel.dk, linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [RFC][PATCH 05/10] mm: Add vmalloc_huge_node() Message-ID: References: <20230714133859.305719029@infradead.org> <20230714141218.947137012@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714141218.947137012@infradead.org> X-Rspamd-Queue-Id: B67681C0030 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 8gzp3n3azuh7s498uatu9y89u61uc4e8 X-HE-Tag: 1689345471-921532 X-HE-Meta: U2FsdGVkX1+8SSRwCW+9Hd0+GqyhOU+SPWD1HMpWBDnPDHUUjLQ7352qu9D6QRDnWRNuNRMeLMqTgIfNPNYVfPIvnGKdZwBHMJvbGzwHW+krIGLZ3gBx4+o3QSBxf6FSXhlyAYQb0bm/iZbIOSS02/5nW6uho0jfrQqyzRHZXlpc2dNCZnQ5BRH3q6wATSeLLqILobsEDbpCqrTB+eTs8dWA5FbZ4u8WuG1KOm2tfyAPhvFuImul/ybOpx+SfbJ43Achl/98v629L2iQvlBwUwP5UUbOBy7O60Wr4HClJssPGnP3mfDijCrwUVBCeZR0kmqFFQZNy1xdGZks2+ly7bimEJHLdwWlDv6iIQiJ7N/yJerz1HDTan1Np2dyo/JEkvSYNTzln1p/X+lDmzS+44rZP2scSygOCLi1jYC0p5+Rip98lTfglbTsM6AkgzgO8u8Pk4bNldoI7IszwZfckSuyM4zhgepM95DpRXgi3AB3547F0mGc9P3pvslrRg0fmru5DFHAZ2tBR02NrzPhxUJq7XsYaNs+joQYk8L7xYxbqRAvXr+h+OyNNmju+lwU144x94qYoUNIwwQR1wozrGEIp/vi+H9Wjm7Q4pSitOQZp/4/NT8NnHgB5t5bEmDEpBVAE5Ku4/lMCISOl0I6nD/x4AwDaNjDPgl0GCa49zlFLiLRZFvijEiqOAc0Jl3zf8DoXMVXRco6pOuP8jEksl5H/jBQRf6gBgBZ2mfDuTTvfyOJ4AfmuVY7mQ0brwnbhi64r+B5Js75iDIZq7ef62blLre+LCP+bu5YRXcrRtGEBDG3ZgjST9KmgMpQB1q9THWSMHOZRkz9fVC4mvdXLikGs9sYgz6ygD/+3pDJ1aVRdIhVhpd6RCu6gdVVwkYQeYraGn9hKOnIXbaO6YvNP+p90YqBv6O7gzgmmvAXu4yMnMgHkmjoi0Fuaip3fgPZFcaEuVCNwl1B4GqMBoP OCYZbmEK YszCu9ORMKWxH0pVtGWvx4buM5A+0ybvAo9HH7aLW5zaf0lbu5PYtuIsmF9YJ+LZH96VwL+bm9ETWAWqwNrPZnvcwFeF3Xrhdn1deWArrAU6uIw9uW7ZA+rpGGXYOyHFXmCBFhoeL5Sg2jwYmbDbjvWEeiPuFRqe6bqjCYXMUaphKotAw+nf2WnHllQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 14, 2023 at 03:39:04PM +0200, Peter Zijlstra wrote: > +void *vmalloc_huge_node(unsigned long size, gfp_t gfp_mask, int node) > +{ > + return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, > + gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP, > + node, __builtin_return_address(0)); > +} > + > /** > * vmalloc_huge - allocate virtually contiguous memory, allow huge pages > * @size: allocation size > @@ -3430,9 +3437,7 @@ EXPORT_SYMBOL(vmalloc); > */ > void *vmalloc_huge(unsigned long size, gfp_t gfp_mask) > { > - return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, > - gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP, > - NUMA_NO_NODE, __builtin_return_address(0)); > + return vmalloc_huge_node(size, gfp_mask, NUMA_NO_NODE); > } Isn't this going to result in the "caller" being always recorded as vmalloc_huge() instead of the caller of vmalloc_huge()?