From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A90F2C001E0 for ; Mon, 24 Jul 2023 20:07:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BD056B0071; Mon, 24 Jul 2023 16:07:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36D068E0003; Mon, 24 Jul 2023 16:07:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 234B08E0002; Mon, 24 Jul 2023 16:07:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 13B266B0071 for ; Mon, 24 Jul 2023 16:07:21 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A3F88A0BB6 for ; Mon, 24 Jul 2023 20:07:20 +0000 (UTC) X-FDA: 81047589840.25.B76FD1F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id C09EAC000B for ; Mon, 24 Jul 2023 20:07:18 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dqbo8Cdn; spf=none (imf22.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690229238; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J5wWW1EtFpBIR05IfxoMHzoYojyakUH8TdbRyvGIOTM=; b=orhe2eT+krGGc1BNuNEuS1ncBLEP9NAds+upZE2xaBP4I0zOHB3CkLHPi3gX3xzIpBRSsk le8OSj0ORlcboJ6z4SOvtEpXJcVEunRUSg4Gd9kpm7tTXK6Oic9Sk5Oxz6plVGOX/8gAHc EMi3QNxQ+yhi5DiykbcFdpyPbU1v3K8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690229238; a=rsa-sha256; cv=none; b=cQqm5oH356FCuRWkWbbAUcCSqPrMOBSMfB7m5vxABm5hrPUg5t23+CXBYXZa0s3NDS4BDI mdN8GoADOjwI0emW/aNZpKdq9kumn21tv4EOoT0g2KSharLHzbnnU6KuzebCo0rNxU2OJr XNA+VC/cmgXRSTKfwWhtXqoRm1X6t3g= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dqbo8Cdn; spf=none (imf22.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=J5wWW1EtFpBIR05IfxoMHzoYojyakUH8TdbRyvGIOTM=; b=dqbo8CdnSUk9Z9Q0jUU79AqTgR TcWOjjUyjkkqeo5PB4ZrIkdlieYkyVRlJz4+DZ/8w3Q7GyAlVp0Mi+OmD03aJA63T+0mpGefhi553 M7GK397iMH4Jhak7mEis7MKfTe9ZvaxGo6zqwniAQry17ceBmQCT0NU8ciNTW1scF3v+rcsdI9Dk7 5Ld6dKPI0RWwdnUZ1uIFHQuVG3oRbrHUQIZm9ftpPcY1zxbFCFV8P3xuJIVU+VeGEU/VSPgWZzfdn AW4QYe+T0gskK/0hgNMWahfGIYEN4zUYPn7qZtk/EGuCBdWA0AauEY9/uwE13etR5+a8M4icYNLzl RVDEpyAg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qO1pp-005MNS-2u; Mon, 24 Jul 2023 20:07:13 +0000 Date: Mon, 24 Jul 2023 13:07:13 -0700 From: Luis Chamberlain To: Christoph Hellwig Cc: Jens Axboe , "Darrick J. Wong" , Andrew Morton , Matthew Wilcox , Christian Brauner , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] block: stop setting ->direct_IO Message-ID: References: <20230720140452.63817-1-hch@lst.de> <20230720140452.63817-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230720140452.63817-5-hch@lst.de> X-Rspamd-Queue-Id: C09EAC000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: fht9aztcs9tgdumzczk8t7htm6hch4wk X-HE-Tag: 1690229238-541690 X-HE-Meta: U2FsdGVkX18ikaeGKN38LrQrMoEzD+JQIPhiwYXxsbROMYONaaWqFZNxnVLTPJ2PZgfX477Ts9i1gKLWKaNGg3wKDr8Ste3FV6JYpA0/B4GRT83b/crkl7UJCP9uuhxRrh1diQ21hRAFmMDXYzKHiyPEX1S5ip8WQyZKozCAlGlulQBw3Xr5qBlJrIpJYNNI9otrcV0yVv6wP5kLkFVM5emJuvit/6+L/x1xX5cSsY1Cn7Nd95osbAwTowhBWu3xqhBi5tle5aq3qv4/EYIepDMbkVo4zCV5VpD7Q9TiSct6Aq5fw1JHd7gPVov4RQ70h5bulLO47ghzWG9FH1T2rdiElbZhTlz+816TKLQdPL0H4JZXE5BIFq33gUPN3bIpvNpyj+CuwBsIogdqi8LB1Zj/biorTBQnyBEGEdzfdsrPl1fhhzP2nAjxiSyCtcrbiNsii3svUhUV7D9B9jccfW+DojyOE/a8wMQVXZrVXNM1hE4DTd/jPM5hp0m2tGCL6VspQKgEuS8ck7bdS1hFzWClh5a6/+5DUdEFJ61y89Rbqv0jEYS+bRgCA/8ETrq8E/3kZRTDY1kwWp7qgZGdSeSElzD3w6izvJ4NyPPdWnPdnC9gYlrGnNJsQlW5DKfpd4oTI/jTvnt5mFfCQ/gcxRfllnhO/+zTUddKa/LRZPMx0DS8rO23nrc3Iz3ChTV6vV+e9/xpw/ysuGFxxAeg/Phj5ISxrd1v7JpHp3X0ImigkQFNYg6F2Ar59isN4ZTiHrgVa944MUFmcXlCvD7vOkSLzKpYsYocxpNHrK+GF5WvhulvuR5gp+HIuurPYpBvjpWP1tm8dVoZhWnXa8/5GZ8AMXrmo9viOux3MBqp3VlU89XdWfSM+G+MOKYbFtPTXDLGHuTyImYpy6UiNMyRl9XM4ghhwmFYfX2ynAJg8WhxXUJKrtDVea5QfODwRw68BhuU989F/5dlrBOB1Rv x8btNUrl /JoUgJCR0+C7pye99hvsZR6xOjH4gOVwuw+myAVgz3OJEDyOo4vyHM2o00lF2xxR2Hkql2HZ3sFReohmliL28VaNLrLBXMS8NEwjBLhCxi+Bt92yTln9KNUpKFmrM07YZN58K12qwwqSmjf3of8UZdUARF0Sqh0wLodi5Z2SkLj+mW8Ijj5nQwvgFCNrQeeY8ICDJP4KECcvZ7PScIn/GzC9v12Dlcf1+FQlt8OCLgjOjuUgYE/g1wX0Ls5lW3GZfoy+1CuIWBvgFfPdkjcoSISINZZp7P5ipc3jclxzf5jZCF0EJjoUxGpHHLBpBz6cpmpQtPmKMsFY+NWFhfT4ZgCH75t8WNCb6pwtHGetiW/cjv+HoLUmg1hZiFEavUoaZcRDED7s23eriN4lCIYxAGnkKIhaIes0f7wAV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 04:04:50PM +0200, Christoph Hellwig wrote: > Direct I/O on block devices now nevers goes through aops->direct_IO. > Stop setting it and set the FMODE_CAN_ODIRECT in ->open instead. > > Signed-off-by: Christoph Hellwig Reviewed-by: Luis Chamberlain Luis