From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B1FEB64DD for ; Mon, 24 Jul 2023 18:41:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 307478E0001; Mon, 24 Jul 2023 14:41:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B7516B0074; Mon, 24 Jul 2023 14:41:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A5F08E0001; Mon, 24 Jul 2023 14:41:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0A47B6B0071 for ; Mon, 24 Jul 2023 14:41:09 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BE496C0A8C for ; Mon, 24 Jul 2023 18:41:08 +0000 (UTC) X-FDA: 81047372616.23.6F5B687 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 16A4080002 for ; Mon, 24 Jul 2023 18:41:05 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bhhIME+G; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf02.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690224066; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RGEv92YhQQpuYKQkWpnK7eBal4DRU2xJEDF+23r9Yn4=; b=v8vJY2JNFnjb6KugEeAX2Ad2amilr33Fug0FZkcvC+EJXPUoSe2UM2bmn0C2460yhuBW2j XCAWnpugkgz9zk4rFX0olmm8IFFmkCzVfYw2Rz4TMeglzi12YnZTWc4HWHjLDzXke6IJNO 3qTxGbJ/uvTEtwfZYJca6aqK7/jsCjQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bhhIME+G; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf02.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690224066; a=rsa-sha256; cv=none; b=UEzG+ZlwJgD/G+Gi2PENn/wNr5rqklD0LRHaITnY1mYL0o1/SHoH6Ryawlf27Hkg2pRo6A ZG+OdIYdbT2lUre80wMzoGDc4JpReOdGBniA9jQ4Na2AXK9/Thl5Zlb5SZvMaXtRS5v4zJ 6EbzFGa/mfrm/pvMnPcwyZerypijgmE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RGEv92YhQQpuYKQkWpnK7eBal4DRU2xJEDF+23r9Yn4=; b=bhhIME+G2vzor+xUP6CPNa/538 zep/kajMS4tosJFtUpcbjgxLX86lHRXT5gUBnEi5n+ngp6wO/SpijJQBnwOCpYfFBAExrFd8nkK4u XlkmrUkNllWk2JwLHamhaIYNvYJjkl1YFQLzfHhTtnv4xIOj1Hl+EhGnFw3RrqAL+wO8/CSVqmKeU 9k3bfjRtQFaNlMzLtbK1AXFralzvThQtqLCx8kjfABrA88tMm9VyUBB6ghW+6AHyK1TFijuMZkeYo u5PSpqJacFmld8TkMXc+Tz7DouqaluD4I9K6riBfUjTlmZD0SwtSUV0feJ5c/PADKiDRps63pnTss Li2AhmEA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qO0UP-005Dqa-1i; Mon, 24 Jul 2023 18:41:01 +0000 Date: Mon, 24 Jul 2023 11:41:01 -0700 From: Luis Chamberlain To: Hugh Dickins Cc: Andrew Morton , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH mm-hotfixes] tmpfs: fix Documentation of noswap and huge mount options Message-ID: References: <986cb0bf-9780-354-9bb-4bf57aadbab@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <986cb0bf-9780-354-9bb-4bf57aadbab@google.com> X-Rspamd-Queue-Id: 16A4080002 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: auwkxybrry6bg6b9xha71mdj3mfet3hu X-HE-Tag: 1690224065-664348 X-HE-Meta: U2FsdGVkX19/7+uWVAmL9aAQtBibEGBNULfDzvIEeNCIxYaZDhIL1F+RfV4sfq9l3Y7UMiNGFlepPJuA7sD7SJm4ZTKIraWDN//lRvqy/Nb8lDFlDPFmjqnSm7TKY/1EqZhBjcmY3FOW50UDQyoWBcaYejakDNa5G90VTB3qcThlZIUWsP/peppVt/EBIwvYuY5k7u3Sado9z5tsDh+k5rBjP5wJ+CH3NrUKP4w7PkOin93Sxvi0hIutJu9GW8/tYTEOwDk0DauYrpdriEdGPTWYWU3eqzUl/bW9OhD8/NyTneKoJaiD2bCA9U4AyA/vPJUfjpQzr4acR0YZcoMoqO1S4KfzbZGl8bLr667zvBz8PahyBp4KjTUA00ash1pLa3guObvY/MGMDcWRhoMmA0btRgjpb6mnFANNZ9dmmXtC3FQlhxI8GUOhsjksm3QjDY9795Ak0wf70DC/CP/O19bSXQ/wqvrXBbhGlcrKZKA++2L1G9Dw3rodU0qLz818gWRlbGiTutGyMARFv7/UksGE4XdIG8dpXSixPWHZ3KC8UUBbMEzYLpBtsR7oIzoq0DKDiCtciRk1CSIoiVksTRSiYZ0djhntsAclg1pKgNfhlwuZOUIYNQRNvLwgB9/VGNtqud/L5utbc2g5lnTTWYu+cpcfj3W9UobO2IowcE7nV6L509t9FDs/Koo2UPJCBlD87UcRFPi/6Kn7VV+URyhG4mdo/JXJB9V7ru7LuAgoEPQaXzLq7RkDzzA9SthQAUpH0tzq5uHiNd5Wyyxu/0RGGUF3dD2Bn+7gtT4dBq3/otS4/hePMlDDYIq7RSBHdCk28xHWCUiiOzSvxi9zBYyr1l+K2iLegDEInpTfKkS4yLcJLrV4hZ/xBMAGS2VAkJxQkUp345kKtR4dHP4VXhVLezjIOi+EshS4Ki/4rV1lbGel5DgC/WgXdseSUUQR/ypZpca0iz9P4ij9c8X cQOw1UOc yUdbR5lZE2ZbjnJlTIGv/G9toVt9rSvj/tpKwRgJoXuNwi7QWTXxdyZ29LwSBu5fHBJRr2mHjUqxEBvK5/uSPVUq8lcl8789hGapBNnPGO8dzKGdzG9EWeICiC0Qyd3cTS0rRwtETXsVv7Yu+EC+hpOJv8JkM919hg11lJ9n8g6Ax3N6qWZHMAiyTHZ1wyQxzwfPqcW1UOMDD7V2RqbKbFMJujREL4EuLLpt1/is7JGeGRVCNGkmJ3+bcpRd2hSgJjVdZrQp4FrEcd7y+PmkmsRjjMGVM7JFff/hUctm0yfXZ8vm3I3n62V1k8c/fppS8GF4viC2uiAvuRHiiDw24mn5LZ+2HFbnnKu1f2OjgOpF0qxTpju/nmH0rbp3apAm/+OTm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 23, 2023 at 01:55:00PM -0700, Hugh Dickins wrote: > The noswap mount option is surely not one of the three options for sizing: > move its description down. > > The huge= mount option does not accept numeric values: those are just in > an internal enum. Delete those numbers, and follow the manpage text more > closely (but there's not yet any fadvise() or fcntl() which applies here). > > /sys/kernel/mm/transparent_hugepage/shmem_enabled is hard to describe, and > barely relevant to mounting a tmpfs: just refer to transhuge.rst (while > still using the words deny and force, to help as informal reminders). > > Fixes: d0f5a85442d1 ("shmem: update documentation") > Fixes: 2c6efe9cf2d7 ("shmem: add support to ignore swap") > Signed-off-by: Hugh Dickins Reviewed-by: Luis Chamberlain Thanks for fixing this and addressing the preference you wanted for master documentation, I'll follow up again with the style fixes for the man pages. Luis