From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3261EC001B0 for ; Mon, 24 Jul 2023 18:18:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CAE38E0001; Mon, 24 Jul 2023 14:18:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47B516B0074; Mon, 24 Jul 2023 14:18:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 344058E0001; Mon, 24 Jul 2023 14:18:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 26B176B0071 for ; Mon, 24 Jul 2023 14:18:35 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DBE3A40B9E for ; Mon, 24 Jul 2023 18:18:34 +0000 (UTC) X-FDA: 81047315748.08.368E7DE Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 8B8641C0017 for ; Mon, 24 Jul 2023 18:18:31 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ALkl62Ci; spf=none (imf21.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690222712; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FftEnjrfbBAd3Ww9EqN8sppXbEA0boEKYQQaC3XYChY=; b=hsvklyKKAlTjk6Pwg99kdIKG618lFomfZXQZBpDH+0vK9f2IDgxNfdWLuwTbaj4OpaWumb Aa3YFkfvxSuKIpkQCjDw25H8YQvRBtyM/AD79sWmKtgJxZ1acdbDeeB31V9oNQ0mBC7DG0 hpm1NLlqwermcrjOPM9g3GexfhYH0zU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690222712; a=rsa-sha256; cv=none; b=8e8Prb8VFk6lrU1invMwL5+AllloUfIAbLJ/O6qxOzmm+sga/qesWBl/pKqFZ8Jwsp8gZH TPJbnD1y1Le6Mmbr6kpgplPTYGs3NfoxOegUw2KfGUH4gG5WB312t4TzRBckFBVUSDPwIP 5kOUE1EgEu6hOzsTHE3NTUTneDJorCk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ALkl62Ci; spf=none (imf21.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FftEnjrfbBAd3Ww9EqN8sppXbEA0boEKYQQaC3XYChY=; b=ALkl62CiRE28E2LSizMN3y7fEY kJycbVRJZEvZWmguJTa9cV8saw4voW845Dk7ZUIQ/EpBqHehcYEObAuEhAbV5cICUXMxpEHgWD1xY 0G6eQD7tzvNPI+5LLNz+rczyJT/b6KyVcZ+bYO3jrw6raTDm6jxMaJpIvIG1XxtiGTStkaoeXQ5ux i2K6PllfRHRUSgqlIGCCkFHMYoEy4mFvIGC8wSVGTqOtUaudgrq/YQeHfsLxDw4QBvQ2/XP3rLron /nYKqQX7yUCVJiO+cQev86wNP91/7Iz+oGCh9AS1aLKpPK5iq4sDhzycio7fP17V8xO0Lv6e1RKak XdsSA3Lg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qO08S-005BNK-31; Mon, 24 Jul 2023 18:18:20 +0000 Date: Mon, 24 Jul 2023 11:18:20 -0700 From: Luis Chamberlain To: Alistair Popple , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, Pankaj Raghav Cc: SeongJae Park , kevin.tian@intel.com, x86@kernel.org, ajd@linux.ibm.com, kvm@vger.kernel.org, linux-mm@kvack.org, catalin.marinas@arm.com, seanjc@google.com, will@kernel.org, linux-kernel@vger.kernel.org, npiggin@gmail.com, zhi.wang.linux@gmail.com, jgg@ziepe.ca, iommu@lists.linux.dev, nicolinc@nvidia.com, jhubbard@nvidia.com, fbarrat@linux.ibm.com, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, robin.murphy@arm.com, mcgrof@kernel.org Subject: Re: [PATCH v2 3/5] mmu_notifiers: Call invalidate_range() when invalidating TLBs Message-ID: References: <8f293bb51a423afa71ddc3ba46e9f323ee9ffbc7.1689768831.git-series.apopple@nvidia.com> <20230719225105.1934-1-sj@kernel.org> <877cqvl7vr.fsf@nvdebian.thelocal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877cqvl7vr.fsf@nvdebian.thelocal> X-Stat-Signature: egbgd7z9cw6geghmf1okb51camhpnxuj X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8B8641C0017 X-Rspam-User: X-HE-Tag: 1690222711-715506 X-HE-Meta: U2FsdGVkX1+Nl4EubucJmY8A71xieuNLWYNIlW9Ri+MpDkSwjYo6/swtjfUjGaouWD69OmN20gWeEx7DqFRH8v5ge2Kztnu+z8tlTWVr6Xjkuy8dxZjcklaeIq9JZ21WXPhrSpAOznsBTaHfe6Yw8u5NE/agKxtcwTIsTyCKwHEgOeTz0tRDHUDFy5Da3UEkWAkRx78bZFsBIpSfM3tAoWLo6acJwSXOXmLWpd6WUATJ0iTa69STEoLQc1O0H2I17Nhh7kvjUb+Bny/jkwuXyfuQrYB/OPT8CdiUqrL4Gz1CPze2CvwF5eixlXpXO3jilLCL99LN++92S6EpfCoSQYOGPQctvOd/kck0ta50a9X9i1RatndbqHiho4mCE/6t1lH39+EOKpfDt0o0ZnTJirE47E/IhCH5nHIglBy5g5dzNbvZzRZoOQQ+RhtN3Sv8etN2gEBRq+h+UK5++NDuT5DGJBOl8k7ffPNjKSpPJvgZukzP9EMw0GVrNqPrlrap3TYbpGrB71qXb3XKHZHsXQvU/5LBDtjEac/cF9niITBkJ41wnzRumAUw+/NwnmfdHe3kI/9Pdvmu73yDgMm2g1UiGtqgzJxUZFqSL86DMwIdVx1b9ZQf21Lob4YUfC9dd5AKvz69grpt3DWJgCtjEUfPWHfoM9EUxB4I5bakPU6/w7igIU21q85tjTDppzBQRdr31XQPswmhyAc3sq9z9bNZRqI+oqQQ0lmCpQ2Kewu3wtR2+TtLsK+LTIliLrl0vllI2/JVd/4HGPKZMaKtEzmbdxML6H2FCyEiSdmV+Kf81IAluRr6KjFHf7CwR2wOstXRs4gDR4MW35YV67qaVHKOf8yVjTKVgGlZzXzZRhDY715GcyYMp7Xo3kOO7WVMDa0sCSr2Hlixayuvi2wNU4YRpl+IT0exqv2w0YYHyWBk8aymug/cI/PimnwhDXXFw2BGT+1oN3LTPhC7LI7 Kmn4tNAY 1YlFC36iezf3HcuB0iWXonQgilh6MBj4hmqEasEC0wD1vMkpshz6pwWb0/hoqAND8eBSic3ri/uqmEqL4y68RRYAZHMlbEW3FKpt9n5SY41uvFGTiq2VSvQKxZ2yUO6fshiDWda2d0KGv2iehiWRtlaqOHKl/+/hvMqR9Wb+84lRoVey0Ldobht08hg/6hv/hMB4GCtLQyIIJ8PN38A+4pm+55muWuXwjV/RB7LQBWRQCbmqrF7LqbDXB2ANfB8hKDr+d6iZ4rILkziyEbvHLc4MmHO7oVA3n9SdpAibXWk2jLxXJvwKvLiwCC7A3Iz7EtHT0MCOgpxojr+JK4zEgEOSyo2WQuYHrFh0ExReBimmZdPnjvpUP4xiXcCg35sPu3mG90Fy48KgxjFNihApiuqfPlBjBULaY3SpGvplYaPShnq44JDigGBhJ0bm1kfmkM7uJ7FZnsXvq6qsa2ZpcZSW2Yg6U1H6vSjft8hLW6SkzhoJEplilfIYODDfSp2V31+gyoKIoZ+x1VVk9FsxUeYj0iX7UA0/75iY8hdYRyihoP3MlcCBn01bf8CQLEzeoBO7WrjSpwYreKBUK5IjQ6ArB5iK4TYjSdB1PAN0vnZi5cYc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Cc'ing fsdevel + xfs folks as this fixes a regression tests with XFS with generic/176. On Thu, Jul 20, 2023 at 10:52:59AM +1000, Alistair Popple wrote: > > SeongJae Park writes: > > > Hi Alistair, > > > > On Wed, 19 Jul 2023 22:18:44 +1000 Alistair Popple wrote: > > > >> The invalidate_range() is going to become an architecture specific mmu > >> notifier used to keep the TLB of secondary MMUs such as an IOMMU in > >> sync with the CPU page tables. Currently it is called from separate > >> code paths to the main CPU TLB invalidations. This can lead to a > >> secondary TLB not getting invalidated when required and makes it hard > >> to reason about when exactly the secondary TLB is invalidated. > >> > >> To fix this move the notifier call to the architecture specific TLB > >> maintenance functions for architectures that have secondary MMUs > >> requiring explicit software invalidations. > >> > >> This fixes a SMMU bug on ARM64. On ARM64 PTE permission upgrades > >> require a TLB invalidation. This invalidation is done by the > >> architecutre specific ptep_set_access_flags() which calls > >> flush_tlb_page() if required. However this doesn't call the notifier > >> resulting in infinite faults being generated by devices using the SMMU > >> if it has previously cached a read-only PTE in it's TLB. > >> > >> Moving the invalidations into the TLB invalidation functions ensures > >> all invalidations happen at the same time as the CPU invalidation. The > >> architecture specific flush_tlb_all() routines do not call the > >> notifier as none of the IOMMUs require this. > >> > >> Signed-off-by: Alistair Popple > >> Suggested-by: Jason Gunthorpe > > > > I found below kernel NULL-dereference issue on latest mm-unstable tree, and > > bisect points me to the commit of this patch, namely > > 75c400f82d347af1307010a3e06f3aa5d831d995. > > > > To reproduce, I use 'stress-ng --bigheap $(nproc)'. The issue happens as soon > > as it starts reclaiming memory. I didn't dive deep into this yet, but > > reporting this issue first, since you might have an idea already. > > Thanks for the report SJ! > > I see the problem - current->mm can (obviously!) be NULL which is what's > leading to the NULL dereference. Instead I think on x86 I need to call > the notifier when adding the invalidate to the tlbbatch in > arch_tlbbatch_add_pending() which is equivalent to what ARM64 does. > > The below should fix it. Will do a respin with this. > > --- > > diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h > index 837e4a50281a..79c46da919b9 100644 > --- a/arch/x86/include/asm/tlbflush.h > +++ b/arch/x86/include/asm/tlbflush.h > @@ -4,6 +4,7 @@ > > #include > #include > +#include > > #include > #include > @@ -282,6 +283,7 @@ static inline void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *b > { > inc_mm_tlb_gen(mm); > cpumask_or(&batch->cpumask, &batch->cpumask, mm_cpumask(mm)); > + mmu_notifier_arch_invalidate_secondary_tlbs(mm, 0, -1UL); > } > > static inline void arch_flush_tlb_batched_pending(struct mm_struct *mm) > diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c > index 0b990fb56b66..2d253919b3e8 100644 > --- a/arch/x86/mm/tlb.c > +++ b/arch/x86/mm/tlb.c > @@ -1265,7 +1265,6 @@ void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch) > > put_flush_tlb_info(); > put_cpu(); > - mmu_notifier_arch_invalidate_secondary_tlbs(current->mm, 0, -1UL); > } > > /* This patch also fixes a regression introduced on linux-next, the same crash on arch_tlbbatch_flush() is reproducible with fstests generic/176 on XFS. This patch fixes that regression [0]. This should also close out the syzbot crash too [1] [0] https://gist.github.com/mcgrof/b37fc8cf7e6e1b3935242681de1a83e2 [1] https://lore.kernel.org/all/0000000000003afcb4060135a664@google.com/ Tested-by: Luis Chamberlain Luis