From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68F8CC001DF for ; Mon, 24 Jul 2023 16:37:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D03F26B0071; Mon, 24 Jul 2023 12:37:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB4246B0074; Mon, 24 Jul 2023 12:37:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA3248E0001; Mon, 24 Jul 2023 12:37:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AC0426B0071 for ; Mon, 24 Jul 2023 12:37:08 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 85155B225E for ; Mon, 24 Jul 2023 16:37:08 +0000 (UTC) X-FDA: 81047060136.25.DDDA61C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 52ADDA0008 for ; Mon, 24 Jul 2023 16:37:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AXdNMh4B; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690216626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=86Sml5/4Juo5dfBsbJVnV+JsVX44yMB+2OJxZMAGIZE=; b=ZZCCrsbfr1cDxz4Fru3bzWGko2Qck3pQZNo8HrPWXB4yFrZ2K4NMMftB2DL7Ye8C2gs+gp 13RZMktqboYroFnyI6pe0oysrKtzL5nq7gckP4fTGKKTHXEla9R4k/DojcUJ2y7iE7pkww 1qebIReUteJBwVVPyjitfi38gGgAuig= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AXdNMh4B; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690216626; a=rsa-sha256; cv=none; b=fkmuMIMZ5uXhx1cjbYsikocIDmFVOVEI2d76ozKA4bI8D3oF2KoBks4rPWuxK6lUm4Nra9 pSQ3F42gNuUVV8vJNd///C96WOGJv8f9rh2nahSyVriScXUsgbG1GKAyisNNbC8Q08R+io nr/d/fAn5lRI7/Efzu76in1YOE0QJjw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=86Sml5/4Juo5dfBsbJVnV+JsVX44yMB+2OJxZMAGIZE=; b=AXdNMh4BbdzOKPB9RuG4mftfxb 3CTRIM63VjO88N6o8Whnh3q4xx/xx6/Ggoe8un2WSgEa4isDbTWfpVjWXpYHjcU3fVlBTLroWwEJd /ey4oo3GkXy8lfAxN6w90rMjhJnVfmSFm4LRHKb07fDtTUCT9dab//p1Un1DRzTu4VJiqqcryl9bK XYwdSpEdG2MrcjEX5SvY88r308/bLg4tmI+tzwP6zaZg0ZvD9hY4bo9Eh9jIGjd3W3OCpFyWLDiRY t94/gN6QQ4geWEuPL8m3cLOqPIjcD5luC4n1A0Levg481tIXoj+t6ZJiW5gZ7uR+hvukQG6ypOz9F FqBoL08Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qNyYP-004b6H-OB; Mon, 24 Jul 2023 16:37:01 +0000 Date: Mon, 24 Jul 2023 17:37:01 +0100 From: Matthew Wilcox To: Jann Horn Cc: linux-mm@kvack.org, Arjun Roy , Eric Dumazet , Suren Baghdasaryan , linux-fsdevel@vger.kernel.org, Punit Agrawal Subject: Re: [PATCH v2 4/9] mm: Move FAULT_FLAG_VMA_LOCK check into handle_pte_fault() Message-ID: References: <20230711202047.3818697-1-willy@infradead.org> <20230711202047.3818697-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 52ADDA0008 X-Rspam-User: X-Stat-Signature: 9buy73nrsdc7eogyew7uqknzyhfdtag6 X-Rspamd-Server: rspam01 X-HE-Tag: 1690216626-808188 X-HE-Meta: U2FsdGVkX1/sCGvXzhL70gxqIqQOGjBHLjyWg2ylm/jATXsULjtpXvS9qgVlsWcK0EU7L0iOxuJBHRZs0NB8n+55WT2thIs+EON+t/d80l5mA/T3DhKjVzawodgIk8tgt+SmzeAJrfAFNYwu8dJ/8GxegvfyG4enligpPZyHRTmo4RgIfbTU/8sQMsKQVPXmYp6JUSYjCd2H/X2ABEK/yjVEN9GuwY4V3leGlnySJoeX9i9VsTCpbO+aYaCsuJpWm/PMilVj7UE+0KAGm0aLTwzvx/ikTlQfHCewzax+3aAV/co3XXnci/LWAcRcQQsAnZGQAvVgEPpqdMR5XG59VBeyPojMpZv6mgHpVjVnP+csOWmMbguhkTE9fOkkDvIL9lhAJLPNlfJjUc3+U2ZdiZQ3u8ZuhnYbs03IwFtnaHodgv5PeZ2kpssHH/qoU6PMsZY+NG/zDxnxFXK7G9D7axJh4tptFdO1XecM1VUOBA7gKTG9+fa9VWcELCYeA2Oxr/IjMIf+9kn0jnJdiMZL8p2qSkWoFPHcOXO29U+hXG566XOBxVxHRVqhWs/lIhHZyNqfRSfOo3XTeIpweD2KkQKC2JB6nzz+LSnVPzaZr6QxxuOZfQ820q7S23ehP6i8SXE1Jytp942ilVO/5F3f7PpjEcfLgnxkf9N0+xif6BVDr2zf+sa+ncceCDvoJVvSykeB9g/d3LOrQfvbN0q/ZxJLACjNOWuzRhu6cuEt95rp2AFw2+knc3U5eoEpFA0YAN1gd2SVDnEoYZGr0Vg+s+DFzLaWpWsWiQOK6csvfa5DiHRJTJFfBIswAu46QefqLB3nVH88Di1YPV2hzZ/uf/OxW1K5mRsxYv+ttSdGHgEpqkzOHfXA9GOpdOKTWH/tlqnMvBbx7bnHAMO0kDMkugzxhUTligsF/kTm6OJ6z20TCaLQfDxSiHgXrusHH2MZ0iDVj5THSrs3tea38x+ kJaPgcg1 ZBhAx50874ZN9ERBgLXhxLhr71hu6X0w4GKHcfgPc2AVgnspQ7Qr+0JUpsUNcEybEA6cJxXdNLDIeOakGBlmjFAUSbdpwjxYlVZt9mFUtI0BY8sSAW59m5A1O9wQoeaBdHGEOPORmQu3TlpnxYv1nEtW3X4KzOJPud8D0RraTR2vr47BWJWuuDVi3lu7zHam7SrzpoM8LZwJghZfruADpMwNP1J9zH0AB016NBkCzBLwCrGJkB3QS+lyuywPUTWRwpAobo4AmYm2LrB0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 24, 2023 at 05:46:57PM +0200, Jann Horn wrote: > On Tue, Jul 11, 2023 at 10:20 PM Matthew Wilcox (Oracle) > wrote: > > Push the check down from __handle_mm_fault(). There's a mild upside to > > this patch in that we'll allocate the page tables while under the VMA > > lock rather than the mmap lock, reducing the hold time on the mmap lock, > > since the retry will find the page tables already populated. > > This commit, by moving the check from __handle_mm_fault() to > handle_pte_fault(), also makes the non-anonymous THP paths (including > the DAX huge fault handling) reachable for VMA-locked faults, right? > Is that intentional? Oof, this patch is all kinds of buggy. Will split this into several pieces. Thanks!