From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B679AC001DF for ; Mon, 24 Jul 2023 14:34:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55A798E0005; Mon, 24 Jul 2023 10:34:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50AEC8E0001; Mon, 24 Jul 2023 10:34:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D33F8E0005; Mon, 24 Jul 2023 10:34:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2A08E8E0001 for ; Mon, 24 Jul 2023 10:34:16 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E97F3160AC7 for ; Mon, 24 Jul 2023 14:34:15 +0000 (UTC) X-FDA: 81046750470.23.C7D1D77 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id DC69740015 for ; Mon, 24 Jul 2023 14:34:13 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FLU0saOm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690209253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sw5JYA3+zGjsKL/Hf3UxVttJt75aXV0WOzCX0uDZMJk=; b=C2CwIK3WHoxFTenAekBabab+SHowF9eykIMkDezL2H3FNyuYbh0oL8JNV/Hx91Fch8dVUW l8jNbonqAyM1mJeG5QmrgLeXWRleTOHOL4Kg3Ie6OovhftG9rdvhrJ3kYwULSVb5nxjOf5 MsW1+VzUE2RSCqWAIN33dYkA3eHGWZ0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FLU0saOm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690209253; a=rsa-sha256; cv=none; b=Krcj3Dik9RSC/fGU0YpwVe6CSvI/4iuHQSdlWFcyqjiapPOL7nsIGsBNTzpTtaLHACNl1C qb7POavcWFlW8dY+ipOua3mIDbLc3of7JWhnmbUUPhM8AIdFjHrqnao161gE2pHi4Do3Cu MLTWynutaoqkyXrhzoQgZI/40qWdnfM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690209253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sw5JYA3+zGjsKL/Hf3UxVttJt75aXV0WOzCX0uDZMJk=; b=FLU0saOmVza3DYUYf0SHJUyBHv6joOTRq4mJlEUlB6c1DbYvgiwzNpn14wwynN+5GGOMWF mTyhwJtWKewNNuE38vnZNRNVuUgii4NpDzoDUi8XDYQS/FQbVgPJeHMgQXBvvYxisgVJfA MVQoE26Ln5YQ166wEY8r/A2GW/096gw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-450-2242VwcsMp6SRYZI29FIGA-1; Mon, 24 Jul 2023 10:34:07 -0400 X-MC-Unique: 2242VwcsMp6SRYZI29FIGA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 15B5C8F77CC; Mon, 24 Jul 2023 14:34:07 +0000 (UTC) Received: from localhost (unknown [10.72.112.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 305672166B25; Mon, 24 Jul 2023 14:33:46 +0000 (UTC) Date: Mon, 24 Jul 2023 22:33:43 +0800 From: Baoquan He To: Jiri Olsa Cc: David Hildenbrand , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Uladzislau Rezki , Matthew Wilcox , Liu Shixin , Jens Axboe , Alexander Viro Subject: Re: [PATCH v8 1/4] fs/proc/kcore: avoid bounce buffer for ktext data Message-ID: References: <86fd0ccb-f460-651f-8048-1026d905a2d6@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Queue-Id: DC69740015 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ytq1te6guoprzibsteffmyjytq8ygf6e X-HE-Tag: 1690209253-226656 X-HE-Meta: U2FsdGVkX1/VRrQQ5HR0VijcmiBnRSXwlOLcI9yg//CuPw9fLZLDBnpRk7diTjW9qvUHIEP3ixFSYck78oizZyZc47yIBNe20hjy+kc1GLmjzFy0Q81kYbZbT6taPjRByTXW4aFK/P17sPt2qYSSva+MYbysVU6A27yqxi3Rm5LE1Q1MF9K6tFBJ2Qei4pV8JiiB5HLxgXKNAhr4hTZ21m7dOGuGtipw7ZU9mhVc+uJOncaAugDwjKebLG/eF02CbCZ1IKsTKU+Z+SOdYt7GezYSuWUNYqLTkrDktRtjyCR67TYX+m4T9ZJGN6Y/UnujFBTdpgTHrFGpADVj2Ic/Y4W8oANFaByropCGVoO7g4EI4L9skVMeMPItW8sDSiRGj+dQ5V/JMwROIujcM/pCVWlFG8Vg5IYMDE/ryEyZw05gLLeN/aM4TSyWGJfEi2Kkl8k7owoUIkt72KkmyXAakd3t8Dt+LbFCiHFAenGaThywqEw5biSw9yEA50QmIJsnS49Ufx/jSnSU+NC34CnQYW1oGbmG/zFLGx29QBc50GyJF1m/Ex2EKW89ineRDFoCvE17wfnmB/Xu2CzLi+gPMi75Iz3ZntRqZOiWg545f1G1gqnVbeRJSLMqTAthXMrTna6km8RZm50Z5aAgfTJdWUN2jMNySOVQKzQBKgsDmJ70Mr4xox/OArud4ww0VXlqD7VAG1ROEUAZgSkr4buSQ2HfpVRaUCRMB9oey7FPN+EtgywOruFiv9ict9ns6JdCzVa0fyzx5S0EF9qswJMXsgUsdiQZztZ6P2aa4c/WjQ3LheeabVQnG/t7+fug96X63T60g3wRjrpkWNdRfp6cPs994pUkg7KWkb/HZa9Ka2QDPPfq16wYbsvYDlEwQxABbB/0a7fq+R/28Ri2VRE8WMHSrJW7U2lbivITb9FONkGMSP9KJmLe3Qeo1zc5wlPpmhV66rMqIf1PWezNPwh hKk87Hiw +/bbjwETFLyM2mW0Sg1GIKR04JSTUNW/F/kIgFpOp13AEu8ZEYfCUaRjggwP3hcS88s33RjizR/wQNulW6s2jE4yG5tL8iZI4VemQBd6exxdoqYPIIUvIdGrI2dGXXooD6Uz1Xm7PupW0Fp7NOB5/wqcoOLjKK/s88e5d8sHy012cw79xhooHrUQYPox7zmdwL8qyapEcCRO/oiE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07/24/23 at 10:18am, Jiri Olsa wrote: > On Mon, Jul 24, 2023 at 04:08:41PM +0800, Baoquan He wrote: > > On 07/24/23 at 08:23am, David Hildenbrand wrote: > > > Hi, > > > > > > > > > > > I met this too when I executed below command to trigger a kcore reading. > > > > I wanted to do a simple testing during system running and got this. > > > > > > > > makedumpfile --mem-usage /proc/kcore > > > > > > > > Later I tried your above objdump testing, it corrupted system too. > > > > > > > > > > What do you mean with "corrupted system too" -- did it not only fail to > > > dump the system, but also actually harmed the system? > > > > From my testing, reading kcore will cause system panic, then reboot. Not > > sure if Jiri saw the same phenomenon. > > it did not crash for me, just the read error > could you get console output from that? I got a new arm64 machine, then executing "makedumpfile --mem-usage /proc/kcore" won't trigger panic, your objdump command can trigger panic. The call trace is pasted at below. It's the same as the panic and call trace I met on my last arm64 machine. [13270.314323] Mem abort info: [13270.317162] ESR = 0x0000000096000007 [13270.320901] EC = 0x25: DABT (current EL), IL = 32 bits [13270.326217] SET = 0, FnV = 0 [13270.329261] EA = 0, S1PTW = 0 [13270.332390] FSC = 0x07: level 3 translation fault [13270.337270] Data abort info: [13270.340139] ISV = 0, ISS = 0x00000007, ISS2 = 0x00000000 [13270.345626] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 [13270.350666] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 [13270.355981] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000400651d64000 [13270.362672] [ffffdc9cf3ea0000] pgd=1000401ffffff003, p4d=1000401ffffff003, pud=1000401fffffe003, pmd=1000401fffffd003, pte=0000000000000000 [13270.375367] Internal error: Oops: 0000000096000007 [#4] SMP [13270.380934] Modules linked in: mlx5_ib ib_uverbs ib_core rfkill vfat fat joydev cdc_ether usbnet mii mlx5_core acpi_ipmi mlxfw ipmi_ssif psample tls ipmi_devintf pci_hyperv_intf arm_spe_pmu ipmi_msghandler arm_cmn arm_dmc620_pmu arm_dsu_pmu cppc_cpufreq acpi_tad fuse zram xfs crct10dif_ce polyval_ce polyval_generic ghash_ce uas sbsa_gwdt nvme nvme_core ast usb_storage nvme_common i2c_algo_bit xgene_hwmon [13270.416751] CPU: 15 PID: 8803 Comm: objdump Tainted: G D 6.5.0-rc3 #1 [13270.424570] Hardware name: WIWYNN Mt.Jade Server System B81.030Z1.0007/Mt.Jade Motherboard, BIOS 2.10.20220531 (SCP: 2.10.20220531) 2022/05/31 [13270.437337] pstate: 20400009 (nzCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [13270.444289] pc : __arch_copy_to_user+0x180/0x240 [13270.448910] lr : _copy_to_iter+0x11c/0x5d0 [13270.453002] sp : ffff8000b15a37c0 [13270.456306] x29: ffff8000b15a37c0 x28: ffffdc9cf3ea0000 x27: ffffdc9cf6938158 [13270.463431] x26: ffff8000b15a3ba8 x25: 0000000000000690 x24: ffff8000b15a3b80 [13270.470556] x23: 00000000000038ac x22: ffffdc9cf3ea0000 x21: ffff8000b15a3b80 [13270.477682] x20: ffffdc9cf64fdf00 x19: 0000000000000400 x18: 0000000000000000 [13270.484806] x17: 0000000000000000 x16: 0000000000000000 x15: ffffdc9cf3ea0000 [13270.491931] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 [13270.499056] x11: 0001000000000000 x10: ffffdc9cf64fdf00 x9 : 0000000000000690 [13270.506182] x8 : 000000007c000000 x7 : 0000fd007e000000 x6 : 000000000eee0b60 [13270.513306] x5 : 000000000eee0f60 x4 : 0000000000000000 x3 : 0000000000000400 [13270.520431] x2 : 0000000000000380 x1 : ffffdc9cf3ea0000 x0 : 000000000eee0b60 [13270.527556] Call trace: [13270.529992] __arch_copy_to_user+0x180/0x240 [13270.534250] read_kcore_iter+0x718/0x878 [13270.538167] proc_reg_read_iter+0x8c/0xe8 [13270.542168] vfs_read+0x214/0x2c0 [13270.545478] ksys_read+0x78/0x118 [13270.548782] __arm64_sys_read+0x24/0x38 [13270.552608] invoke_syscall+0x78/0x108 [13270.556351] el0_svc_common.constprop.0+0x4c/0xf8 [13270.561044] do_el0_svc+0x34/0x50 [13270.564347] el0_svc+0x34/0x108 [13270.567482] el0t_64_sync_handler+0x100/0x130 [13270.571829] el0t_64_sync+0x194/0x198 [13270.575483] Code: d503201f d503201f d503201f d503201f (a8c12027) [13270.581567] ---[ end trace 0000000000000000 ]---