From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A02DFC001DE for ; Mon, 24 Jul 2023 13:37:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 043C18E0002; Mon, 24 Jul 2023 09:37:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F34D98E0001; Mon, 24 Jul 2023 09:37:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD5EA8E0002; Mon, 24 Jul 2023 09:37:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CF9368E0001 for ; Mon, 24 Jul 2023 09:37:42 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4C68B40B1C for ; Mon, 24 Jul 2023 13:37:42 +0000 (UTC) X-FDA: 81046607964.05.A4D0F33 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2058.outbound.protection.outlook.com [40.107.92.58]) by imf30.hostedemail.com (Postfix) with ESMTP id 300F980010 for ; Mon, 24 Jul 2023 13:37:37 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ohKNIww2; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf30.hostedemail.com: domain of jgg@nvidia.com designates 40.107.92.58 as permitted sender) smtp.mailfrom=jgg@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1690205859; a=rsa-sha256; cv=pass; b=68Oskb8pBRdspq9rCxfjxt5tj7GbJAQBBVvBqj/P6Nul8rNpIKGkSo5/wAuuDBrPpGHAIq bDiEUdtfThILMeJ4Z8kW9l7LFoeQKRxoHOyhf4hTgfc+slooMkoDBV2X9z8zpFHvdYBWCL C+c52SouSZ1scpSwi+inzvC/CryllJY= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ohKNIww2; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf30.hostedemail.com: domain of jgg@nvidia.com designates 40.107.92.58 as permitted sender) smtp.mailfrom=jgg@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690205859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H/09n71snllHjFHRMVrjiRX7oSy6Zdp5gmwNJY5RWpg=; b=Ah77UboHlFrMc85bcNxTpHUos2AiVG8VzkJ+xAdgRlVi3XG7xGk26VOMsAjS5FvweX180b DjC65T7HAkeMJIJk/rrM85iUTZNB1DzAIjZPR72JP0QgamSuRrrrNYqc3lsKqjEkFvyaN9 v2lSfiSM9xI7Q/P5jPrVqfIKqiX1M+k= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U4WH0ryhRNhUKtwWI7MiFSwYIOTHGkr2NIXgPoCW84kaq6OT8PZJmi2e8QWb3PCND6BSdQDk+4MPq3EYYqlpCGwHDj8xR8BiPLTR8mo+HGc4ESoxTL+jnS7lv2eQJ6EIuA+7IsKcfUjBML0VndvHWYTFBJFfRFikTzzVB+AhJQW9dFTQq+vuRbBD5QtCA6wbpeEZj4PnN9mfKys66v90vye6e9m/N4uDuBnkGbnDuvlLqhNVhhuL7bcrA5MrDhwfEX8hg8amWW1/xq5RVIxfxznO4DY/dz/ItyB38HbElNfKvAYsyyX7mkjhVRtc4SQYcGSrJan+FqFv1mPsCotDxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H/09n71snllHjFHRMVrjiRX7oSy6Zdp5gmwNJY5RWpg=; b=YP3RYuQaEeKn+CT6FzbSpBM7IcnVXWfmPfXyc2eRUes53GE3qDbxc3SF6zD5Iz020xwbu78BzSLK6+vfAFRb3V94lNiqCP9HaIV8L64sYcM45z/c0n9pn1CihdAljZokjkMetxQc9nf6gJXF25v8wFF7aSyDwAxPZ2jZknsIH7ITBq8y1UxqXDroCOaPMO1VSbU39whEzukGPsXaoOFtMBxEur8vejuoTqTj5WkV619iJspTKbaBOh/yiUxgx5e3q6j+fatf/S2WESa8ZFIFvz/K38yq9Fs1gIiDYUGpzk2jsW5YkWeiisU9sinrTzXsYJj9+af72nJMQhEWa0qyZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H/09n71snllHjFHRMVrjiRX7oSy6Zdp5gmwNJY5RWpg=; b=ohKNIww2n2v6b5/Dm7FJ6Omw/c7+WbGHtNnb2jTpeJweUkjpGsFEKJLawMFGAOK5sa9J9dl54m9xJtYsoxfYfCRC6Vt+HyrVkQn+zVBIVS3WEOBMBLDIQPrdMK7UuD2JBJzemRROJRCM4AxyCMZkeOqkpyK7bnn2zTXzxOJVLMWpBugUYbzT3xiUILyz2PR4JCKTm+DqusG5WjRyoFDHMXfEOTNzizDnCY16bSf17Li1d9Z1A4xVarqnJobLq197D2VFuputAP9fqOXOUqQcmWH0W5jy9y9sbT5hzBtNyboKfhkEEcAblGO2mcYT94UEH95VhTUnL0cpinyzqosg2g== Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by PH0PR12MB7009.namprd12.prod.outlook.com (2603:10b6:510:21c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.32; Mon, 24 Jul 2023 13:37:35 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::5111:16e8:5afe:1da1]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::5111:16e8:5afe:1da1%6]) with mapi id 15.20.6609.032; Mon, 24 Jul 2023 13:37:35 +0000 Date: Mon, 24 Jul 2023 10:37:34 -0300 From: Jason Gunthorpe To: Alistair Popple Cc: "Kasireddy, Vivek" , Gerd Hoffmann , "Kim, Dongwon" , David Hildenbrand , "Chang, Junxiao" , Hugh Dickins , Peter Xu , "linux-mm@kvack.org" , "dri-devel@lists.freedesktop.org" , Mike Kravetz Subject: Re: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages) Message-ID: References: <20230718082858.1570809-1-vivek.kasireddy@intel.com> <20230718082858.1570809-2-vivek.kasireddy@intel.com> <87jzuwlkae.fsf@nvdebian.thelocal> <87pm4nj6s5.fsf@nvdebian.thelocal> <87zg3lzbd1.fsf@nvdebian.thelocal> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zg3lzbd1.fsf@nvdebian.thelocal> X-ClientProxiedBy: BL1PR13CA0367.namprd13.prod.outlook.com (2603:10b6:208:2c0::12) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|PH0PR12MB7009:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f3652c0-f267-408e-81ad-08db8c4b23d7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PPuybVw27VKor0nODLEZ71MGECSIBonEKO+wHYVV3TS+/3GPJqTwUjVKQJCIVNlE7tFr/9wbig58f5vrqeALpwWF6NKZw2aArCvHt2NarA+En/yIEayfS2QMMiIUFp1hdAI48TnFNa1+PvPRIOaS3G0MSo1xfPUxoO9g/GSCKUSXti9DvUCQg0KWSemPvyDQApiyq1DqXyJiI9acdHMLk791Ef55lFPfxksnFBs4xEaji9Za0l4Uiq4CdvUkWuDKgx5eLHwHiWafY1chDtCAaQXKD4AZBzlvIwueHNsNZk3cyC6bmXXQXowLO7JFN/I7Hj6KIGwkKqCceWtHDdxHPgs6c/R1H3Ey5gy5nbT2yO3ULSf+Mk+HtQ/WVIhzu9j5/VdmsZRHpyUnKRTG03fJEthyAOTMLG3qxn/L270oQi/O2a8R/i2XeCKOBAFTesz0OekTFWnnM1WBsjlV6d0wUC2+vCmJ0E0oZMomrOUX6zmtBN70UxAxZZ/dAA/QT7mFHY6Lw0DwxMUEUmNezU/zvp/XgGnLpYF+SvXfLhrCMFqtmuZ/+iLBu41e6EwtkPjmoi991XTzB+ZBRY/uIBwl2mFlrJ2glJftP9Ry4Lrdycs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(136003)(366004)(396003)(346002)(451199021)(86362001)(6486002)(38100700002)(478600001)(66556008)(66946007)(66476007)(37006003)(54906003)(4326008)(6636002)(6512007)(316002)(41300700001)(83380400001)(2616005)(2906002)(36756003)(4744005)(8676002)(6862004)(8936002)(7416002)(186003)(26005)(6506007)(5660300002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P2W1RNlpAY4Z4cnZQhhMDL1nPWnnK0ErWleUMCctnG27ZP4GBXY1z1j9bPKT?= =?us-ascii?Q?MkhkHxCCE1IaQXJaf5KrikqlLzBwshYR0PCog50XIKIO3VXjmwdi6Yl1IsEz?= =?us-ascii?Q?A4lBBz7L89blrC2FvwpebyBt+o6LitEXY2Rpp8fdbKgOYQAWIcQN5QMATw9k?= =?us-ascii?Q?owkXMCuc4v+55vij4DjCKvhi6SJWoUPcjDFCk/g5B3NO33jjpjH34ESD0vwh?= =?us-ascii?Q?dAFYOHQMcl119MXsAUlLeJryme+PuNqXXfjA0J3dOX/eP+lq4zR+Eci7FTAS?= =?us-ascii?Q?Me1wt2iks+SJKm1Mmav9jyQi6YvzDpBoSDcKUXGWTkE3U6ncBefa4MKoCAmI?= =?us-ascii?Q?rsTTbvKzqvVi2REmM/LjfJfZY3hpyIizldDsbWd6PVjQ6XgNw9CcCSdJaR2l?= =?us-ascii?Q?AxLBxMJkYf4cOBFD6Mu9DicmGC1Mh/dOLXKdc4lU/WC5YgJy0kjrs9FNxvcz?= =?us-ascii?Q?IhrI6Jbvo4Ga4UtRzzTU588uG4b7CtUSpXP1o9Bn9iFsAwAW7p1UHsCLqYCH?= =?us-ascii?Q?ZCEymadF/cECcnNjj78gOz3eINDFVwMgUmcBYla7i1XwPIC91uvREADiaxuk?= =?us-ascii?Q?kPY/ZWH1I91ivgDs5/EyQrKD3V4ezzTf35HL+UNXnFiW2eiPuU9Hd+2F7PXh?= =?us-ascii?Q?IcyjnkW+HOpaM2MzJYDSZ5KCQjN2W0jStMkInlgIztgUnHaSwYLQJT4i85pf?= =?us-ascii?Q?6sT/7Qy9ZyCMt3Zx2xtJIdN27/347JTGWqst8awrquK6PvShvAaNXYwd0pmY?= =?us-ascii?Q?gLfrdzCb36y2pb8KYjsvDMKcRwpIB+Wc0e9RFlfa87EduTuILjo7K2qexuAF?= =?us-ascii?Q?LsGnaR02EJR/TwU1QPmAip3PS5H6rAZeFSK3Mw7RnOyF8Fa/BpuVNcnLDK0V?= =?us-ascii?Q?Juxu9hMLknLJUDU4f6Bmfy8ewyW0SERkQQhBtAW41+Q1PeiGqe3XTzboEb0g?= =?us-ascii?Q?2G+K8Zh+MkQavZwbIDY+XkLQyWpIu2K6JAMfljXZhizW3R1nS83V1/0ARoCn?= =?us-ascii?Q?0UBqllRbQAfVlzVsYhfU/OdiP6oYeopAO5iV/cJcAMz8cyTwB/ulQ5kWUoCI?= =?us-ascii?Q?X5yxhZiTLszw1POj00KZTFagxJXyCnVH/a+0M2wyCOxGuktXkvVIHD1bTgkQ?= =?us-ascii?Q?4YkQnXd2uaN4v5taxObNQ2rusm3yTZ2w+CimXr9qzk3J0YSsJ3eBQiba9fK4?= =?us-ascii?Q?Q+/2yPPDAWE60wKtgHrDoy3mXYhztNGl1NYt7IP+g5MWedmhAqH0piVQGQ6V?= =?us-ascii?Q?hBo2Jvgv0IkyRFZcvyK5u+DPXAaH+xyxcwbYj9Amw/0fa7Ma8vkphgCdLt28?= =?us-ascii?Q?xmtIUJd2hnLEBy3GMVbHW/55A7mUSCpAmmQaozq0aN/sl37O3MG0PS6rGaI8?= =?us-ascii?Q?8JXZapM2yc2aIT6mxbUI6SgTy8bBV2PDtmINb9kj0bK66dWkDk0cQbANQ8tu?= =?us-ascii?Q?SGjLgQffMNJ58Yqk03vvz2v//J7e4tY/d+k0UPzuxctgxXn2NIXwmIIviuJd?= =?us-ascii?Q?AQPN3lqInSiXkxhDvja3o3AAOjfVcR79shIzmKqRIeRHAIzm14Esa+56oZ30?= =?us-ascii?Q?cM+unzxBvpgu8yohWoQTchi5WE4o9NaK1w0c671K?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f3652c0-f267-408e-81ad-08db8c4b23d7 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 13:37:35.6117 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qo0iD/kZz2VUrCMDBCa6QUTXhEUTqfqUygi7PZ8vHLfZC71AVvHOrXGdbRYQK7D7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7009 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 300F980010 X-Stat-Signature: io8mrsbb3c7ubegwwoi73dum6xxzcrg9 X-HE-Tag: 1690205857-952389 X-HE-Meta: U2FsdGVkX198kALoduqFErvwyy9JMbE/t36i3IuW3fPxAdGsC2z4GbaCGXzyOpWaQ+c+xxHhu8l7RoXEycNokQtjFVA9Yo0vvKSwd9n6PioGMzKfgRv/WIt2mM4GBipr5znZOd9axSul3G6Ks0fWcmJxycAAG+Uw51WI/GZHnmpoQ5RsBs7fs7xYBghojSiXHH26koeXMoBJseGjJSybk0DN4cJE3y4SC5lrV39Ek+LkD7gojDubuP0Hf8svsxKLrmQ9DxrVOcxmWHfTbPzZ59AR8R7N0EpaVBI2Xf2Ivb15RZdm9mPfrnR2uGbbkZO4bCC8XTlXtVo82w5OS3D79ZVsywBn3C8hMHobluWW6bOjXPl0wB2FPZi3iuVTEMen8mU0OhooI03FbP5UnjJAAdrDpMDnqCUp/qr1jcuUIHIP5ioq94sq8wNyH3eLc0uf6N1wW9vI9pXUWMJHc+MNFF09rEd+gVSsAmXdJ0MpBx9APhdIQYqRA1ndMl4BJoDgpZn2BGPg30/SJAgyNLM6rFFeNstTICxHAPD9nOVkMG/ACK+ywCG1JkrwDUspT7ct3Fos4miBQco12X35I6Z9p6B9UXuiiO34+TIU3Q9iea2iYw8KhNwerqHIIH9g60YDORWO0mYGzxreWdso6LcpMfbmXiMVioT1fMHgTSNhhXeF7WHPvWCYKDlvvFUknCF27p5iB1u7L9cK+fEHxXQoekx3Myr/eAv/1iFF7KS1pB7Dy8R8PDtL1DzGJlzaRZ7zoierfsFvEij+STQVsv5sFNnbBLBeYU3e/3FQQCPz0biHJxdvrzgYArz0+R5o8D5oFExZLRqv6sqXGttsMDsFCf3hGk4qY0M4w36Dcxs6p9UglfZaj5cI4CEz3edvNGwAWwmCn6NERmGe/eAqqtNtDeiMc4tg2STONyv78GgY6BVOMF4+QJ+5SmsFL9zc+D4cq2cS+dL98JZV6G1YV5+ M/Cd18Hz gArmRMUMeLkFYc9wk+rcSM1GMAvobWTzfGiI5M3HjwZymF6Ui7F2TmqOOdISXzgeeQcjVl8qswI2VEpBjnJY5U1TcaOSGt7OXAzqsSv7PKzfFXbbZ1D2u0XCDvhy7EBIf0RaRDsKwU8J0CsoEN0ekcio2cczk07L0AyGhYiPiMvZK5fD09ECIWfRFIIwt3pDxzNqqwHhgnub6Y8ttuusdB/ECG4KYPTdDpR4oGMEcwzgtobkayJTH0c/xHbJZB+a0N33CJO8/Fs+ZAWXbsk7RYD6soxXkHq/jkDlNpjx2cB1RHmY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 24, 2023 at 11:36:47PM +1000, Alistair Popple wrote: > My primary issue with this patch is the notifier is called without the > PTL while providing a PTE value. Right, this is no-go. The PTE value must be protected by the PTLs at all times. We've made enough bugs already by being lazy with this in the past.. And I don't think the existing sequence locking helps make sense of this at all.. Jason