From: Matthew Wilcox <willy@infradead.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH] mm/memcg: fix obsolete function name in mem_cgroup_protection()
Date: Sun, 23 Jul 2023 21:37:27 +0100 [thread overview]
Message-ID: <ZL2Ph5g05Ud5vAdT@casper.infradead.org> (raw)
In-Reply-To: <20230723032538.3190239-1-linmiaohe@huawei.com>
On Sun, Jul 23, 2023 at 11:25:38AM +0800, Miaohe Lin wrote:
> @@ -582,9 +582,9 @@ static inline void mem_cgroup_protection(struct mem_cgroup *root,
> /*
> * There is no reclaim protection applied to a targeted reclaim.
> * We are special casing this specific case here because
> - * mem_cgroup_protected calculation is not robust enough to keep
> - * the protection invariant for calculated effective values for
> - * parallel reclaimers with different reclaim target. This is
> + * mem_cgroup_calculate_protection calculation is not robust enough
> + * to keep the protection invariant for calculated effective values
> + * for parallel reclaimers with different reclaim target. This is
> * especially a problem for tail memcgs (as they have pages on LRU)
> * which would want to have effective values 0 for targeted reclaim
> * but a different value for external reclaim.
This reads a little awkwardly now. How about:
* We are special casing this specific case here because
- * mem_cgroup_protected calculation is not robust enough to keep
+ * mem_cgroup_calculate_protection is not robust enough to keep
* the protection invariant for calculated effective values for
* parallel reclaimers with different reclaim target. This is
next prev parent reply other threads:[~2023-07-23 20:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 3:25 Miaohe Lin
2023-07-23 20:37 ` Matthew Wilcox [this message]
2023-07-24 1:52 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL2Ph5g05Ud5vAdT@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox