From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB3AEB64DA for ; Sat, 8 Jul 2023 15:02:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D4EA6B0071; Sat, 8 Jul 2023 11:02:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1841A6B0072; Sat, 8 Jul 2023 11:02:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04C4B8D0001; Sat, 8 Jul 2023 11:02:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E6FB96B0071 for ; Sat, 8 Jul 2023 11:02:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B97061C79E7 for ; Sat, 8 Jul 2023 15:02:40 +0000 (UTC) X-FDA: 80988761280.28.602D2B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 8BFDB140022 for ; Sat, 8 Jul 2023 15:02:38 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bUPOe8ft; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688828558; a=rsa-sha256; cv=none; b=QUQG9aNOaP1ELvTYxkaKXgBosowN8Js1yfTni8FJ4s62+POFQ6cB4tekH5DVKJ/Ia3l1zI hImbVzaoxV2vR8sOWYZon5aWrzxhMYnW5Rssd/oQ5OYAq+0q0wujShxorvGFMiV/VGDKNG K62eJZiSMZMd4Xh7wTpgQIBydlJVUEU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bUPOe8ft; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688828558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T3GRnokqrPVaYV/THcdBGlJffY7BDH+AcPJHejmPSVM=; b=Y09EaCwUz4Uus/UanpXGO2YgxReXnY47V/99XXkYUZV6uuS6Yz/aOYLRv4llpqicZd2XY7 d/ghPu3724htm7KRrLWR1CFwUHfhRrxBlgb/5iqlcFuTzzmHPHzKtKEpOT4ZiekwLHXcS8 LilaldtE9w/KZfbUFfWmOv0Rq5Wo2ic= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688828557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T3GRnokqrPVaYV/THcdBGlJffY7BDH+AcPJHejmPSVM=; b=bUPOe8ftgS9nqFxx2l8gM7jwZ65gPpqg/kYq/npOY6e3L8n7uZpfCL17yfqIWUrg7ySeJw R8kNfgTwhWW96uyC14G/81eHqoZ5HOsp5sp1hvTaDVvyH9SSzOlUtpgbWTjgP02DE+OP49 LZC2b6BPz98CVMjucr2wmv4UWfqB7f0= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-LeaCzr49O_i3vSfCCOysEA-1; Sat, 08 Jul 2023 11:02:36 -0400 X-MC-Unique: LeaCzr49O_i3vSfCCOysEA-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-402fa256023so6088871cf.0 for ; Sat, 08 Jul 2023 08:02:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688828556; x=1691420556; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T3GRnokqrPVaYV/THcdBGlJffY7BDH+AcPJHejmPSVM=; b=HAnLg0Bw7UEex5kYYAdeMFTzxV99je6QcIHHZ/KuoxhEdv+bf2cXMjSKtioLpWU+IC RdJpTIc0WJ4FnnK/ObX8+4U1Y5roBsHxDYOLvu6FKupm8ixh39wQnBUvdEAOAcwBUiYP vbDSVT8YYzU06JvsX5UYBRuQhr77nfLJR6tA5me/CY4iWByZcPOW8go5TsUjVQTDaX2e BAkd+OLlutXL/g4dXNLkWFOMoycPk8xK+hUpdt3rXoc4bD0kbbg74YCduQ3WFD3SLucq ukfk4ZNqpsC/CltQZcks50H+raaKArNVf0CtmSDIodd7Cs+76xxqZt/+1eWv5eRMGJJu pQgQ== X-Gm-Message-State: ABy/qLYIyaiyl5qywc/zPyt/ftbqvrGclld7DjgGyFbJd8Ea7D6DxdCd +7warhTA3dTKemAuhcdmhN4gU80X9ySl4FLkN4gzrSe06yl5/Z96ldXEqIv8JGJ66xO54uX0iSo Ngv9Wq2LiAL8= X-Received: by 2002:a05:6214:b65:b0:634:cdae:9941 with SMTP id ey5-20020a0562140b6500b00634cdae9941mr8767604qvb.0.1688828556023; Sat, 08 Jul 2023 08:02:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlGj53IzcQAPmiI/v43Lyk7eh+euAZZXrSV8HTK/l4O/V2y1GtOUmoqfRyODcRL3zSDwxMPZhQ== X-Received: by 2002:a05:6214:b65:b0:634:cdae:9941 with SMTP id ey5-20020a0562140b6500b00634cdae9941mr8767568qvb.0.1688828555801; Sat, 08 Jul 2023 08:02:35 -0700 (PDT) Received: from xz-m1.local (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id i4-20020a0cf484000000b0063013c621fasm3417890qvm.68.2023.07.08.08.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jul 2023 08:02:35 -0700 (PDT) Date: Sat, 8 Jul 2023 11:02:33 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Brian Geffon , Christian Brauner , David Hildenbrand , Gaosheng Cui , Huang Ying , Hugh Dickins , James Houghton , "Jan Alexander Steffens (heftig)" , Jiaqi Yan , Jonathan Corbet , Kefeng Wang , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Ryan Roberts , Shuah Khan , Suleiman Souhlal , Suren Baghdasaryan , "T.J. Alumbaugh" , Yu Zhao , ZhangPeng , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 7/8] selftests/mm: refactor uffd_poll_thread to allow custom fault handlers Message-ID: References: <20230707215540.2324998-1-axelrasmussen@google.com> <20230707215540.2324998-8-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20230707215540.2324998-8-axelrasmussen@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8BFDB140022 X-Stat-Signature: og1pdy88xfswoih5tjjt86zdq58s6phe X-HE-Tag: 1688828558-194553 X-HE-Meta: U2FsdGVkX1/Ps1/g0twPDEQIKb5MnKO6IPp1WIbtO172EPcoNpkEdcmbptuUNszo4P0Wyp+bWbz3GsyDzdfip04WoWvTFCCulVq3/V7SoUw1qjNRRFLeCmOYmA2WoV26jauCdIhdyif3nf0sld44D6LJWOadnlED1EwIt9vKrTbLi3WUtBHhdH50xCRfnGmqnl90wERmtAKYBfIrd3+GhpUa/jpEdPhhUFiNLvQDE83XCNeeIzkS16VuFvzNOqv7SJlZNUTrkMU8ISLRB+Mpt+KNod5xT7GrRfe3YkFniWxOH6AirZgX9woxJOE39Yz1NHmg316IyRMF1n+mhQjjJ60MG+vVYrpQKzfj753KdURHM8nbU+zeegxGjSVOx6Oa2dMRkJyDsMJV1sW5MtYBTA7SjoZGk/bVKgKjxPqJz5ExxlE/y5CZJMDJ3+3P4cS/0PDJgRqMoiQPgkiVvWZR2a1SgB2mYlP1FISAAJVTcYBwTYlmW5iyrySYHL1zODq31BiFAeikWoHSKCwUSd0AnQABdWDKlYNvy1L6iUGvCoPXcKvduE7kwj3A/J+SxevdmHf7bFYkmIl1mH8WUDGsQS9WjIfYMBDOaEe8NubtnKAK6+wuLUpW/Zuk7TA3UHo7Kls3i6i9cODrE7H5QvryiIfhtqbKIsCjO4p8ecec1f3G/0vWsxxHAXzwGjipGqijRSWb1f5yiiD/zJp5ABjkYVLqnW5alKgbFd02gVfbskBya1FPqOhufsrxonYsg5x9X/2V5EPPW/4ukj/DzEuz6qcyAjcZ56Qkzy4u6U77ruIQ+Oip+17iBy+e3uh1e2iUxOf+Iq+FZU3s4sYcZU6WnsWYcAFduPij24IZEsQWgy/IFfEEcUZQ4c4A8Ou0NKJFPRHVKzoT9gdtF+1ZliW6muKP0tQzFpJ47yWcLTrCgY72fgZ1s9e+rJGmigbFtTMT2JF8EJ9pHX/Ea3oMV5V sN3uQqhx S13G9wOm3fwPy4YnqVzoZ5C72kakEkIooVBfM/h1KY+PBifvMaV4A0TYebppR+TwPwpfouToh/2gaPH7GYZux2YdBnR9ep0tScUOEoLlZO6328vohKFM8WG1gJdsXBGDNLTuO/0pkPMQghkUu7tRdnXv0E97LOq1qmMSbsnAm2AdkCkmCoyyJZ0IwJwR8zCY8RFzuKN6fJeuCEFP9Ergh5goGMARqf4yMuZhds3/2BxsyID0U5guVt6JDtjsw3A0UipCRNZ88oV5sdDXRuGP6wYLMwkEWyGjZGbS29UmcGZnDs04Nh5eJlNQSoKVzU7pxlPRqItrTZMlahJT0oWJjbPir18gbZDtMfZ9uhazOE0pKkcWSpD+32nexBKxDGky7WP6AXm3mcEX+2zo6Up6FxpPmdx/3Bb4qhcNQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 07, 2023 at 02:55:39PM -0700, Axel Rasmussen wrote: > Previously, we had "one fault handler to rule them all", which used > several branches to deal with all of the scenarios required by all of > the various tests. > > In upcoming patches, I plan to add a new test, which has its own > slightly different fault handling logic. Instead of continuing to add > cruft to the existing fault handler, let's allow tests to define custom > ones, separate from other tests. > > Signed-off-by: Axel Rasmussen Acked-by: Peter Xu PS: please remember to update manpage after it lands. I still have a plan to update but not yet happening; if you happen to update before mine please feel free to update for whatever is missing. Thanks! -- Peter Xu