From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E040EB64DA for ; Sat, 8 Jul 2023 15:00:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46DD18D0001; Sat, 8 Jul 2023 11:00:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F63F6B0072; Sat, 8 Jul 2023 11:00:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 270468D0001; Sat, 8 Jul 2023 11:00:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 12E166B0071 for ; Sat, 8 Jul 2023 11:00:49 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CE69EC0218 for ; Sat, 8 Jul 2023 15:00:48 +0000 (UTC) X-FDA: 80988756576.19.7C2ED0A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 5187E14001E for ; Sat, 8 Jul 2023 15:00:46 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VemNo4n2; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688828446; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vo+xktwiVBdnYZNSkVaZ1jBQzqcsS/NnXCqSzqSIy/s=; b=0u4+tmgHOHjYgqosyTGISGKn6r3agBzlOJeNW32eOMKtvaX73GJo5kae6gsaLRUdBxjH6v H4yDWx4mWKRGyzgxex2Y8pc+Y2O3ZhsCr8nb6oVggzLNpQtd9XAT+O+ok5iY03QpPOPDJp Va/maJuV5pmMpvT0CQFrhYetKONr2Aw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688828446; a=rsa-sha256; cv=none; b=LhpDhDtutjXExXcaGpgwej9Tm46f0ZdxFjcuME+WnbzRTrHLaCMzRKGLxUBltg/rmDovF4 oRNZ5+7VoqrrmHQfkETH9Fc26K1F1PDUc4bxDIL0ZTDKBra81344UIcoU6LmS66R5yK2XQ TYKj9BgKBv1KVmQiuzF+7kZ6tQeR/Us= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VemNo4n2; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688828445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vo+xktwiVBdnYZNSkVaZ1jBQzqcsS/NnXCqSzqSIy/s=; b=VemNo4n22hNz/hL/Xs5eo2t3JxTm62f/urL1hwR51S8a4Y21PLcONznqlIZ6Xwb2kS84YW CjFaq94TxPZcrXLTKTdaM9h28VHURAIgWlKhQ8kLtSC52/OcYJcv/yFLbjq85Zut0C6ppr 2Mhre81B6rDGdjUbfiEtEM2xlYl9YJM= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-b1IGGarsO7KTrCTNY1G7OA-1; Sat, 08 Jul 2023 11:00:42 -0400 X-MC-Unique: b1IGGarsO7KTrCTNY1G7OA-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6364867fa8aso5981836d6.1 for ; Sat, 08 Jul 2023 08:00:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688828441; x=1691420441; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vo+xktwiVBdnYZNSkVaZ1jBQzqcsS/NnXCqSzqSIy/s=; b=c+0VyULGz8RbH6CdiPFiwQj/jfHKF2tjBB9wUiBdGb8tS9/bF/14WSlp8qJNcp/r5p Aq3R/MDUZwxdVJRp/GWQ0l8QwKVQoa9S/gXvQC2wZlAG79H4VkDx+FHHuALzLUWua4cf OqeAL/jMMFJe9X4IXnJ6DAhUuNz3VPvMesAPXHds0CtNFFVBZEdc5p9EeRFKCXAr1R1f bAOiVn/tOXMAvSqgtsFDGOtCDXKAzgyxtL6xOBIvbWztmQce8OBeGnja+0xBkRSxvnEa z5swQP2rzHflDDU6+72uHV1pnQVFEGua0cQf4s1MJQPB6G08cAu1iNuUZgwjzOutx0Hl CNvQ== X-Gm-Message-State: ABy/qLaFaOXAVZ9Y7rN8XXJfBZi0XhcFeGU18StXU/j/CQG3BRmera7V OcvkVqGLGQUPf5U4Rh/TYHLRwcaPeyr8lggj2P/pKcORnQFtziilPcCaHIvoKpFhNNpA2pO0YUy vKqFBQRkFUME= X-Received: by 2002:a05:6214:20cc:b0:635:da19:a67f with SMTP id 12-20020a05621420cc00b00635da19a67fmr8751531qve.1.1688828441403; Sat, 08 Jul 2023 08:00:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlFkX6m7GxhH9s94whBzq2AYzdzEBV2j5KQt1+Wi1Rfa+0O1g5J2LP1pKpldyxPAC+GVDL2kcA== X-Received: by 2002:a05:6214:20cc:b0:635:da19:a67f with SMTP id 12-20020a05621420cc00b00635da19a67fmr8751500qve.1.1688828441141; Sat, 08 Jul 2023 08:00:41 -0700 (PDT) Received: from xz-m1.local (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id e12-20020a0caa4c000000b0063627a022b0sm3467336qvb.49.2023.07.08.08.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jul 2023 08:00:40 -0700 (PDT) Date: Sat, 8 Jul 2023 11:00:38 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Brian Geffon , Christian Brauner , David Hildenbrand , Gaosheng Cui , Huang Ying , Hugh Dickins , James Houghton , "Jan Alexander Steffens (heftig)" , Jiaqi Yan , Jonathan Corbet , Kefeng Wang , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Ryan Roberts , Shuah Khan , Suleiman Souhlal , Suren Baghdasaryan , "T.J. Alumbaugh" , Yu Zhao , ZhangPeng , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 1/8] mm: make PTE_MARKER_SWAPIN_ERROR more general Message-ID: References: <20230707215540.2324998-1-axelrasmussen@google.com> <20230707215540.2324998-2-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20230707215540.2324998-2-axelrasmussen@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 5187E14001E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: w8wprfyxyodar7hrdccecmfn36x4e4bi X-HE-Tag: 1688828446-43353 X-HE-Meta: U2FsdGVkX19WdSzUPY/QC+dQHlqtyT6rk69mDwZ86J5lOrid+0dDpiSMeem+4KoKxg395F7o4QidnnDhyTWCDyFheBhg+4kja6N0aV7jXoWNK1N7y/0UNG9PHbtKSfGZJpQmlR/MI+kmECO9swaNrlofklfZDWEXKOCNtgJENBGqKVD7jrvsZ3hkv+vaXq0eMIlWriSVMhmbEZ4dRBqd/LaUC+saIAPG0ajss0HVA5pR8O+NWNoRPaRTeQIf/1A6CoNJ7nvEQoJEYtPngzc2JczH6rDhgGBGbI2A+ycE4/rxod1PvZ0wf2NeX/PRdQ/j6IzYhE5E5AUAY85hMyOqNfouVaM6nuc8Mev4CjpgPOU9pW8Ms+SB9/jw7usy+NfYoTst0X9LgMthSxYOxm6qv/B3NBYox21MvK3JxcTe+trO5Qq2UTqg6NGqmJjzclRHnUrIhb8W5BnX/4q8o7ECDr5hglIPQzMrA7wwc6JDwUsVr1C/FkhkdvEb2CCs2XeF1eLMPsqUmk41i9t3bLd2PsJQgQJuhFY+Zw/eUH7S4YtkVarmzmVbkhutgnirR5KzDHPrZWYuaKmQrMuGWlRpqIYye9JtUmZPmZN78xhOpSSIGtgygA+a0aPhaPi+UsMo/U8vPrsCq+4pSy+v32Cs3WijQFVAZLvTPRheyWSbZt4wAExnuN62L71Gtd2hD0sJEdsSRfH9J95c+z1iF0wdm5qWttMmmqXfLL9KIC361LDbk/WEMlq+mOrcQpmxHKrVs8yJvaBTFKWvMez96I5qdPM0PoOSp9snaZHdW+En2qkPuV3ew0D5S9sifc7Fh0YheqIoWYrEl30LjNRmxGp58wmIBUobYil2rin2d8kMPxsyDyyrSrPe95ZdCo1b3xEQF400lyTgxMnJ7jQ4cbLMsz3hJ6Kt1KonEhMmLB5xyHOs5xGMEH91s+UinybJZMD8AKiyEhfH96iE3IMSguc 2HfxBPtM ZUJx4C4RMM0n7WeRE62RF4U6PsORHxSNa6vidQEaqdQNrSyIvmjmIYsmLwoX+ISZDXcxpgqS7Q6xZyE7VswZ8BWmPPvGJqjTUCCP9i1QvmaUiSIpK8CUA6tWF0Y1iQ0rizBsC7ajWr58xN4YK7p82yzoydRkBpI+OL/ThbF5+xLIvaprlrznv0TVu9/4yTZiqO7MhpWu6aRw1+7tl34k1t4kURRrpDPG/X2jQzNsJ3A+jAUcHpq47G83QAmDc/PK+hZ41OddNvvMXe0dpqhQjggYYghh8HAbz/ImbZaNFEM/lLjuJ3hr1WsMU9SmNMjK+9rqYJWbyHe9toqh8LmuvWSna7KmFAIPzmr2JjyTK1m2veVirSUXhSyor+2JIVqVk4agx0lzW9XjiTTY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 07, 2023 at 02:55:33PM -0700, Axel Rasmussen wrote: > -static inline swp_entry_t make_swapin_error_entry(void) > +static inline swp_entry_t make_poisoned_swp_entry(void) > { > - return make_pte_marker_entry(PTE_MARKER_SWAPIN_ERROR); > + return make_pte_marker_entry(PTE_MARKER_POISONED); > } > > -static inline int is_swapin_error_entry(swp_entry_t entry) > +static inline int is_poisoned_swp_entry(swp_entry_t entry) > { > return is_pte_marker_entry(entry) && > - (pte_marker_get(entry) & PTE_MARKER_SWAPIN_ERROR); > + (pte_marker_get(entry) & PTE_MARKER_POISONED); > } These two can be slightly confusing when put together with hwpoison entries, so maybe it'll be good to somehow attach a "marker" inside the names: make_poisoned_marker_entry() is_pointed_marker_entry() (the old helpers didn't attach a "marker" keyword because we started with consuming a swp entry type, I think) But we can still identify easily with "hw" prefix being there or not, so it's still pretty clear at least to me. I'd say not worth a repost, so your call to keep or change, just in case a new version for other reasons. All fine here now: Acked-by: Peter Xu Thanks, -- Peter Xu