From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E966EB64D9 for ; Fri, 7 Jul 2023 20:03:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 863C66B0075; Fri, 7 Jul 2023 16:03:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8134B6B0078; Fri, 7 Jul 2023 16:03:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DAC88D0001; Fri, 7 Jul 2023 16:03:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5FC266B0075 for ; Fri, 7 Jul 2023 16:03:25 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EBF3F1C6F33 for ; Fri, 7 Jul 2023 20:03:24 +0000 (UTC) X-FDA: 80985890328.15.7AD312A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 3880E80016 for ; Fri, 7 Jul 2023 20:03:21 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lKyf77A8; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688760203; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4l5M7cRNcF+51B7hcbH/mOb7nfZ7595fttU8Ngirums=; b=zbA3/9Y1th3QfVBegyL3EpaPguitsij/CVG34A8v1xrXXQGSvhiDDj9f+l0vYP4YD/yL3t GHWjthfXHSJwPq6ryeIilZCHQOiuIH5FcJUHf+74iHEeWT/ZPlgBnn3VhCPlapPOj6SW8O JZSu6qHvALQBmS3eQF486jsvVBWDE+k= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lKyf77A8; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688760203; a=rsa-sha256; cv=none; b=C03RrhTeQov++nj9stGU+fExcDa1nKZDbqAIzf2L6xzxjnSuPV5QvwkpZzzHGu9zFZtph7 22Bjlt1OOfyfRml7uGP7/VWPRzbZSZN4QY9tfcSCyT9JG52Wf8l2dK3Y7qmbVxuwX23xac HlZn/raI4BsDNpjsRlC3ZNkFYtYgMK8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=4l5M7cRNcF+51B7hcbH/mOb7nfZ7595fttU8Ngirums=; b=lKyf77A8SIucnXsLvV29lCMVga +erHL0kpoq4uhvTYj9AKs+sTDZmUM7FRO3/fgRsAjEFFib+nqLUb/Bkc94md5J6M/cCwUu+nSsc7C bk/RFwD1w9mSySvf1E3e3LHQH36JzRI5EgiDsxDcr8TMACm2KFjoQfMlybx5oWGHJb5ZWFAHrir4m MuLONcaTgZoHH4fnQ3Lb7a31FtMZX+7DYZsV6GkbS9VAXfoBq29Wl0E1NoG1+Beaa3QDLf9yfW/Hn Nc/yby9d/7GnwsjGTFAgIbbhhGUC91oZVm91KFDKF9NYyM8K9NzqCt8Djp6zotUBFU8Y7hwHSo5G4 /0SCLz3w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qHrfe-00CJpB-Rp; Fri, 07 Jul 2023 20:03:14 +0000 Date: Fri, 7 Jul 2023 21:03:14 +0100 From: Matthew Wilcox To: Markus Elfring Cc: Suren Baghdasaryan , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, kernel-team@android.com, Andrew Morton , LKML , Axel Rasmussen , David Hildenbrand , David Rientjes , Davidlohr Bueso , Greg Thelen , Hugh Dickins , Jann Horn , Jerome Glisse , Johannes Weiner , Laurent Dufour , "Liam R. Howlett" , Lorenzo Stoakes , Michal Hocko , Michel Lespinasse , Pasha Tatashin , Peter Xu , Punit Agrawal , Shakeel Butt , Vlastimil Babka Subject: Re: [PATCH 1/2] mm: lock a vma before stack expansion Message-ID: References: <20230707043211.3682710-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 3880E80016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7qpyb85nujcefy5mrf4nyxja54o361mf X-HE-Tag: 1688760201-130860 X-HE-Meta: U2FsdGVkX19qqdw06MTXnHp6iWvxa9hCw0iabLNmC34HNgEs41oXGjvg+I280KBGKfobJqKyRmRjpVthJ6hgUE4fU51H0sIRfVKAMcWSe9AM7JaWQkNfD7I/vs6zSpiOEsK839FYJXZ/bXSEp8S5UDQH13ycvAiOereqQlyTB4q6oRXDNSES5WAz4+lerGYUCdLvd0YZ5sfhWRkieP/u/UZVGan8KILr5PFeNdtX/cjtEa1H3T9QTDDsX1mryTvB45EesAgzbv194Bl0OQYIkQ3QNEuf9BoYsI1mHPoOsH7GVRJmHf7QujO0DBKyj3oGQ+pFMGFMTTNTdI9MCmAjxfLWG1qu06r2tfAU13XRweTWFZ7SZ5myRsgfMe1opmCNpe6hWF3ZC/Vzt8jlRmhtVJWr5dqRPUQ2KWGXBHYNInlGoPfVJQytB6pS5GECzccjiJQS+crUWcQyoqkox3SaLYn8qphWF/MYyMO2MnPm5od1G12WrGUma8WpORr/08ImHtYHbCoafUypT9K38/IVaFkcxi1LdRbIHZhq8IEwSTesITtsACmBoggtRlAO1KXxNlkc+rSXWkPzKMbKd3oP6fIXQVloE+I6tUzY55yRzJ10ahufYkkRkg5e7PVSFDYZKey+tqIz2u+sfEotASHDYAFgx/0XKfeoezxxipv/vDetwR6BShlfY1oMe2tyHzJFQAI2j9+Hbm5mJPrqXsU0jGggdVzikk+ypvwfmJUGw7gF2c2/xb54WTZtECdHowCglV6nwc6os30OlG6FyMzgDERjyst01h6pzOszzZDTIL6Bir11mJHg+Gi328WYOVM6c3T1WO6HIcbqNDAKOcXhElBR8QvFxcx19IMmWashtectVeVAOC+ljnguaOlvKeo4MZnoe4kki65Nyw+MrKXtcrV5U0yg12R9OG+hwOxwOOwn9QMB8QndQ/hgvz94m9GBDtuJsZMXjZVbtWwX1oo +yhOE2me swXiAAOxSDRdRM4rniNlhITrYh/jEI6qAVgel5kymDIG3hOKo04Y3h5/1rJivDh+/SRvPpznLCwDV94BDDU45CCEm9vTtN66I8zwOGgs0zaGxNw+jDW1NLS8pBu4A7Wv56ExuUJZYokSDOPyLHXrM3h3ewLYARs1xCYi4XR07m3p0nd2skl/BZUa759Mq9OuJ9Ngo5S0BAF46vWoEikAZJ2KNR7rIK/sTH+OO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 07, 2023 at 10:00:42PM +0200, Markus Elfring wrote: > … > > write-locked to prevent page faults into the VMA being expanded. Add > > the necessary locking. > > 1. Would it a bit nicer to put the second sentence on a separate line > in such a change description? > > 2. I noticed that you put the address “stable@vger.kernel.org” > into the message field “Cc”. > Would you like to specify such a hint as a tag? > > See also: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n264 > > 3. How do you think about to add the tag “Fixes”? > > 4. Will a cover letter become helpful also for the presented small patch series? Markus, your nitpicking is not useful. Please stop.