From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C16CC001E0 for ; Fri, 7 Jul 2023 18:28:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 578556B0072; Fri, 7 Jul 2023 14:28:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 527EF6B0074; Fri, 7 Jul 2023 14:28:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EFAB8D0001; Fri, 7 Jul 2023 14:28:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2F3396B0072 for ; Fri, 7 Jul 2023 14:28:04 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F2CDA1C7FCF for ; Fri, 7 Jul 2023 18:28:03 +0000 (UTC) X-FDA: 80985650046.12.FAAAC00 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by imf01.hostedemail.com (Postfix) with ESMTP id DA9E740012 for ; Fri, 7 Jul 2023 18:27:59 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=j3geTWRk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.179 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688754479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iYQfxXiGIbONBSMq6Yza7HFvxxB0EcOOzA9wruYd9/s=; b=GgfgU1Kaw/alJBuRVporg93RkLhfUB9gmqsbNG5QGVOozpEKfz63Q1N3h5yh9lyjNF4IG2 9T3t87d567ahmKXcpyG8W63A0x48+QuRsx/RMrcDXQ2wjzcW3jIwLxnw3O8jhy14g2x3bP QlOzbCLeAvWP/K84HOl9OfEP4u/pmMU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=j3geTWRk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.179 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688754479; a=rsa-sha256; cv=none; b=mMsH7HxXzGEa8yN1G/ofc+1e2+OAKK2+h0ic3Zle2wNuZD6bOrY5yOrVHqFyvSULwBPslv Q2NmuDLWEangB5ysywY9OcKMl4ahTTyoNhOAft9YO//UO6rYLdXqRgjM/B+v4bd9wmFKRT hDbVpp7czK9Ns+0AwsoGHQ5ZkW6eXbQ= Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-39eab4bcee8so1812476b6e.0 for ; Fri, 07 Jul 2023 11:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688754479; x=1691346479; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=iYQfxXiGIbONBSMq6Yza7HFvxxB0EcOOzA9wruYd9/s=; b=j3geTWRkEi3aeiGz2BF4fSfBPYHNsjFbdUALg4Z6+wh1OZhMpmxe/qUenhsbvBmC7j yHrk29Qw2/fd222QSd/7L4e5lvCPVgiE7jHmQo3vZhwwMY5ZLYMj1UogKzNP8cKCecVd XQSML42ydPCsukuqBl2iATBWJF7vYK2eoHPL3XioEeZsm9U83H+9t46w1o/iePkULvMn ghR0Nyuna3L17isRB+Xifod3A37dAqVGRhZvZZ2GSnkZd1Fkp1+FrJ0mN9myunq1zU0c 7DtBuaWasks/8OCl45eKLTPffT2APC4cQVO8IKkIGOTZ8naNNY/joAXdt62xDiY8be+U ZfBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688754479; x=1691346479; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iYQfxXiGIbONBSMq6Yza7HFvxxB0EcOOzA9wruYd9/s=; b=GIAqPB/tdeSNVJHPXNIIXE0S+5aLNnxanr3H5BQqOD4QgINzM2lFy96q7QWgJ1FQCg rsIloU6y+oHh689e0Ymygx+d6FB91yNmRqVNFEhvVPYOnbyJkHGztRcJNcINbcZ4P8RC eEaLXFBnrb7GdwyNQoghIJiLdOfoCwyAl+hy4isd41l40gqp/qOdRo8A1wCt7zqs1sZF 5x27eNSD4S7OdSwbNwzi0OeCew3r73XA6zxnzMPRLkOYUTPXrdINY9pJ61knp9g4Tifk NpSSUWHHFK6l6Als1wsCyYNO+uAcq7CXbxFGLKeTIi4TcQMOtSdLE2cKQhd++NA4l5c4 FlUQ== X-Gm-Message-State: ABy/qLZeZc4kfHpJ4Jf90I034uZ8bME6XuGrxRElC/wO/6PYm4JgcmaO dzoF4aeSDCvQYIPmGKBDFmk= X-Google-Smtp-Source: APBJJlGyNnx65V8DrUjHW0YCJrqFGc33K7OB7NDJ9VF8y/PY5FmBu9OfcUtqWP5Qz4NxceHxptdnHQ== X-Received: by 2002:a05:6808:202a:b0:3a3:d153:2723 with SMTP id q42-20020a056808202a00b003a3d1532723mr6588090oiw.29.1688754478621; Fri, 07 Jul 2023 11:27:58 -0700 (PDT) Received: from fedora ([121.135.181.61]) by smtp.gmail.com with ESMTPSA id fe27-20020a056a002f1b00b0064d47cd117esm3189901pfb.39.2023.07.07.11.27.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 11:27:58 -0700 (PDT) Date: Sat, 8 Jul 2023 03:27:42 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: David Wysochanski Cc: David Howells , Andrew Morton , Matthew Wilcox , Linus Torvalds , Jeff Layton , Christoph Hellwig , linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org, Rohith Surabattula , Steve French , Shyam Prasad N , Dominique Martinet , Ilya Dryomov , linux-mm@kvack.org, Daire Byrne Subject: Re: [BUG mm-unstable] BUG: KASAN: use-after-free in shrink_folio_list+0x9f4/0x1ae0 Message-ID: References: <20230628104852.3391651-1-dhowells@redhat.com> <20230628104852.3391651-3-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: DA9E740012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ojo3ysepb9fhex1cdkkpz14e4oz6kfgt X-HE-Tag: 1688754479-132675 X-HE-Meta: U2FsdGVkX19xHLlCXeh1IB0dugV2BqVgvSWXgn3N/73gvE3MDPfdXPxL3ynROY4PiWknkTPpRKcmb6PDMGj/+bHOpUEK3Z1eIPdTlcym0jrKgJsGmvU50d/Kc5mbXr8WIDt1/quc/uCK5B3UuMqOQnQCobe2QazSUUsxpKdEJ6J7gVIkPGKfE6S8BA6ALVjy/upGdJrxCCGOg6uM3FCOSIBC7Sh4tlQpcfFoR09F0xz4JZXsCmIVjmnwnPJiE12QnLOK/bh837ZyZWG99b4EEUWaSHDHMvqE2s3l8vEwYU9Xj3mmMTmEm7b+Oo+XnsbpA7gNcLTVCuCkyIOxahUAfUiiPFX0WuRx0/FKan/QxutvHNrmTLEQAAv2RF9UaVyEwJdXYCxaBWf0q6OWynLoR6uYywv9qWQoj2D29MjOxuaPvXU4HdGLjlRxFXfgwo42C40PmxiLYwWhfr2JtS0RqaVgdrLupA7+YqlV0zD9lNg6crYeU0PapS7w08CZlL5becDcj+jZa9NdODEV93CGyOo5xjjhfsi9UM85Vr2fPofOo/jXEiAlYf1pIBxDBi2HTti+sUWoc+G8jYG4KwZvPidPUh/lNdktHKljvUmpj15z64ppkeUF7j5IicW57RfZcjgA/eUPQ70eEGAFmYz0NIsVcFRaV4nL93PKkdphL+ogTuRBRRi+9HvuyjW4efWZnEnlLYqzch/JWj/LXQAQhqZSi16OMIbE+SPSt/cpM7pvq4R20NCCz0KfbnIsmHy+dHRuiwTrZLkbuJfDcvu5/DXnanggNeYCV/dWx2anEnFRKJGLZOT+mcJZ4f7EbOapzq04ha1R8yZBMiHrN18UPvk/13SEJ8YxDoJ8Z2VcfjgGJIrnCX4c4h1c7W+CEVCy6DaoQ9wLtN6atSuOJP+A8Z4eO+oH+6stV05q0yaRBmaGeQXEZmQpswNTqcT+Gl3/iIRudi83tnjPGLCnrdB 0PwqliXj Oq2aA7daClCFf/OZJT4CkrS261oreG2zuG95eg9p7ErFz6RZA0JvG+gnXDjIEegMKspvPWNyvW9Iv1Wl1Lj5XE3s56ZLA7oKo20Bm14qV4N4kf2Ee1Trb9DYALlcSwJTgUG2Ve45lsSeV6WKh/GLRIrIU7KttsO6XE/HSh5fEZaBWNc8bD5+0nb6pXblfvRGZ8K20ZRGJcdodfIAT6v7gUkGApTfaPBvtKWyFx8q4Tq2phHg2pxgCxjC6OlXE1gAG3wPbZSWnBB9G8GjVV8ryHIeKGbo5h9nsOGqbbqDH0HvG05DRw3fLFBoUG0uwuwzaWxjTYlLhFv5a3NAIWUoi+UHaZlFElaM6KpX3gKnGCm7ujljkMWwoukJpdGSIbXVhFcRRL4TaRdFoAYwT9t2Pf85Adqj9BHLhMjrnKvwjpjrQ8JjdpY30a05KKvUNPhVDsuQHOCK+NOEY+xQ+F31qnNxH9JMEntTMGgLqAJL0FbU0aFOsZx7PE7X5+ClqQT9yOY+N423QUq/ugxOWKK/Rb6SsjIAyY0DxCrek21ioNziolIXz/oRRET5sFhAGQTptCtR32v1PPZnfvgfqtGuk6qkvVNOYBFYLJxgUT+JUAnI3B+yHxXWttNbiMxhJWsLRGrv/3Ec6FShX/N+y+etXpUqg10uIP6lbONOkP3UN6ys6jdk8z2Xov5W+PF4qxf5rH3tHaHN27HPDut8zFyzKmXFU61E7FChuJOJ46CTdw+cwV1ADg1VvDqezmZbNde1wTnq17M3k5v0a5w9GrHVGK87z+XuvTc1KLnrMcQdjo16djsGRP4ObE+DBSKqamnB1nnZNaUibyhA5CgWU4tb9p0cKDOTsOlz4A+xUO831gEhNeVKndBsqbl6HIzakUhF1z+Nt+ZW7WHwB8Wp7BVm+j06+0IFpVu8i6Ro9IGDbsJPQyRYqmQmmhSVEth+Twyn9uo1DPOjtRIlOADimSK/VfqplQPl2 mpFlpHVE OgfgPlC+fmFbg25feCpR/OxEmru1uRgffdHscc5qlMABczlRH7ik7g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 07, 2023 at 02:12:06PM -0400, David Wysochanski wrote: > On Fri, Jul 7, 2023 at 12:46 PM Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote: > > > > On Sat, Jul 8, 2023 at 1:39 AM Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote: > > > > > > On Wed, Jun 28, 2023 at 11:48:52AM +0100, David Howells wrote: > > > > Fscache has an optimisation by which reads from the cache are skipped until > > > > we know that (a) there's data there to be read and (b) that data isn't > > > > entirely covered by pages resident in the netfs pagecache. This is done > > > > with two flags manipulated by fscache_note_page_release(): > > > > > > > > if (... > > > > test_bit(FSCACHE_COOKIE_HAVE_DATA, &cookie->flags) && > > > > test_bit(FSCACHE_COOKIE_NO_DATA_TO_READ, &cookie->flags)) > > > > clear_bit(FSCACHE_COOKIE_NO_DATA_TO_READ, &cookie->flags); > > > > > > > > where the NO_DATA_TO_READ flag causes cachefiles_prepare_read() to indicate > > > > that netfslib should download from the server or clear the page instead. > > > > > > > > The fscache_note_page_release() function is intended to be called from > > > > ->releasepage() - but that only gets called if PG_private or PG_private_2 > > > > is set - and currently the former is at the discretion of the network > > > > filesystem and the latter is only set whilst a page is being written to the > > > > cache, so sometimes we miss clearing the optimisation. > > > > > > > > Fix this by following Willy's suggestion[1] and adding an address_space > > > > flag, AS_RELEASE_ALWAYS, that causes filemap_release_folio() to always call > > > > ->release_folio() if it's set, even if PG_private or PG_private_2 aren't > > > > set. > > > > > > > > Note that this would require folio_test_private() and page_has_private() to > > > > become more complicated. To avoid that, in the places[*] where these are > > > > used to conditionalise calls to filemap_release_folio() and > > > > try_to_release_page(), the tests are removed the those functions just > > > > jumped to unconditionally and the test is performed there. > > > > > > > > [*] There are some exceptions in vmscan.c where the check guards more than > > > > just a call to the releaser. I've added a function, folio_needs_release() > > > > to wrap all the checks for that. > > > > > > > > AS_RELEASE_ALWAYS should be set if a non-NULL cookie is obtained from > > > > fscache and cleared in ->evict_inode() before truncate_inode_pages_final() > > > > is called. > > > > > > > > Additionally, the FSCACHE_COOKIE_NO_DATA_TO_READ flag needs to be cleared > > > > and the optimisation cancelled if a cachefiles object already contains data > > > > when we open it. > > > > > > > > Fixes: 1f67e6d0b188 ("fscache: Provide a function to note the release of a page") > > > > Fixes: 047487c947e8 ("cachefiles: Implement the I/O routines") > > > > Reported-by: Rohith Surabattula > > > > Suggested-by: Matthew Wilcox > > > > Signed-off-by: David Howells > > > > > > Hi David, > > > > > > I was bisecting a use-after-free BUG on the latest mm-unstable, > > > where HEAD is 347e208de0e4 ("rmap: pass the folio to __page_check_anon_rmap()"). > > > > > > According to my bisection, this is the first bad commit. > > > Use-After-Free is triggered on reclamation path when swap is enabled. > > > > This was originally occurred during kernel compilation but > > can easily be reproduced via: > > > > stress-ng --bigheap $(nproc) > > > > > (and couldn't trigger without swap enabled) > > > > > > the config, KASAN splat, bisect log are attached. > > > hope this isn't too late :( > > > > > > > cc: Matthew Wilcox > > > > cc: Linus Torvalds > > > > cc: Steve French > > > > cc: Shyam Prasad N > > > > cc: Rohith Surabattula > > > > cc: Dave Wysochanski > > > > cc: Dominique Martinet > > > > cc: Ilya Dryomov > > > > cc: linux-cachefs@redhat.com > > > > cc: linux-cifs@vger.kernel.org > > > > cc: linux-afs@lists.infradead.org > > > > cc: v9fs-developer@lists.sourceforge.net > > > > cc: ceph-devel@vger.kernel.org > > > > cc: linux-nfs@vger.kernel.org > > > > cc: linux-fsdevel@vger.kernel.org > > > > cc: linux-mm@kvack.org > > > > --- > > > > > > > > Notes: > > > > ver #7) > > > > - Make NFS set AS_RELEASE_ALWAYS. > > > > > > > > ver #4) > > > > - Split out merging of folio_has_private()/filemap_release_folio() call > > > > pairs into a preceding patch. > > > > - Don't need to clear AS_RELEASE_ALWAYS in ->evict_inode(). > > > > > > > > ver #3) > > > > - Fixed mapping_clear_release_always() to use clear_bit() not set_bit(). > > > > - Moved a '&&' to the correct line. > > > > > > > > ver #2) > > > > - Rewrote entirely according to Willy's suggestion[1]. > > > > > > > > fs/9p/cache.c | 2 ++ > > > > fs/afs/internal.h | 2 ++ > > > > fs/cachefiles/namei.c | 2 ++ > > > > fs/ceph/cache.c | 2 ++ > > > > fs/nfs/fscache.c | 3 +++ > > > > fs/smb/client/fscache.c | 2 ++ > > > > include/linux/pagemap.h | 16 ++++++++++++++++ > > > > mm/internal.h | 5 ++++- > > > > 8 files changed, 33 insertions(+), 1 deletion(-) > > > I think myself / Daire Byrne may have already tracked this down and I > found a 1-liner that fixed a similar crash in his environment. > > Can you try this patch on top and let me know if it still crashes? > https://github.com/DaveWysochanskiRH/kernel/commit/902c990e311120179fa5de99d68364b2947b79ec Oh, it does not crash with the patch applied. Hmm, was it UAF because it references wrong field ->mapping, instead of swapper address space?