From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D33BEB64D9 for ; Fri, 7 Jul 2023 20:32:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E25EA6B0075; Fri, 7 Jul 2023 16:32:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD5A36B0078; Fri, 7 Jul 2023 16:32:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC3DB8D0001; Fri, 7 Jul 2023 16:32:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BD9D06B0075 for ; Fri, 7 Jul 2023 16:32:12 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9013780125 for ; Fri, 7 Jul 2023 20:32:12 +0000 (UTC) X-FDA: 80985962904.26.FFD5279 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 55765C0015 for ; Fri, 7 Jul 2023 20:32:09 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VaeBkhzo; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688761931; a=rsa-sha256; cv=none; b=lv0Uqg3xIJmVObrVlEGJGdoBIwD9xGBucfSvwNqx03qJ6KW6CV3QR2Wt5Gh2MSo5cZcBkR ZfYAiqwEcY4AakUGhDQL2sqSQInpPN7rzIZ22JaZakOdhKNSiDkwkrn+75RVTBZBJevdxA KKvgjME/wWNCNqW8A1IYtZanzzW8Sg0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VaeBkhzo; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688761931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P+FCa81j9ubiSAGO/SLe1juiHTz9AhiNjQZs1H2CNhM=; b=OCUoRpKuuRQbAJsZCjduj3OAqxM4SBtHhWsYT5cdaBYS94Rk1KVbH4aqrcuOKID4T3CwQf 4DvwS1tMInQofkORxZ5uvevoy2wblhkiYQ6ViwdCItdLR+IkcUflYPfiLGwBqbz5VrNLWF pNB6RYp1GeydEp8jIEiJE1R2GQDpD9E= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=P+FCa81j9ubiSAGO/SLe1juiHTz9AhiNjQZs1H2CNhM=; b=VaeBkhzojN83ipyJoaxI3rKpIN gkIatzNzoJEWjFht8ROxrPQRnc2o+1hGmyJNZLBiHXcYacL5O+Bahq8/sXBTv7BL2b5NQClJVhQEZ ckQ7iXEGATl9pHnhLZEn/OZlycP8YC24RHAwJumuKiDnsPAmXtkGyRL2mVmJ+L8mqftlxlrRqfCd3 Cxpf+778t3L3gxgRPrYyfVze/+YOS7ybq48Q9gKgBXKZj+8mhNI/QjgkaLBTXFrTRMHrcEXPQaiDe aRy/rs6xavQV6DmWHc+xruBVnYs0h66BdY9c+SAEWyyTfXPlqWHrpLe+fWO9mFS2aMcpqC60/kezq GhsADLnQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qHs79-00CKsY-NA; Fri, 07 Jul 2023 20:31:39 +0000 Date: Fri, 7 Jul 2023 21:31:39 +0100 From: Matthew Wilcox To: Jiaqi Yan Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, naoya.horiguchi@nec.com, songmuchun@bytedance.com, shy828301@gmail.com, linmiaohe@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duenwen@google.com, axelrasmussen@google.com, jthoughton@google.com Subject: Re: [PATCH v3 2/4] mm/hwpoison: check if a subpage of a hugetlb folio is raw HWPOISON Message-ID: References: <20230707201904.953262-1-jiaqiyan@google.com> <20230707201904.953262-3-jiaqiyan@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230707201904.953262-3-jiaqiyan@google.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 55765C0015 X-Stat-Signature: qkpu5gxh1mwp433w6ajhaxgsqd7gpf15 X-Rspam-User: X-HE-Tag: 1688761929-646722 X-HE-Meta: U2FsdGVkX1+znvEn1G8JMAx/KQgiaYAPg1K7PKbwUUSqEp+JdOEvke/YpncAXpF80azvbfe7PedqI85VeiWJgeUKjzfh5jiF3hAWOPKKfpDRmM6L61F4ZEbKV0HQhjlSjamwTz5bE8gxh0hy6kdxu+5pVW/uHDfZRM8rIaNjDGan2O0dyDl0kSGKJCD8SNu46dGHFMuhaY5sx6bJhm9oynPhaGKfRTsJXX8MtQiwWXcnF7gBb5zfckkVfXYZIipR7lKOXW4EVpvycXQ3GeGSCB3KSDFEtNW8FPQq0O2GYDFAClox0k/z2+yBVTWX9I4sTnKgkg6WSGDC9fttncZfG+w1XkGQy5iZOwR8+TY9ptJ0+kgX9Itwr08kl9P2VYT5LYonOBj4MhgHhx0a2C9UsFSOuLTkDzpTB8HGr5rzZSdIPwlq+7fa2b8NNcUnrJIpo3ccTDDq8zpNL7FkdzLIWoMVlNbRhX4gj0mV06g7V6HmOlW3to6HPpBtvrE/gulErdkPfqEauFK+sRpXBVBh+weXMtzJ1K/QuZatME5RAZxYmH4KcyOF/Is3rUlCLOgHJUsyXaJGDAxY3a0NsR+YE976gpOf9TeeRti7ns/7D/QhXJ4SvmJOXn1nf876LUS0EEGdAB9CcsxKeoTSI5/tjv9mbmmKM37amdG+b2GyTDEtYsSX1pDIr7hQ9l6YEWoeRSaqzOD/DntqaiHfuY7muXfZE2xjTsC+cFZs8Z0v8l4mo5LW5gRJ8gxJt8wPv82CEaHDc95kOMa7Dy2aR7CzY+ctrYLusuwQKKLAzMAu8qDwQ0FB7pHNQi3/7r0NSSTlr2la0FFo41CWmz5IpT7kXzwWpRzlSfIvzW/K1Do++Rwbgqe+QAkNA4v+2pPwH3bvhdh2vVstmkFA6NKydeE1WmqvrGH42HP4T2tfhJBuGmoCmZjFiY9bpqIOz6kYWbIgCPCFTQwEXJygSazaxC6 0kBvbtAL rdYr2Gw7KdyvVH9md4T9HTmPzVhSr2BCondEiQ//LW2gi17n7fax4l7YUouQeiri1K7xBh/xjOtcZHRzPukEz1iDpLBdchBdJ2nvXVPd1xm+MPXcrDS7u7HEXIfANgwlijrItjkIV/LAESdk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 07, 2023 at 08:19:02PM +0000, Jiaqi Yan wrote: > Add the functionality, is_raw_hwp_subpage, to tell if a subpage of a This is incorrect naming. "subpage" was needed before we had the folio concept, but it should not be used any more. We have folios and pages now. Also, abbreviating "hwpoison" as "hwp" seems like a bad idea to me. hwp is already used as an acronym by acpi, intel_pstate, some clock drivers, an ethernet driver, and a scsi driver.