From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E7DFEB64D9 for ; Fri, 7 Jul 2023 14:44:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B227D8D0003; Fri, 7 Jul 2023 10:44:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD15B8D0002; Fri, 7 Jul 2023 10:44:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 999058D0003; Fri, 7 Jul 2023 10:44:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 86FFD8D0002 for ; Fri, 7 Jul 2023 10:44:38 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2F0DDB098E for ; Fri, 7 Jul 2023 14:44:38 +0000 (UTC) X-FDA: 80985087036.10.FF25C18 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf28.hostedemail.com (Postfix) with ESMTP id E1409C0003 for ; Fri, 7 Jul 2023 14:44:35 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=gY16RP7U; dmarc=pass (policy=quarantine) header.from=suse.com; spf=none (imf28.hostedemail.com: domain of mhocko@suse.com has no SPF policy when checking 195.135.220.28) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688741076; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZVMmLaENPaM0JjXRiuX3xuMS8784Ru8KYNLD4w1UHB4=; b=J8D2UHS4IGELyp1JvBcZD5wjJuV/KUHkhkKpFY9XXhUbKtbSQUmTDfaiYh5lgSyEMmaBvf 7ynI+E524YV7v5FzCzfRFJhjfXzNnzYFl7WItcP46eQ3LRj6BlRUP32OXoGHy3nBynKkG4 FqMgobjxM22KNDYeksoucq6vTLytB94= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=gY16RP7U; dmarc=pass (policy=quarantine) header.from=suse.com; spf=none (imf28.hostedemail.com: domain of mhocko@suse.com has no SPF policy when checking 195.135.220.28) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688741076; a=rsa-sha256; cv=none; b=iOCUt2RUuU7Gnd6/iJmhDWSuGzzvM6G+EUSAFLymnrmrUuYRfQJbutdqjsyIkwF3e6RZrP nj9NwmhRrHJb/F2WumXtf+vgWm7q1OqqQ58Z/F7IJhbcpwPdQD/cv7CYlSpHxW0eqhb1Hi 47Acysph1lVQP1gZ0yXYW2rHtudW6mM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 31B5221E84; Fri, 7 Jul 2023 14:44:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1688741073; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZVMmLaENPaM0JjXRiuX3xuMS8784Ru8KYNLD4w1UHB4=; b=gY16RP7UTDxhFJM2hnrjCGu6gLgj1ACcLbJSPiViO60JctutlSt7kRGD6KBsq9dt4yCgTX 7Bjq2+UxfpV0ghSg/FJHi/C5r5ezI9TzDz3CcxXimErfiEl1gNhX9lpFEcozGWkxexZ8Wa eZ/jBuMEYFz7xH24+i+Pq8BGdrpViZY= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 10997139E0; Fri, 7 Jul 2023 14:44:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id K9bHAdEkqGTRfQAAMHmgww (envelope-from ); Fri, 07 Jul 2023 14:44:33 +0000 Date: Fri, 7 Jul 2023 16:44:32 +0200 From: Michal Hocko To: =?utf-8?B?6LS65Lit5Z2k?= Cc: minchan@kernel.org, senozhatsky@chromium.org, david@redhat.com, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [External] Re: [RFC PATCH 0/2] zram: objects charge to mem_cgroup Message-ID: References: <20230707044613.1169103-1-hezhongkun.hzk@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: E1409C0003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: f9mecmjmymuthphgxxkj86ai35tnz18f X-HE-Tag: 1688741075-150786 X-HE-Meta: U2FsdGVkX18cm7nzHU0u9/T3JxvM2mVAp1+5NJuioYYzhRqPwdhNjP8giIL4xbbaottAEXt98wmQzJxUNAmbgYrZgdsrOsffmKap2QhMjkLzbfXHcbwDC/TXmQF4scXuKP6yH9JKeM5z2+rxMoYjAsmi8HdO3qGgGZ/g9NooR7K3q6mK1H1TBm+EIcGDIYJQXiTwqaYMoa04BvooW8rsWYsjCtVw/BSoqjF+uEeF2kZKHoh2AakcgipJcHgY9USyrq3/r/nEO4M/kj74ttCL6BOjjlXZ3B5/Ivgk6gg9ai6KELYmhvZN8BzkHM9vTOyX7VZCLGETlcAi6R+wJuNtW+vAW5S86/ocEqiRdehWfUX/xwMZP7wDC9wWFbgL6Ek4F1cT6j9EEXgGEusnAnhmJK4bYkTfONpNEvM/wqXMaf7vZuTRrnzgY3LqjBHOBxnZnFF0nVm+yinm2yX/Eigkrfv073A0NLN1IAbvI6vyM29hpYj27xtt7H/i+YbIyNQhD0zrdc+ItOI8y4FGlSE6c35hPNxU2wA+C2Eg8ce3r4GD//Z9Ph7s8+EcGexof1BMkXBn7aJuo54b4EfP+J7O1VglJGBlYJJ2n3R2ope6i/aeDwB3ptZ/B3wPVK5aikMlXQTL7OyVyQ84c2Ew9XQr6r/i/c77mYeDXgorPrc2WNbkXg5FCwkDMCfBPLIi+h13jqVqCfwWPchDu6GS5++g+AV7SdMG5dtzv4pY0aUs14B7B7lc1NdaMLvseqLdWxzqIuEmcyg6B+HxBmpXdrR30RIY+7FvcMON6SUrNEv972Z2kDe2KIphKnsHdAmAIbPGzwIPQhVdQEBbCGimgIx3S86/tR8j3bkO4IRRqLgzGLfWKROyRLMAp+SLDyTFW9/Kn5aj+JGcWpVREXtginkkLQ+lXBXAlT487IC8PxX8P/QSPd1lTCq7qWXqNrb9qMalsz0X7+IDohzh96YLwxJ qbkXiZ8C zD9OeG9sl9oavzcFm2FoRfcpgzE6GXM1tK8qlVKm/v/sHlAmGMlXl7Q11n3Oz8KfDZVwkAHnHm/hAIt+TO+IkIyURLoGUVp9TWzdOc4i1n+lUB6hZuzi7V8Gfu4X2JXuRk2y2n/z+zOZgW7jdkdC28mKr0J2BY8/qr3bL1ZUbddmuk/H/vVnVYjRQJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 07-07-23 22:25:48, 贺中坤 wrote: > > Please state the objective you are trying to achieve by this patchset. > > It is always good to summarize the previous discussion and mention what > > is done differently or how previous review feedback has been addressed > > but the overall idea/purpose should be always explicit. > > > > Please elaborate more about both. > > > > Thanks for your reply. > objective： > the compressed memory of zram charge to the cgroup of the user. Why do we want/need that? > summarize the previous discussion: > [1] As I can see, Michal's concern is that the charges are going to fail > and swapout would fail. > > The indirect use of zram is in the context of PF_MEMALLOC, so > the charge must be successful. No, this was not my concern. Please read through that more carefully. My concern was that the hard limit reclaim would fail. PF_MEMALLOC will not help in that case as this is not a global reclaim path. Also let's assume you allow swapout charges to succeed similar to PF_MEMALLOC. That would mean breaching the limit in an unbounded way, no? -- Michal Hocko SUSE Labs