From: Michal Hocko <mhocko@suse.com>
To: 贺中坤 <hezhongkun.hzk@bytedance.com>
Cc: minchan@kernel.org, senozhatsky@chromium.org, david@redhat.com,
yosryahmed@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [External] Re: [RFC PATCH 0/2] zram: objects charge to mem_cgroup
Date: Fri, 7 Jul 2023 16:44:32 +0200 [thread overview]
Message-ID: <ZKgk0HfuuxsyBBXI@dhcp22.suse.cz> (raw)
In-Reply-To: <CACSyD1M9rSadO7xb8-H0dU2-xtrZnJMBgqEMTSHhE6M5vFgC-Q@mail.gmail.com>
On Fri 07-07-23 22:25:48, 贺中坤 wrote:
> > Please state the objective you are trying to achieve by this patchset.
> > It is always good to summarize the previous discussion and mention what
> > is done differently or how previous review feedback has been addressed
> > but the overall idea/purpose should be always explicit.
> >
> > Please elaborate more about both.
> >
>
> Thanks for your reply.
> objective：
> the compressed memory of zram charge to the cgroup of the user.
Why do we want/need that?
> summarize the previous discussion:
> [1] As I can see, Michal's concern is that the charges are going to fail
> and swapout would fail.
>
> The indirect use of zram is in the context of PF_MEMALLOC, so
> the charge must be successful.
No, this was not my concern. Please read through that more carefully. My
concern was that the hard limit reclaim would fail. PF_MEMALLOC will not
help in that case as this is not a global reclaim path.
Also let's assume you allow swapout charges to succeed similar to
PF_MEMALLOC. That would mean breaching the limit in an unbounded way,
no?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-07-07 14:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 4:46 Zhongkun He
2023-07-07 7:57 ` Michal Hocko
2023-07-07 14:25 ` [External] " 贺中坤
2023-07-07 14:44 ` Michal Hocko [this message]
2023-07-10 9:35 ` 贺中坤
2023-07-10 10:41 ` Michal Hocko
2023-07-10 13:16 ` 贺中坤
2023-07-10 13:34 ` Michal Hocko
2023-07-10 15:02 ` 贺中坤
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKgk0HfuuxsyBBXI@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=david@redhat.com \
--cc=hezhongkun.hzk@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox