From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10C6CEB64DA for ; Fri, 7 Jul 2023 13:42:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82C498D0005; Fri, 7 Jul 2023 09:42:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DBF98D0002; Fri, 7 Jul 2023 09:42:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A46D8D0005; Fri, 7 Jul 2023 09:42:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5D45B8D0002 for ; Fri, 7 Jul 2023 09:42:28 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0FC84C0D7B for ; Fri, 7 Jul 2023 13:42:28 +0000 (UTC) X-FDA: 80984930376.11.4F5F642 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id CBBFF40006 for ; Fri, 7 Jul 2023 13:42:25 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XdnZwQo1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688737345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vvyaqhuLF/j1Og8h3rNFyZh2EidT6aQSYdLt9GNhDDY=; b=ItwGh4hX/cZSEgw6bLh2+FIwsJqhVUXqsUBWxhlloiT839A8HVaR6b9sD6LvJNkQa4pMni Kj9TuKL1mAaa3PnKh3xfe4/GlnLZ3YjnuwI5FjgpFFEweWogPLS2oNJj5tFYtyFUnf/G4Y vP0gs/wvHb+KoSHNFmCwk0H7/1/ZkTQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XdnZwQo1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688737345; a=rsa-sha256; cv=none; b=tl3wNvV4cSr3vJgq0mHPr17MfRT3XDaOU+9MWmVFWT58s6aCBP5kapd/FIoE+1pdYaSPfy iBMhCv0bhYn+h2+zvU1NtvUqqq+ZbgKioUW+oKZp9+hOhO2brSWErGn1cD4/FU5Mv2Hv9I BmW86/7OhS7p2zeApBNCAWyct9FQado= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688737345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vvyaqhuLF/j1Og8h3rNFyZh2EidT6aQSYdLt9GNhDDY=; b=XdnZwQo1Sy4yNK3Ay/703CPRa+VMGIbMEnWxerQ56zzBusVP9v+XR9oaT7Lhr5z196n+3Z 5sYmKj72KrPXZZLs+f34NUZAVvP1JPD2XGyH7uvw8AdT2A9RnRNNsASuXNvOp7gvroOR98 BUeVmPMUPazvn5cTuJYzAuANZ1lkg+A= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-yRK4nLQ8Nzuq0jZvKepWKg-1; Fri, 07 Jul 2023 09:42:22 -0400 X-MC-Unique: yRK4nLQ8Nzuq0jZvKepWKg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-62ffa1214edso3770806d6.0 for ; Fri, 07 Jul 2023 06:42:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688737341; x=1689342141; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vvyaqhuLF/j1Og8h3rNFyZh2EidT6aQSYdLt9GNhDDY=; b=Yrh2/8I0PC93i5D2bzdFTCR2CY/uGKeWxGjumAxmJhdAXuGBY9+KxZ++EqGXpfKz0c quciHVSj3iICiR2o9Q4yozycW4nT/2zVL2CpPP25YHOFZTUzWnK1rnZYhbEOPyOZsJ0d RlDbnBrfw0ICbq5svOi2utvvKdFWHR1NkZQIklr7B+RlSwcoNlYhQFj8U0+QZ8HWfweQ 0dOVjM0o9UjnQmwk64IVJt0maQJMATDL7JTuJ9hmfPrfJxoOTKrTecxvGLlCWSXUcVKC kiR+jDfGXvMpqe+txF/OujhngUb6D5Y04V0yH+bk9GA8E/nCIYAAikz9kMeYxFlikcmO QoFg== X-Gm-Message-State: ABy/qLYa5rkK//6p8YZ2NuW5KPfaMoFpIQUzrW2/2WF2JOxD3ssQL+ad YGAJnSzqtA35vSALR/PNZUXPltyN1KUJ83XDazYobfN9JG+Jr0giG1V0s1WoCaiIQ0I8zJvCg1g VMNsLYc3sOvw= X-Received: by 2002:a05:6214:20cc:b0:61b:2111:c2e2 with SMTP id 12-20020a05621420cc00b0061b2111c2e2mr5425175qve.2.1688737341659; Fri, 07 Jul 2023 06:42:21 -0700 (PDT) X-Google-Smtp-Source: APBJJlHFH2MLUjHuHlJ0o0C1Yq4RbSkSJbn/7QaojqKFFhq0TCDBNojgWoYsFCzsCzTX8XCvxMu0gw== X-Received: by 2002:a05:6214:20cc:b0:61b:2111:c2e2 with SMTP id 12-20020a05621420cc00b0061b2111c2e2mr5425138qve.2.1688737341415; Fri, 07 Jul 2023 06:42:21 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id p8-20020a0c9a08000000b0062ffbf23c22sm2090348qvd.131.2023.07.07.06.42.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 06:42:21 -0700 (PDT) Date: Fri, 7 Jul 2023 09:42:17 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Brian Geffon , Christian Brauner , David Hildenbrand , Gaosheng Cui , Huang Ying , Hugh Dickins , James Houghton , "Jan Alexander Steffens (heftig)" , Jiaqi Yan , Jonathan Corbet , Kefeng Wang , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Ryan Roberts , Shuah Khan , Suleiman Souhlal , Suren Baghdasaryan , "T.J. Alumbaugh" , Yu Zhao , ZhangPeng , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 7/8] selftests/mm: refactor uffd_poll_thread to allow custom fault handlers Message-ID: References: <20230706225037.1164380-1-axelrasmussen@google.com> <20230706225037.1164380-8-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20230706225037.1164380-8-axelrasmussen@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CBBFF40006 X-Stat-Signature: f7jzs8a8cgxd6ryi799npuc8waxo1xhr X-HE-Tag: 1688737345-358552 X-HE-Meta: U2FsdGVkX19tW3b66Ze4u6kiHX/n8nKrcewu0z8LU42LLe4R0oAQCwZUsqTFPa685GfrRnwxzRtUYdYgIcOdBGEbQRQYIcMi/3+wzR7AmlYq54Xm7qKhSy/UVmoFVSzU4Y2cOZCi0ciPIVrdtM/Nk7T5NhpAulpyDVFJINNkBp8XBYMbJM4CwnkI6iRaWuwF+9a5KALmpoZH3imLSYYb8uATBCZpxqOEcVsiXzYK0nPjOZYvhwrwWid9o1T3J9BiJTe241NLiQ8Bz2RmenLM6LUAmkWiolZI2tMx7tLn+Ch8k/ob5SOQDYvav+AClsR/ndwjFIoy3kTJYuZHqtCC7eJj8GlD3kNOGbkVWvd5fP+IIfdBEgOpJCzjusPEwFDnksG8qppZ8/+RPvZWjH1QDu71En0I0vdlu4BKW3UsdD3Nz0qrL5RbaSGzAdja4Oj67Nkbc6O6GKuiZM8UWNVoBmy9j5UZ5Q7B9rVL0Q5W9jeKHLxquLV07FVh/0Hn4PUy4G5Z4MSF8W29pnrKO7r+hRoK2fpb9bL+iuqXDkbrf4nu25HHrdT46CEfxtT4BQ/uMHuePdOHyBGGR3ChWkC9Jxp9OiV7R1sXmB8q7iUEubu2BymuYB+zsRfUtaqri9PE1lOdTzjTdexddTDKYOA4YzgIsFscVC6Q3IALW+NzYzjyPdQNO3P8sEuZSxio1OcSLHa7K8a3yPPY+U/oNVXCA3MmXR9rXELAFtNbVCGFnZIEH1HJlqYhtG1M6VEgEel+XuSqBzKsyVX/FfljlfpUPaysktBSiDgH42ekwIrsTDvhdbMrJuoLYgNwx5qt0uyDeM19RSMBk+3oep/BRkaHAzzMAIyR/NULek7UhC6qUCn9IyyfVXi1ll2bkRyZFcsa+RkIsZgEavQ3eH1ArzmWb1ZrypxyhyxpsoSxHU54DliEFOwo5E2OLUeKslLYvZrdMnCG1e9OoAwsepM9MY0 Rz8JCVyP rhE8g3Xk2kcexSc87azvT3PrW4DkvzrFgYXHvqb2LZEiHa7BokbiNIhRKNMG7J+BG5WPYrVsvwJ9V5q3WOFhGDvsrBvr1UQvhJaAfZeZEnRFSrGOJ9zbkMMORM1a127+ljJa7xzGvrJS/TDDUUK6IJTYfWOkA9/jK7c5hYA540YhSzcEaVzxm8Kxr+6wjdFjGrbfdZfCUUytxXbUc1RBfKpq0CwwNiHv8EGU0STa3I0MRB2WdWje+XAAYZkZh1cKwgJo5Y/IXafy263pZdHAL7NtPuQ848eiE/zhBwQqlOVXAX5zTH8mvV11alLSr9uBHcj4864IZyA6y3f8cj3lbI6dX4HQ9BhMQd1X62s+pSmgYeEKToG5Byna/7PeytpoQqtA882CQMThLpB1T/BbQ5F/E+NIe1Q9RqDkArCJhEguEDopi7qnSKXElrw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 06, 2023 at 03:50:35PM -0700, Axel Rasmussen wrote: > @@ -247,9 +245,13 @@ static int userfaultfd_stress(void) > { > void *area; > unsigned long nr; > - struct uffd_args args[nr_cpus]; > + struct uffd_args *args; > uint64_t mem_size = nr_pages * page_size; > > + args = calloc(nr_cpus, sizeof(struct uffd_args)); > + if (!args) > + err("allocating args array failed"); This is trivial, but I think I requested a "free" (or keep it allocate on stack) in previous version but it didn't get a response on why we cannot and it kept going.. could you help explain? -- Peter Xu