From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C9AFEB64D9 for ; Fri, 7 Jul 2023 13:15:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB3F56B0074; Fri, 7 Jul 2023 09:15:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3CBB6B0075; Fri, 7 Jul 2023 09:15:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8E706B0078; Fri, 7 Jul 2023 09:15:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A25896B0074 for ; Fri, 7 Jul 2023 09:15:57 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 78EC21C7C8E for ; Fri, 7 Jul 2023 13:15:57 +0000 (UTC) X-FDA: 80984863554.19.77C4AD7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 51A5940025 for ; Fri, 7 Jul 2023 13:15:51 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XKz+z5z+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688735751; a=rsa-sha256; cv=none; b=hSjk4ZGjO//z6yz+nr8//VJfSFjhi6jQXzxjXtaQFMA2AVglJYy5+0dl2Kp3IN+q4JKcjo 4kPXI635bNgdS6NKQwCITTnNMyEHjZ3faq3BUIBk/ieUZJlvFqiIhkxeUgrIYB6m2Ehb5Y 6wuQr+I9/io28vgSQsx6gJte80VebfI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XKz+z5z+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688735751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/scmW41nRLEVCcvmVFRaHD3MznC8NV7fH9vmMT3xxpU=; b=CI5YSztsBGt4a1iinykc9soJw9Z4IU273lWc50qdqC8wBgoOlj6t9Algfp51hEYxggt1Hk IbDltgnswfgfP7bK+xhvlKVFoSZ+O3JznBndtMfWP7g7YGzscFz308XDaHCqleBCcXliVn tQ1fENjm8lq/rU3Gd8I7ILVOGcUPsvA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688735750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/scmW41nRLEVCcvmVFRaHD3MznC8NV7fH9vmMT3xxpU=; b=XKz+z5z+XaIBEKxFucvEi7DBUwmuvpqt4f3Bd/5X/j5dqZc23qSfkFJX9hDeC6wk67KOlQ EaELiesjnetegZnBmi7O7GOGJpMVkggoK46SBEWk9oXXpCOD5RtFOWal5DNRh1mn7v7PIi N5oJxzHfj4YA2JHNYOPvr5RoIkxrhCY= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-499-8gn-NvquN6iF5CuE4BFjAw-1; Fri, 07 Jul 2023 09:15:49 -0400 X-MC-Unique: 8gn-NvquN6iF5CuE4BFjAw-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-76716078e78so38626485a.1 for ; Fri, 07 Jul 2023 06:15:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688735749; x=1689340549; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/scmW41nRLEVCcvmVFRaHD3MznC8NV7fH9vmMT3xxpU=; b=DY0KgzURR8utgkZYCn6UKwVvjr5LbnZ0GCVIxlCmIi/T+PIHeJ4LmI9/vCFTODab79 FbOD0r75Ei58gSop+mnYw8jNVdvXuxJhWF3bRbVugp64G+TDL1rKSOcUD+Wpp0glVKAe 25xSRt3/r6QGBuknNoXLsSFQW5DUYTQD+CTjwEEnrFJ3hmPWHV3KWEtH33Ud2esdQweo TbGcUrgD+kuJPkyo7bsj4LavE08l3fHXi6Wvu8nE4Yuf0r9YF1hye5Fg/8GLKBR3fM/f JwRgObZe3uc6T6Kz9G1TP6OuVebzlUHswXLHgU1euk9K8KgJsZ9WKnvZomQjTY7+dHGQ cnIQ== X-Gm-Message-State: ABy/qLbGUMp8XPUA5HcW/gUqm6B5doNdQwWba7QUJZlmFrEzBn7T6jFg 0tadTGaDhsdavwZmV9yQ3bIPtg9+gMumZ1ZUdVpUSJMHp1GoqeNZ1lZJEFiD6ls6ay5BbYJkKmw iwkWuOWZ0dT0= X-Received: by 2002:a05:620a:1908:b0:765:a957:f526 with SMTP id bj8-20020a05620a190800b00765a957f526mr5626670qkb.3.1688735748814; Fri, 07 Jul 2023 06:15:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlHGcT7o9U4nGwCRjHqy1oj78ajsK+fO3PKeth2RE5DnD0ZtdR5yHIs+kzadtUDYBH9DWM2VOg== X-Received: by 2002:a05:620a:1908:b0:765:a957:f526 with SMTP id bj8-20020a05620a190800b00765a957f526mr5626622qkb.3.1688735748545; Fri, 07 Jul 2023 06:15:48 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id c11-20020ae9e20b000000b0075cebaa1540sm1797911qkc.58.2023.07.07.06.15.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 06:15:48 -0700 (PDT) Date: Fri, 7 Jul 2023 09:15:44 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Brian Geffon , Christian Brauner , David Hildenbrand , Gaosheng Cui , Huang Ying , Hugh Dickins , James Houghton , "Jan Alexander Steffens (heftig)" , Jiaqi Yan , Jonathan Corbet , Kefeng Wang , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Ryan Roberts , Shuah Khan , Suleiman Souhlal , Suren Baghdasaryan , "T.J. Alumbaugh" , Yu Zhao , ZhangPeng , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 3/8] mm: userfaultfd: extract file size check out into a helper Message-ID: References: <20230706225037.1164380-1-axelrasmussen@google.com> <20230706225037.1164380-4-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20230706225037.1164380-4-axelrasmussen@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 51A5940025 X-Stat-Signature: 13ahhabwywf6rcricmbj58i3191dyifr X-HE-Tag: 1688735751-915728 X-HE-Meta: U2FsdGVkX1/PWQ67JLK98zxbfGB1xSnpL0MH7yoWhMAa8xCfLd9tdMxvXsd/ywN8rZiDIQofWNps+gsYfHR1PGKwLhrIvXiIZB8RoVUYFgCBkKhp35L5oXW27XHHlhuV3c5yRcOKI0qRFUaCpS0Ut6ELzoaScXieWpTMVYsC2WbMD5qAk/w7xez4mypPnS2EypdrLzCcKOrmQFMcTNnAFWJYjOoGd3gAeYwSH+OetWaylKDug0S5wNkiwruBVcnKyNFSDVibVtBOyZSI96R2+ag71rRP+H+giI+Q73918bo3UkQ8n5jnkO0CHfGWgwfEd4O2amQY3ZvxmsYNDDjjUsaQHre3fk8wym8HqMH91Ne2dYCjAAWFcwBx6QQPH06JVCDC9FQqkfz6nbriJ+dMsZVJhQXqYO7Ja+W0znr0hQDBZM+uM7Dvg4Is5t9tZ1PW4J5rYt8b6335Uum5DUARqMboSk+9F6xD9X8KbInACyId/RoTnFKsthN0fxU+OLuKZkXL53Typ/WBD5bJ9r5WgBJXXQKhdVT0eogHreQ6HV3YX15RR0dLt/Mz3roqt0k+X0tHu1yAsECq1mOesfTMCeOBi5vYUpK/erycLAtHdWIrPRXKC72VXP5vwwX88Qq7nTXXePC+WRny/yARkxTerwSPNs8pz514JXIue99UXV6mekQPRuKiPwWGj3VdUdUO4VCv4PYVcJ1tr0f58KLbcZPjrHpIIiGLc4kPnoXcCrxobcheoMUtfjx5yhZDHnIDdl7q4LRKgFOcZtHg4OP3emsJ8fXnGvmWBtj4OXrDSY0qeaEhVPS6kwn7/EG1LxaOIMukQJWQ0IEnesjJnXJosyo69VWznmNUVoaM4/1I3nVPzb4e8ftCKSYiKPCcaDNEjm4CMtNrrUG+G6f3DHBZS3Iu2eK0htS3CuMwitv30vyKeTmtGAqUzbxT57C8fxy9//INbgambkHmItg2Phb WOiiH9e6 WIz0myKAK7BuVz0MAZBc2VRsF1Guf0u762piG7VbIVb9UrTvFxptndqle9bXW6FBlbivQ0S9c5RxVOmpl3mHm1ayYhdXbgjQ0EXZrf/UvW9Z7475rIltiWbOfZ7/YM2aoxJjIaTZxnRVwe4ElfjNResXz3RgyMA1EVxsHvgPKyYpYRhGwccUA2YtU94o7bnsODvB/e/5vAzB33cwQRqfxj/D4m90c6f+2zu5Jribhz49jq9qN/ij9jXRwZ09R8MEpQSp3e0zliBo7cDV9oteXMjgqNlPXkf0DoTemFXUBqQfZnVNuZvCb7iWO4nvP2vr3fWnrO/Gm4rJZKeQFZ39eQ7W9gkTDhp8b9y14FwITvhdoKgd6yxXQVpgcB4IhEuLRSv3VuUQK91CXU6WU2oIUZHK3lnk1c1sS1eU/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 06, 2023 at 03:50:31PM -0700, Axel Rasmussen wrote: > This code is already duplicated twice, and UFFDIO_POISON will do the > same check a third time. So, it's worth extracting into a helper to save > repetitive lines of code. > > Signed-off-by: Axel Rasmussen Reviewed-by: Peter Xu -- Peter Xu