From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39403EB64D9 for ; Fri, 7 Jul 2023 13:11:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32E876B0072; Fri, 7 Jul 2023 09:11:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DD508D0002; Fri, 7 Jul 2023 09:11:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17D8D8D0001; Fri, 7 Jul 2023 09:11:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 083376B0072 for ; Fri, 7 Jul 2023 09:11:00 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C6C84B0901 for ; Fri, 7 Jul 2023 13:10:59 +0000 (UTC) X-FDA: 80984851038.06.B33935E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 37F2F12004B for ; Fri, 7 Jul 2023 13:10:48 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IPVmheJh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688735449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t1O9zb5GHKVELS5klWqCpQjcxJWJEqyoSLzfvfMUZe4=; b=jcwTlCA3pKNhNX3IUa6lpsMM29x2fCyKvUrvBbZOmXH3/di+5ewcSflgCh5PCh9XmMJRYI xXuMZ30RVhMvvrFimyVoV6zQq9D2I/K2woGaeJWr2yiQJ2ArcGTmAUZNYDoxuQ+Rf1YWOA bbfTLR0ak5LX8IZ3y+WLQAwXijYe/7U= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IPVmheJh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688735449; a=rsa-sha256; cv=none; b=Wcd8haStrrooVQ6vEtYAsY3zGiwE6cZxobTWbzlIeAbu46T8M3AzP5X+S+HGtKDQIn8Alq N15p7+/Po9wMiM8D2sO2ERrBEdsti/UJOrN0sDo+rawS7LGSKz3KQo+rBznZ048i8MMTNR KN1l0oX2yQVJCm96NYVBBsp9yw5VzLQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688735447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t1O9zb5GHKVELS5klWqCpQjcxJWJEqyoSLzfvfMUZe4=; b=IPVmheJhCCKUHKd9txEYGUD3L9+nQPE1buhinmMRm53xZ/UZbAkkl7bLzDNlaRgmAF5IGE dl0B8Vql5T9DVEZAspQeKrsa0cxjr92vqOiOrlp/74JnIpgjC+17aLHzAE8hmb+rzjRVwU JwaqZYKgyj/svQrVqBbY7+AWpduE7/E= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-kBnKOyBlMjWLCHJTQZWENg-1; Fri, 07 Jul 2023 09:10:45 -0400 X-MC-Unique: kBnKOyBlMjWLCHJTQZWENg-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-63656624620so4001436d6.0 for ; Fri, 07 Jul 2023 06:10:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688735444; x=1691327444; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t1O9zb5GHKVELS5klWqCpQjcxJWJEqyoSLzfvfMUZe4=; b=IxCoQ6WHmuqqzONabkpHaD7Nlw0HrWb2zMfw/hk7+2VTKbvlj3ZlNuMex+KjFPP1YP UKKdc9SwwSJ7obVEcfzq6EecrncHhhpSrVkNCImgSv6cpxddI6myRetguxZh1cAmCux9 gxvOQZsVclEjuasuW7f64VF77OF1KwDsAMwohMv2r7z0AnhvD8U7rRSHqu1mcpfyzF5V ltfg5r+KyLoBn+blbbTm5TZktOiwYZRywTsoyXzFDD8HQjK4u1fEV38l/NFkDYdSN/Oq IxfodLcIjeyhRVEoPqIkSrSLXoxQymiGw7f2PSnZ1k4UXF9yx5lGbEG5RO35wVY+q72V x0ew== X-Gm-Message-State: ABy/qLZTM2GgSz1Ei2JEFEOHcT+976t5MiUiI+0UBZ+g+Bi6dtHnmFMW u0NIP0kVBbsVSnjuFCbK423PCPZ3/fE30ht4mLmqRJXCy+OI46bcG6AHYBkk8vBLHxmka6kmb5S HweohFAwceKI= X-Received: by 2002:a05:6214:b65:b0:634:cdae:9941 with SMTP id ey5-20020a0562140b6500b00634cdae9941mr5244177qvb.0.1688735444341; Fri, 07 Jul 2023 06:10:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlFcMXIEnO4pEK4x9rJYrWIuHjnwN+qpj3mBxRaYTRfLT3AgJiKgGQJyC0v2TXCl9WOzVHERgw== X-Received: by 2002:a05:6214:b65:b0:634:cdae:9941 with SMTP id ey5-20020a0562140b6500b00634cdae9941mr5244120qvb.0.1688735443971; Fri, 07 Jul 2023 06:10:43 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id p8-20020a0ce188000000b0063757aea986sm2066436qvl.28.2023.07.07.06.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 06:10:43 -0700 (PDT) Date: Fri, 7 Jul 2023 09:10:28 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Brian Geffon , Christian Brauner , David Hildenbrand , Gaosheng Cui , Huang Ying , Hugh Dickins , James Houghton , "Jan Alexander Steffens (heftig)" , Jiaqi Yan , Jonathan Corbet , Kefeng Wang , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Ryan Roberts , Shuah Khan , Suleiman Souhlal , Suren Baghdasaryan , "T.J. Alumbaugh" , Yu Zhao , ZhangPeng , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 1/8] mm: make PTE_MARKER_SWAPIN_ERROR more general Message-ID: References: <20230706225037.1164380-1-axelrasmussen@google.com> <20230706225037.1164380-2-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20230706225037.1164380-2-axelrasmussen@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 37F2F12004B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: hfz13emjh1sth7s4jh4tqk6ahedqkhnp X-HE-Tag: 1688735448-439948 X-HE-Meta: U2FsdGVkX19w8l3cSPUhbPURkOWyL2aumQAz7UyKl0eBrxMO5s8sYi/zRKHZLiM7MUq2/mb+uIOFLvvingIrrBUldTQHBgdcwLp0Z9vTmFzJvdoGZ8mvfLsSeTtlBsCQp0YHEKE5oPV/5ZXLKoZoCDri8jbERliwcRh5jWI2s5JRSz6CnrgKGI8qq/Y0vCxr2X6H3ti307o5H4Nde/eW5wFOSC5qS+fNpnCoSIKtikdvrs+zJkVHqS8AgSNe80yzGbaMDipO9CWq/m0YTpP3q8shUPEYicfFgISM9Du06eGp73kPBgMX9S1NWHYgoXQwIPNr2ZCQLj3nnW45DIMXj7+ZChNF/Vtca7rOZ8Ktxmq2apYHjqwuEKJKgnpuSMsDhZ0OMZUVR5LawfvWMa16eYOHsWmde7flvl3N3k46TR/vnQdalhgtRNKSxlss9LUQLKYYOWqiEnlbY3o4ygZQvg2AHZF0ssqICyCLwcvoWARHSluOXTVse4XLucfnM9izOC9d2Pa73+w3ju9MiAvRW3xhj/Z6DFjZ5Xluz4K/3m2kRA0ZidQTMgsVuafN2xr8ljWbAwzYAxkYAmQVOOSV54EKFUMMSw4Cz50FjytzXex2KQO5mbbBoaDW79vE4yXsnOsIy7no4kf1fvOBgCr2zBwLiI7MDwMNoLilgzZ7j7KRWWIjJ+225/AOGKzVWyDI5jYofljTSLABK8pbng7XKXYV/g3pgVqzcijoblIkTYfo14mujKIVMgWPLniNDPil1mbweG4vHpj0mtfjWX1hb/gVOOs6DT1jh2s2iXPvWDRQgxvFb0ogB9ApxwOxiFz7Z0BvcSwlUzMUk4by/K6RZV0S1Rd0RNOp7gQfZvyf6bynQrLCngp7Qq8XiT5YZa/aVAWqlTGM1RHbtbFIqTfo9dTc86zwEFlGQim8/VptBa4phD3UgEV7rH7xl0dFPOWiRG7RYg0T/iffuQLNQm2 DQQ5myrx o8Z84qvYqChjeCSSWnwuCcp238hQ/DGcpCtf5xu4yOjXTaGad23F25jduJinqaY34TYUxBMUGcqOGqkEqMwPJ7WY8ITVBUlnXbKSoTcOr2Hctjuhh3JTbxYa4GjPqM64BUrNe0JMAk7Flj34QEagKNuVj7ntcQ9GMaZH5sbwjZnCNUWeG78CQD6s1n2GMamKvW7nluKIwD7rQEZP8suJsGMRZwcM3Ry56AZa1foxTkwkJ986nLnH6wfp4u9scclood+aJX8Mr+nosnZ9TA5HRad4K/BVvMsHiCjdsthUBBWGj1PCWqe8/P7UFQXOTsO7CXBOjHVXAPn70dIdOHTnP4gtnMA9T5itGOL4z2sLP3Nvhd3HmVcGhCZDPk8YaDjuTj8kn0Hhbk/sC170ljKtPGKh/DLXLb8+jOedb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 06, 2023 at 03:50:29PM -0700, Axel Rasmussen wrote: > diff --git a/mm/madvise.c b/mm/madvise.c > index 886f06066622..59e954586e2a 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -660,7 +660,7 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, > free_swap_and_cache(entry); > pte_clear_not_present_full(mm, addr, pte, tlb->fullmm); > } else if (is_hwpoison_entry(entry) || > - is_swapin_error_entry(entry)) { > + is_error_swp_entry(entry)) { is_error_swp_entry() made me think whether we should call this marker as ERROR at all - it's too generic, is_error_swp_entry() can be easily read as "this swap entry is not legal". Can we come up with a less generic one? PTE_MARKER_PAGE_POISONED / PTE_MARKER_POISONED / PTE_MARKER_PAGE_ERR / ...? We do use poisoned only in real bad physical pages before, but I think we can still keep using it when applying it to a pte. I think it's fine to call a pte poisoned if it's not legal to access, just like a poisoned page. > pte_clear_not_present_full(mm, addr, pte, tlb->fullmm); > } > continue; The code change across the whole patch look good to me otherwise, thanks. -- Peter Xu