From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2623EB64D9 for ; Fri, 7 Jul 2023 07:57:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 441018D0002; Fri, 7 Jul 2023 03:57:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F0B28D0001; Fri, 7 Jul 2023 03:57:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DFB18D0002; Fri, 7 Jul 2023 03:57:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1E9568D0001 for ; Fri, 7 Jul 2023 03:57:14 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B22211A0D0F for ; Fri, 7 Jul 2023 07:57:13 +0000 (UTC) X-FDA: 80984060346.15.D50468F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf03.hostedemail.com (Postfix) with ESMTP id A7B0C20012 for ; Fri, 7 Jul 2023 07:57:11 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=WYaR6N2i; dmarc=pass (policy=quarantine) header.from=suse.com; spf=none (imf03.hostedemail.com: domain of mhocko@suse.com has no SPF policy when checking 195.135.220.29) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688716631; a=rsa-sha256; cv=none; b=RebZXwtkXy4FG9vvU3zSxT2XYdQ+vc4K+qrgTeY0+ZfILbhP6RJZp41TCDd3jDHMiwxh5O yamopI6TW/uUIiligNtytugrmurwwx8uyQsorLeRRq1CET5c0QhLl5PfjVH1VyN2sZ2Z76 R9U/poYPFqsp8pJt/5TZPVtv9JYn4B8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=WYaR6N2i; dmarc=pass (policy=quarantine) header.from=suse.com; spf=none (imf03.hostedemail.com: domain of mhocko@suse.com has no SPF policy when checking 195.135.220.29) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688716631; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5oXGl2RHh2utP9BKE007mSj04cSpxSVlQJRSnyPwfww=; b=UvNphLdDcv9kE/WoIJR+LOQSUyKWlLv1qyLs+VM+lZ6daXFEcBnaiZCXMORMF20d8sC6Vo DMoCkf0rheq98mLmU9fHH1wlFmWOsdheucJ+PPyp2M1nH7ORP/0Or9E50QKX2wbxojuTDD CFhLOEy26mZLy2exZ/z/9fvCuxoNvhw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3521F1FE78; Fri, 7 Jul 2023 07:57:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1688716630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5oXGl2RHh2utP9BKE007mSj04cSpxSVlQJRSnyPwfww=; b=WYaR6N2ihFi/ZHF15scZpNz3dh5DqmBlK27ioXRU/7+XWRQexLVE0s7yg9okn+VVmSSAAD AgK9o+DJ6yZas752PSgB33VwAAHt8Il01N9tjeHswZzzn97ofZD7QXI2q1eXTwM51KWExu wzQbKSKrAySBjGOcH7avBeHPgpL0iMw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1905C139E0; Fri, 7 Jul 2023 07:57:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6P/HAlbFp2TYKwAAMHmgww (envelope-from ); Fri, 07 Jul 2023 07:57:10 +0000 Date: Fri, 7 Jul 2023 09:57:09 +0200 From: Michal Hocko To: Zhongkun He Cc: minchan@kernel.org, senozhatsky@chromium.org, david@redhat.com, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/2] zram: objects charge to mem_cgroup Message-ID: References: <20230707044613.1169103-1-hezhongkun.hzk@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230707044613.1169103-1-hezhongkun.hzk@bytedance.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A7B0C20012 X-Stat-Signature: apos5aes6u6j14cg3o6p3f3hx9o3ngbf X-HE-Tag: 1688716631-222528 X-HE-Meta: U2FsdGVkX1/hP8QKfWeHQmHzWRVnvZQRXqE2XXpLJOKWXYK3EYPueCzlO6/m+TbUnEcHVz7EPWqCoR8HGnjPoxYliS01fTgFThUqUP1b9qSNOEnJmApJmvqRVU39lnWtCKfvAPwitBK5RNqGHIphKSGSU0/iVYHGyEbpm9GEWTwLD1ySDHhkfXLLJ35YdWVxGjkKq03QeP3e4/pyauDBcsR57+0lDUzaf5NxeKd8a+JrTohH4ZhenRoDosEOwy/GgENFP/phes0Cm76mOqZD7yqhZiCq/1ngrQKgqM8YgJ1sVsgFN+knFiLC6lrOYeSMQx9LV7QhThiIg9avbhekFd71RMMxa98ZCQBTLP2j3gU1UaO72u2dHekwg/gBNOfSGeMi1fP60UgWUuiLxbuJzo0cFXjkpjSCdWEl1+IFNWueM5G3F+reKymtCpwujyHoZqnhKi+Whea6NpIt8N9D4odbi37mZbadNoYD1cxEIY2Nxmf/ZPCCjVYUqDoWvBXSPOy6x8Bh4MXTTxaKCbU0ZyqlLGgPtC4o1TeiYe2sEOWvbermHPpMxhWRI78yy7aQS/vNlFTZ2T/kIW64mN5hZ+4eMyVhC4jTdeBbKQU1AuIBCYj+Ur4FdelkRQun8r4T/WMFlqhjPfyLFylBUqLyBUR946bVbL4GeFyYrslbG77ZO4ZCO1PNhQOEw6tg5ir9opPYkLIvlr8kkDGRa5cKCY72cYCFHeRQ2jZNXbJJxfO5DIEU3eFwAl4XvLscrWhdb/oj75FSTEkTsG9V8iLAfemYvPC6uNiOFBEf5luGYeoRm15m5fAOcpf2+XCAimXztktV0dmLlauLy/bdRaWC+GRRhw6q75YtwP/JETSVeX+x8MCQu5X7LdWTRh1W6uHu5KI8WbrgbDNHl0YOgBxyTOHWzVnbMb4zGo28VonyhzorPxSbelK3qDsqxoTyf/4LR0KWgcb//bVgRSdfQAq m1rEh22s teMiPZ0M7m3xGvtIINH9jqSA4Z2jKF5WO0sFhzKxLz0ssUVznXfhr7ylUpPkN/8fDZ2DiN9bIDXtrqBKoZow9aKPa9sQOhoyeD9Snj/I/YEShZgz01j54a6Cfj3F1IHhSpEWEM2jcEs2nB1f2zl1o6/1WtT3GC+auplIKCOQIzicWQjZUIyKqpPJ2Kzr9RSKOEk2+QLivnyrgi8ZxQuRBbCjcaZHqmK71fYa4eP19HnS2UsfOnvIE2Sx52jEOXKGaGNzDgrrkxNlsIB3hPggpdrBxvseIR7GA6MnUaNRDLriKdjg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 07-07-23 12:46:13, Zhongkun He wrote: > This is a new solution to charge ZRAM objects,more simple than > previous one[1],The compressed RAM is currently charged to > kernel,not to any memory cgroup. > > As we know, zram can be used in two ways, direct and > indirect, this patchset can charge memory in both cases. > Direct zram usage by process within a cgroup will fail > to charge if there is no memory. Indirect zram usage by > process within a cgroup via swap in PF_MEMALLOC context, > will charge successfully. Please state the objective you are trying to achieve by this patchset. It is always good to summarize the previous discussion and mention what is done differently or how previous review feedback has been addressed but the overall idea/purpose should be always explicit. Please elaborate more about both. > [1] > https://lore.kernel.org/all/20230615034830.1361853-1-hezhongkun.hzk@bytedance.com/ > > Zhongkun He (2): > memcg: Add support for zram object charge > zram: charge the compressed RAM to the page's memcgroup > > drivers/block/zram/zram_drv.c | 43 +++++++++++++++++++++++++++++++++++ > drivers/block/zram/zram_drv.h | 1 + > include/linux/memcontrol.h | 10 ++++++++ > mm/memcontrol.c | 23 +++++++++++++++++++ > 4 files changed, 77 insertions(+) > > -- > 2.25.1 -- Michal Hocko SUSE Labs