From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C06EB64D9 for ; Fri, 7 Jul 2023 11:29:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01F4E8D0003; Fri, 7 Jul 2023 07:29:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F380F8D0001; Fri, 7 Jul 2023 07:29:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E001F8D0003; Fri, 7 Jul 2023 07:29:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D26478D0001 for ; Fri, 7 Jul 2023 07:29:15 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 987E4B024F for ; Fri, 7 Jul 2023 11:29:15 +0000 (UTC) X-FDA: 80984594670.15.ECF380B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id DAC67100017 for ; Fri, 7 Jul 2023 11:29:12 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=W8BupQP6; spf=none (imf05.hostedemail.com: domain of BATV+5a4ca43f00c3395d7048+7257+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5a4ca43f00c3395d7048+7257+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688729353; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RUfYUy8/J6JDn9FoGNDP036sYhvQ7qr7NPrif4Grdk0=; b=NYKAt5+W2dd/BgdwzBqsCNqFmzyw45TzRcc7D0Qg6ra45ZOKJ4kEdtjhVnDGzbGaM0Nj+W I5W+GbJa3HZYHy6B5ibfuXmNXPoMsoPoxdyd60hOtRDcm5wQ+nLoGl+dfMdGMCZqYm4vPl 2tpVhUdfnSaZITE+NXZKCSleO6Q8ego= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688729353; a=rsa-sha256; cv=none; b=0gpyl3PIFyUP31E7Uyxh5oQbbssn6hux3uJuTzdkFYAaLmlHag6yJnsakYpVLLAyAdZwud 8SV0dUUNPrNvjzFl08QVW6/4p3MOnXBpjCf6WMdU/blwABPn6dJNymas2ACWdLTnkn1yWe iPapijXmqDHu7iWPk1iPg5R+LXrR/ls= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=W8BupQP6; spf=none (imf05.hostedemail.com: domain of BATV+5a4ca43f00c3395d7048+7257+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5a4ca43f00c3395d7048+7257+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RUfYUy8/J6JDn9FoGNDP036sYhvQ7qr7NPrif4Grdk0=; b=W8BupQP6fTnw1maVtPw7n0FTsE YYE/luqofOMT0IhbP2TwnItjey780Gaej+IMiW55ud+2XaULxiO0l44TVjXxHDze0xRAuH+mluyhr 7ui49FHiGFXBu/ov7yuPVdyKZ6eJKL+3QsdTV3Gb1KlNN/rv7nlB69UacHrPvm/XuXzbJNEgBM50m lj+5xIDBkcqtRkKNokX0ONlo/QTCRQkdYA2xSwzuGzgo4ax7OTAfgkKR0gXaMSjd0fblhIFZkcy3O uLWO9DupcrKt+pDlGpSx+Miz6qpzw/HtoMbVHr58WOYYIaYLstJnc/oPaBlHCJkaDsT5H35KaxEXD vOIi6ADg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qHjdh-004Vpz-0w; Fri, 07 Jul 2023 11:28:41 +0000 Date: Fri, 7 Jul 2023 04:28:41 -0700 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions Message-ID: References: <20230629165206.383-1-jack@suse.cz> <20230704122224.16257-1-jack@suse.cz> <20230706161433.lj4apushiwguzvdd@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230706161433.lj4apushiwguzvdd@quack3> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: DAC67100017 X-Rspam-User: X-Stat-Signature: 8disz81d6hcrrrouudfduf5izpascbim X-Rspamd-Server: rspam03 X-HE-Tag: 1688729352-377332 X-HE-Meta: U2FsdGVkX18zReQHbxtplrwxQMGy0sk8Ao8KYG2TYJAjp7uuE7kNMD8QPdIq7OfaeBuTcwPeg2IvR8Ea9FPgkY9wW/L3wJwTx+X7rPG90r31m3AKyPHNjbLL07RMYC0cWnZLvhQ3bionGUdaXU3HscqiM3vHeHUAJWkT7CMIukA1+9+znXx3+H6Yl+L+M/0IuwePQPC/ARlr7psUOAWQpNhHZ/R/7UkJakIpTph4FmDYFFjczXTO6DwJrGzHvsuu9AsmQ8Gkm9pcl03x1UXYu3/YLtyMIzTLvv9DAHN0z6cJFdCYrrSp+dJMKDhNTN9psSAlRs3yrL/yh8KyV9JK/zRy1qWiWGBfBCZD47QaG03uUhEo3+B8IJdIaA+l8+nr/viVqhE2nyZdTMVWU8Or+FiLGt0PwSdiu63Hpyvtmwn7WdKWGbUGpX5PHD+T0/F/Hj+uvez5dQXC0vxvZ+xB2ZeCObiNd3ZKu44XAvaW2srUjtBeqqYWIiIeyb76avUtP7LVUAm2SdfdusKZ2jrLD7wO8C63AOWijt83unZuFzuP/ACttZeTsPEJPtUEddA/nMUk01ucByXcBprH1NfhUfEjNfcrPqGc3Pt+fYxnXv5wtqoWB+GF1GaC92NyCEVpELv/EUmWqIeONAwFx1/GeAmiFhmNNPRZoITPm5tOp2gKmCcdOvm5pKzRZzBHuFolAZMUzo6MN+mF0m+eP9Nq78YWV7vJ88LChH6SC0BfbGWxGDKI4wDeza4XQO0mCM9K4mVnmNXEV8vrAns3gsgzVoQmyqZejR6JkKummeojDZfopMrIf3VFyvDQV3RemGqQAlD+wen5ufmM9J+nkPhH1POLsLq5TNVgUtnn2ZMvwTGT9FUL+M6b6+YldDupBffTMN52Z14b19SN+gXgi7sCOv8GBde6mW/vjDy+bUzcmNc0ZkBqV6qw+zmQ6Np0u/UVXtxspnq6olPbj4m4BB3 y+QbIrt/ 2I0kn39fBK44ypbxoVTEmLMcoDCH5h0eWxoT7gskhzrK+5uDxGzVTw+xEq5YwTJQVrMwFhhhGgj5N3io/3pKyGBXYejNUWy5s0w5C251k6+CzgGsxzsKOriGmvDnAPN6CV/Giwo0uLbBoSibRntq8spUZonMURP/LBpthxhvoh2fg/tmKQpLXWdwe6K2XqBCc8oole+JmLNY2P6j/XtV+uTLhEXmAw1tgSi91wD8wVDJyrhC5PmTf6wKkY0qBFmcbhVw8EXAG//dKdId2ZdF2sAbckporTRV+ychmq69Ls5hT7GZ27gvbWke+LlseZfLlhwMXa/1nlSX/f19v88EJ589F1ZzrtyouMYygCXR1BZagg3WFHsyjGs0p4exZpURxnSMs1KRTU8os88NidWtkwUrj7PHIj/hjXsMEnrt30NEIiuhol7tUwCaQ9utydZhMkzSl4SOYSlnGiEZwj6B3qJHAgbIld5FsIsApET1fOS4zKxJSDk8GYT3TiajFowrGliCFEcNxykfmjh06pvTn+24G5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 06, 2023 at 06:14:33PM +0200, Jan Kara wrote: > > struct bdev_handle *bdev_open_by_path(dev_t dev, blk_mode_t mode, > > void *holder, const struct blk_holder_ops *hops); > > void bdev_release(struct bdev_handle *handle); > > I'd maybe use bdev_close() instead of bdev_release() but otherwise I like > the new naming. We're using release everywhese else, but if Jens is fine with that I can live with close.