From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D7CC001DD for ; Thu, 6 Jul 2023 15:39:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EF0E8D0001; Thu, 6 Jul 2023 11:39:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49DDA6B0078; Thu, 6 Jul 2023 11:39:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 365AB8D0001; Thu, 6 Jul 2023 11:39:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 26C656B0075 for ; Thu, 6 Jul 2023 11:39:02 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DC60B120615 for ; Thu, 6 Jul 2023 15:39:01 +0000 (UTC) X-FDA: 80981595282.22.C1AE45E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id DB8C8A000F for ; Thu, 6 Jul 2023 15:38:59 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=LJt1aHPp; dmarc=none; spf=none (imf15.hostedemail.com: domain of BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688657939; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YwAEpZO7Vu5hoax5tz5QpnX5k8pjtsK6yDO/dOzPntw=; b=VGWmuUttx32MLmPszBThYHCDSy9U7LP3PHZR9orgK1ujIMVmM4Eb6C4TYmzI9xVoVzUgWq P/oNd1HnbAPMZ0bsJREfHqG1Spj3wLfzX69RIlk/ZUmtwcsKD8yebUi5DmwQUvhji7wNzF aIdvv9xjdTQrAMFaLE7ZV6bg3yWxbuo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=LJt1aHPp; dmarc=none; spf=none (imf15.hostedemail.com: domain of BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688657939; a=rsa-sha256; cv=none; b=oMuWvEQMBj8XDSpqjE4ohP1AfB/O7UNQ+ZnIG4TiKNe2zOu+wj27ZvwUIc2HKsW62Gim6i ISmLIgjdZWkiPpYRlRezXkiLVb2S2Xbp2ODS1fGMqt+676u2N4LhLZukSdrKvRre8xO3F/ 6MhvF7NIbaEn2C0VupR/J3hByHMJXFw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YwAEpZO7Vu5hoax5tz5QpnX5k8pjtsK6yDO/dOzPntw=; b=LJt1aHPpR1VtNNU97F662mFcBQ 04pv5pjmhELPxcfY8IU2J9oyhfgQvItd1fUo/P+Wom3ADKBICTxeaU2ubravoUlJ9bJKThqcbtmZO YHZ6Bq5JNF5Oy1kZk0vGrojv9a9LNU4bL+WXTD5k/gljEqzdXg69aNBObe/lnHCHtRlMc6Ppc7Hqe +NefvxaKjDH4eBZ/aYpgK8N4uyEQGVFSG36iqC/zjMjHjPuCdtgFFvp4F+STCUxI3HsTMMx8Jecfh X5dQPxytEjbEWkMaTy11b/rkROV7wOirXDfTif06nI996QOXUgedgb0owSphnlvJb3u4X61SBTklq DymCsIxA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qHR44-0021w3-0C; Thu, 06 Jul 2023 15:38:40 +0000 Date: Thu, 6 Jul 2023 08:38:40 -0700 From: Christoph Hellwig To: Jan Kara Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions Message-ID: References: <20230629165206.383-1-jack@suse.cz> <20230704122224.16257-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230704122224.16257-1-jack@suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: DB8C8A000F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: szu4n7a5xw5wy6pdqmm4h94ztcrnozpo X-HE-Tag: 1688657939-527109 X-HE-Meta: U2FsdGVkX18KdvPTQ65jJ+lgP90uLPaPeuI8DrJh70iYqGv7UYUm6WZNvBvkZ9YFh5IH0AFnlosimpAfqJJ9j7mIo8AzXYJFtrqZha2q1A1bgiQr5/1+rRswoaFxvq+q2TjNNK1uR+PjzfusMdd60nQzDl4dkuHflxygpTYQopK+a4tqZL6FdCPV8KSw2fxKtRG7gz4ooRoQrIQ/LpFt4yI6X8EW37WsHxSesYAf3qPjBD3z6Mq0En0dlP2z5BPukq+1XS2Ut6ktwK3UN8EDlEnLCNDyyv2m0g74lBvmNWPA/1x1YiiinsrwtFK0gAmaKM+UOYkNze45c4PvlwLkqz5PCH0vqfPLPI8B9Z89F3TspFZ3JsWQrYYCe0gih2Tk5iZyFZXroQwI4I26F8jLtex9E2AwLNwbFcAck9fzSkw6kMe42UwAzj8AssKjkyIlqs+kwy3d//5BE3AQELjnKtxbY85j1u71dwuVwerFnjCUV493PjbRwruHWCj0gOIp4cMFmesyZHx7iQ8/4xQvsQ+GShvKr+bcEbqOHOaCWdtXmTUsywNNRqggADkjdjdXDfdx6QIQ0iaMOGTF4OjPVYQ7CA4kl0srJcNqEpMf7I+p1oBLmhUmnC+yv6KZ5w0sG86mLPBKyhvVNSY9bG0n2T0qY3Z6cXl6cUNu1FBSCJADXRcc/xep74Tp2TW98CJOqXKIErDMuIanHrhOckZ3ieehO/mCsuXSepknaA72bNwY7A/8XRqjGwOu8yj8JoNJ06i/CJZr3rNXiX4ehBDabalSF4pE3R3/PMQyd6vZcevhBr9c236UjnyPy1NT7q20Oj+f/zqZEZUKNZBSuDRC9k9fpCz7OW1xN4o6bzaH+cGt1w7yHBcOnB7Eigl2mR1OgT7TwPdAIAo+1QPGLsQomvAhFMiRHcR7gaUfEONH9U97i7qf2rK9OS/qhX53VmCUzn4/n/1BbGZxiYGvPEn L2D1y8dQ acP3gTSJzLeHIzGE7zU8kLfnFC/eZ0k35At0XbAeTUauB0SlpZ3sYKZAv1ptHvYu57nA1HAr7X0v6WJZZfDlx1UtjBcIGIZCNJS5NfI7BJUtMviko9SkfTe/hiXOpxxaklwYaT1XqWdMYk3f/Q3oq4kIk0/M4t5xfGU1rw45C9R2MVdKe/YXzboZ69aSIf4MjaPjRVZp3ncDeKfPvfaRfHhIPiB1vRR6Pcs6yjXpBupQnj60BFbciJ7j3ij01mo9pkCLGJGsnZxDhYvH4apoXiwXtWXitaa4umTK0u6y4JJ5leN8RCFlBu8kgTGDiwCkAZEEfJZNVElLD+Uq3OXBhXtL1dX4pny0x+Jl02AjQGP2jngKKqUMGtWHTGi8hW/k0p0lXHHwdkgET8B2IKSE8mL6Dy22zdDTDKvcwZcQCCu7njMWm7FyPPr4QQxjVkuUoyT5Vt+7pDYJRDiG/IL/V17yeTeaxDq6Eqz5oXEVtw7vuI+DrkJ2rK5AiyimP/9HJtPLhGF4k8RNkBp1n7qWZQ7ysUw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > Create struct bdev_handle that contains all parameters that need to be > passed to blkdev_put() and provide blkdev_get_handle_* functions that > return this structure instead of plain bdev pointer. This will > eventually allow us to pass one more argument to blkdev_put() without > too much hassle. Can we use the opportunity to come up with better names? blkdev_get_* was always a rather horrible naming convention for something that ends up calling into ->open. What about: struct bdev_handle *bdev_open_by_dev(dev_t dev, blk_mode_t mode, void *holder, const struct blk_holder_ops *hops); struct bdev_handle *bdev_open_by_path(dev_t dev, blk_mode_t mode, void *holder, const struct blk_holder_ops *hops); void bdev_release(struct bdev_handle *handle); ?