From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 465E3EB64D9 for ; Thu, 6 Jul 2023 15:32:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7C366B0074; Thu, 6 Jul 2023 11:32:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D05378D0001; Thu, 6 Jul 2023 11:32:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA5FB6B0078; Thu, 6 Jul 2023 11:32:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AACBA6B0074 for ; Thu, 6 Jul 2023 11:32:17 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7F69A80786 for ; Thu, 6 Jul 2023 15:32:17 +0000 (UTC) X-FDA: 80981578314.06.C75DDB4 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf01.hostedemail.com (Postfix) with ESMTP id DA13F40052 for ; Thu, 6 Jul 2023 15:32:06 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=CnZWUl66; spf=none (imf01.hostedemail.com: domain of BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688657526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OcmDcA2w/L1lHnlZrwRLksnmZ52AfyCMFAOcR/tiwrg=; b=4ohFdfxpNvfk0GpzihFSkNon5ntkhi5++9z+ptTOzEVloiktt+UcIobr487Rs30JfNIvuB 0HJGXBwcnX9tvayx8c8S6dSCOL+ixJRxM+D0yGNFhzDSzs1Fe3NKOZCJS3X2UaNT4HNMeq rsMpKhBQ3lmG2hYSTy6jPYKW1lMBxsg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688657526; a=rsa-sha256; cv=none; b=fQf4HqIRZv0+uyv1sO03/979Xh1pd5X/79g5qak6SSVAWmXQf2VelSPXDG6sG7o9z218Mv ncMlqwDVVo88wZKKtQOWvb0KWtVk5TgI5BjbQCkk3QizD+2n6N3J6tz6nAzE+vfPxh+ZrV hbSTBXpc/+Q0sIKn5oX0x4JWGr//XYA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=CnZWUl66; spf=none (imf01.hostedemail.com: domain of BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OcmDcA2w/L1lHnlZrwRLksnmZ52AfyCMFAOcR/tiwrg=; b=CnZWUl66G57JWeMq3Cumm9nGHy v5NuUfSTp48+X5P0+Mpr6wABQnANv6kh5ZvyaKkxHVVXymOryBWC+NdeDQHFkgwlzl+sdXRKNfoES dm6adObEyutfkZXL3b47P+961rwnxXp+05kxhnVkGsV7jjZRzwqHyd/QTB2MOsqpWIX+GD637oFjh 4KW7JsHk1PRz2zWxEgJOYgnkR9IKZfeKMlRO+4QAqo7ACn6RV8hfl6WOh5d/QRf6OZx3E9Mh8E+UJ o6fdzAczPKvtWkSrAx24Bxq5YFmjMyz6Wv+u+n4gBXmxQ4CsxL+icvARitB0PgCKsZojcNI4K0Lfs tGMUhcxQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qHQxT-0020wj-1O; Thu, 06 Jul 2023 15:31:51 +0000 Date: Thu, 6 Jul 2023 08:31:51 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Christian Brauner Subject: Re: [RFC PATCH 08/11] iov_iter: Drop iov_iter_rw() and fold in last user Message-ID: References: <20230630152524.661208-1-dhowells@redhat.com> <20230630152524.661208-9-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230630152524.661208-9-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: DA13F40052 X-Rspam-User: X-Stat-Signature: nhy11n4oihi5t77e5cxdd3sgde71m7oe X-Rspamd-Server: rspam03 X-HE-Tag: 1688657526-581827 X-HE-Meta: U2FsdGVkX194nvKj1zFTgte34G3USpyioxD7xNyfvFQuMy3VtIHaj2dSXDXcEmVAP87g00tWKvrcaHLC+K1qXdhkRgs0fcyslyAe+/I3a5sIq2d6oa4V5tcuvpiZ5t6f0dWZVCKshwrlGPtjRI2UgUf6nKVqZgqDA1K6ySzcBhEauSghl4DXzpnnVIXlTAyrM7i9ijRZqQIcEyuoC8+W4fTtCC/PLoQmgJx04Q4JIjM/P4Z2MCxblGlvehWd+fEzFIcH4/Q8E3Q1H+BpLEIhYbUXY7TsTWGppKl0LGZvDH3efUtJnHLAm63LSWJiIu/vxlDCJ+p6uI7eWoOEW+JRNtdXCYYqFiswLxy6+xF/j9ebezy0EXBL/urTILzkQ//S5BU0GpEtrgzmZhBxDQeVOZrltjnV2v6K1d4lkTvXkPjRfxsc76L2aGJ1DK12ucIqM4AV9VMOSBeyx8YmCpmThhXLl5ijR9ZzRYJDdBWYRhO0RWPgZm9Ft24VbFnYhyJS7VXoghChMIQxhIHKgdqhhxLeNC0Jl9dGirgjCQdN1QmP2g36XRjzfMKjaX29gtXhNy3sJg+Hc2CPafNvViSEfSZjcZ8mH6QFKz7Mxv4zvvH4p8xUEn6lQZZzzdtm4Kr0efcxEMmeC+eHc579dmeX63v3ePcbJVdkWrMCE12QgGlHDk9kLnWSZeRglAz5ArEoavFsxZcuy5qhFYLlHOgXTiN6GntigDTKGC+9vmoa6X4+sTGfD+7UIiUz6nYBTC1SJvoD+t3wb353h31drz8Q8vUE0oOrx0Zrb6t6JyDnw4Gcg4Zsga94RL8hmzRBxdb60LjmYQiHr22r42JJetNxO11EAI9lLeG3CIfdqaDCFitBQfctTu8V2K2D5KwuJG5W+dvhw8fX5nUkboTG3XI5naHTsBNr9ILvZLIQAq5Q8HDwpGG+ej5qgoeObdretsUTA8yQCBY75uW1a9QrDbK TDTpApMm bvV+557Du0VXG0zSLpviDQMPvLB96dfcxYjHvwyEerbfDQ6o60hZdnFz6kRAlb4KT5xAwgReJZ9docuy6VkAQqHgVgssCo6OA0/aj1VYzhZQEbTpE7nGS3Z/AS16r4zcIrO5NvXUW8EFOJaFb0Zbc0+jabLBK+2J5R/jFuYLU6H5AX2tqLGZlzhtg+tF36vp6GkOo1cDjo2H/4nWe/+UEdJrpxAZAKOp8/dbPigRhhTmLfz/lT2uAIc0jfbvlqIW8x/e4X3olmvRzXs+/+Wwtf8p2wTbG2uXZ4OVMOS2oVEFyqtLPojq17v6jTpfwLRYYjHB7AaipqFHbh9yEvH3YGnFltTM4EiOx/PhmLjmxdQp/moMRRo0ZIkCC1Pa7gECyD3HYgCJRLTNa+rjSJsZb+1P25jpCD6UVhI89PmoTIGOG1ZQ0mOGfb8t4fQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 30, 2023 at 04:25:21PM +0100, David Howells wrote: > Drop the last usage of iov_iter_rw() into __iov_iter_get_pages_alloc(). Well, if we can't just drop this check entirely, the rest of the prep work is just churn and not actually very useful. Shouldn't we go all the way and kill ITER_DEST/SOURCE?