From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB963EB64D9 for ; Thu, 6 Jul 2023 15:31:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 454466B0072; Thu, 6 Jul 2023 11:31:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B6626B0074; Thu, 6 Jul 2023 11:31:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2578D8D0001; Thu, 6 Jul 2023 11:31:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 17ABE6B0072 for ; Thu, 6 Jul 2023 11:31:26 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EA8DB140C67 for ; Thu, 6 Jul 2023 15:31:18 +0000 (UTC) X-FDA: 80981575836.17.35A0788 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id DC67E140039 for ; Thu, 6 Jul 2023 15:30:39 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BTSyek31; dmarc=none; spf=none (imf09.hostedemail.com: domain of BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688657440; a=rsa-sha256; cv=none; b=NxZ7VvHeRX06F0HwWKDd6k1XJp+INzCmhotelwcZpnPUs3RWcq2X8mulEKMlrQKN9XeQxM s7kqIWvwvE39UuTFirsrAyXRfo/tYGLxHzx6D85auL5e0u8YB9g4Ig6GdNz3wITMIN4lhN EAoOKD4SVWVxrLfrhhjeeKry9YFOMAI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BTSyek31; dmarc=none; spf=none (imf09.hostedemail.com: domain of BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688657440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wY5Dot1/zTMAJ+7vVNWs/yMvd7ZTGFOfgJeR2bahFjQ=; b=HRQCdaUeFFnt0Dj0HZCUl3J5e70oE3UkvK6O0JoJWtxEli7p9mjoyoaeO6pHZXNot38/ns vMIH9jHy1qWE6sf01w0jXKy0GD0KIcv2wyzmOt4BfBwJDej54WMFaQdMERkiQYDvAaFtHP uAemuA+QP3s9kj7Sw27shxcGy9MOxsc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wY5Dot1/zTMAJ+7vVNWs/yMvd7ZTGFOfgJeR2bahFjQ=; b=BTSyek31EkyyPudrxmynZoVthN 81KWr6uMtnlBbcKq8tTiT4/oN//7sPQ0IUO+/LCa93l+kiLgsCVrkBZe1tB0n7QFBCKuhIAvFK10p n13Zryn1H3WWsvqTg7C7I7IJSTEs0sopsCb8K10HznqFkXscj+lpyQsaX37JCHieii+swEiwRnSWA JHzgvaU73n1x7ULgjhfZVyOTFik7lvZ8l3ZUFHRoAxlUUy+d2nrIt96GfPJgBOXoHFSpkCP86iuU+ ALoVEjNSHGDfyGlACeQ0IsaYd24bkCCK3ClVrO+fwcVu/0F92ch134xa1t3tW2DKFQ7G03FUtfOkT sOI9ztiw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qHQw8-0020gL-0X; Thu, 06 Jul 2023 15:30:28 +0000 Date: Thu, 6 Jul 2023 08:30:28 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Christian Brauner Subject: Re: [RFC PATCH 06/11] iov_iter: Use op_is_write() rather than iterator direction Message-ID: References: <20230630152524.661208-1-dhowells@redhat.com> <20230630152524.661208-7-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230630152524.661208-7-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DC67E140039 X-Stat-Signature: 19xit59xnx9fui5fwtzutxzm4ei6hhfr X-HE-Tag: 1688657439-591045 X-HE-Meta: U2FsdGVkX19BTwUHfoErdpcZd4Xxwxpf1ugqWpCVh/fv7C/yxLZTCCWygZecVWxLviDiLpS9oK5J1drO1FArYOLr2OwbSy+YIInf9uLwTafKJkuClN+/DsowSqXtt0tNC3qfnFOUVhstv3HkgTIzzxh3ytgfDgpzk7t8wkAk9mmgZhhh4g2slbn1XZHj8glmIzq2JnLaVzuUqon/jX6wKLp+C8QKW16qsJbpIBfJgJf2c0MKOLwaOoE7GsrGwx2ClnqWIO8IEZbc3Jt29CcQ4Z7YJnuFcl5c/ANauklvixR19UhINWpnczuBL2WPbQ7/W99e3QERpjkI8AMHsL0me6uSUIgV0YnvHYzLvDwIbKD3HAQN1PYWzagGq/gwPDb3QFM0WKM5NwdVDPP7N/3BZj4F+BcCNSq6VlHZYhahSZx7dPoyJKGK7QGxukzn6ncs/ttqbzE8+b8kE+mdk3rodKi848MzUrqNLpJrKS1OlPFHohMkZclsznlc3gKFlO3BHiC9irVx4/DESH4LiKe5US6w7l7IsZsDqMLjGWD1JzMqdf3BxJgKafg6kj6zH68XjNil/4wOkVYIDR+8J/B2mxtbNbb1GN+mYAnNFYWhkGyYJ2ksbX93S80RKLSGDVUeBv4CqXCqp6K/w+CXYz3tHW8gZ8BsEnyiRDmrcREDpOTAi52ttLVI1uiZvIE3YRK/OoJfwAEbKoQUhFTrQhOH2mfRMpG8mdeuRX+jSgDEjTIwTqkPPhK3gcaZMj5if3O3YY9CmvrqUY6s43uM3m/GMpOQvc+J5H49CxJt9GecKolw/WZ6CKJsvjMKTnq9tuTtteJ0kZ5M6N0Ysg1s5NMM/BxmPnFVyZp/3RIFkPGRHo0vikGRB9rCOwpfBdZj96k2r9qtQcjkm2LL4GRdAHFc/p0vNpZGROznUwc1LqEWxJIVjBRlzEmyShP3I3KYqigrpQnCCrhF8wch2unKgE6 eTv8fY31 bc/6yDbRBpm9IWPpsd2Em+vywt9HqJXxX6cwYeP9HHYQ/GV64kNygNo1KwG8UPxnRsIylrRvXXEtUvfsdSJPTDLAeWyMUci9+e1kvO6kbJNbKWZS9vnU4WlsrBushpjpuRG1LU79X1DcJh4y9++sEg9fzRh293UevZpjTXobO6NU/OW2p46t+2KCbzF8ZuJPrefpEmo0Vdv4DxEpQKORU2dzlLKtvYFVjCUeMjNBIDPr6zwCYka9ZrNg5KYlwHz0HrYQHl934qXGgMn6oWO5klcYWItrv5CKPnw8rQVUPCOVgV2CP3w4otsS4LfgbPq+ly8jfmhW4WH+1jQWuh430P5B6u+iYtz1bmD3/3arbdgzJdIWzypm69hZZB5W+NYRTOpvuxtH5ecQSgY2al7i9Lm3jDO/ZIXYzywfO9FDyFe/ihueLxRfkLA5t0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 30, 2023 at 04:25:19PM +0100, David Howells wrote: > If a request struct is available, use op_is_write() instead of the iterator > direction. s/iov_iter/block/ in the subject.