From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44012EB64D9 for ; Thu, 6 Jul 2023 15:29:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D077B6B0071; Thu, 6 Jul 2023 11:29:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB7966B0072; Thu, 6 Jul 2023 11:29:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA6758D0001; Thu, 6 Jul 2023 11:29:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AA6CE6B0071 for ; Thu, 6 Jul 2023 11:29:44 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 79FB61C7FC7 for ; Thu, 6 Jul 2023 15:29:44 +0000 (UTC) X-FDA: 80981571888.19.10E4099 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id 912224000E for ; Thu, 6 Jul 2023 15:29:42 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="JaE/0fWX"; spf=none (imf12.hostedemail.com: domain of BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688657382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VaWrOj7qxCfN/aR/+wlf6fU45vuCjby7Nm0Ri4aQJmw=; b=JDtwZLdasmYoBK+OBNB03E3F3V7hGAVfT8R4Uj0ct88bYIUOswISr1E/1WKGhjRKHxUgB1 qH4lhZMOyS1x6ZttCS/3oaK4TpYuI+5b7d5zQHggN8KtGYagQgcUan+HxMAyJAStrHR0fr G5w34g4I7sjS0NFfGBfH2skr9KuLC04= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688657382; a=rsa-sha256; cv=none; b=kz9jL+rBpgGJaA2y+9R2613vN/sZfwhpdfo79mDstqUmOfF7FVFJkkgpVR+E8rrtW66Dx2 00SX5Z0HP367XGfUqfVNtQS1gc6VxqhR4Ruo+q1ecH0ZwnmFZgq4k3pPYD0RM4Cdd6qGVm i9NG2Ctm/8dfFfipXUyXeyxmeYWESng= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="JaE/0fWX"; spf=none (imf12.hostedemail.com: domain of BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VaWrOj7qxCfN/aR/+wlf6fU45vuCjby7Nm0Ri4aQJmw=; b=JaE/0fWXQgO2xj2f3aFJmBZT5Q j6++1w0jrD7V6RkWJs3PDshW7GjlpZfvyQoTTJ1CWgonZ+2AktQ2W0WMpn0QR1xiTmqU319iICsGC 64kKXFo/nIsWzCAc8Lw66uKl2P9PtTuqTKQDsMNt7jFOA5TB1a6i1gnN8D7RNImMSYEq1hFweL5NN OsN9HNt3EaMVo61D1E2z8zoD/Yc2hUlbIXLlqAOaYKzR7yZpvUAaLNm+TilvBWp1EB2Cm5KPpvMAz k2dTNjwEazjsUUv4U4jC6XLDA+aFIhco1jmCE66xnS8Evo0WHqgKu3FkOk82Grau21wfT9osTZx/7 QTSa18og==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qHQv8-0020SQ-2T; Thu, 06 Jul 2023 15:29:26 +0000 Date: Thu, 6 Jul 2023 08:29:26 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Christian Brauner Subject: Re: [RFC PATCH 03/11] vfs: Use init_kiocb() to initialise new IOCBs Message-ID: References: <20230630152524.661208-1-dhowells@redhat.com> <20230630152524.661208-4-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230630152524.661208-4-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 912224000E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: uc6j4ergy4qguofbhkdgd6bkbqbrs74g X-HE-Tag: 1688657382-451725 X-HE-Meta: U2FsdGVkX18e1y16zGe63eVMw6Efp3DKVHuE2e/c+2jeKBv+MkWwQA4vWVN0iLg4bU+syIlLBR6yHs9qHDUYMdPynKJT9k72D95OZVFz/FSLgKRBttas4p9RuLwFl/5LtX73zjqmw8kchMVCOzbp+zU8uWj5XHZ8mBGyAQ891zQIz58ov/z3RxSRho8yKc3Gpv1S6g6l3K/boa+s2rZaXURmiVampAWp9DEPSV1jTG17w61eW9VpPo6qqdccGqpB0nQcMDGmSa3RU8v8/xxpoekdlfu8Q5ZCmQhPMx9nzDDtb1XeZGuqiywDsfECrHfQzlSFh6pDEyyKpEA69V9wqXTTaDlfMoiGUHNjHtp+Uajs6G0NJcmSc8u3lsZh6uUfciNa4hwZnW4nbfc/B6Uc6Er1BxViPyk2+C0bgGyrsAUU5sluWNayQC6DSu5wnhaXruHrf6fmEtn5TsBLJrbmVUJ4X7eRAnx1Ql22HmIGbdSEFP47ZwAoO4cc/2DOxc4bfreFmy4GhKAtO7XWinSctADQdV3CxwDyboZDEyl+rthDd19AIqvKw41rDW63GRWNNVaf+VOnR+/LCUmmAZOxTDT7cdE5z1IhnhbyR1bs/qWIG1ruHW/CMokx/BOeQQJiXeW/35Fwi+r+D+G0GJOoXFkIMsZzJVxSrU6HzNhtFxlDZqAg1hIIRHsLjxHOhcG1/L+gW4JQ18QuTRK2fKNUjTyYeztpUn+I7Aq8htsGU9sdxK/8jwhi4T0BWpnRaL+PzCXjf4nbHmqtk5MXxgUD7UgmKkcJChy/XNXgsvgS8wi/4CzR+KkA8tTi3qNWI3m05ox/j/t8ks9sfBCuKCvb/5MIEGWLrkE3r6owJ3mBKcwAOcdBg6t0ePq4nO1YpzD9HFvTZBtPl+V9XDzuoUWOaa0lGNgJiVz/yRXJipzlLgBjQCZKpHf6fVQ9a4G/cJmHrtWidj8AYSMKGcDNd7T ChSwbgbh oBw/03o4Kdo2gX1DiETSeG64QUswtH8OWRQVeejsaoDxMDvPSxQ33UQqji+lDk91XOtlNCB2HeU7fHc5pIf8D98KW/7CVqczKCJ7CGl9Me0QLd/T0XXzVmiC9m8XRwNh1IGBZFxmfCdh4sGaj4E/Ftk3Rrsy2B3lbdwXNqLFDPP7DbkFV2Gz4/fXAOq2EySIrZGtJYXtuigYYsd5tEqKFZx6RVXVT0McJsam0hJUby5RdWUleAiNOr7yOduBVQt2Im2IWAGlUyJKGoVqHlMOC1oh00Ssk0QyjE0LA2jGrMI1H2Gx3rlOEAlRkiojA5qd5Rde02OfDRpj3WV/l89ILkDXIKKpwMXeGWXpi78DD9peFP5V3tRBCJ9wYsAm0LSIUsnxz/hixah1jZiZiYDY2CwtPmvfnvZtAASqVqjopTBhPKRU4BPSeHqjZ7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 30, 2023 at 04:25:16PM +0100, David Howells wrote: > A number of places that generate kiocbs didn't use init_sync_kiocb() to > initialise the new kiocb. Fix these to always use init_kiocb(). > > Note that aio and io_uring pass information in through ki_filp through an > overlaid union before I can call init_kiocb(), so that gets reinitialised. > I don't think it clobbers anything else. > > After this point, IOCB_WRITE is only set by init_kiocb(). Nothing in this patch touches the VFS, so the subject line is wrong. And I think we're better off splitting it into one per subsystem, which also allows documenting the exact changes. Which includes now setting the flags from f_iocb_flags and setting and I/O priority. Please explain why this is harmless or even useful. > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index 37511d2b2caf..ea92235c5ba2 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -439,16 +439,17 @@ static int lo_rw_aio(struct loop_device *lo, struct loop_cmd *cmd, > } > atomic_set(&cmd->ref, 2); > > - iov_iter_bvec(&iter, rw, bvec, nr_bvec, blk_rq_bytes(rq)); > + iov_iter_bvec(&iter, rw == WRITE ? ITER_SOURCE : ITER_DEST, > + bvec, nr_bvec, blk_rq_bytes(rq)); Given the cover letter I expect this is going to go away, but the changes would probably a lot more readable if you had a helper to convert from READ/WRITE to the iter flags inbetween. Or maybe do it the other way - add a helper to init the > @@ -490,12 +491,12 @@ static int do_req_filebacked(struct loop_device *lo, struct request *rq) > return lo_fallocate(lo, rq, pos, FALLOC_FL_PUNCH_HOLE); > case REQ_OP_WRITE: > if (cmd->use_aio) > - return lo_rw_aio(lo, cmd, pos, ITER_SOURCE); > + return lo_rw_aio(lo, cmd, pos, WRITE); > else > return lo_write_simple(lo, rq, pos); > case REQ_OP_READ: > if (cmd->use_aio) > - return lo_rw_aio(lo, cmd, pos, ITER_DEST); > + return lo_rw_aio(lo, cmd, pos, READ); I don't think there is any need to pass the rw argument at all, lo_rw_aio can just do an op_is_write(req_op(rq)) > -static int io_rw_init_file(struct io_kiocb *req, fmode_t mode) > +static int io_rw_init_file(struct io_kiocb *req, unsigned int io_direction) > { > struct io_rw *rw = io_kiocb_to_cmd(req, struct io_rw); > struct kiocb *kiocb = &rw->kiocb; > struct io_ring_ctx *ctx = req->ctx; > struct file *file = req->file; > + fmode_t mode = (io_direction == WRITE) ? FMODE_WRITE : FMODE_READ; > int ret; > > if (unlikely(!file || !(file->f_mode & mode))) I'd just move this check into the two callers, that way you can hard code the mode instead of adding a conversion.