From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11E3EEB64D9 for ; Thu, 6 Jul 2023 15:21:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8288F6B0071; Thu, 6 Jul 2023 11:21:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B1466B0072; Thu, 6 Jul 2023 11:21:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 604E48D0001; Thu, 6 Jul 2023 11:21:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4207A6B0071 for ; Thu, 6 Jul 2023 11:21:36 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 05D00160713 for ; Thu, 6 Jul 2023 15:21:36 +0000 (UTC) X-FDA: 80981551392.07.2C99D8F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id AB6A9140009 for ; Thu, 6 Jul 2023 15:21:33 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=md2yoQbs; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688656893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zla1ImuYlSI5ZdeorNKDcqvlZHdC0vro7cklgNetIq4=; b=JybE4NbRkR3Zz712HZOjchD97T6KgC0veGkIVXnXgjpkU7vi+xr6JLjZUKQa+qDUxgtCnT Uc/YrQNVCrvWT7Zm/ESUJ1wkX29Ctjvrg7JaZPmeQPkWRN1xNYXX3XYBNq7zd1jat3f6B1 9FtuAU+Ct7bZZhFaNvUD5m1KZZ3t+Yc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=md2yoQbs; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c95f280863011604c0c+7256+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688656893; a=rsa-sha256; cv=none; b=tIqJbyuOBjsGuz/orXUbtThVankOpk+DNenW8BGEjvxeHdUfiw7UgYJLz2fPG+NG+3DG5R UzQnZ6BuOkzUvRSHpe4rzOwEz7f+HX+FHhnbHjyYf5bJVxPB5KJegn2JVaIKN6zcNPlrmO TnjFYL4VCPH1hUqEgQ+BxSz/qlkQBQo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zla1ImuYlSI5ZdeorNKDcqvlZHdC0vro7cklgNetIq4=; b=md2yoQbsnnELLcfX6YH8bFGdgD sVm3mfyQyYUBNSKlDnq01v4epjnSUGYjdn0UcoSP/y4qznjsZ5DVvjb7Ednq5ebTwXF4vGlcRcNND LHM0q+covQuGM7MQUrnz/4r6PTvLDf17t9LKMo0Y6QNTtcD9gSa8AKjWLG+0EX5OMku5iH7jLNtfR TMZay13oaFnWOSnyEOQAeHrFwWMJkHxTimLAEwwF5Sc0FIlDLrpGOFofVyIet7FH6QyCxvzOjElFP o0bo0vZKvhnQjryDZlVlhCzo9+Q5jmy5qcpOp9MZ4LG7iGYUVoJF3xPRmKLbhkyjS/ZyZqGZy/Tqe zW+T7FUA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qHQn6-001zS5-18; Thu, 06 Jul 2023 15:21:08 +0000 Date: Thu, 6 Jul 2023 08:21:08 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christian Brauner Subject: Re: [RFC PATCH 01/11] iov_iter: Fix comment refs to iov_iter_get_pages/pages_alloc() Message-ID: References: <20230630152524.661208-1-dhowells@redhat.com> <20230630152524.661208-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230630152524.661208-2-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AB6A9140009 X-Stat-Signature: bfnhwsfqa5biim6fyjd48u6axk68nbo5 X-Rspam-User: X-HE-Tag: 1688656893-464127 X-HE-Meta: U2FsdGVkX1/ZaKtvZfWHf15/thUbHZkpxiiHuYBtaY6GqWmsduN8Lhio8VZtxKzjKzymqQZGgLekcak68EtyuAGO5pk51qcUT5higv2TB3Uu7EOxZ/JYnVzVgTfa4WoPvTB3kDusphm2nr+vFU1l8nuhZ65lqClR3tM6sBYY6kBNsuqnBg+esQCIob/9/e9Lpa7tKwmHkeAE9cWqn4+4pEtBW/htFoYTkIqHhc4OzHbK1ju62hzTR0fEkw0sCLQroFlRpmXAAdW1MkTVUCPsgHxjJmrIEbkgXY82ITH6G0DOZ7oXZK9eCHGtQS1zOqqqggLQ6SaF/UvIi6St/8vKvKAMLZmzJv0EQLHfCFTcUm0e1tepVY0PCdmDhs9U9g6s/08GR3HXIn6i6I3IYhW2HRlR1NToxvVRaP5ydC8k1Lr/w1GJG2eZggKNID0kCnVU1FSTbgt3eSvEaIDuCeGtcU3zRu9XFUcYX2fbWH9ATzjc6v60G4TW7wwaFHFqZL35hB84biUSOGc9JWSk/bpRN//u34T22VsuNpKMk9EWRW8njFkaJNrRgxm1XqgkOM2mnIgPh2ijb6JEkk3Nln2ZrWgYFWr84QZ+wwnr7qDiGEaSCc6ZevZl1ITMhXIYO9FtCN67h9ZftCLieMwbuY2DSlWbifM5XAF1+UtTHQ4efC/tU6QHpfDJsCnEBY1LjxVe+d5M/FsOxhITOCvvgDp2+Lq8b+Z/KjIQBdsnVpU2Uax9IxL/DlPpoXWloFlysKw2Kfhm1AYnCP6hIp1kA5SFVhOZHRaNk4mzH+YeSZ6F2WbWkLBqSzqTyLUTjCSwAla8vgdY/PyGgzrNpI1Uxn4FlvIcJPN3yErk4T/enQfuA2+TVhwO+ldVR4+TbU6bAHot6uMQRsKLQuaAgt1VNQReueFM5bzWsFIu00lHRv33/CAj4pCoXwYSzLBXE6xzbHnY599vAY3vEhX2otMUS1E 7somdjO/ vCbPWkX3LC9uEoeAl+f52Xfe0eUp+DiWg7COiXRrs9u+nfbgFbFB06RQOoFftRj4X9rurHdHvmkPoykfHUQxnx/OwWhlenpDTlQLduOPBoNi9XoUYEuUTKYzcdvKcFM9XMAhHlZ+5E4VLZhAR7WZUVcDrcl6R8HzrNwCmTNaz0Dh3cLCnpaYeDmJh51GCyRLZrxlsf1klHaE+HqZSACMRt6PsQIRiptAfItIGYpOUnGkMUvWxWti5pPDuLkUMb6gce9NSk7G+EkoGkf2d3bHeUL5uUUw5yqfHhjUH/3U9Toj3IiyplgaLiEsFbUhFpm3Uz8TkyVZRM3HWocIiAQ3zTA7N1mtvhUToziKcEX4jWSyPpas9QAazHcuI3jxqBre0i6nHGePu47IWjYhYnddYIP+HlEjwfS6aIgWIV6r5Tg3aDbN4Ekyi1MTk9Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 30, 2023 at 04:25:14PM +0100, David Howells wrote: > /* > * FOLL_LONGTERM indicates that the page will be held for an indefinite > * time period _often_ under userspace control. This is in contrast to > - * iov_iter_get_pages(), whose usages are transient. > + * iov_iter_get_pages2(), whose usages are transient. > */ I don't think this should refer to iov_iter_get_pages* at all. The flag should document that actual get/pin_user interfaces and not refer to a (deprecated) interface built on top of it.