From: Matthew Wilcox <willy@infradead.org>
To: Peter Xu <peterx@redhat.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
David Hildenbrand <david@redhat.com>,
akpm@linux-foundation.org, jirislaby@kernel.org,
jacobly.alt@gmail.com, holger@applied-asynchrony.com,
hdegoede@redhat.com, michel@lespinasse.org, jglisse@google.com,
mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org,
mgorman@techsingularity.net, dave@stgolabs.net,
liam.howlett@oracle.com, peterz@infradead.org,
ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com,
will@kernel.org, luto@kernel.org, songliubraving@fb.com,
dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de,
kent.overstreet@linux.dev, punit.agrawal@bytedance.com,
lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com,
chriscli@google.com, axelrasmussen@google.com, joelaf@google.com,
minchan@google.com, rppt@kernel.org, jannh@google.com,
shakeelb@google.com, tatashin@google.com, edumazet@google.com,
gthelen@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3 2/2] mm: disable CONFIG_PER_VMA_LOCK until its fixed
Date: Wed, 5 Jul 2023 22:27:56 +0100 [thread overview]
Message-ID: <ZKXgXFfrBzUjfkDN@casper.infradead.org> (raw)
In-Reply-To: <ZKXRsQC8ufiebDGu@x1n>
On Wed, Jul 05, 2023 at 04:25:21PM -0400, Peter Xu wrote:
> There'll still try to be a final fix, am I right? As IIRC allowing page
> faults during fork() is one of the major goals of vma lock.
Good grief, no. Why would we want to optimise something that happens
so rarely? The goal is, as usual, more performance. Satisfying page
faults while mmap()/munmap()/mprotect() are happening is worthwhile.
Those happen a lot more than fork().
In this case though, there's also a priority-inversion problem that
we're trying to solve where process A (high priority) calls mmap() while
process B (low priority) is reading /proc/$pid/smaps and now (because
rwsems are fair), none of process A's other threads can satisy any page
faults until process B is scheduled.
Where on earth did you get the idea that we cared even a little bit
about the performance of page fault during fork()?
next prev parent reply other threads:[~2023-07-05 21:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 17:12 [PATCH v3 0/2] Avoid memory corruption caused by per-VMA locks Suren Baghdasaryan
2023-07-05 17:12 ` [PATCH v3 1/2] fork: lock VMAs of the parent process when forking Suren Baghdasaryan
2023-07-05 17:14 ` David Hildenbrand
2023-07-05 17:23 ` Suren Baghdasaryan
2023-07-05 23:06 ` Liam R. Howlett
2023-07-06 0:20 ` Suren Baghdasaryan
2023-07-06 0:32 ` Liam R. Howlett
2023-07-06 0:42 ` Suren Baghdasaryan
2023-07-05 17:12 ` [PATCH v3 2/2] mm: disable CONFIG_PER_VMA_LOCK until its fixed Suren Baghdasaryan
2023-07-05 17:15 ` David Hildenbrand
2023-07-05 17:22 ` Suren Baghdasaryan
2023-07-05 17:24 ` David Hildenbrand
2023-07-05 18:09 ` Suren Baghdasaryan
2023-07-05 18:14 ` Suren Baghdasaryan
2023-07-05 20:25 ` Peter Xu
2023-07-05 20:33 ` Suren Baghdasaryan
2023-07-06 0:24 ` Andrew Morton
2023-07-06 0:30 ` Suren Baghdasaryan
2023-07-06 0:32 ` Suren Baghdasaryan
2023-07-06 0:44 ` Andrew Morton
2023-07-06 0:49 ` Suren Baghdasaryan
2023-07-06 1:16 ` Suren Baghdasaryan
2023-07-05 20:37 ` David Hildenbrand
2023-07-05 21:09 ` Suren Baghdasaryan
2023-07-05 21:27 ` Matthew Wilcox [this message]
2023-07-05 21:54 ` Suren Baghdasaryan
2023-07-05 21:55 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKXgXFfrBzUjfkDN@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=bigeasy@linutronix.de \
--cc=chriscli@google.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=hdegoede@redhat.com \
--cc=holger@applied-asynchrony.com \
--cc=hughd@google.com \
--cc=jacobly.alt@gmail.com \
--cc=jannh@google.com \
--cc=jglisse@google.com \
--cc=jirislaby@kernel.org \
--cc=joelaf@google.com \
--cc=kent.overstreet@linux.dev \
--cc=ldufour@linux.ibm.com \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=luto@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=michel@lespinasse.org \
--cc=minchan@google.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterjung1337@gmail.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=punit.agrawal@bytedance.com \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=shakeelb@google.com \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=tatashin@google.com \
--cc=vbabka@suse.cz \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox